Project_Name Code_ReviewComment CheckStyle_Check Patch Source_Code_Line_Number Vaadin "Javadoc is missing actual explanation of what \""responsive layout capabilities\"" means. " [JavadocType] server/src/com/vaadin/server/Responsive.java+refs-changes-63-2863-1 23 Eclipse_CDT Please add a space after // [WhitespaceAfter] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/ReplaceTests.java+refs-changes-42-52942-1 765 EclipsePlatformUI fits in one line [NoLineWrap] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/WelcomeEditor.java+refs-changes-21-90521-3 982 OpenDaylight_Controller not sure about all these nulls would at least add TODO for refactoring [TodoComment] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/ConsumerContextImpl.java+refs-changes-63-8463-5 58 OpenDaylight_Controller It would help if this timeout was named MODULE_TIMEOUT_IN_MILLIS [ConstantName] opendaylight/config/config-it-base/src/main/java/org/opendaylight/controller/config/it/base/AbstractConfigTestBase.java+refs-changes-94-16294-9 61 OpenDaylight_Controller Robert - do you agree with my comment i.e. suppress it and if/when findbugs is fixed to handle it properly we can remove the suppression? [SuppressWarnings] opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java+refs-changes-73-47473-3 32 OpenDaylight_Controller method name changed [MethodName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java+refs-changes-87-9087-4 291 OpenDaylight_Controller "why the strange naming? I mean the \""set\"" before the addShardReplica? " [MethodName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shardmanager/ShardManagerInfo.java+refs-changes-42-27742-10 107 Vaadin Missing license header [Header] uitest/src/com/vaadin/tests/push/PushFromInit.java+refs-changes-56-1856-5 1 EclipsePlatformUI Is this different when the Javadoc on super? [JavadocMethod] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java+refs-changes-11-53511-2 219 Vaadin TODO needs to be fixed [TodoComment] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-09-1009-1 468 Vaadin This should probably be private [VisibilityModifier] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-75-3375-5 361 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToByteConverter.java+refs-changes-00-50300-8 45 Vaadin long line [LineLength] client/src/com/vaadin/client/ui/VTabsheetPanel.java+refs-changes-10-2910-1 167 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToShortConverter.java+refs-changes-00-50300-8 40 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableValue.java+refs-changes-99-50299-9 28 EclipsePlatformUI "Can we rename this method to something more descriptive e.g. \n\nisCorrectPhase()\n\nI think we should also combine the checks you are doing e.g. for the fragment \n\nif (!\""fragment\"".equals(ce.getName())) { // NON-NLS-1 && !isCorrectPhase(){\n\t\t\t\t\tcontinue;\n} " [MethodName] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java+refs-changes-11-21111-10 113 Eclipse_CDT Expand UDL abbreviation.\n\nfind -> finds [AbbreviationAsWordInName] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-67-24367-1 3033 Eclipse_CDT Copyright missing [Header] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS_7_5.java+refs-changes-35-5835-3 1 Eclipse_CDT Fits into previous line. [NoLineWrap] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-5 112 Eclipse_CDT if-else statements have to use braces in both branches. [NeedBraces] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java+refs-changes-46-41346-8 600 Eclipse_CDT Can you put some javadoc since the method inherits the one describing the implementation you are changing. [JavadocMethod] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/ExpressionInformationControlCreator.java+refs-changes-75-16575-1 201 Eclipse_CDT Class comment [JavadocType] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/utils/DSFDebugModelListenerEpiphany.java+refs-changes-33-25133-6 8 Eclipse_CDT Also I'd suggest EpiphanyDSFDebugModelListener as the interface name. [TypeName] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/utils/DSFDebugModelListenerEpiphany.java+refs-changes-33-25133-6 8 Eclipse_CDT Fits into previous line. [NoLineWrap] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpHelper.java+refs-changes-77-22177-3 654 Eclipse_CDT A better name for this class would be VisibilityAsserts. [TypeName] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/VisibilityHelper.java+refs-changes-01-11901-2 17 Eclipse_CDT Please add a class comment. [JavadocType] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/selection/BaseSelectionTests.java+refs-changes-07-44807-1 43 Eclipse_CDT Avoid cryptic abbreviations. [AbbreviationAsWordInName] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpInformation.java+refs-changes-77-22177-3 102 Eclipse_CDT Extra space after ( [ParenPad] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java+refs-changes-07-31807-8 268 Eclipse_CDT "Spaces are required around \""-\"" " [WhitespaceAround] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-5 195 Eclipse_CDT Please remove or make private. You can actually remove since it is not used [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/GdbPlugin.java+refs-changes-72-5972-3 45 Eclipse_CDT Please add javadoc like other MICommands. It is basically a copy/paste of the GDB manual [JavadocType] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIInfoOs.java+refs-changes-35-5835-3 19 Vaadin javadoc? [JavadocMethod] server/src/main/java/com/vaadin/data/SimpleResult.java+refs-changes-55-14055-3 34 Vaadin old naming with separate variables was quite clear now might need to think more about what diff means at different points [LocalVariableName] server/src/com/vaadin/ui/Grid.java+refs-changes-40-12240-1 1638 Vaadin complete javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/SelectionChangeEvent.java+refs-changes-05-3605-1 106 Vaadin Javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/GridStaticSection.java+refs-changes-16-4016-3 66 Vaadin No license header? [Header] uitest/src/com/vaadin/tests/util/PortableRandom.java+refs-changes-18-3118-2 0 Vaadin Should catch Exception instead of Throwable see http://dev.vaadin.com/ticket/12531 [IllegalCatch] server/src/com/vaadin/server/communication/PushHandler.java+refs-changes-85-1985-1 293 Vaadin Javadoc needs to be updated to reflect the new boolean parameter. [JavadocMethod] server/src/com/vaadin/server/communication/PushHandler.java+refs-changes-40-4140-1 202 Vaadin Changed variable name to be a bit more descriptive. [LocalVariableName] server/src/com/vaadin/data/util/sqlcontainer/SQLContainer.java+refs-changes-70-2670-1 53 Vaadin copy to javadoc body [JavadocMethod] server/src/com/vaadin/ui/Grid.java+refs-changes-91-7091-3 202 Vaadin javadoc? [JavadocMethod] server/src/main/java/com/vaadin/ui/Grid.java+refs-changes-81-14181-1 307 Vaadin What are these TODOs? are they still relevant? If not remove them. [TodoComment] uitest/src/com/vaadin/tests/components/table/ExpandingContainer.java+refs-changes-41-2441-1 52 Vaadin No license header? [Header] uitest/src/com/vaadin/tests/minitutorials/v7b9/MainView.java+refs-changes-18-3118-2 0 Vaadin javadoc for paramteres [JavadocMethod] server/src/com/vaadin/data/util/PropertyValueGenerator.java+refs-changes-84-4684-4 36 Vaadin missing javadocs though it is quite obvious what it does [JavadocMethod] client/src/com/vaadin/client/widgets/Escalator.java+refs-changes-28-7628-1 4533 Vaadin Missing JavaDoc. Repeat below [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/SelectionModel.java+refs-changes-05-3605-3 88 Vaadin fill or remove empty javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/SelectionChangeEvent.java+refs-changes-05-3605-1 40 Vaadin Name not clear even though reflects the old getUsedPaintables().\nCould use e.g. getConnectorsForWidgetset(...) [MethodName] client-compiler/src/com/vaadin/server/widgetsetutils/ConnectorBundleLoaderFactory.java+refs-changes-14-614-1 835 Vaadin Javadoc [JavadocMethod] server/src/com/vaadin/server/FontAwesome.java+refs-changes-89-8589-3 584 Vaadin javadoc [JavadocMethod] server/src/main/java/com/vaadin/ui/ProgressBar.java+refs-changes-30-14230-1 110 Vaadin Public method missing JavaDoc [JavadocMethod] client/src/com/vaadin/client/ui/VCalendarPanel.java+refs-changes-08-1008-5 2180 Vaadin full sentence ends with period. repeat below [JavadocStyle] server/src/com/vaadin/ui/components/grid/ColumnGroup.java+refs-changes-87-2187-5 70 Vaadin No license header? [Header] server/tests/src/com/vaadin/tests/server/component/tree/TreeListeners.java+refs-changes-18-3118-2 0 Vaadin private ? [VisibilityModifier] uitest/src/test/java/com/vaadin/tests/components/textfield/Selection.java+refs-changes-12-14212-2 6 Vaadin Will fix javadoc/license header if this is approved. [Header] client/src/main/java/com/vaadin/client/event/InputEvent.java+refs-changes-54-14054-8 0 Vaadin No license header? [Header] uitest/src/com/vaadin/tests/components/table/FixedHeightTable.java+refs-changes-18-3118-2 0 Vaadin Remove TODO. I don't understand what it means [TodoComment] uitest/src/main/java/com/vaadin/tests/components/grid/basics/DataObject.java+refs-changes-81-14181-1 78 Vaadin nit: ending period. [JavadocStyle] server/src/com/vaadin/ui/Grid.java+refs-changes-64-7664-2 5089 EclipsePlatformUI My only comment here is that the names are bit confusing. How about activePerspective inactivePerspective activePart inactivePart? [MemberName] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/HandlerActivationTest.java+refs-changes-31-50531-4 67 EclipsePlatformUI Is this different when the Javadoc on super? [JavadocMethod] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java+refs-changes-11-53511-2 219 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToByteConverter.java+refs-changes-00-50300-8 45 Eclipse_CDT "Please add javadoc" [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBRunControl.java+refs-changes-20-52520-1 23 Eclipse_CDT "Consider using a shorter class name, for example A." [TypeName] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/pdom/tests/ClassMemberVisibilityTests.java+refs-changes-01-11901-5 38 Eclipse_CDT "I think this should be a constant so LOAD_METER_TIMER_MIN" [ConstantName] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizer.java+refs-changes-77-10077-4 150 Eclipse_CDT "Please add javadoc" [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBRunControl.java+refs-changes-20-52520-1 25 Eclipse_CDT "Opening brace in a wrong place." [LeftCurly] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/PDOM.java+refs-changes-59-10659-3 469 Eclipse_CDT "Add JavaDoc explaining what the additional suffixes mean." [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/CPreprocessor.java+refs-changes-67-24367-1 392 Eclipse_CDT "Add JavaDoc." [JavadocMethod] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/inlinetemp/ExpressionOperatorCounter.java+refs-changes-77-22177-3 25 Eclipse_CDT "Add Javadoc explaining semantics of candidates.\n\nThe other ctor can be eliminated if this one is changed to take ICPPFunction... candidates" [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPDeferredFunction.java+refs-changes-62-9062-1 36 Eclipse_CDT "Please indent all your code." [Indentation] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TraditionalRendering.java+refs-changes-33-11133-1 610 Eclipse_CDT "private?" [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/command/GdbCommandTimeoutManager.java+refs-changes-23-5523-1 77 EclipseJDTCore "This will throw an NPE unless internalResolveLeafType is invoked first. If this is meant to always be the case, we should have JavaDoc on both methods explaning the ordering contracts between the two methods. We should also unconditionally throw an IllegalStateException if the methods are invoked in the wrong order.\n\nIf there is no such ordering guarantee, then this is a bug." [JavadocMethod] org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ParameterizedQualifiedTypeReference.java+refs-changes-74-76174-2 79 EclipsePlatformUI "Can we rename this method to something more descriptive e.g. \n\nisCorrectPhase()\n\nI think we should also combine the checks you are doing e.g. for the fragment \n\nif (!\""fragment\"".equals(ce.getName())) { // NON-NLS-1 && !isCorrectPhase(){\n\t\t\t\t\tcontinue;\n} " [MethodName] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java+refs-changes-11-21111-10 113 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableValue.java+refs-changes-99-50299-9 28 EclipsePlatformUI rename [LocalVariableName] bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterType.java+refs-changes-11-90511-1 207 EclipsePlatformUI This is not an English sentence.\nJavadoc should end with a dot. [JavadocStyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java+refs-changes-31-36331-4 204 EclipsePlatformUI I think this method contains also real Javadoc [JavadocMethod] bundles/org.eclipse.jface/src/org/eclipse/jface/action/SubMenuManager.java+refs-changes-30-34330-1 142 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/ValuePropertyDetailValue.java+refs-changes-99-50299-9 141 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableTracker.java+refs-changes-99-50299-9 280 EclipsePlatformUI Use better name here also [LocalVariableName] bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java+refs-changes-12-90512-2 331 EclipsePlatformUI Maybe put a TODO comment for future generations. [TodoComment] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java+refs-changes-97-56797-1 436 EclipsePlatformUI Does this fit into one line? [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java+refs-changes-72-90272-2 310 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java+refs-changes-00-50300-8 138 EclipsePlatformUI "Fits into previous line." [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java+refs-changes-00-50300-8 213 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java+refs-changes-00-50300-8 204 EclipsePlatformUI Use package visibility [VisibilityModifier] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/LazyImageDescriptor.java+refs-changes-28-62028-1 18 EclipsePlatformUI Should fit in one line [NoLineWrap] bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java+refs-changes-53-39353-1 47 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java+refs-changes-00-50300-8 193 EclipsePlatformUI fits in one line [NoLineWrap] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerCategory.java+refs-changes-21-90521-3 112 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/SetDetailValueObservableMap.java+refs-changes-99-50299-9 99 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java+refs-changes-00-50300-8 493 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java+refs-changes-00-50300-8 359 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java+refs-changes-00-50300-8 182 EclipsePlatformUI Fit in one line? [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/LegacyActionPersistence.java+refs-changes-17-90517-4 505 EclipsePlatformUI "This name doesn't convey the purpose of this method: what makes an element \""valid\""? Perhaps hasVisibleContent()? " [MethodName] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java+refs-changes-28-39128-3 120 EclipsePlatformUI rename 'element' [LocalVariableName] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentitySet.java+refs-changes-11-90511-3 85 EclipsePlatformUI Merge with the previous line. [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java+refs-changes-98-64498-1 774 EclipsePlatformUI rename 'listeners' [LocalVariableName] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/IntroPart.java+refs-changes-15-90515-2 114 EclipsePlatformUI rename 'type' [LocalVariableName] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java+refs-changes-20-90520-3 585 EclipsePlatformUI rename 'markerType' [LocalVariableName] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java+refs-changes-20-90520-3 588 EclipsePlatformUI "add brackets" [NeedBraces] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/ContributorTrackingSet.java+refs-changes-13-90513-2 115 EclipsePlatformUI "* private constructor to prevent instantiation. should stay here" [VisibilityModifier] bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceConverter.java+refs-changes-30-34330-1 94 EclipsePlatformUI "Strange indentation." [Indentation] bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/CopyFilesAndFoldersOperation.java+refs-changes-94-55894-2 1834 EclipsePlatformUI rename 'child'? [LocalVariableName] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/Activator.java+refs-changes-11-90511-3 86 EclipsePlatformUI rename 'desciptor' [LocalVariableName] bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java+refs-changes-15-90515-2 298 EclipsePlatformUI There is a type in the class name. Should be Unknow_n_ [TypeName] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/AskUserViaPopupUnknowEditorStrategy.java+refs-changes-59-62659-10 23 EclipsePlatformUI "A space is missing before 'implements'" [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableMap.java+refs-changes-99-50299-10 46 EclipsePlatformUI "can fit in one line" [NoLineWrap] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/filesystem/FileSystemSupportRegistry.java+refs-changes-22-90522-3 138 EclipsePlatformUI "Please use blocks for control statement blocks, i.e., {}" [NeedBraces] bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java+refs-changes-02-31002-26 105 EclipsePlatformUI find better name [LocalVariableName] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/CheckboxTreeViewer.java+refs-changes-01-88501-2 369 EclipsePlatformUI "Magic strings should at least be named constants. But why don't you just use the empty string?" [MultipleStringLiterals] bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java+refs-changes-60-38560-3 463 Vaadin "javadoc, can remove @author" [JavadocType] shared/src/com/vaadin/shared/ui/upload/UploadState.java+refs-changes-51-12151-1 21 Vaadin "what is this? probably could use javadoc, even if only for those working on the internals of Tabsheet" [JavadocMethod] shared/src/com/vaadin/shared/ui/tabsheet/TabsheetState.java+refs-changes-27-2727-3 33 Vaadin "Needs javadoc" [JavadocMethod] server/src/com/vaadin/ui/AbstractComponent.java+refs-changes-28-2828-3 974 Vaadin "Ticket number, remove TODO" [TodoComment] uitest/src/com/vaadin/tests/components/combobox/ComboBoxScrollingWithArrows.java+refs-changes-48-3348-1 67 Vaadin "TODO review rest of file; functions etc." [TodoComment] theme-compiler/src/com/vaadin/sass/internal/parser/LexicalUnitImpl.java+refs-changes-79-2479-2 816 Vaadin "Missing JavaDoc. Repeat below" [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/SelectionModel.java+refs-changes-05-3605-3 88 Vaadin "John> Missing javadoc" [JavadocMethod] client/src/com/vaadin/client/event/PointerEventSupport.java+refs-changes-16-3116-4 28 Vaadin " including @since 7.2 as this is the first version including a constructor with this signature." [MissingCtor] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-29-3029-2 72 Vaadin "Please add javadoc" [JavadocMethod] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-29-3029-2 72 Vaadin "Private missing. Fixing asap" [VisibilityModifier] server/src/com/vaadin/data/util/TransactionalPropertyWrapper.java+refs-changes-75-3075-1 51 Vaadin "This should probably be private" [VisibilityModifier] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-75-3375-5 361 Vaadin "javadoc" [JavadocType] client/src/com/vaadin/client/ui/grid/events/ColumnResizeEvent.java+refs-changes-28-2428-2 22 Vaadin "Instead of empty try-catch I would use the @Test(expected=IllegalArgumentException) since it is much cleaner." [EmptyCatchBlock] server/tests/src/com/vaadin/tests/server/component/abstractcomponentcontainer/AddParentAsChild.java+refs-changes-28-2828-8 46 Vaadin "No license header?" [Header] uitest/src/com/vaadin/tests/widgetset/client/minitutorials/v7a2/MyComponentState.java+refs-changes-18-3118-2 1 Vaadin "add javadoc" [JavadocMethod] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-05-3605-1 1559 Couchbase "Well, we don't know what other stuff could happen. It'd be better to not catch all of them I think, just the documented ones. " [IllegalCatch] src/main/java/com/couchbase/client/BootstrapNodeUtil.java+refs-changes-94-32994-4 98 Couchbase Why not catch the specific exceptions you want to include ins your IOException? [IllegalCatch] src/main/java/com/couchbase/client/BootstrapNodeUtil.java+refs-changes-94-32994-4 98 Couchbase formatting [WhitespaceAround] src/main/java/com/couchbase/client/java/document/subdoc/MutationSpec.java+refs-changes-23-58223-11 57 Couchbase looks like indentation is off here [Indentation] src/main/java/com/couchbase/client/java/CouchbaseAsyncBucket.java+refs-changes-23-58223-11 1509 Couchbase "no need to nest, just use else if or switch " [NestedIfDepth] src/main/java/com/couchbase/client/java/CouchbaseAsyncBucket.java+refs-changes-95-69995-1 1311 Couchbase please skip a line between one method and the next [EmptyLineSeparator] src/main/java/com/couchbase/client/CouchbaseClient.java+refs-changes-05-21805-1 241 Couchbase seems like these need some javadocs [JavadocMethod] src/main/java/com/couchbase/client/protocol/views/HttpOperation.java+refs-changes-88-13688-2 40 Couchbase those getters on the class need some javadoc love - will be used a lot! [JavadocMethod] src/main/java/com/couchbase/client/java/subdoc/DocumentFragment.java+refs-changes-01-60201-3 93 Couchbase want to get rid of that stuff and add 2 docblocks to the new methods? [JavadocMethod] src/main/java/com/couchbase/client/java/Bucket.java+refs-changes-01-60201-3 4425 Couchbase weird line wrapping? [NoLineWrap] src/main/java/com/couchbase/client/ViewConnection.java+refs-changes-17-31017-12 332 Eclipse_CDT A space is missing after the type in cast. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/indexer/IndexerPreferences.java+refs-changes-99-70799-3 185 Eclipse_CDT A space is missing before { [WhitespaceAround] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/refactoring/actions/CDeleteAction.java+refs-changes-77-62777-1 38 Eclipse_CDT Can you put some javadoc above each test to explain what the test is meant to verify? [JavadocMethod] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/SourceLookupTest.java+refs-changes-68-52068-7 85 Eclipse_CDT For consistency with the prevailing style fields should be declared before the constructor. [DeclarationOrder] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/HeuristicResolver.java+refs-changes-28-70928-1 229 Eclipse_CDT "For each new method added to this interface, please add a comment describing what it does. " [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IValue.java+refs-changes-61-69661-1 35 Eclipse_CDT Indentation is off. [Indentation] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/numberformat/detail/NumberFormatDetailPane.java+refs-changes-74-71274-2 366 Eclipse_CDT It would be helpful if each of these create() overloads had a comment describing what it does. [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/CompositeValue.java+refs-changes-61-69661-1 102 Eclipse_CDT Java doc missing [JavadocType] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/sync/GdbDebugContextSyncManager.java+refs-changes-96-77896-32 23 Eclipse_CDT Let's add javadoc to the two above constant [JavadocVariable] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/console/GdbTerminalConnector.java+refs-changes-75-82675-6 35 Eclipse_CDT "Not strictly related to this change, but it would be nice to add Javadoc to this class with examples of cases it is intended to handle. " [JavadocType] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/HeuristicResolver.java+refs-changes-50-66050-1 34 Eclipse_CDT Please add javadoc to know what these imply [JavadocType] debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/IMemoryBlockAddressInfoRetrieval.java+refs-changes-00-68300-4 27 Eclipse_CDT "Please explain, in a comment, what this function does, and what the two components of the pair signify. It's not at all obvious to a reader. (I still haven't figured it out, and I've been looking at this code for a while.) " [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalUtil.java+refs-changes-61-69661-3 99 Eclipse_CDT "Please write a Javadoc for this method, explaining in particular the meaning of the 'includeValue' parameter. " [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ISerializableExecution.java+refs-changes-61-69661-1 14 Eclipse_CDT Remove unecessary true [SimplifyBooleanExpression] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/AbstractPane.java+refs-changes-00-68300-4 910 Eclipse_CDT Should 300 be a field constant ? [MagicNumber] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/preferences/GdbDebugPreferencePage.java+refs-changes-66-82866-1 547 Eclipse_CDT "Similarly to the MIN value, lets define a constant for the MAX value as well. Done in patch set 12" [MagicNumber] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/preferences/GdbConsolePreferencePage.java+refs-changes-34-81134-10 62 Eclipse_CDT Spaces are required around '>'. [WhitespaceAround] codan/org.eclipse.cdt.codan.core.cxx/src/org/eclipse/cdt/codan/core/cxx/model/AbstractIndexAstChecker.java+refs-changes-04-66704-1 207 Eclipse_CDT Stray tab? [FileTabCharacter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.java+refs-changes-56-66356-2 368 Eclipse_CDT "The instance variables above can all be \final \"""" " [FinalLocalVariable] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/console/GdbBasicCliConsolePage.java+refs-changes-71-79771-7 27 Eclipse_CDT The number one rule for API methods is to have detailed Javadocs. [JavadocMethod] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/build/IToolChain.java+refs-changes-01-79301-1 64 Eclipse_CDT "This declaration was split across two lines on purpose, to respect the 110-character width limit. Please preserve it, here and elsewhere. " [LineLength] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.java+refs-changes-61-69661-3 1125 Eclipse_CDT This import is not used. [UnusedImports] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPVariableInstance.java+refs-changes-61-69661-3 23 Eclipse_CDT This import seems unnecessary. [UnusedImports] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java+refs-changes-61-69661-1 97 Eclipse_CDT "Ugh, comments at the end of a line. " [TrailingComment] core/org.eclipse.cdt.core/model/org/eclipse/cdt/core/settings/model/util/PathEntryTranslator.java+refs-changes-75-68475-1 813 Eclipse_CDT "When discussed a while back, the Eclipse_CDT project decided not to use * for imports. This change was done automatically for you, so to prevent that, you should change the preference found at Preferrences->Java->Code Style->Organize Imports->Number of imports needed for .* and set it to a high number." [AvoidStarImport] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java+refs-changes-82-84382-8 52 Eclipse_CDT "consider adding curly brackets for \if \"" and \""else\"" blocks, even if not strictly required in this case?"" " [NeedBraces] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbConnectCommand.java+refs-changes-50-66250-3 309 Eclipse_CDT missing 'private' [VisibilityModifier] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TraditionalRendering.java+refs-changes-19-67419-5 119 Eclipse_CDT private final ? [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/console/GdbConsoleTerminateLaunchAction.java+refs-changes-20-80220-4 21 Eclipse_CDT split this long line? [LineLength] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/views/debuggerconsole/DebuggerConsoleManager.java+refs-changes-86-77986-18 121 EclipseJDTCore Fix the TODO [TodoComment] org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/AbstractRegressionTest.java+refs-changes-48-6848-1 2237 EclipseJDTCore indentation [Indentation] org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ClasspathJar.java+refs-changes-23-68823-3 185 EclipseJDTCore copyright header missing [Header] org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/classfmt/ClassWithExternalAnnotations.java+refs-changes-23-68823-3 1 EclipseJDTCore document the purpose? It's not intended as a general purpose setter. [JavadocMethod] org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/env/NameEnvironmentAnswer.java+refs-changes-23-68823-3 44 EclipsePlatformUI A space is missing after the cast. [WhitespaceAfter] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java+refs-changes-40-28240-19 97 EclipsePlatformUI A space is missing before (. [WhitespaceAround] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java+refs-changes-40-28240-19 99 EclipsePlatformUI Add JavaDoc explaining what this test tests. [JavadocType] tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/EvaluationCacheTest.java+refs-changes-40-28240-22 23 EclipsePlatformUI A space is missing before 'implements' [GenericWhitespace] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/DetailObservableMap.java+refs-changes-99-50299-10 46 EclipsePlatformUI "Can you please place the test annotation after the javadoc, not before ? " [AnnotationLocation] tests/org.eclipse.ui.ide.application.tests/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisorTest.java+refs-changes-85-83185-1 40 EclipsePlatformUI Inconsistent use of curly braces. [LeftCurly] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java+refs-changes-70-82970-8 28 EclipsePlatformUI Indentation is off [Indentation] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java+refs-changes-70-82970-8 28 EclipsePlatformUI Make class final [FinalClass] bundles/org.eclipse.jface/src/org/eclipse/jface/operation/ProgressMonitorUtil.java+refs-changes-78-79578-7 21 EclipsePlatformUI Maybe better to keep same indentation as previous line here (spaces) [Indentation] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/DialogCellEditor.java+refs-changes-61-81461-1 255 EclipsePlatformUI Please add Javadoc. [JavadocVariable] tests/org.eclipse.ui.tests.performance/src/org/eclipse/ui/tests/performance/ProgressReportingTest.java+refs-changes-57-80057-1 24 EclipsePlatformUI Please add license header [Header] tests/org.eclipse.ui.ide.application.tests/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisorTest.java+refs-changes-85-83185-1 0 EclipsePlatformUI Please remove those unnecessary braces. [AvoidNestedBlocks] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java+refs-changes-83-41383-3 3845 EclipsePlatformUI Please remove whitespace at the end [NoWhitespaceAfter] bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/resources/CSSResourcesHelpers.java+refs-changes-46-41946-1 88 EclipsePlatformUI Please remove ws [NoWhitespaceAfter] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java+refs-changes-18-43618-1 408 EclipsePlatformUI Put in one line [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java+refs-changes-01-38801-2 123 EclipsePlatformUI Redundant initialization [ExplicitInitialization] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PendingSyncExec.java+refs-changes-87-83487-2 24 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java+refs-changes-00-50300-8 67 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java+refs-changes-00-50300-8 194 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java+refs-changes-00-50300-8 78 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java+refs-changes-00-50300-8 140 EclipsePlatformUI This class needs a comment as to its purpose. I think that it listens for dirty changes for the currently selected part. The filtering if this PropertySheet instance is found is a bit strange (see below). [JavadocType] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheet.java+refs-changes-26-75126-7 140 EclipsePlatformUI "Typically string constants like this are all uppercase (see IPresentationEngine, for example)" [ConstantName] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/ModelAssemblerTests.java+refs-changes-20-66520-14 66 EclipsePlatformUI Use brackets for single statements [NeedBraces] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/SelectPerspectiveDialog.java+refs-changes-28-82328-3 316 EclipsePlatformUI Use curly braces in 'if ' statements containing 'else' branch. [NeedBraces] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java+refs-changes-40-28240-19 179 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/Activator.java+refs-changes-99-50299-9 47 EclipsePlatformUI Why does it have the default visibility? Should better be private final [VisibilityModifier] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/addons/SaveAllDirtyPartsAddon.java+refs-changes-42-66742-3 49 EclipsePlatformUI "not sure if this is gerrit, but please check indentation. " [Indentation] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/FileEditorsPreferencePage.java+refs-changes-87-89187-1 191 EclipsePlatformUI please use blocks for if /else [NeedBraces] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java+refs-changes-87-89187-1 155 EclipsePlatformUI same thing about keeping indentation [Indentation] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TextCellEditor.java+refs-changes-61-81461-1 251 EclipsePlatformUI style nit: please place opening brace on same line with method name [LeftCurly] tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/ImageHyperlinkTest.java+refs-changes-12-85512-8 104 EclipsePlatformUI "why it is protected, not package protected or private? " [VisibilityModifier] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java+refs-changes-44-62344-3 657 EclipsePlatformUI "Indent to match other multiline @params in the same file (five spaces after the m in \""param\"")\n\nNo capital at the start of a @param comment." [JavadocTagContinuationIndentation] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java+refs-changes-28-62028-6 137 Eclipse_CDT = false' can be removed. [ExplicitInitialization] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTTranslationUnit.java+refs-changes-04-14404-3 85 Eclipse_CDT Add a blank line above. [EmptyLineSeparator] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/inlinetemp/Messages.java+refs-changes-77-22177-3 33 Eclipse_CDT Please indent for readability [JavadocTagContinuationIndentation] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-86-5586-5 614 Eclipse_CDT "minor nit: extra space before \""dispose()\""" [SingleSpaceSeparator] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/view/EpiphanyVisualizer.java+refs-changes-33-25133-6 88 Eclipse_CDT Please add blank lines between methods. [EmptyLineSeparator] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPTemplateTemplateParameterSpecialization.java+refs-changes-33-14533-2 66 Eclipse_CDT "'if \ statements with 'else' branches should have curly braces around both branches."" " [NeedBraces] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/db/PDOMExternalReferencesList.java+refs-changes-72-20972-1 117 Eclipse_CDT ==true is redundant ==false is better expressed as ! operator. [SimplifyBooleanExpression] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-86-5586-1 142 Eclipse_CDT A space is missing after cast. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-05-36605-3 3140 Eclipse_CDT A space is missing after cast. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-05-36605-3 3173 Eclipse_CDT A space is missing after cast. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-05-36605-3 3189 Eclipse_CDT A space is missing before ( [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/parser/AbstractCLikeLanguage.java+refs-changes-04-14404-5 141 Eclipse_CDT A space is missing before == [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/commenthandler/ASTCommenter.java+refs-changes-19-6119-1 178 Eclipse_CDT Add JavaDoc. [JavadocMethod] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpPushDownBase.java+refs-changes-77-22177-3 89 Eclipse_CDT Add JavaDoc. [JavadocMethod] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/utils/VisibilityEnum.java+refs-changes-77-22177-3 40 Eclipse_CDT Add JavaDoc. [JavadocType] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/inlinetemp/InlineTempInputPage.java+refs-changes-77-22177-3 34 Eclipse_CDT Add a space after ... [WhitespaceAfter] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPAttributeTests.java+refs-changes-55-22555-5 137 Eclipse_CDT Add a space before ( [WhitespaceAround] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/RebuildIndexAction.java+refs-changes-34-34434-1 21 Eclipse_CDT Add javadoc explaining return value of the method. [JavadocMethod] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-86-5586-3 610 Eclipse_CDT Add spaces around - [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTLiteralExpression.java+refs-changes-67-24367-4 514 Eclipse_CDT And capitalized since they are constants [ConstantName] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MITuple.java+refs-changes-90-37090-6 25 Eclipse_CDT Avoid unnecessary setting to null [ExplicitInitialization] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/DSFSessionState.java+refs-changes-26-26726-5 47 Eclipse_CDT Avoid unnecessary setting to null [ExplicitInitialization] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/DSFSessionState.java+refs-changes-26-26726-5 50 Eclipse_CDT "Better to break before \implements\""."" " [LineLength] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/CASTBaseDeclSpecifier.java+refs-changes-47-43847-1 24 Eclipse_CDT "Braces, please! Especially because there are two commands here, which only works because the first one is an if statement... " [NeedBraces] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/AbstractPane.java+refs-changes-33-11133-1 845 Eclipse_CDT Braces. [NeedBraces] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TextPane.java+refs-changes-33-11133-3 247 Eclipse_CDT Braces. [NeedBraces] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TextPane.java+refs-changes-33-11133-3 337 Eclipse_CDT Braces. [NeedBraces] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TraditionalRendering.java+refs-changes-33-11133-3 570 Eclipse_CDT Break into two lines. [LineLength] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/callhierarchy/CHViewPart.java+refs-changes-14-43114-1 227 Eclipse_CDT Class comment. [JavadocType] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/view/EpiphanyVisualizer.java+refs-changes-33-25133-6 48 Eclipse_CDT Class comment. [JavadocType] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/view/EpiphanyVisualizerIO.java+refs-changes-33-25133-6 21 Eclipse_CDT Could you you provide well formed JavaDoc for this new public method? [JavadocMethod] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/AbstractCPropertyTab.java+refs-changes-70-16770-2 612 Eclipse_CDT Do not exceed 110-character limit. Same elsewhere. [LineLength] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-8 118 Eclipse_CDT Don't initialize [ExplicitInitialization] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/model/VisualizerCore.java+refs-changes-77-10077-4 30 Eclipse_CDT "Don't initialize: compiler will set to null, and we'll avoid having to step into that code when debugging " [ExplicitInitialization] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/model/VisualizerCPU.java+refs-changes-77-10077-4 36 Eclipse_CDT "Don't replace with '*'. Eclipse does that automatically so you have to change a preference. Preferences->Java->Code style->Organize imports: increase the number for umber of imports needed for .*\""""" [AvoidStarImport] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java+refs-changes-18-22118-1 47 Eclipse_CDT Empty else [EmptyBlock] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBBreakpoints_7_4.java+refs-changes-27-8327-1 303 Eclipse_CDT Expand UDL abbreviation. [AbbreviationAsWordInName] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-67-24367-1 3040 Eclipse_CDT Extra space after ( [ParenPad] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java+refs-changes-07-31807-8 268 Eclipse_CDT "For strings, you have to use equals() to compare, not == or != " [StringLiteralEquality] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/PersistentSettingsManager.java+refs-changes-07-42907-4 190 Eclipse_CDT "Function naming convention: avoid abbreviations in function names. (\Src\"" -> \""Source\"")""" [AbbreviationAsWordInName] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizer.java+refs-changes-26-26726-2 409 Eclipse_CDT "I find it is safer to always us {} even from one-line if statements. This has been our approach in DSF. I never mentioned it before because it is not a big deal, but then I found what could be a good reason right in this file, so I thought I'd mention it. in changes like the one above where the {} were used and included rm.done() by mistake, consistency in using {} may help. if we don't always use the {} we run the risk of the person writing the code or reviewing it, to miss that the rm.done() is inside the brackets because she/he assumed there was no bracket in this case (as one could argue there should not have been above). By always using the brackets, we always have to check what is contained inside of them and increase our changes of noticing such bugs. So although I'm probably not perfect at it, I try to always use brackets. This is open for discussion of course, since you are the most active (and really the only) other DSF committer." [NeedBraces] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIBreakpointsManager.java+refs-changes-27-8327-1 505 Eclipse_CDT "I would make these private. We should avoid protected fields. if we want to provide access, we should use getters/setters." [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/PersistentSettingsManager.java+refs-changes-07-42907-3 126 Eclipse_CDT Invalid formatting. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/AbstractIndexerTask.java+refs-changes-59-10659-3 1011 Eclipse_CDT "Missing spaces after \if \"" and before {"" " [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPClassSpecialization.java+refs-changes-01-11901-1 455 Eclipse_CDT Missing spaces before ( and after ) [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPLinkage.java+refs-changes-01-11901-1 366 Eclipse_CDT One brace instead of two? [AvoidNestedBlocks] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBMemory.java+refs-changes-71-18371-2 137 Eclipse_CDT Please add Javadoc explaining the semantics of the returned value. [JavadocMethod] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ArithmeticConversion.java+refs-changes-58-9058-1 373 Eclipse_CDT Please add a blank line between constructors. [EmptyLineSeparator] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalFunctionSet.java+refs-changes-73-11073-1 62 Eclipse_CDT Please add a blank line between tests. [EmptyLineSeparator] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/refactoring/rename/RenameTemplatesTests.java+refs-changes-64-11064-1 67 Eclipse_CDT Please add a class comment. [JavadocType] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/selection/BaseSelectionTests.java+refs-changes-07-44807-1 43 Eclipse_CDT Please add a space after the cast. [WhitespaceAfter] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/DeclaratorWriter.java+refs-changes-73-48473-1 68 Eclipse_CDT Please add java doc for this new API [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunch.java+refs-changes-51-5751-1 325 Eclipse_CDT Please add javadoc [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBRunControl.java+refs-changes-20-52520-1 23 Eclipse_CDT Please add javadoc [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBRunControl.java+refs-changes-20-52520-1 25 Eclipse_CDT "Please add javadoc. For interfaces, I think we should properly document each mehtod. " [JavadocMethod] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBMemory.java+refs-changes-29-11529-1 11 Eclipse_CDT Please add spaces around - [WhitespaceAround] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2Tests.java+refs-changes-04-14404-4 5909 Eclipse_CDT "Please add {} for the for loop. We try to always use {} even for single line statements. Note here how the closing } is indented with the for loop although it affects the if . This can lead to some really find to hard bugs, which is why we always put {}" [NeedBraces] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MITuple.java+refs-changes-90-37090-3 48 Eclipse_CDT Please always use braces for multi-line then-clauses [NeedBraces] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/Cost.java+refs-changes-58-9058-1 291 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 162 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 244 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 340 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 365 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 451 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 480 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 494 Eclipse_CDT Please bring the braces back. [NeedBraces] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 498 Eclipse_CDT Please define a constant for the default value. [MagicNumber] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/core/CCorePreferenceInitializer.java+refs-changes-04-14404-4 73 Eclipse_CDT Please move fields to top of the class [DeclarationOrder] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/osview/OSData.java+refs-changes-35-5835-3 149 Eclipse_CDT Please remove extra spaces. [ParenPad] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/Cost.java+refs-changes-58-9058-1 309 Eclipse_CDT "Please remove, or make private. You can actually remove since it is not used " [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/GdbPlugin.java+refs-changes-72-5972-3 45 Eclipse_CDT Please use curly braces. [NeedBraces] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTQualifiedName.java+refs-changes-51-15451-2 180 Eclipse_CDT Please use {} [NeedBraces] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIStack.java+refs-changes-75-40075-2 961 Eclipse_CDT Private [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/actions/ShowDebugToolbarAction.java+refs-changes-17-43017-3 28 Eclipse_CDT Private [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/PersistentSettingsManager.java+refs-changes-07-42907-3 131 Eclipse_CDT "Private or protected, no ? we have a getLoad() to access this " [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/model/VisualizerLoadInfo.java+refs-changes-77-10077-4 26 Eclipse_CDT Redundant initialization [ExplicitInitialization] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTTranslationUnit.java+refs-changes-04-14404-3 85 Eclipse_CDT Redundant initialization. [ExplicitInitialization] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-78-43278-1 63 Eclipse_CDT Redundant parentheses. [UnnecessaryParentheses] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTLiteralExpression.java+refs-changes-67-24367-1 238 Eclipse_CDT Redundant parentheses. [UnnecessaryParentheses] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/InternalParserUtil.java+refs-changes-82-9982-3 161 Eclipse_CDT Redundant parentheses. [UnnecessaryParentheses] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/Lexer.java+refs-changes-67-24367-1 739 Eclipse_CDT Remove [TrailingComment] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/CVariableReadWriteFlags.java+refs-changes-15-12515-2 50 Eclipse_CDT Remove [TrailingComment] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/actions/DsfStepIntoSelectionCommand.java+refs-changes-05-11305-5 83 Eclipse_CDT Remove // NON..... [TrailingComment] debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/RegisterGroupsPersistance.java+refs-changes-80-13980-20 152 Eclipse_CDT Remove extra spaces. [ParenPad] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/Cost.java+refs-changes-58-9058-1 292 Eclipse_CDT Remove the 'else' branch. [EmptyBlock] codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/internal/ui/preferences/CheckedTreeEditor.java+refs-changes-24-53724-1 220 Eclipse_CDT Rename to cppOwners. [LocalVariableName] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/PDOM.java+refs-changes-01-50301-5 1600 Eclipse_CDT Restore formatting. [ParenPad] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ErrorParserManager.java+refs-changes-56-5656-3 386 Eclipse_CDT Restore space. [WhitespaceAfter] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-56-5656-3 736 Eclipse_CDT Restore the space after ) [WhitespaceAfter] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-56-5656-3 524 Eclipse_CDT Restore the space. [WhitespaceAfter] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-56-5656-3 564 Eclipse_CDT Restore the space. [WhitespaceAfter] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-56-5656-3 625 Eclipse_CDT Restore the spaces. [WhitespaceAround] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/ErrorParserExtensionManager.java+refs-changes-56-5656-3 719 Eclipse_CDT "Should have javadoc comment since it is API used by subtests, need to mention that method only can be called if resolveBreakpointLocations called prior " [JavadocMethod] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/BaseTestCase.java+refs-changes-72-36872-14 279 Eclipse_CDT Space is mising after = and before < [WhitespaceAround] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-5 221 Eclipse_CDT Space is missing before ( [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/ClassTypeHelper.java+refs-changes-01-11901-2 925 Eclipse_CDT Space is missing before ( [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPClassType.java+refs-changes-01-11901-1 434 Eclipse_CDT "Space is missing before \else\"". Remove space after (."" " [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/CVariableReadWriteFlags.java+refs-changes-15-12515-2 50 Eclipse_CDT Space is missing between if and the opening parenthesis. [WhitespaceAround] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/PDOMManager.java+refs-changes-94-11194-2 527 Eclipse_CDT Surround this branch with curly braces since other branches have them. [NeedBraces] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/VariableReadWriteFlags.java+refs-changes-15-12515-5 127 Eclipse_CDT There should be no space before [ Same elsewhere. [NoWhitespaceBefore] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-5 212 Eclipse_CDT "This collection is not assigned any where else so for clarity/simplicity is better to have it as \final \"""" " [FinalLocalVariable] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/breakpoints/CBreakpointGdbThreadsFilterExtension.java+refs-changes-27-33727-1 32 Eclipse_CDT This one is not needed. [UnusedImports] build/org.eclipse.cdt.autotools.ui.tests/src/org/eclipse/cdt/autotools/ui/tests/SetConfigurationParameter.java+refs-changes-67-35767-1 25 Eclipse_CDT This would be really nice to do. [TodoComment] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/inlinetemp/InlineTempRefactoring.java+refs-changes-77-22177-3 237 Eclipse_CDT "Usually our member variables start with an f for field. Although the current class does not use that. We could refactor the class to add 'f' to each member variable. I don't think the '_' suffix is a bad idea, except for the fact we don't use it anywhere else. One can imagine that the next developer to contribute may have his/her own way of naming parameters and we'll get into a mix of naming convention." [MemberName] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/ExprMetaGetVarInfo.java+refs-changes-98-41198-2 61 Eclipse_CDT class with lowercase letter. Converted is too generic. Converted to what? [TypeName] build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSCustomPageData.java+refs-changes-07-41507-3 423 Eclipse_CDT if -else statements have to have braces around all branches. [NeedBraces] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/togglefunction/ToggleFromInHeaderToImplementationStrategy.java+refs-changes-60-45460-1 381 Eclipse_CDT if -else statements have to use braces in both branches. [NeedBraces] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java+refs-changes-46-41346-8 600 Eclipse_CDT private [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizerCanvas.java+refs-changes-72-43072-1 1176 Eclipse_CDT private [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-77-10077-4 76 Eclipse_CDT private for above three [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-77-10077-4 171 Eclipse_CDT we should probably remove or change this comment [TrailingComment] core/org.eclipse.cdt.core.tests/model/org/eclipse/cdt/core/model/tests/CModelTests.java+refs-changes-93-46093-1 632 Eclipse_CDT "while you at it these should be private too then, or somebody using them? " [VisibilityModifier] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MITuple.java+refs-changes-90-37090-6 25 OpenDaylight_Controller "Presumably, we want indentation to be right here." [CommentsIndentation] opendaylight/md-sal/topology-manager/src/main/java/org/opendaylight/md/controller/topology/manager/FlowCapableTopologyExporter.java+refs-changes-12-10412-3 161 OpenDaylight_Controller "+1, the rule is that static final members are capitalised, not loggers. (But most loggers are static final .) " [MemberName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractRaftActorBehavior.java+refs-changes-11-46511-2 42 OpenDaylight_Controller @Override or package-private? [DesignForExtension] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java+refs-changes-02-32602-6 163 OpenDaylight_Controller A bit of documentation on this interface will be helpful [JavadocType] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/utils/RoutingLogic.java+refs-changes-62-9862-3 13 OpenDaylight_Controller A comment on what fitCriteria stands for may be helpful. [JavadocVariable] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/controller/md/sal/dom/xsql/jdbc/JDBCResultSet.java+refs-changes-92-14592-6 295 OpenDaylight_Controller A liitle javadoc or just plain comments should be added to describe the contract of this method (in particular: Optional.absent returned if the filter is present but contains no tree and Optional.of(ROOT) returned in case not filter is present). [JavadocMethod] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/get/AbstractGet.java+refs-changes-83-16483-4 162 OpenDaylight_Controller Add a TODO for supporting multiple filter trees. [TodoComment] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/get/AbstractGet.java+refs-changes-83-16483-4 176 OpenDaylight_Controller "Add a private no -arg ctor to prevent instantiation of this class. Else, consider marking it as an interface. " [MissingCtor] opendaylight/samples/reactiveforwarding/src/main/java/org/opendaylight/controller/samples/reactiveforwarding/LBConst.java+refs-changes-09-809-1 14 OpenDaylight_Controller Add documentation [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 92 OpenDaylight_Controller Again either change name or [MethodName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java+refs-changes-87-9087-4 357 OpenDaylight_Controller At least a brief description of public interfaces is required. [JavadocType] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/api/MessageTransformer.java+refs-changes-93-6793-10 15 OpenDaylight_Controller Can we be more specific than Exception? [IllegalCatch] opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/osgi/NetconfSSHActivator.java+refs-changes-98-6198-4 79 OpenDaylight_Controller Can we move this above the new error log you added? Also line is very long... [LineLength] opendaylight/md-sal/sal-dummy-distributed-datastore/src/main/java/org/opendaylight/controller/dummy/datastore/DummyShard.java+refs-changes-23-15423-1 67 OpenDaylight_Controller Can we rename this method to testMissingKeyInPayload? [MethodName] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 122 OpenDaylight_Controller Can we rename this method to testMissingKeyInURI? [MethodName] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 105 OpenDaylight_Controller Can we rename this method to testURIAndPayloadKeysDifferent? [MethodName] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 81 OpenDaylight_Controller Can we rename this method to testValidKeys? [MethodName] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 69 OpenDaylight_Controller Can we rename this to completeWith? (scala/akka names a similar method that way) [MethodName] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteDOMRpcFuture.java+refs-changes-76-22376-3 41 OpenDaylight_Controller extra space [SingleSpaceSeparator] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-83-39283-37 334 OpenDaylight_Controller Can we rename this to getApproximateRetryPeriod? [MethodName] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataStoreUnavailableException.java+refs-changes-78-20678-1 27 OpenDaylight_Controller Can you add class javadocs here? [JavadocType] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/notifications/RegisterRoleChangeListener.java+refs-changes-33-12933-2 6 OpenDaylight_Controller Can you add javadoc? Looks like this class tests ShardManager prefix shard creation [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/PrefixShardCreationTest.java+refs-changes-05-44705-3 63 OpenDaylight_Controller "Can you avoid all the whitespace re-formatting, specifically adding the space before ')'? " [ParenPad] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/utils/MessageCollectorActor.java+refs-changes-47-29947-3 138 OpenDaylight_Controller Can you javadoc this method explaining what is meant by clean and what it returns? [JavadocMethod] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ClusterUtils.java+refs-changes-05-44705-3 25 OpenDaylight_Controller Can you move this to the bottom of the file? That's where we've been putting inner classes. [InnerTypeLast] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 57 OpenDaylight_Controller Can't we just catch a specific exception like IOException? [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/admin/ClusterAdminRpcService.java+refs-changes-15-29215-2 153 OpenDaylight_Controller space after commas [WhitespaceAfter] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 206 OpenDaylight_Controller Changed to private. [VisibilityModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-4 229 OpenDaylight_Controller Class documetation is missing [JavadocType] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/DOMStore.java+refs-changes-94-7394-2 17 OpenDaylight_Controller Code does not seem to be uniformly formatted [LeftCurly] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shard/ShardStatsTest.java+refs-changes-50-9850-4 74 OpenDaylight_Controller Code style: missing spaces around != and ? [WhitespaceAround] opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/controller/netconf/client/NetconfClientSessionNegotiator.java+refs-changes-26-16926-2 132 OpenDaylight_Controller Constants for these strings may be a good idea. [MultipleStringLiterals] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/controller/md/sal/dom/xsql/jdbc/JDBCResultSet.java+refs-changes-92-14592-6 312 OpenDaylight_Controller Cosmetic thing... please put return on separate line with braces (that is part of the ODL coding style). [NeedBraces] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java+refs-changes-65-10665-12 47 OpenDaylight_Controller "Cosmetic issue, extra spaces" [SingleSpaceSeparator] opendaylight/config/config-persister-feature-adapter/src/main/java/org/opendaylight/controller/configpusherfeature/internal/FeatureServiceCustomizer.java+refs-changes-56-20656-5 42 OpenDaylight_Controller if this is not a constant do not use all caps for it. [AbbreviationAsWordInName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-4 45 OpenDaylight_Controller Could we make this final ? [FinalLocalVariable] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/transformer/NormalizedNodePruner.java+refs-changes-13-36013-2 259 OpenDaylight_Controller Could you put the opening brace on the same line as the if . It's the prevailing coding style in this code. [LeftCurly] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/DefaultAkkaConfigurationReader.java+refs-changes-60-24460-1 28 OpenDaylight_Controller Default looks like a magic string. It should be a constant somewhere. [MultipleStringLiterals] opendaylight/md-sal/sal-persisted-dom/src/main/java/org/opendaylight/persisted/ObjectDataStore.java+refs-changes-53-12053-40 115 OpenDaylight_Controller Describe the class with a few words. [JavadocType] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/DOMStoreReadWriteTransaction.java+refs-changes-04-5604-4 3 OpenDaylight_Controller "Do not catch Throwable, do not use Exceptions.sneakyThrow() " [IllegalCatch] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/ConsumerContextImpl.java+refs-changes-71-7271-2 81 OpenDaylight_Controller Do not catch Throwables! [IllegalCatch] opendaylight/md-sal/inventory-manager/src/main/java/org/opendaylight/controller/md/inventory/manager/FlowCapableInventoryProvider.java+refs-changes-87-6387-1 43 OpenDaylight_Controller Do we need a hardcoded 5 sec sleep? [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipIntegrationTest.java+refs-changes-64-29364-2 290 OpenDaylight_Controller Do we really need 2-letter shortcuts? [MemberName] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java+refs-changes-98-18498-16 65 OpenDaylight_Controller Do you mean you'd rather optimize it in follow-up patches? if so can you add a TODO/FIXME comment? [TodoComment] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/CompositeDataTreeCohort.java+refs-changes-02-32602-15 108 OpenDaylight_Controller Document these and their thread/state safety [JavadocMethod] opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/controller/netconf/api/AbstractNetconfSession.java+refs-changes-78-5678-10 93 OpenDaylight_Controller Document this method please. [JavadocMethod] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java+refs-changes-31-15131-3 184 OpenDaylight_Controller Can you add class javadocs explaining the usage of this class? [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/RootDataTreeCandidateNode.java+refs-changes-91-18591-10 16 OpenDaylight_Controller Enforce noninstantiability with a private constructor [HideUtilityClassConstructor] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/util/NetconfMessageTransformUtil.java+refs-changes-93-6793-7 39 OpenDaylight_Controller Formatting issue - brace on next line [LeftCurly] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/gossip/Gossiper.java+refs-changes-10-14810-5 179 OpenDaylight_Controller "Hard-coded name is no good, either. I would expect the new encoder to _replace_ the old one " [MultipleStringLiterals] opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/controller/netconf/api/AbstractNetconfSession.java+refs-changes-78-5678-10 57 OpenDaylight_Controller Hard-coded name... [MultipleStringLiterals] opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/controller/netconf/api/AbstractNetconfSession.java+refs-changes-78-5678-10 57 OpenDaylight_Controller I guess your auto-formatting config in IJ added the space but I prefer the no space :) [NoWhitespaceBefore] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-04-29804-2 237 OpenDaylight_Controller I know this is preexisting but this should use the CAPACITY constant. [MultipleStringLiterals] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java+refs-changes-65-10665-8 42 OpenDaylight_Controller I think line is a bit too long here [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/config/ConfigurationImpl.java+refs-changes-05-44705-3 192 OpenDaylight_Controller I think this needs a description [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/TransactionStatsMXBeanImpl.java+refs-changes-23-10823-11 207 OpenDaylight_Controller I usually prefer to spell out words rather than abbreviate like Cnt. How about renaming to calculateMajorityVoteCount? [AbbreviationAsWordInName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-18-28018-2 152 OpenDaylight_Controller I would add a class level comment that points people to the inherited interface. Just an {@link} - that makes it easier to jump there in IDE java doc views [JavadocType] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ReadTransaction.java+refs-changes-35-8735-7 18 OpenDaylight_Controller "Import order broken, static imports go first then alphabetical. " [ImportOrder] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTest.java+refs-changes-96-24496-4 112 OpenDaylight_Controller "Please get rid of the static imports, this is much more clear. " [AvoidStaticImport] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/store/impl/DataChangeEventResolver.java+refs-changes-43-6143-3 213 OpenDaylight_Controller Indentation - can be cleaned up later - doesn't need to block this patch. [Indentation] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/test/DataTreeChangeListenerTest.java+refs-changes-27-17527-4 50 OpenDaylight_Controller Indentation is wrong here. [Indentation] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractRaftActorBehaviorTest.java+refs-changes-20-8920-2 21 OpenDaylight_Controller Indented too far... [Indentation] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/serialization/PathArgumentSerializer.java+refs-changes-68-10268-4 234 OpenDaylight_Controller "Is the purpose to check if a local shard already exists? if so, then you can check the localShard map. checkstyle: use '!' instead of == false for booleans" [SimplifyBooleanExpression] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-42-27742-1 769 OpenDaylight_Controller "Is this protected on purpose (Use protected only if aimed to be overridden, use the least visibility whenever possible)? Why would this be overridden ?Also should be static if does not work with instance fields (This goes for all the methods: if possible, make static)" [VisibilityModifier] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/get/AbstractGet.java+refs-changes-83-16483-1 146 OpenDaylight_Controller "Just add a TODO here, this will be handled in another commit. " [TodoComment] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/RuntimeRpc.java+refs-changes-71-16071-4 213 OpenDaylight_Controller Let's leave it like this. I'll add the javadoc in a follow-up. I need to do one anyway to handle the SchemaValidationFailedException (when that gets through) [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeSnapshot.java+refs-changes-16-21016-6 20 OpenDaylight_Controller Line too long. For the future please try to fit the line within 100 characters. It's easier when reviewing code side by side. [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-42-27742-10 755 OpenDaylight_Controller Line's a little too long but that can be cleaned up later. [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-47-14947-9 472 OpenDaylight_Controller Lowercase f here? [ParameterName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java+refs-changes-86-33386-2 256 OpenDaylight_Controller Magic numbers make me feel somewhat uncomfortable. Could we put this in a constant? [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-86-38086-1 1325 OpenDaylight_Controller "Can we rename this method to \""testMissingKeyInPayload\""? " [MethodName] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 122 OpenDaylight_Controller Make 10000 a constant. [MagicNumber] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/yang/gen/v1/http/netconfcentral/org/ns/xsql/rev140626/XSQLModule.java+refs-changes-92-14592-6 29 OpenDaylight_Controller Minor thing but please keep the same coding style and omit the space before '('. [MethodParamPad] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/DefaultAkkaConfigurationReader.java+refs-changes-60-24460-3 24 OpenDaylight_Controller "Not a major thing, could be done in another patch, but can you add some javadoc on top of it, explaining what this is for? " [JavadocMethod] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java+refs-changes-31-15131-2 184 OpenDaylight_Controller "Nothing major, but try to keep it consistent, brackets or no brackets for single lines if if condition. two lines above, there is bracket, here, its not " [NeedBraces] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/common/actor/MeteredBoundedMailbox.java+refs-changes-67-10267-5 74 OpenDaylight_Controller Override [DesignForExtension] opendaylight/md-sal/inventory-manager/src/main/java/org/opendaylight/controller/md/inventory/manager/InventoryActivator.java+refs-changes-87-6387-1 29 OpenDaylight_Controller Please add comment and note that mBeanType is the concept defined in AbstractMXBean. [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBeanImpl.java+refs-changes-27-10327-8 23 OpenDaylight_Controller "Please add javadoc comments, e.g. This class parses JSON elements from a gson JsonReader. This class differs from the gson JsonParser in that it disallows multiple elements of the same name." [JavadocType] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/gson/JsonParser.java+refs-changes-80-8280-7 26 OpenDaylight_Controller "Please add javadoc, so we can get an idea of what DataProviderService is. " [JavadocType] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataProviderService.java+refs-changes-14-2114-2 19 OpenDaylight_Controller "Please add spaces when using comma ', ' " [WhitespaceAfter] opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/NetconfITTest.java+refs-changes-23-6023-9 382 OpenDaylight_Controller Please add the copyirght notice in new files [Header] opendaylight/protocol_plugins/stub/src/main/java/org/opendaylight/controller/protocol_plugins/stub/internal/TopologyServices.java+refs-changes-21-1521-1 0 OpenDaylight_Controller Please add the copyright notice [Header] opendaylight/protocol_plugins/stub/src/main/java/org/opendaylight/controller/protocol_plugins/stub/internal/Activator.java+refs-changes-21-1521-1 0 OpenDaylight_Controller Please add this comment to the javadoc [JavadocMethod] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/FollowerLogInformation.java+refs-changes-27-15627-10 31 OpenDaylight_Controller Please avoid using == with boolean - this causes a sonar violation. Use ! for false check. [SimplifyBooleanExpression] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-70-29370-3 984 OpenDaylight_Controller Please don't start the interface with capital I - it's very non standard in Java. [MethodName] opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/IBroadcastPortSelector.java+refs-changes-00-1700-4 15 OpenDaylight_Controller Please don't wrap .values() here - it looks a little silly. [SeparatorWrap] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionProxy.java+refs-changes-64-9964-2 194 OpenDaylight_Controller Please elaborate on the documentation of this class (remove the created by) [JavadocType] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/protobuff/client/messages/Payload.java+refs-changes-00-9300-5 12 OpenDaylight_Controller Please keep imports in alphabetical order. [ImportOrder] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Follower.java+refs-changes-15-14615-4 27 OpenDaylight_Controller Please remove tabs and trailing whitespace throughout the file. [FileTabCharacter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/RpcInvocationStrategy.java+refs-changes-06-6906-3 66 OpenDaylight_Controller Please remove this space. [TypecastParenPad] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RoutedRpcMetadata.java+refs-changes-85-36485-19 108 OpenDaylight_Controller Please remove unused imports. [UnusedImports] opendaylight/topologymanager/src/main/java/org/opendaylight/controller/topologymanager/ITopologyManagerClusterWideAware.java+refs-changes-31-831-1 14 OpenDaylight_Controller "Please, what is JsonReader and where we are using it in rest-connector? " [JavadocMethod] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/nn/to/json/test/NnAndYangWithJsonReaderEmptyDataTest.java+refs-changes-09-21209-5 348 OpenDaylight_Controller Probably should have class javadocs but that can be done in future patch. [JavadocType] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeProducerFactory.java+refs-changes-98-14998-8 13 OpenDaylight_Controller Remove todo [TodoComment] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/MdsalNetconfOperationService.java+refs-changes-52-15252-2 37 OpenDaylight_Controller Seems unnecessary this import [UnusedImports] opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/action/Action.java+refs-changes-31-1131-1 15 OpenDaylight_Controller SerializationUtils throws unchecked exceptions. [IllegalThrows] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/admin/ClusterAdminRpcService.java+refs-changes-15-29215-2 153 OpenDaylight_Controller Should be formatted. [RightCurly] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/xsql/XSQLModule.java+refs-changes-79-44579-4 29 OpenDaylight_Controller Should be indented 4 more spaces. [Indentation] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientTransactionCommitCohort.java+refs-changes-09-44909-11 23 OpenDaylight_Controller Should this be private? Looks like the only usage is in newInstance(). [VisibilityModifier] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/io/FileBackedOutputStreamFactory.java+refs-changes-67-55767-15 29 OpenDaylight_Controller Should we be handling a more specific exception ? [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-82-12582-1 542 OpenDaylight_Controller Shouldn't these be final ? [FinalClass] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-1 78 OpenDaylight_Controller no line wrap here please [SeparatorWrap] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionProxy.java+refs-changes-64-9964-2 224 OpenDaylight_Controller needs

tags [JavadocParagraph] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadWriteTransaction.java+refs-changes-46-8046-6 15 OpenDaylight_Controller "Since this is an interface, public is redundant - checkStyle reports this as a minor violation. " [RedundantModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContext.java+refs-changes-15-14615-4 176 OpenDaylight_Controller "Since this isn't static, it should be lower-case. " [MemberName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-70-14870-1 95 OpenDaylight_Controller add javadoc comments briefly explaining its usage/intent? Not a big deal - I'm fine if you want to do this in a follow-up. [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeSnapshot.java+refs-changes-16-21016-6 20 OpenDaylight_Controller So this class is now used to serve up pruning mods. and/or add javadoc comments briefly explaining its usage/intent? Not a big deal - I'm fine if you want to do this in a follow-up. [TypeName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeSnapshot.java+refs-changes-16-21016-6 20 OpenDaylight_Controller Missing text here ... [NonEmptyAtclauseDescription] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java+refs-changes-95-5595-7 67 OpenDaylight_Controller "Sonar asks expressions like this to be simplified, please consider using !old.equals(copy) " [SimplifyBooleanExpression] opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/DeadlockMonitor.java+refs-changes-64-5964-4 74 OpenDaylight_Controller Suggest breaking this method into smaller methods. [MethodLength] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Follower.java+refs-changes-98-8998-4 38 OpenDaylight_Controller TODO [TodoComment] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/CompositeDataTreeCohort.java+refs-changes-02-32602-15 108 OpenDaylight_Controller The Cisco copyright notice? [Header] opendaylight/protocol_plugins/stub/src/main/java/org/opendaylight/controller/protocol_plugins/stub/internal/Activator.java+refs-changes-21-1521-1 0 OpenDaylight_Controller The canonical order is private static final (I think Checkstyle or Sonar complain about this...) [ModifierOrder] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-3 72 OpenDaylight_Controller The two above lines probably want to be one. [NoLineWrap] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-87-9087-4 304 OpenDaylight_Controller "There is no need to define methods of interface as public - they are implicitly public. it's allowed , but discouraged by the JLS. It's also confusing to have one method defined as public, and another without modifier in the same interface." [RedundantModifier] opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/IBroadcastHandler.java+refs-changes-00-1700-1 50 OpenDaylight_Controller These should not have been moved - please keep imports in alphabetical order with statics first. [ImportOrder] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTest.java+refs-changes-52-17652-2 110 OpenDaylight_Controller These timeouts should be configurable. Could you atleast put a TODO for this. [TodoComment] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shardmanager/ShardManagerInfo.java+refs-changes-42-27742-7 112 OpenDaylight_Controller This can be simplified to if (!Boolean.valueOf(attr.getValue())) { or even if (!Boolean.parseBoolean(attr.getValue())) { [SimplifyBooleanExpression] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/OpendaylightNamespaceHandler.java+refs-changes-76-36476-19 91 OpenDaylight_Controller "This is copied straight from xtend generated code. It essentially wraps all exceptions as Runtime exceptions. I know and agree with your statement about Throwable, but I am not attempting to restructure code, just translate. Will change. " [IllegalCatch] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/ConsumerContextImpl.java+refs-changes-71-7271-2 81 OpenDaylight_Controller This line is rather long - can you wrap it? [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipIntegrationTest.java+refs-changes-01-35501-2 328 OpenDaylight_Controller This line is too long [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCandidatePayload.java+refs-changes-91-18591-10 64 OpenDaylight_Controller "This line of code exceeds more then 120 characters ,Better if you break it in two lines. " [LineLength] opendaylight/netconf/netconf-testtool/src/main/java/org/opendaylight/controller/netconf/test/tool/DummyMonitoringService.java+refs-changes-84-35584-1 81 OpenDaylight_Controller This one deserves a javadoc [JavadocMethod] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/actors/ShardSnapshotActor.java+refs-changes-72-50572-5 89 OpenDaylight_Controller This timeout is hardcoded and rather small. I think it should use ActorContext.getOperationDuration to be consistent with findLocalShard et al. [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/ShardedDataTreeActor.java+refs-changes-69-48869-23 566 OpenDaylight_Controller "To eliminate then hardcoded sleep, can you use a custom matcher here where hasOwner == false (I did this using AbstractEntityOwnershipTest.ownershipChanged in other tests)? " [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipIntegrationTest.java+refs-changes-64-29364-2 294 OpenDaylight_Controller We can make owner final too [FinalParameters] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/common/actor/MeteredBoundedMailbox.java+refs-changes-73-9973-3 51 OpenDaylight_Controller We're using the commons/opendaylight/sun_coding_style.xml to format the code and replace tabs with whitespaces. [FileTabCharacter] opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/PriorityMessage.java+refs-changes-42-342-1 60 OpenDaylight_Controller What is the purpose of this class? Could you doc. [JavadocType] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/base/messages/IsolatedLeaderCheck.java+refs-changes-99-12799-4 10 OpenDaylight_Controller What is this class for? Can you add javadocs? [JavadocType] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/policy/DisableElectionsRaftPolicy.java+refs-changes-59-24459-3 11 OpenDaylight_Controller What is this magic number? [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/ReadyLocalTransactionSerializer.java+refs-changes-55-19255-5 35 OpenDaylight_Controller Why a hard-coded 5 sec sleep here? [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-09-50609-41 177 OpenDaylight_Controller Why are we catching Exception? [IllegalCatch] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteRpcImplementation.java+refs-changes-68-8768-4 64 OpenDaylight_Controller Why are we dividing by 5 here? Can you add a comment and/or maybe define a constant for 5? [MagicNumber] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-53-13553-2 761 OpenDaylight_Controller Why catch Exception here? Wouldn't it be better to catch specific exceptions to avoid runtime exceptions. [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-98-18498-26 513 OpenDaylight_Controller "Why isn't this error logged?nAlso, please add brackets (curlys - {}) around the 'if ' statement body." [NeedBraces] opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/authentication/AuthProvider.java+refs-changes-49-4449-3 64 OpenDaylight_Controller Would be nice if this constant was all uppercase with words separated by underscores just like DEFAULT_TRANSACTION_TIMEOUT. [ConstantName] opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java+refs-changes-11-3911-2 72 OpenDaylight_Controller Yes you understood right. Basically now I can wait for the dataSize to get 5 times as much as normal before I do a real snapshot. I'll move the 5 to a constant. [MagicNumber] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-43-13943-1 774 OpenDaylight_Controller You forgot the private ;-). [VisibilityModifier] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-3 70 OpenDaylight_Controller You may want to mark the parameters as final as before [FinalParameters] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/RootBindingAwareBroker.java+refs-changes-06-13806-11 138 OpenDaylight_Controller You mentioned that indentation is correct according to modified Guava style. What is the Guava style? This line is inside the 'if ' block so I don't understand why it wouldn't be indented in this case to match line 91 - seems inconsistent and it doesn't look right. [Indentation] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortRegistrationProxy.java+refs-changes-02-32602-15 89 OpenDaylight_Controller You must add braces even if you have only one statement in the if . It prevents issues where you may inadvertently exclude statements that need to be part of the condition. [NeedBraces] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/controller/md/sal/dom/xsql/jdbc/JDBCResultSet.java+refs-changes-92-14592-6 337 OpenDaylight_Controller You should catch IllegalArgumentException and AskTimeOutException I think these are the only expected Exceptions here. [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shardmanager/ShardManagerInfo.java+refs-changes-42-27742-10 116 OpenDaylight_Controller abstract methods should be documented [JavadocMethod] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/ContextReferenceExtractor.java+refs-changes-46-19146-2 47 OpenDaylight_Controller abstract methods should be documented as it they were in an interface: add javadoc [JavadocMethod] opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/frm/AbstractChangeListener.java+refs-changes-74-8174-2 89 OpenDaylight_Controller add empty line above [EmptyLineSeparator] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/ClientBackedReadTransactionTest.java+refs-changes-88-53988-15 32 OpenDaylight_Controller add empty line above this [EmptyLineSeparator] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/ClientBackedTransactionChainTest.java+refs-changes-18-54018-6 30 OpenDaylight_Controller "add javadocs, please " [JavadocMethod] opendaylight/md-sal/sal-test-model/src/main/java/org/opendaylight/controller/md/sal/test/model/util/ListsBindingUtils.java+refs-changes-87-9687-4 83 OpenDaylight_Controller also misses documentation [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataCommitCoordinatorImpl.java+refs-changes-95-7395-3 37 OpenDaylight_Controller also needs a private constructor [HideUtilityClassConstructor] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/MakeLeaderLocal.java+refs-changes-42-53542-10 24 OpenDaylight_Controller "as this is a private inner class, it's confusing to see its 2 fields and some of its methods declared public. if I were you I would simply remove all public and private in this particular case - it will be more readable (and be about the same - the surrounding class is private anyway). You could also opt to make this a external class in its own file, and keep it package local (and, for me, I would still be fine to not use public or private anywhere in it then)." [VisibilityModifier] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-1 77 OpenDaylight_Controller braces would be nice [NeedBraces] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/RpcRegistry.java+refs-changes-13-9713-10 76 OpenDaylight_Controller "can it be private, too? " [VisibilityModifier] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazySerializedContainerNode.java+refs-changes-46-19146-2 101 OpenDaylight_Controller can this be final . Also we can do with a Hashset too i guess. [FinalClass] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/FixedLeaderElectionStrategy.java+refs-changes-66-19266-2 19 OpenDaylight_Controller can we name it something shorter? i.e. getDisconnectedDevices etc. ? [MethodName] opendaylight/switchmanager/api/src/main/java/org/opendaylight/controller/switchmanager/ISwitchManager.java+refs-changes-19-3419-5 74 OpenDaylight_Controller checkstyle will emit warnings for missing spaces :-) [WhitespaceAround] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/ContextReferenceExtractor.java+refs-changes-46-19146-2 60 OpenDaylight_Controller "checkstyle: for booleans, use if (a) for true and if (!a) for false. " [SimplifyBooleanExpression] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-42-27742-2 772 OpenDaylight_Controller class documentation [JavadocType] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 37 OpenDaylight_Controller code formatting issue [LeftCurly] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java+refs-changes-82-17182-3 61 OpenDaylight_Controller coding style - return should be on separate line. [EmptyLineSeparator] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/MessageTracker.java+refs-changes-81-15581-1 82 OpenDaylight_Controller constructor [MissingCtor] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/xtendbeans/XtendBuilderExtensions.java+refs-changes-99-44099-15 35 OpenDaylight_Controller "constructor, which throws UnsupportedOperationException " [MissingCtor] opendaylight/commons/protocol-framework/src/test/java/org/opendaylight/controller/config/yang/protocol/framework/GlobalEventExecutorUtil.java+refs-changes-09-5609-7 17 OpenDaylight_Controller cosmetic - should be a space in between the params. [WhitespaceAfter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataBrokerAdapter.java+refs-changes-26-17526-1 56 OpenDaylight_Controller cosmetic - spaces in between params [WhitespaceAfter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataTreeChangeListenerAdapter.java+refs-changes-26-17526-1 33 OpenDaylight_Controller cosmetic - spacing in between params. [WhitespaceAfter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazyDataObjectModification.java+refs-changes-26-17526-1 58 OpenDaylight_Controller create should be capitalised. [ParameterName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActorRegistry.java+refs-changes-02-32602-13 157 OpenDaylight_Controller "documentation, non-static -- why? " [JavadocType] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataCommitCoordinatorImpl.java+refs-changes-95-7395-3 69 OpenDaylight_Controller does it make sense to keep this class non-final ? [FinalClass] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderInstallSnapshotState.java+refs-changes-14-45514-1 18 OpenDaylight_Controller don't use * imports [AvoidStarImport] opendaylight/websocket/websocket-server/src/main/java/org/opendaylight/controller/websocket/server/WebSocketServerHandler.java+refs-changes-92-4592-2 39 OpenDaylight_Controller either missing @Override [DesignForExtension] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataBrokerAdapter.java+refs-changes-26-17526-3 99 OpenDaylight_Controller javadoc. [JavadocMethod] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataBrokerAdapter.java+refs-changes-26-17526-3 99 OpenDaylight_Controller extra space [ParenPad] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/DataStoreAppConfigMetadata.java+refs-changes-90-38390-5 101 OpenDaylight_Controller extra space in here [WhitespaceAround] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-18-28018-9 431 OpenDaylight_Controller final [FinalLocalVariable] opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/RpcErrorsExceptionTest.java+refs-changes-03-54303-3 48 OpenDaylight_Controller final class [FinalClass] opendaylight/commons/protocol-framework/src/test/java/org/opendaylight/controller/config/yang/protocol/framework/GlobalEventExecutorUtil.java+refs-changes-09-5609-7 17 OpenDaylight_Controller final if possible [FinalClass] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceTopologyAdapter.java+refs-changes-66-14566-2 52 OpenDaylight_Controller "final , plus make a singleton instance available " [FinalClass] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/MakeLeaderLocal.java+refs-changes-42-53542-3 16 OpenDaylight_Controller give documentation that indicates this isn't guaranteed to result in a snapshot being installed. [JavadocMethod] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java+refs-changes-87-9087-4 357 OpenDaylight_Controller having method name as executeAsyncOperationWithWait might be better [MethodName] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-15-11415-3 197 OpenDaylight_Controller inconsistent use of spaces [ParenPad] opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/frm/AbstractChangeListener.java+refs-changes-74-8174-2 63 OpenDaylight_Controller indentation [Indentation] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java+refs-changes-71-33871-1 67 OpenDaylight_Controller indentation [Indentation] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActorRegistry.java+refs-changes-02-32602-13 158 OpenDaylight_Controller inline if /else produces sonar warning [AvoidInlineConditionals] opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/controller/netconf/client/NetconfClientSessionNegotiatorFactory.java+refs-changes-12-5512-6 63 OpenDaylight_Controller is this class threadsafe/should it be? Please add documentation [JavadocType] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleDataBroker.java+refs-changes-63-8463-5 24 OpenDaylight_Controller it can be final [FinalClass] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderInstallSnapshotState.java+refs-changes-14-45514-1 18 OpenDaylight_Controller it's not Java standard to have underscores in method names. [MethodName] opendaylight/md-sal/clustered-data-store/implementation/src/test/java/org/opendaylight/controller/datastore/internal/ClusteredDataStoreManagerTest.java+refs-changes-23-2723-7 45 OpenDaylight_Controller "javadoc would be nice, as this is an API " [JavadocMethod] opendaylight/md-sal/samples/toaster-consumer/src/main/java/org/opendaylight/controller/sample/kitchen/api/KitchenServiceRuntimeMXBean.java+refs-changes-35-38335-6 11 OpenDaylight_Controller javadocs for these are needed [JavadocVariable] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/CompositeDataTreeCohort.java+refs-changes-02-32602-6 35 OpenDaylight_Controller line too long [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-1 158 OpenDaylight_Controller line way too long [LineLength] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-1 98 OpenDaylight_Controller magic constant [MagicNumber] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-58 226 OpenDaylight_Controller make constant? [MagicNumber] opendaylight/md-sal/cds-access-client/src/test/java/org/opendaylight/controller/cluster/access/client/AveragingProgressTrackerTest.java+refs-changes-97-52997-2 35 OpenDaylight_Controller make final if possible. [FinalClass] opendaylight/netconf/netconf-testtool/src/main/java/org/opendaylight/controller/netconf/test/tool/FakeModuleBuilderCapability.java+refs-changes-66-14566-2 20 OpenDaylight_Controller make timeout a final field [FinalLocalVariable] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/RpcRegistry.java+refs-changes-75-34175-3 122 OpenDaylight_Controller "Code style: missing spaces around \""!=\"" and \""?\"" " [WhitespaceAround] opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/controller/netconf/client/NetconfClientSessionNegotiator.java+refs-changes-26-16926-2 132 OpenDaylight_Controller missing class doc [JavadocType] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataBrokerTransactionChainImpl.java+refs-changes-95-7395-11 30 OpenDaylight_Controller missing comments [JavadocMethod] opendaylight/md-sal/sal-binding-util/src/main/java/org/opendaylight/controller/md/sal/binding/util/AbstractLazyNotificationTransformer.java+refs-changes-22-8222-2 73 OpenDaylight_Controller missing documentation [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 54 OpenDaylight_Controller (or @Override?) [DesignForExtension] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 54 OpenDaylight_Controller "missing documentation. Is the 'list' nature needed, or is this really an immutable Collection? " [JavadocMethod] opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerMXBean.java+refs-changes-27-10327-8 22 OpenDaylight_Controller missing javadoc [JavadocMethod] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/Util.java+refs-changes-31-15031-2 55 OpenDaylight_Controller missing javadoc. the result of this is platform-dependent due to use of String.getBytes() [JavadocMethod] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/Util.java+refs-changes-31-15031-2 32 OpenDaylight_Controller missing space [WhitespaceAround] opendaylight/config/config-util/src/main/java/org/opendaylight/controller/config/util/xml/DocumentedException.java+refs-changes-26-48326-1 83 OpenDaylight_Controller missing spaces mean checkstyle warnings. [WhitespaceAround] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMDataBrokerAdapter.java+refs-changes-26-17526-3 55 OpenDaylight_Controller new tab added please remove it. [FileTabCharacter] opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManagerImpl.java+refs-changes-45-245-4 201 OpenDaylight_Controller no documentation [JavadocMethod] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 83 OpenDaylight_Controller no need to mark interface method as public. [RedundantModifier] opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/IBroadcastPortSelector.java+refs-changes-00-1700-3 8 OpenDaylight_Controller "no parentheses, please " [UnnecessaryParentheses] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceManager.java+refs-changes-31-15031-2 69 OpenDaylight_Controller param spacing [WhitespaceAfter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazyDataObjectModification.java+refs-changes-26-17526-2 86 OpenDaylight_Controller please add comments and an any of these be nulls? What is the contract here? [JavadocMethod] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/statistics/DOMStoreStatsTracker.java+refs-changes-27-10327-8 22 OpenDaylight_Controller please avoid using * import. [AvoidStarImport] opendaylight/config/yang-jmx-generator-plugin/src/test/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/JMXGeneratorTest.java+refs-changes-49-2249-2 20 OpenDaylight_Controller please do not leak mutable fields: make them private. [VisibilityModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-18-28018-4 89 OpenDaylight_Controller please keep the order of variables:- static final - final - non-final [ModifierOrder] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/FutureSchema.java+refs-changes-81-35881-3 33 OpenDaylight_Controller please order your imports [ImportOrder] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/test/Bug1418AugmentationTest.java+refs-changes-87-9687-4 19 OpenDaylight_Controller please refrain from trailing comments: they elicit sonar warnings [TrailingComment] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonMapper.java+refs-changes-37-7337-9 178 OpenDaylight_Controller please remove tab and use space instead [FileTabCharacter] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/WriteTransaction.java+refs-changes-35-46335-3 23 OpenDaylight_Controller missing space [WhitespaceAround] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActor.java+refs-changes-84-51584-7 193 OpenDaylight_Controller please use word abstract in the name of class and is this in correct package? [AbstractClassName] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/RequestExceptionTest.java+refs-changes-38-52638-2 13 OpenDaylight_Controller private [HideUtilityClassConstructor] opendaylight/commons/protocol-framework/src/test/java/org/opendaylight/controller/config/yang/protocol/framework/GlobalEventExecutorUtil.java+refs-changes-09-5609-7 17 OpenDaylight_Controller private [VisibilityModifier] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/io/FileBackedOutputStreamFactory.java+refs-changes-67-55767-15 29 OpenDaylight_Controller private static class? [VisibilityModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-9 220 OpenDaylight_Controller private? [VisibilityModifier] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/io/FileBackedOutputStreamFactory.java+refs-changes-67-55767-15 29 OpenDaylight_Controller probably not. I'll reduce visibility. [VisibilityModifier] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeSnapshot.java+refs-changes-16-21016-1 19 OpenDaylight_Controller Constants for these strings may be a good idea. [MultipleStringLiterals] opendaylight/md-sal/sal-dom-xsql/src/main/java/org/opendaylight/controller/md/sal/dom/xsql/jdbc/JDBCResultSet.java+refs-changes-92-14592-6 312 OpenDaylight_Controller I try to rewrite JavaDoc please read and comment it. [JavadocType] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/api/EventSource.java+refs-changes-01-16401-5 26 OpenDaylight_Controller Can you javadoc the difference between writeDocument and writeData? At first I didn't know the difference until I looked at the source code in XmlStreamUtils (it would also be good if the XmlStreamUtils methods were javadoc'ed). [JavadocMethod] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlMapper.java+refs-changes-77-8877-2 79 OpenDaylight_Controller "public interface without documentation. Also, coding style guidelines state that the I prefix should not be used. " [JavadocType] opendaylight/md-sal/sal-persisted-dom/src/main/java/org/opendaylight/persisted/codec/ISerializer.java+refs-changes-53-12053-40 3 OpenDaylight_Controller "public is implied by interface, so lose the superfluous declaration (sonar) " [RedundantModifier] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataCommitErrorListener.java+refs-changes-95-7395-3 30 OpenDaylight_Controller public is redundant in an interface - checkstyle will report a minor violation. [RedundantModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContext.java+refs-changes-15-14615-6 172 OpenDaylight_Controller add javadoc [JavadocType] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceTwoPhaseCommitTransaction.java+refs-changes-93-6793-6 52 OpenDaylight_Controller remove these tabs here (and figure out why Checkstyle has not caught this?!) [FileTabCharacter] opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/BitBufferHelper.java+refs-changes-18-58018-1 523 OpenDaylight_Controller removed all public from this interface. [RedundantModifier] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContext.java+refs-changes-15-14615-6 172 OpenDaylight_Controller same comment here regarding starting interface with capital I - not common in Java. [MethodName] opendaylight/samples/simpleforwarding/src/main/java/org/opendaylight/controller/samples/simpleforwarding/IBroadcastPortSelector.java+refs-changes-00-1700-1 7 OpenDaylight_Controller "should be @author. Also should add a javadoc comment as well (we'll likely enforce checkstyle at some point), e.g. Enumerates the possibly strategies when a component is updated. " [JavadocType] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/UpdateStrategy.java+refs-changes-86-44386-3 11 OpenDaylight_Controller should be final [FinalClass] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/xtendbeans/XtendBuilderExtensions.java+refs-changes-99-44099-15 35 OpenDaylight_Controller "should be final , too " [FinalClass] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestLeadership.java+refs-changes-42-53542-3 17 OpenDaylight_Controller should be indented [Indentation] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/impl/test/DataTreeChangeListenerTest.java+refs-changes-82-46082-2 58 OpenDaylight_Controller "since we are touching this class, can we add javadocs to public methods? " [JavadocMethod] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingToNormalizedNodeCodec.java+refs-changes-46-19146-2 75 OpenDaylight_Controller since we're here -- make this class final [FinalClass] opendaylight/md-sal/sal-test-model/src/main/java/org/opendaylight/controller/md/sal/test/model/util/ListsBindingUtils.java+refs-changes-87-9687-4 31 OpenDaylight_Controller space [NoWhitespaceBefore] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlice.java+refs-changes-67-55767-15 112 OpenDaylight_Controller space after comma [WhitespaceAfter] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-53 131 OpenDaylight_Controller space after comma [WhitespaceAround] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-53 131 OpenDaylight_Controller space after commas [WhitespaceAfter] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 215 OpenDaylight_Controller space after commas [WhitespaceAround] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 215 OpenDaylight_Controller "space after if , else if " [WhitespaceAfter] opendaylight/northbound/commons/src/main/java/org/opendaylight/controller/northbound/commons/query/WrapperTypeInfo.java+refs-changes-55-7755-3 44 OpenDaylight_Controller spaces :) [WhitespaceAfter] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMRpcImplementationAdapter.java+refs-changes-02-20902-3 70 OpenDaylight_Controller spaces after commas [WhitespaceAfter] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 80 OpenDaylight_Controller static class -> separate file. Missing documentation [ModifierOrder] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-3 86 OpenDaylight_Controller static final [FinalClass] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-58 263 OpenDaylight_Controller static imports should be listed first [ImportOrder] opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/OpendaylightToaster.java+refs-changes-32-39732-2 22 OpenDaylight_Controller this method should be protected [VisibilityModifier] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/TransactionCommitFailedException.java+refs-changes-45-7745-1 19 OpenDaylight_Controller this must be final ... [FinalClass] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-1 71 OpenDaylight_Controller "this should be private final , exposed via protected final getLogger() " [FinalClass] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/NetconfRemoteSchemaSourceProvider.java+refs-changes-56-6356-1 35 OpenDaylight_Controller this should remain final to ensure it is initialized. [FinalLocalVariable] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActor.java+refs-changes-84-51584-8 191 OpenDaylight_Controller "throws IOException, see below " [IllegalCatch] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorSnapshotCohort.java+refs-changes-72-50572-5 37 OpenDaylight_Controller to-do this [TodoComment] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequestTest.java+refs-changes-96-52896-4 13 OpenDaylight_Controller too long line [LineLength] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/RuntimeRequestExceptionTest.java+refs-changes-38-52638-2 19 OpenDaylight_Controller trailing comments -> warning in sonar. just don't do it [TrailingComment] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataBroker.java+refs-changes-95-7395-11 17 OpenDaylight_Controller unneeded parentheses [UnnecessaryParentheses] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java+refs-changes-78-47578-2 173 OpenDaylight_Controller use of spaces before /after parentheses is discouraged [ParenPad] opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/frm/FRMActivator.java+refs-changes-74-8174-2 50 OpenDaylight_Controller utility class: must be final with a private constructor [HideUtilityClassConstructor] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/Util.java+refs-changes-31-15031-2 31 OpenDaylight_Controller what about the space after the for :) This does not make sense. There are many many statements in here which do not have a space after an if - why was this space added? [WhitespaceAround] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-04-29804-2 445 OpenDaylight_Controller what is this class? what sort of concept is it? what is its relationship with other concepts? [JavadocType] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/DOMStoreTransactionFactory.java+refs-changes-94-7394-2 3 OpenDaylight_Controller with braces. Also other places in this file. [NeedBraces] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/MessageTracker.java+refs-changes-81-15581-1 82 OpenDaylight_Controller with private constructor [HideUtilityClassConstructor] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/xtendbeans/XtendBuilderExtensions.java+refs-changes-99-44099-15 35 OpenDaylight_Controller would be better to name this isActive? [ParameterName] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/FollowerLogInformation.java+refs-changes-15-12515-3 71 OpenDaylight_Controller would be nice to have some javadoc [JavadocMethod] opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/ToasterProviderRuntimeMXBean.java+refs-changes-35-38335-6 11 OpenDaylight_Controller } else if { [RightCurly] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-86-38086-4 711 Vaadin "(convention) Everywhere else we use \protected abstract...\"""" " [ModifierOrder] client/src/com/vaadin/client/ui/VTabsheetBase.java+refs-changes-27-2727-9 64 Vaadin Add a comment explaining what this does [JavadocMethod] uitest/src/com/vaadin/tests/widgetset/client/ProfilerCompilationCanary.java+refs-changes-43-11943-2 30 Vaadin Change the order [ModifierOrder] server/src/main/java/com/vaadin/ui/declarative/DesignAttributeHandler.java+refs-changes-85-14585-3 63 Vaadin "Convention is \public default\"" according to checkstyle"" " [ModifierOrder] shared/src/main/java/com/vaadin/shared/data/selection/SelectionModel.java+refs-changes-73-14473-5 116 Vaadin "Could the use of a \magic number\"" be eliminated in some way?"" " [MagicNumber] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-19-11119-1 1005 Vaadin Could this be private instead of package private? [VisibilityModifier] server/src/com/vaadin/ui/declarative/DesignContext.java+refs-changes-86-6086-1 73 Vaadin Could use a bit of JavaDoc.. [JavadocMethod] client/src/com/vaadin/client/connectors/GridConnector.java+refs-changes-03-11903-5 1391 Vaadin Could use some JavaDoc [JavadocVariable] uitest/src/com/vaadin/tests/components/notification/NotificationsWaiAria.java+refs-changes-72-4072-2 19 Vaadin "Fix TODO and remove comment, or create an issue. TODOs in the code are only there to be forgotten about" [TodoComment] uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridContentTest.java+refs-changes-81-14181-1 19 Vaadin "Fix TODO and remove comment, or create an issue. TODOs in the code are only there to be forgotten about " [TodoComment] uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridContentTest.java+refs-changes-81-14181-1 19 Vaadin "Fix TODO and remove comment, or create an issue. TODOs in the code are only there to be forgotten about Why should API for sorting be tested in the same unit test method?" [TodoComment] uitest/src/test/java/com/vaadin/tests/components/grid/basics/GridSortingTest.java+refs-changes-81-14181-1 74 Vaadin "Fix TODO and remove it, or create an issue about it " [TodoComment] server/src/main/java/com/vaadin/ui/Grid.java+refs-changes-81-14181-1 240 Vaadin "Format in this file is not following Vaadin standards, you should wrap long lines to 80 chars, there are other issues like parameters alignment etc. " [LineLength] client/src/com/vaadin/client/communication/JsonDecoder.java+refs-changes-83-4283-13 85 Vaadin Formatting issue [FileTabCharacter] server/src/com/vaadin/data/util/converter/StringToBooleanConverter.java+refs-changes-31-11531-1 98 Vaadin "I'd like to see some JavaDoc or comment describing the purpose of this method, so that the next person who reads the code won't have to inspect the method to know what it filters and why. " [JavadocMethod] uitest/src/com/vaadin/tests/tb3/TB3Runner.java+refs-changes-34-2934-1 127 Vaadin I'll add a javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/EditorRow.java+refs-changes-32-4332-1 143 Vaadin Javadoc [JavadocMethod] server/src/com/vaadin/data/util/converter/StringToBooleanConverter.java+refs-changes-31-11531-1 38 Vaadin Javadoc [JavadocMethod] server/src/main/java/com/vaadin/ui/CheckBoxGroup.java+refs-changes-86-14386-3 63 Vaadin Javadoc [JavadocMethod] server/src/com/vaadin/server/communication/ClientRpcWriter.java+refs-changes-09-1009-1 27 Vaadin Javadoc [JavadocType] server/src/com/vaadin/server/communication/UidlWriter.java+refs-changes-09-1009-1 32 Vaadin Javadoc - fill or remove [JavadocVariable] uitest/src/com/vaadin/tests/tb3/CustomTestBenchCommandExecutor.java+refs-changes-80-11380-1 49 Vaadin Javadoc for public method [JavadocMethod] client/src/com/vaadin/client/ui/AriaHelper.java+refs-changes-51-851-4 99 Vaadin Javadoc for public method [JavadocMethod] client/src/com/vaadin/client/ui/VPopupCalendar.java+refs-changes-51-851-4 400 Vaadin Javadoc for public stuff. [JavadocType] client/src/com/vaadin/client/ui/VCalendarPanel.java+refs-changes-51-851-4 1846 Vaadin Javadoc missing. Should at least mention that you're not supposed to override this method. [JavadocMethod] server/src/com/vaadin/ui/UI.java+refs-changes-85-2885-1 652 Vaadin Javadoc required [JavadocMethod] server/src/com/vaadin/ui/UI.java+refs-changes-79-1979-2 100 Vaadin Javadocs [JavadocType] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-82-2082-1 359 Vaadin "Javadocs? Not that I think that this method needs it, but because framework... " [JavadocMethod] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-18-7818-4 1143 Vaadin John Missing class javadoc of what this class is supposed to do. [JavadocType] client/src/com/vaadin/client/event/PointerEventSupport.java+refs-changes-16-3116-4 20 Vaadin John> Missing javadoc [JavadocMethod] client/src/com/vaadin/client/event/PointerEventSupport.java+refs-changes-16-3116-4 2 Vaadin License header missing [Header] uitest/src/com/vaadin/tests/push/TogglePush.java+refs-changes-56-1856-7 0 Vaadin Long anonymous class. I would extract it to non-anonymous and just instantiate it here. [AnonInnerLength] server/src/main/java/com/vaadin/ui/Grid.java+refs-changes-81-14181-1 241 Vaadin Mark as private [VisibilityModifier] uitest/src/com/vaadin/tests/tb3/ScreenshotTB3Test.java+refs-changes-80-11380-1 200 Vaadin "Missing header, will fix. " [Header] shared/src/main/java/com/vaadin/shared/ui/textarea/TextAreaServerRpc.java+refs-changes-68-14068-12 0 Vaadin Missing javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-07-1907-2 220 Vaadin Missing javadoc [JavadocMethod] shared/src/com/vaadin/shared/ui/tabsheet/TabsheetServerRpc.java+refs-changes-27-2727-3 44 Vaadin Missing space [WhitespaceAfter] server/src/com/vaadin/ui/renderers/DateRenderer.java+refs-changes-91-10991-2 114 Vaadin Missing space after cast. Please check your formatter settings. [WhitespaceAfter] uitest/src/main/java/com/vaadin/tests/components/checkbox/CheckBoxGroupTestUI.java+refs-changes-86-14386-3 29 Vaadin Missing trivial javadoc [JavadocVariable] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-13-2113-1 379 Vaadin Nitpick: protected abstract [ModifierOrder] client/src/com/vaadin/client/connectors/AbstractSelectionModelConnector.java+refs-changes-56-11856-2 53 Vaadin Nitpick: public abstract [ModifierOrder] client/src/com/vaadin/client/connectors/AbstractSelectionModelConnector.java+refs-changes-56-11856-2 39 Vaadin no license header? [Header] uitest/src/com/vaadin/tests/components/gridlayout/GridLayoutWithNonIntegerWidth.java+refs-changes-18-3118-2 0 Vaadin no license header? [Header] uitest/src/com/vaadin/tests/minitutorials/v70/CookieMonsterUI.java+refs-changes-18-3118-2 0 Vaadin no license header? [Header] uitest/src/com/vaadin/tests/minitutorials/v7a2/MyPickerWidget.java+refs-changes-18-3118-2 0 Vaadin no license header? [Header] uitest/src/com/vaadin/tests/widgetset/client/minitutorials/v7a2/WidgetContainerConnector.java+refs-changes-18-3118-2 0 Vaadin Non-private shoud have javadocs [JavadocType] server/src/com/vaadin/ui/AbstractComponent.java+refs-changes-35-6235-2 1293 Vaadin Order [ModifierOrder] shared/src/main/java/com/vaadin/shared/data/selection/SelectionModel.java+refs-changes-73-14473-5 135 Vaadin "Please add javadoc" [JavadocMethod] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-29-3029-2 72 Vaadin Please avoid one letter variables. [LocalVariableName] server/src/main/java/com/vaadin/data/util/converter/StringToDateConverter.java+refs-changes-93-14193-1 54 Vaadin Protected API should have javadocs [JavadocType] server/src/com/vaadin/data/util/AbstractInMemoryContainer.java+refs-changes-01-2001-1 182 Vaadin Public API without javadoc [JavadocMethod] server/src/com/vaadin/event/ConnectorActionManager.java+refs-changes-26-2026-2 44 Vaadin "Public fields, document or make nonpublic (I don't see much reason to have them public or have them at all) " [JavadocVariable] server/src/main/java/com/vaadin/ui/CheckBoxGroup.java+refs-changes-86-14386-5 55 Vaadin Redundant public [RedundantModifier] shared/src/main/java/com/vaadin/shared/ui/textfield/AbstractTextFieldClientRpc.java+refs-changes-12-14212-2 33 Vaadin Redundant public [RedundantModifier] shared/src/main/java/com/vaadin/shared/ui/textfield/AbstractTextFieldClientRpc.java+refs-changes-12-14212-2 38 Vaadin Remove [WhitespaceAround] uitest/src/main/java/com/vaadin/tests/components/splitpanel/GridLayoutWithCheckbox.java+refs-changes-58-14058-5 41 Vaadin Remove TODO. I don't understand what it means [TodoComment] uitest/src/main/java/com/vaadin/tests/components/grid/basics/DataObject.java+refs-changes-81-14181-1 78 Vaadin Remove TODO. Javadoc is not strictly needed since this is a private class. [TodoComment] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-07-1907-4 61 Vaadin Single letter variable is veeeeeeeery bad style. Bad too minor issue of course. [LocalVariableName] uitest/src/com/vaadin/tests/tb3/VaadinBrowserFactory.java+refs-changes-62-11362-7 58 Vaadin TODO review this method [TodoComment] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-07-11407-3 1085 Vaadin TODO review this nested class [TodoComment] server/src/com/vaadin/ui/Grid.java+refs-changes-07-11407-3 1553 Vaadin TODO? [TodoComment] client/src/main/java/com/vaadin/client/connectors/selection/AbstractSelectionConnector.java+refs-changes-27-14227-4 43 Vaadin The formatting is off here [Indentation] client/src/com/vaadin/client/ui/VScrollTable.java+refs-changes-56-856-5 1104 Vaadin This class is missing JavaDoc [JavadocType] server/src/main/java/com/vaadin/server/data/SortOrder.java+refs-changes-80-14080-3 22 Vaadin "Using \magic numbers\"" should be avoided, but I guess that a small number such as 10 here is quite safe."" " [MagicNumber] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-19-11119-1 989 Vaadin Vaadin convention is to never use wildcard imports [AvoidStarImport] server/tests/src/com/vaadin/tests/server/renderer/RendererTest.java+refs-changes-91-10991-9 25 Vaadin "Very long line, may be split ? " [LineLength] server/src/com/vaadin/server/AbstractClientConnector.java+refs-changes-80-11480-1 95 Vaadin What does this TODO mean? [TodoComment] server/src/com/vaadin/ui/Grid.java+refs-changes-42-8842-1 3902 Vaadin add javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/HasSelectionChangeHandlers.java+refs-changes-05-3605-1 27 Vaadin address TODO [TodoComment] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-24-14224-21 561 Vaadin class and method javadoc & @since? [JavadocType] client/src/com/vaadin/client/communication/CommunicationProblemEvent.java+refs-changes-07-8607-6 23 Vaadin class javadoc [JavadocType] shared/src/main/java/com/vaadin/shared/ui/combobox/ComboBoxConstants.java+refs-changes-55-14255-25 20 Vaadin class javadoc? [JavadocType] server/src/main/java/com/vaadin/ui/Grid.java+refs-changes-81-14181-1 46 Vaadin could have javadoc on the class [JavadocType] server/src/test/java/com/vaadin/ui/ComponentTest.java+refs-changes-40-14340-6 26 Vaadin dat method name [MethodName] uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridColumnReorderTest.java+refs-changes-40-8740-2 352 Vaadin format the class? [WhitespaceAround] server/src/test/java/com/vaadin/tests/server/component/AbstractListenerMethodsTestBase.java+refs-changes-58-14058-5 152 Vaadin i'd rather se this nested if be added with a && into the previous one [NestedIfDepth] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-32-4332-1 2057 Vaadin including a constructor with this signature. [MissingCtor] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-29-3029-2 72 Vaadin javadoc [JavadocMethod] client/src/com/vaadin/client/ui/orderedlayout/Slot.java+refs-changes-97-4597-3 466 Vaadin javadoc [JavadocMethod] server/src/com/vaadin/ui/Button.java+refs-changes-80-980-1 584 Vaadin javadoc & @since for add/removeDataGenerator [JavadocMethod] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-07-11407-3 1113 Vaadin javadoc to indicate how this is where unrecoverable errors end up? [JavadocMethod] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-07-8607-6 3334 Vaadin javadocs [JavadocType] server/src/main/java/com/vaadin/ui/components/grid/Header.java+refs-changes-65-14465-7 25 Vaadin "javadocs? I know that there is none in the other classes, but why should you make it even worse. " [JavadocType] server/tests/src/com/vaadin/data/util/sqlcontainer/query/ValidatingSimpleJDBCConnectionPool.java+refs-changes-28-8828-2 26 Vaadin long line [LineLength] client/src/com/vaadin/client/componentlocator/VaadinFinderLocatorStrategy.java+refs-changes-10-2910-1 438 Vaadin long line [LineLength] client/src/com/vaadin/client/ui/VScrollTable.java+refs-changes-10-2910-1 4505 Vaadin long line [LineLength] client/src/com/vaadin/client/ui/dd/VDragEvent.java+refs-changes-10-2910-1 179 Vaadin missing space [WhitespaceAfter] server/src/com/vaadin/ui/renderers/ButtonRenderer.java+refs-changes-91-10991-2 62 Vaadin new name makes more sense to me in this scope [MemberName] client/src/com/vaadin/client/ui/VTree.java+refs-changes-94-4994-1 168 Vaadin private ? [VisibilityModifier] uitest/src/test/java/com/vaadin/tests/components/textfield/Selection.java+refs-changes-12-14212-2 6 Vaadin protected requires javadocs [JavadocMethod] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-41-14641-2 497 Vaadin should make fields private (when merging with DCPH) [VisibilityModifier] client/src/com/vaadin/client/communication/ReconnectingCommunicationProblemHandler.java+refs-changes-18-8618-10 34 Vaadin shouldn't a constant be uppercase? [ConstantName] client/src/com/vaadin/client/ui/orderedlayout/Slot.java+refs-changes-48-3548-3 86 Vaadin still missing javadocs [JavadocMethod] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-41-14641-3 497 Vaadin strange indentation [Indentation] uitest/src/main/java/com/vaadin/tests/core/SpecialCharactersEncodingUI.java+refs-changes-04-14204-1 20 Vaadin strange whitespace [ParenPad] server/src/test/java/com/vaadin/server/AbstractClientConnectorTest.java+refs-changes-09-14709-3 48 Vaadin these fields should be private [VisibilityModifier] client/src/com/vaadin/client/communication/ReconnectingCommunicationProblemHandler.java+refs-changes-20-8620-13 45 Vaadin why is this imported if not used? [UnusedImports] server/src/test/java/com/vaadin/tests/design/ComponentFactoryTest.java+refs-changes-54-14054-7 22 EclipsePlatformUI add brackets [NeedBraces] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/set/UnionSetProperty.java+refs-changes-11-90511-3 63 EclipsePlatformUI Description is missing. [JavadocStyle] examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/TestJobRule.java+refs-changes-55-46455-2 26 EclipsePlatformUI Did not check but can this method be declared as private? [VisibilityModifier] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/e4/compatibility/ModeledPageLayout.java+refs-changes-32-33732-2 627 EclipsePlatformUI final [FinalParameters] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/SuppliedImageDescriptor.java+refs-changes-28-62028-3 20 EclipsePlatformUI Fit in one line? [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java+refs-changes-17-90517-4 736 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/map/DelegatingMapProperty.java+refs-changes-99-50299-9 35 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToBigIntegerConverter.java+refs-changes-00-50300-8 33 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToByteConverter.java+refs-changes-00-50300-8 45 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityObservableSet.java+refs-changes-99-50299-9 107 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToShortConverter.java+refs-changes-00-50300-8 40 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/UnionSet.java+refs-changes-99-50299-9 84 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/UnmodifiableObservableValue.java+refs-changes-99-50299-9 28 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java+refs-changes-00-50300-8 163 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java+refs-changes-00-50300-8 568 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java+refs-changes-00-50300-8 28 EclipsePlatformUI Fits into previous line. [NoLineWrap] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/value/ValueProperty.java+refs-changes-99-50299-9 193 EclipsePlatformUI indentation? [Indentation] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/CommonActionDescriptorManager.java+refs-changes-13-90513-2 194 EclipsePlatformUI Make final [FinalLocalVariable] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PendingSyncExec.java+refs-changes-87-83487-2 17 EclipsePlatformUI Merge with the previous line. [NoLineWrap] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java+refs-changes-98-64498-1 164 EclipsePlatformUI rename 'selection' [LocalVariableName] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java+refs-changes-13-90613-1 978 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java+refs-changes-99-50299-9 189 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java+refs-changes-00-50300-8 182 EclipsePlatformUI Remove the space after [GenericWhitespace] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java+refs-changes-00-50300-8 140 EclipsePlatformUI rename 'descriptor' [LocalVariableName] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/NavigatorSorterService.java+refs-changes-13-90513-2 59 EclipsePlatformUI "Can we please name it \""descriptor\""? \""res\"" is usually used for IResource and friends. " [LocalVariableName] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workbench/ResourceExtensionLabelProvider.java+refs-changes-99-82899-3 61 EclipsePlatformUI the reason to use _ is exactly that it is uncommon so noone else is overwriting it [ParameterName] bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceImpl.java+refs-changes-98-40098-1 86 EclipsePlatformUI Wrong intension [Indentation] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/ContributionRoot.java+refs-changes-17-90517-4 92 OpenDaylight_Controller Please add the copyirght notice in new files [Header] opendaylight/protocol_plugins/stub/src/main/java/org/opendaylight/controller/protocol_plugins/stub/internal/TopologyServices.java+refs-changes-21-1521-1 0 OpenDaylight_Controller add javadoc [JavadocType] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/NetconfDeviceTwoPhaseCommitTransaction.java+refs-changes-93-6793-6 52 OpenDaylight_Controller Can you add class javadocs explaining the usage of this class? [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/RootDataTreeCandidateNode.java+refs-changes-91-18591-10 16 OpenDaylight_Controller Can you javadoc the difference between writeDocument and writeData? At first I didn't know the difference until I looked at the source code in XmlStreamUtils (it would also be good if the XmlStreamUtils methods were javadoc'ed). [JavadocMethod] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlMapper.java+refs-changes-77-8877-2 79 OpenDaylight_Controller final if possible [FinalClass] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/get/FilterSchema.java+refs-changes-83-16483-1 20 OpenDaylight_Controller I can but I don't think it would add much value. This is not a public API. There is only one caller and it propagates unchecked exceptions back to akka anyway so it wouldn't benefit from the declaration. Plus there's other code paths that could raise unchecked exceptions (yang tools is littered with them) and we don't declare RuntimeException everywhere so we're being consistent by not doing so here. [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java+refs-changes-87-36987-5 94 OpenDaylight_Controller I forgot to tell you that all new files need to contain a copyright header: Please see https://wiki.opendaylight.org/view/OpenDaylight_Controller:Developing_With_Intellij#Copyright_headers and set your IDE to add these headers. Also please add header to all new Tests. [Header] opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/controller/netconf/client/NetconfClientConfigurationTest.java+refs-changes-48-11048-1 1 OpenDaylight_Controller I guess your auto-formatting config in IJ added the space but I prefer the no space :) [NoWhitespaceAfter] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-04-29804-2 237 OpenDaylight_Controller indentation [Indentation] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java+refs-changes-71-33871-1 67 OpenDaylight_Controller javadocs please [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardModification.java+refs-changes-29-46829-62 22 OpenDaylight_Controller Minor thing but it's not usually good practice to catch Throwable as that includes JVM errors although in this case it's OK since it will get propagated. But it will trigger a checkstyle/PMD violation - catch Exception will avoid that. [IllegalCatch] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shardmanager/ShardManagerInfo.java+refs-changes-42-27742-6 120 OpenDaylight_Controller missing space [WhitespaceAround] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActor.java+refs-changes-84-51584-7 193 OpenDaylight_Controller Please add javadocs [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/CDSShardAccessImpl.java+refs-changes-43-53543-6 35 OpenDaylight_Controller Please put return on separate line. [OneStatementPerLine] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java+refs-changes-65-10665-12 62 OpenDaylight_Controller Robert - do you agree with my comment i.e. suppress it and if/when findbugs is fixed to handle it properly we can remove the suppression? [SuppressWarnings] opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java+refs-changes-73-47473-3 32 OpenDaylight_Controller some javadoc would be nice [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/ShardConfigUpdateHandler.java+refs-changes-09-50609-30 49 OpenDaylight_Controller space after commas [WhitespaceAfter] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-2 206 OpenDaylight_Controller What is this class for? Can you add javadocs? [JavadocType] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/policy/DisableElectionsRaftPolicy.java+refs-changes-59-24459-3 11 OpenDaylight_Controller What's the purpose of this class? I don't see it used. Also since this class is a utility and not a message it should be in a utils package. [JavadocType] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/NormalizedNodeObjectOutput.java+refs-changes-90-16690-14 19 Vaadin No license header? [Header] uitest/src/com/vaadin/tests/components/gridlayout/GridLayoutWithNonIntegerWidth.java+refs-changes-18-3118-2 0 Vaadin Comment about what this contains. Options enabled on server side? [JavadocVariable] client/src/com/vaadin/client/ui/VOptionGroup.java+refs-changes-81-381-2 58 Vaadin extra import java.sql.Time? [RedundantImport] server/src/test/java/com/vaadin/tests/server/component/datefield/DateFieldDeclarativeTest.java+refs-changes-02-13602-3 18 Vaadin fill or remove empty javadoc [JavadocStyle] client/src/com/vaadin/client/ui/grid/selection/SelectionChangeEvent.java+refs-changes-05-3605-1 40 Vaadin Javadoc [JavadocMethod] server/src/com/vaadin/server/FontAwesome.java+refs-changes-89-8589-3 584 Vaadin Javadoc [JavadocMethod] client/src/com/vaadin/client/ui/grid/GridStaticSection.java+refs-changes-16-4016-3 66 Vaadin javadoc [JavadocMethod] server/src/main/java/com/vaadin/ui/ProgressBar.java+refs-changes-30-14230-1 110 Vaadin javadoc [JavadocMethod] client/src/com/vaadin/client/communication/ServerMessageHandler.java+refs-changes-08-8608-7 76 Vaadin Javadoc missing from all methods [JavadocMethod] server/src/com/vaadin/ui/components/grid/renderers/NumberRenderer.java+refs-changes-01-3801-1 32 Vaadin javadoc? [JavadocMethod] server/src/main/java/com/vaadin/ui/Grid.java+refs-changes-81-14181-1 307 Vaadin javadoc? [JavadocMethod] server/src/main/java/com/vaadin/data/SimpleResult.java+refs-changes-55-14055-3 34 Vaadin Missing JavaDoc. Repeat below [JavadocMethod] client/src/com/vaadin/client/ui/grid/selection/SelectionModel.java+refs-changes-05-3605-3 88 Vaadin Missing license header [Header] uitest/src/com/vaadin/tests/push/PushFromInit.java+refs-changes-56-1856-5 1 Vaadin More minor details: The style of this javadoc is not consistent with the one for removeBlurHandler and neither follows the official recommendations from http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html.\n\n* \"The description is in 3rd person declarative rather than 2nd person imperative\" i.e. \"Adds\" rather than \"Add\".\n* First Sentence: \"This sentence ends at the first period\".\n* @param: \"When writing a phrase do not capitalize and do not end with a period\" and \"If you prefer starting with a sentence capitalize it and end it with a period\". A sentence should however have verbs and stuff... [JavadocStyle] client/src/com/vaadin/client/ui/VRichTextArea.java+refs-changes-98-1398-3 425 Vaadin No license header? [Header] uitest/src/com/vaadin/tests/components/table/FixedHeightTable.java+refs-changes-18-3118-2 0 Vaadin No license header? [Header] server/tests/src/com/vaadin/tests/server/component/tree/TreeListeners.java+refs-changes-18-3118-2 0 Vaadin Please create an enhancement ticket instead of keeping a TODO in the code. [TodoComment] server/src/com/vaadin/server/ClientMethodInvocation.java+refs-changes-05-2005-1 48 Vaadin Pls don't have non-private fields. Instead add a documented method for doing the needed data access.\n\nAn alternative approach could be to instead keep track of the actual mapping inside AbstractRemoteDataSource and using an abstract method for getting the key for an object that the extender should implement. [VisibilityModifier] client/src/com/vaadin/client/data/AbstractRemoteDataSource.java+refs-changes-13-3713-3 58 Vaadin private ? [VisibilityModifier] uitest/src/test/java/com/vaadin/tests/components/textfield/Selection.java+refs-changes-12-14212-2 6 Vaadin Should document which type of index this is [JavadocMethod] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-14-3614-8 1791 Vaadin so is this to be camelCase or not? [MemberName] client/src/com/vaadin/client/Util.java+refs-changes-06-3006-2 151 Vaadin The purpose of this variable could need some explanation. I think I got it figured out by seeing the variable in actual use but an explanation here wouldn't hurt. [JavadocVariable] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-56-1956-5 1426 Vaadin TODO ? [TodoComment] server/src/com/vaadin/ui/declarative/DesignContext.java+refs-changes-44-12144-2 564 Vaadin TODO needs to be fixed [TodoComment] server/src/com/vaadin/server/VaadinPortlet.java+refs-changes-09-1009-1 468 Vaadin What are these TODOs? are they still relevant? If not remove them. [TodoComment] uitest/src/com/vaadin/tests/components/table/ExpandingContainer.java+refs-changes-41-2441-1 52 Vaadin Will fix javadoc/license header if this is approved. [Header] client/src/main/java/com/vaadin/client/event/InputEvent.java+refs-changes-54-14054-8 0 CheckStyle Description Check nested (inner) classes/interfaces are declared at the bottom of the class after all method and field declarations. [InnerTypeLast] no_file 0 CheckStyle Description Validates identifiers for abstract classes. [AbstractClassName] no_file 0 CheckStyle Description "Check location of annotation on language elements. By default, Check enforce to locate annotations immediately after documentation block and before target element, annotation should be located on separate line from target element." [AnnotationLocation] no_file 0 CheckStyle Description Checks for long anonymous inner classes. [AnonInnerLength] no_file 0 CheckStyle Description Detects inline conditionals [AvoidInlineConditionals] no_file 0 CheckStyle Description Checks that there are no static import statements. [AvoidStaticImport] no_file 0 CheckStyle Description Checks for long methods and constructors [MethodLength] no_file 0 CheckStyle Description "Checks the padding between the identifier of a method definition, constructor definition, method call, or constructor invocation; and the left parenthesis of the parameter list. That is, if the identifier and left parenthesis are on the same line, checks whether a space is required immediately after the identifier or such a space is forbidden. If they are not on the same line, reports an error, unless configured to allow line breaks. To allow linebreaks after the identifier, set property allowLineBreaks to true." [MethodParamPad] no_file 0 CheckStyle Description Checks line wrapping with separators. [SeparatorWrap] no_file 0 CheckStyle Description Checks that string literals are not used with == or !=. [StringLiteralEquality] no_file 0 CheckStyle Description "Checks the policy on the padding of parentheses for typecasts. That is, whether a space is required after a left parenthesis and before a right parenthesis, or such spaces are forbidden." [TypecastParenPad] no_file 0 CheckStyle Description "Checks that There is one blank line between each of two paragraphs and one blank line before the at-clauses block if it is present. Each paragraph but the first has

immediately before the first word, with no space after." [JavadocParagraph] no_file 0 CheckStyle Description "Checks that the at-clause tag is followed by description." [NonEmptyAtclauseDescription] no_file 0 CheckStyle Description "Controls the indentation between comments and surrounding code. Comments are indented at the same level as the surrounding code" [CommentsIndentation] no_file 0 CheckStyle Description Checks for empty catch blocks. [EmptyCatchBlock] no_file 0 CheckStyle Description This check can be used to ensure that types are not declared to be thrown. Declaring that a method throws java.lang.Error or java.lang.RuntimeException is almost never acceptable. [IllegalThrows] no_file 0 CheckStyle Description Checks that there is only one statement per line. [OneStatementPerLine] no_file 0 CheckStyle Description Checks for redundant import statements. [RedundantImport] no_file 0 CheckStyle Description This check allows you to specify what warnings that SuppressWarnings is not allowed to suppress. You can also specify a list of TokenTypes that the configured warning(s) cannot be suppressed on. [SuppressWarnings] no_file 0 OpenDaylight_Controller The Customizers with the AddServvice are both created and registered after this assignment in start(). I would expect start to be called after stop has completed. [not_related_to_checkstyle] opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/osgi/ConfigPersisterActivator.java+refs-changes-44-9844-1 61 OpenDaylight_Controller Merging in proposed changes now. [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/RpcInvocationStrategy.java+refs-changes-06-6906-4 95 OpenDaylight_Controller Can we verify expected data in the ReplicatedLog instead of just verifying a new instance? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTest.java+refs-changes-71-12471-2 747 OpenDaylight_Controller Can this blocks be put in a common method passing the reply we are expecting? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/BasicIntegrationTest.java+refs-changes-70-8270-3 62 OpenDaylight_Controller We should out this in the try block as IMDS call is actually synchronous and might throw unchecked exception. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java+refs-changes-82-15182-1 128 OpenDaylight_Controller NPE if the topology does not exist. Also topology.getNode() is guaranteed to be immutable so no there's no point of copying it. If you really need a mutable copy just perform new ArrayList<>(topology.getNode()) with check for null. [not_related_to_checkstyle] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceTopology.java+refs-changes-31-15031-2 95 OpenDaylight_Controller Can you prepend persistenceId() to the log messages? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-04-29804-2 254 OpenDaylight_Controller com.google.common.util.concurrent.ThreadFactoryBuilder ? [not_related_to_checkstyle] opendaylight/netconf/netconf-testtool/src/main/java/org/opendaylight/controller/netconf/test/tool/NetconfDeviceSimulator.java+refs-changes-42-11842-2 101 OpenDaylight_Controller so I believe this log will provide similar information than bundle:diag minus any stacktrace\n\nShouldn't this be set to WARN level so user is able identify easily those event in the logs? [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/BlueprintBundleTracker.java+refs-changes-20-42320-1 212 OpenDaylight_Controller Why not just remove this method? This isn't a public/published API. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DatastoreContext.java+refs-changes-68-29668-8 400 OpenDaylight_Controller Create Proper Public Access to the lists print it in the shell command not here.. [not_related_to_checkstyle] opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java+refs-changes-23-6823-7 1622 OpenDaylight_Controller What if a shard configuration doesn't exist for the shard name? onReplicateCreatedShard adds the prefix config before sending AddPrefixShardReplica so that shouldn't happen unless someone else sends AddPrefixShardReplica. So other than not checking for a shard config this method is the same as onAddShardReplica so why not use AddShardReplica in place of AddPrefixShardReplica? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManager.java+refs-changes-05-44705-3 1171 OpenDaylight_Controller Should we ensure the current state is CAN_COMMIT_PENDING? Same with failedCanCommit successfulPreCommit et al [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohort.java+refs-changes-97-42497-7 159 OpenDaylight_Controller "Should be \""It provides...\"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMNotificationPublishService.java+refs-changes-84-11484-10 17 OpenDaylight_Controller This code seems to be platform dependant. Could you please add that into comments for this example. [not_related_to_checkstyle] opendaylight/md-sal/samples/pingDiscovery/src/main/java/org/opendaylight/controller/sample/pingdiscovery/impl/PingServiceExecSystemImpl.java+refs-changes-49-7249-16 43 OpenDaylight_Controller I updated all of TwoNodeRaftStrategy and will conform going forward. Thanks. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/consensus/TwoNodeRaftStrategy.java+refs-changes-32-12832-1 88 OpenDaylight_Controller Can you put this check in a method isServerConfigurationPayload(ReplicatedLogEntry) for clarity and change the other 2 places as well to call it? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorRecoverySupport.java+refs-changes-12-29112-2 160 OpenDaylight_Controller Yup - made a boo boo. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreIntegrationTest.java+refs-changes-82-12582-1 686 OpenDaylight_Controller If the ctor is private how would one construct an instance? [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/io/FileBackedOutputStreamFactory.java+refs-changes-67-55767-15 29 OpenDaylight_Controller how is this different from java.util.concurrent.ThreadPoolExecutor? [not_related_to_checkstyle] opendaylight/md-sal/sal-persisted-dom/src/main/java/org/opendaylight/persisted/ThreadPool.java+refs-changes-53-12053-40 5 OpenDaylight_Controller Im assuming that using Cache would provide us with extra functionality that we want to leverage can you provide more details on that -- Since the number of Shards are pretty much static i.e. on a running system the size of HashMap should have been fixed -- trying to understand how HashMap would have impacted. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shard/ShardMBeanFactory.java+refs-changes-42-10342-4 27 OpenDaylight_Controller Yes I will tunnel that in a follow up patch [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/RemoteProxyTransaction.java+refs-changes-46-39946-48 53 OpenDaylight_Controller Done. But just for curiosity what is the benefit of doing this in enum's constructor? [not_related_to_checkstyle] opendaylight/config/config-util/src/main/java/org/opendaylight/controller/config/util/xml/DocumentedException.java+refs-changes-26-48326-1 74 OpenDaylight_Controller Does not apply to this abstract method. [not_related_to_checkstyle] opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/ProgressTracker.java+refs-changes-53-49053-14 304 OpenDaylight_Controller OK - instead of requiring the client to unregister can't the implementation do it automatically? Essentially this means the listener is done so auto-unregistering seems to make sense. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeListener.java+refs-changes-98-14998-8 37 OpenDaylight_Controller Add @Nonnull [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/config/ConfigurationImpl.java+refs-changes-05-44705-3 189 OpenDaylight_Controller There was a reason originally I was passing it down but it no longer needs to be. I changed it to create the DurationStatsTracker in the DOMDataCommitCoordinator and get it via accessor. I assume that's not a layering violation. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataBrokerImpl.java+refs-changes-27-10327-8 57 OpenDaylight_Controller Yes will change it. [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/utils/LatestEntryRoutingLogic.java+refs-changes-62-9862-3 41 OpenDaylight_Controller Should this wait on the Future to ensure it completes? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortFailureTest.java+refs-changes-75-9975-1 198 OpenDaylight_Controller Can any of these be null? [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingToNormalizedNodeCodec.java+refs-changes-26-17526-1 245 OpenDaylight_Controller if this statement throws an exception you return false and fail to unregister [not_related_to_checkstyle] opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/AbstractMXBean.java+refs-changes-27-10327-8 105 OpenDaylight_Controller Why are these all commented out? [not_related_to_checkstyle] opendaylight/md-sal/statistics-manager/src/test/java/test/mock/PortStatisticsTest.java+refs-changes-80-11780-9 73 OpenDaylight_Controller Verification removed??? [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/test/java/org/opendaylight/controller/protobuff/messages/transaction/ShardTransactionChainMessagesTest.java+refs-changes-95-11795-7 33 OpenDaylight_Controller An Isolated leader does not stop replicating when isolated - thus it should be capable of installing a snapshot. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-09-13109-3 75 OpenDaylight_Controller This test alone will take 6 seconds atleast to complete. Why can't we just use Await.result here? [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/RemoteRpcProviderTest.java+refs-changes-62-9862-3 61 OpenDaylight_Controller I'll make it clearStatistics then. This appears as a button in JConsole so I think it needs more context than just clear. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/TransactionStatsMXBean.java+refs-changes-23-10823-11 95 OpenDaylight_Controller The RaftRoleChangeNotifier already logs to info when it starts so this appears redundant. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-33-12933-2 141 OpenDaylight_Controller I would argue to remove RaftState class. Its confusing whether state transitions should happen between RaftState or RaftActorBehavior.\n\nWe could change the method signature to \nprivate RaftActorBehavior switchBehavior(Class behavior) \n\nSwitching behavior based on provided behavior seems more clear. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-98-8998-4 133 OpenDaylight_Controller I can use that [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java+refs-changes-68-14868-5 1189 OpenDaylight_Controller Maybe we should include the underlying exception with the RestconfDocumentedException? [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonNormalizedNodeBodyReader.java+refs-changes-17-19417-1 113 OpenDaylight_Controller Can't QName be NULL? [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/serialization/PathArgumentSerializer.java+refs-changes-68-10268-7 190 OpenDaylight_Controller "I am not sure how to read this. Please make sure your use of capital \""MAY\"" and similar follows RFC 2119. " [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataListener.java+refs-changes-42-14542-2 28 OpenDaylight_Controller (Debug) Should we include any logging to report the effective dispatcher for each DispatcherType @ runtime since a default dispatcher will always be assigned? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/Dispatchers.java+refs-changes-92-15592-1 42 OpenDaylight_Controller "Yes line 226 is what I referred to as \""the next line\"". The clarity is debatable but it's clearly a little better by switching the order to remove one addition (it's not a performance problem). " [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-50-19450-1 225 OpenDaylight_Controller This is a policy to disable raft elections which might be generally useful so I think we should put it in sal-akka-raft. In fact there already is a DisableElectionsRaftPolicy under sal-akka-raft/src/test/java so you could just move it. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/policy/ShardInitRaftPolicy.java+refs-changes-96-28596-1 19 OpenDaylight_Controller This is not correct as it prevents subclasses from increasing the bound e.g. returning ListenableFuture instead. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMNotificationPublishService.java+refs-changes-92-45992-1 90 OpenDaylight_Controller and do not add here blank line as usual in other files in project [not_related_to_checkstyle] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/RuntimeRequestExceptionTest.java+refs-changes-38-52638-2 8 OpenDaylight_Controller yup [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/NormalizedNodeXMLOutput.java+refs-changes-87-36987-4 55 OpenDaylight_Controller You should call mockRaftActor.waitForInitializeBehaviorComplete() [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTest.java+refs-changes-96-28596-4 1019 OpenDaylight_Controller CLI file please don't change it because the output shall be generated to user directly [not_related_to_checkstyle] opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManagerCLI.java+refs-changes-98-4498-1 0 OpenDaylight_Controller new HashMap<>(); [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-53543-6 423 OpenDaylight_Controller log.debug() would be useful to privde equivalent info as the throw below. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RoutedRpcMetadata.java+refs-changes-05-47605-1 98 OpenDaylight_Controller Access to registrations should be synchronized. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java+refs-changes-89-49189-37 325 OpenDaylight_Controller Can you provide a link? [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/RuntimeDataProvider.java+refs-changes-22-8322-1 19 OpenDaylight_Controller This looks to be common between all these classes - you could create an abstract base class. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/ShardedDataTreeActor.java+refs-changes-69-48869-23 719 OpenDaylight_Controller "Should we convert elapsedTime to millis for better readability? Also include the units in the message i.e. \""Elapsed Time = {} ms/ns\"". " [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-47-15547-1 287 OpenDaylight_Controller You can actually get a snapshot directly from the getDataTree. I did this in my patch so as not to have to make ReadOnlyShardDataTreeTransaction et al public. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnershipShard.java+refs-changes-05-25505-1 313 OpenDaylight_Controller delete line [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplTest.java+refs-changes-72-21372-1 148 OpenDaylight_Controller that is correct -- all of them are rooted at / [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ModuleShardStrategy.java+refs-changes-29-46829-69 34 OpenDaylight_Controller Not sure how that happened. I'll fix it in the follow-up. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/BlueprintContainerRestartServiceImpl.java+refs-changes-76-36476-19 23 OpenDaylight_Controller I added 'id' later for the debug logging and didn't add Preconditions check. I can add it if you want. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/GetSnapshotReplyActor.java+refs-changes-85-29085-9 84 OpenDaylight_Controller This probably should be declared volatile to ensure immediate thread visibility. [not_related_to_checkstyle] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/eventsources/netconf/NetconfEventSourceManager.java+refs-changes-01-16401-4 74 OpenDaylight_Controller Why not just make this volatile? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractShardBackendResolver.java+refs-changes-92-48292-22 47 OpenDaylight_Controller It's used by DOMDataBrokerImpl. I added a second ctor that takes no tracker instance so I didn't have to change all the unit tests that don't care about the stats to have to pass an instance. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/NoopTransactionStatsTracker.java+refs-changes-23-10823-11 18 OpenDaylight_Controller violation of @GuardedBy [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/PingPongTransactionChain.java+refs-changes-77-42277-2 267 OpenDaylight_Controller Right. Duh. I should've seen that. [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/AbstractForwardedDataBroker.java+refs-changes-96-24496-2 156 OpenDaylight_Controller Declare as List instead of concrete ArrayList? [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazyDataObjectModification.java+refs-changes-26-17526-1 51 OpenDaylight_Controller Utilize the new updated boolean returned from FollowerLogInformation. I did this for logging. I found it useful to log the follower's current indexes but only if they changed. I didn't want to always log it as that results in a lot of extraneous output from heartbeats when nothing changed. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-27-15627-10 192 OpenDaylight_Controller add a message [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/CDSShardAccessImpl.java+refs-changes-43-53543-6 64 OpenDaylight_Controller decorate checks for the base interface ServiceMetadata. I could check for MutableServiceMetadata there and ignore if it's ServiceMetadata but not MutableServiceMetadata. This was the pattern I borrowed from Aries code in their extensions i.e. they fail if the component isn't mutable. All the components created internally by Aries are mutable. In extensions they strongly recommend you return mutable metadata instances so they can be extended by others. Not sure of their motivation for hard failure if not mutable.\n\nGiven that I think we're safe to just check for MutableServiceMetadata in decorate and ignore if not. What do you think? If we agree I'll do it in my follow-up. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/OpendaylightNamespaceHandler.java+refs-changes-82-36482-21 101 OpenDaylight_Controller Why is LLDP code still in the controller? I wonder if any of the classes in this package are even used anymore... [not_related_to_checkstyle] opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java+refs-changes-18-58018-1 19 OpenDaylight_Controller Let's use interpolation instead of concatenation for logging. Will be faster and will have less of an impact when debug logging is off. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/example/ExampleActor.java+refs-changes-20-9520-1 59 OpenDaylight_Controller "Looks like listenerRegistrations needs to be synchronized. However the registerNotificationListener interface indicates that \""registering an instance multiple times results in notifications being delivered to each registration\"". So if this method is called twice for the same SchemaPath we would have 2 registrations which I don't think is desired.\n\nSo similar to what I commented below for streamIsActive you could use a LoadingCache> for listenerRegistrations. You would need to register for each SchemaPath separately instead of passing the entire list in one registerNotificationListener call. " [not_related_to_checkstyle] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/eventsources/netconf/NetconfEventSource.java+refs-changes-01-16401-4 118 OpenDaylight_Controller "\""at least\"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedShardFactory.java+refs-changes-05-44705-2 24 OpenDaylight_Controller Looks a bit like a layering violation. What are the lifecycle rules here? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataBrokerImpl.java+refs-changes-27-10327-8 57 OpenDaylight_Controller Can you remove this unnecessary change? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohort.java+refs-changes-02-32602-15 50 OpenDaylight_Controller Done using concurrentHashSet [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/CDSShardAccessImpl.java+refs-changes-43-53543-6 41 OpenDaylight_Controller I realized we don't even use/need this. Removing this completely. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardFrontend.java+refs-changes-89-49189-37 46 OpenDaylight_Controller Just in case keyScheme is not set in config.ini wouldn't it be better to set it to IP scheme by default here? [not_related_to_checkstyle] opendaylight/hosttracker/implementation/src/main/java/org/opendaylight/controller/hosttracker/internal/HostTracker.java+refs-changes-17-2817-9 128 OpenDaylight_Controller ==> https://git.opendaylight.org/gerrit/#/c/45589/ [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/xtendbeans/AssertDataObjects.java+refs-changes-99-44099-15 21 OpenDaylight_Controller Why this change? The toString should be the correct one. [not_related_to_checkstyle] opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManagerImpl.java+refs-changes-45-245-4 739 OpenDaylight_Controller Yeah this was a mark for follow-up to analyze injection strategy I will follow up a bit more. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/config/yang/config/distributed_entity_ownership_service/DistributedEntityOwnershipServiceProviderModule.java+refs-changes-01-35501-2 59 OpenDaylight_Controller We need a reference to config/operational data store and the base/one/subtree enum here. [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataChangePublisher.java+refs-changes-95-5595-1 29 OpenDaylight_Controller Switched to MessageCollectorActor. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java+refs-changes-08-15208-2 105 OpenDaylight_Controller Preconditions.checkNotNull() or is null special? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/FlipShardMembersVotingStatus.java+refs-changes-86-38086-4 19 OpenDaylight_Controller inline into callers [not_related_to_checkstyle] opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/gofactory/AbsModuleGeneratedObjectFactory.java+refs-changes-90-57190-1 48 OpenDaylight_Controller Tokes (sic) [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/TokenTypes.java+refs-changes-74-30274-25 31 OpenDaylight_Controller Is this right? We send a poison pill to self and then continue with processing? Technically this should be fine because the PoisonPill will be queued but we'll be scratching our heads about this later. \n\nOr this could be a merge issue.... [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java+refs-changes-98-18498-26 87 OpenDaylight_Controller this could have been done in the patch on top of this one related to toaster to be *really* accurate with commit message [not_related_to_checkstyle] opendaylight/md-sal/samples/toaster-it/src/test/java/org/opendaylight/controller/sample/toaster/it/ToasterTest.java+refs-changes-91-39891-1 35 OpenDaylight_Controller whats the change here? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/identifiers/ShardIdentifier.java+refs-changes-66-19266-2 127 OpenDaylight_Controller What if e was null? Should we protect against that? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/PingPongFuture.java+refs-changes-81-17581-3 24 OpenDaylight_Controller NOK; FYI this was already like this in AbstractDataBrokerTest today since the dawn of time; I've just re-factored it here... Tell you what as this is not how I would design this for today's JUnit anyway I've moved this helper method as-is away from here in the new AbstractBaseDataBrokerTest into the now @Deprecated AbstractDataBrokerTest just so not to break existing tests and new tests extending AbstractConcurrentDataBrokerTest can instead of this just use their own @Before annotated method as illustrated in the AbstractDataBrokerTestTest (it works). [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/AbstractBaseDataBrokerTest.java+refs-changes-86-51486-1 36 OpenDaylight_Controller What do these changes have to do with this particular patch? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractSnapshotBackedTransactionChain.java+refs-changes-59-19259-31 123 OpenDaylight_Controller The namespace can be extracted from the element does not have to be passed separately [not_related_to_checkstyle] opendaylight/netconf/mdsal-netconf-connector/src/main/java/org/opendaylight/controller/netconf/mdsal/connector/ops/get/AbstractGet.java+refs-changes-83-16483-1 124 OpenDaylight_Controller It seems to me a WriteTransaction might suffice for this. [not_related_to_checkstyle] opendaylight/md-sal/inventory-manager/src/main/java/org/opendaylight/controller/md/inventory/manager/InventoryOperation.java+refs-changes-47-9747-6 14 OpenDaylight_Controller Fair enough :) [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/SnapshotManager.java+refs-changes-72-50572-5 137 OpenDaylight_Controller This may happen if the chain is closed before the last transaction is readied. Also when the chain fails asynchronously. I do not think its a user error and we can recover easily. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractSnapshotBackedTransactionChain.java+refs-changes-43-18843-3 179 OpenDaylight_Controller Same as above comment about returning Option vs null [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/CompositeNodeCompatibility.java+refs-changes-67-10167-3 277 OpenDaylight_Controller datastore-info might make more sense [not_related_to_checkstyle] opendaylight/md-sal/mdsal-cli/src/main/java/org/opendaylight/mdsal/cli/StoresInfo.java+refs-changes-51-36751-6 25 OpenDaylight_Controller I wrote this code before I tested and found xsd validation takes care of it. Only time we will hit this is if new parameter is added to xsd but not to parsing code. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/OpendaylightNamespaceHandler.java+refs-changes-86-44386-3 366 OpenDaylight_Controller "\"". this \"" -> \"". This \"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LeaderFrontendState.java+refs-changes-32-41032-64 39 OpenDaylight_Controller "Done.. if I understood you correctly please double check. I went straight fro String instead of Object serviceType in line 145 because even if it is null the type cast will work (it would just be a null string) so not sure why you suggested to do it after line 150? Like this is actually perfectly fine:\n\n Object o = null;\n String s = (String) o; // no Exception thrown here\n System.out.println(s); // \""null\"" " [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/SpecificReferenceListMetadata.java+refs-changes-98-56098-1 170 OpenDaylight_Controller I hate to say it but this is what we need to describe here. We can't expect new users to be able to find that documentation by them selves. I don't even know where to find that based on the above description.\n\nWe don't have to provide the explicit behaviors here (though I think that would be smart). We at a minimum need to provide direct pointers so folks can quickly and easily find the references defined above.\n\nRemember our goal is to make this something a person can pick up and understand quickly with little effort. [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java+refs-changes-46-8046-1 134 OpenDaylight_Controller I think you could watch for listener actor Terminated message. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/notifications/RaftRoleChangeNotifier.java+refs-changes-33-12933-2 75 OpenDaylight_Controller Let me try this & comeback Tom [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTest.java+refs-changes-21-27721-2 1036 OpenDaylight_Controller Can these be accessed concurrently? Use AtomicLong? At the very least they should be volatile. [not_related_to_checkstyle] opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/YnlListener.java+refs-changes-20-52320-5 28 OpenDaylight_Controller Done. 1st log added for my debugging removed it. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-96-28596-1 816 OpenDaylight_Controller I'm not sure what you're doing here. We want to set the leaderId in this instance to null. But since this is specific to Follower it should be done in Follower#handleMessage on receipt of the ElectionTimeout message. So when the scheduled timer is triggered and the ElectionTimeout message we want to set leaderId to null if !canStartElection. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractRaftActorBehavior.java+refs-changes-88-41088-1 408 OpenDaylight_Controller We should write the data to a file for troubleshooting. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java+refs-changes-74-42974-19 60 OpenDaylight_Controller Remove commented code [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Follower.java+refs-changes-00-9300-5 43 OpenDaylight_Controller Right I lost the final case :-) [not_related_to_checkstyle] opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/AbstractClientConnection.java+refs-changes-10-44910-58 203 OpenDaylight_Controller Is this right? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionProxy.java+refs-changes-95-15095-3 218 OpenDaylight_Controller It's not exactly duplicated since the base class is different the in sal-distributed-datastore seem to rely on this different base class. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/AbstractClusterRefActorTest.java+refs-changes-29-46829-62 18 OpenDaylight_Controller can any of these be null? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataCommitCoordinatorImpl.java+refs-changes-95-7395-3 77 OpenDaylight_Controller not sure if it means the one on which the IFRM call is executed or the one that programs the flow on node (and I know what it supposed to mean :) ) [not_related_to_checkstyle] opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/ForwardingRulesManager.java+refs-changes-50-5050-6 559 OpenDaylight_Controller Since you have your own null-check \n\n if (this.store != null && !this.store.equals(store)) { [not_related_to_checkstyle] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-1 107 OpenDaylight_Controller The assertion is fine but I don't see how it could be null here. Loop goes 0-10 so will get in. If createTestActor succeeds it will return inline. If InvalidActorNameException is thrown we set lastEx. If an unchecked ex is thrown from createTestActor it will throw out of the method. Am I missing something here? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/AbstractRaftActorIntegrationTest.java+refs-changes-47-19447-1 205 OpenDaylight_Controller Do we need this to be a warning? Won't this happen every time as bundle 0 is stopped first on shutdown? [not_related_to_checkstyle] opendaylight/md-sal/sal-schema-service/src/main/java/org/opendaylight/controller/sal/schema/service/impl/GlobalBundleScanningSchemaServiceImpl.java+refs-changes-82-56182-2 222 OpenDaylight_Controller Missing var arg [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/ModuleShardBackendResolver.java+refs-changes-33-43333-26 114 OpenDaylight_Controller I presume you are not calling initialize in the constructor because the DatastoreSnapshotRestore instance is created from the Activator and you would probably want to fail data store construction in the module if initialize fails. A note about this may help. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DatastoreSnapshotRestore.java+refs-changes-43-29243-11 54 OpenDaylight_Controller You mean IsolatedCheckInterval should not be a FiniteDuration? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java+refs-changes-48-15548-1 66 OpenDaylight_Controller Sure I'll have to update some unit test cases then. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-68-14868-5 423 OpenDaylight_Controller I think you exactly know that it is no anyLong but 0L ? [not_related_to_checkstyle] opendaylight/md-sal/cds-access-client/src/test/java/org/opendaylight/controller/cluster/access/client/TransmittingTransmitQueueTest.java+refs-changes-74-53074-2 140 OpenDaylight_Controller commented code???? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplEntryTest.java+refs-changes-83-14483-4 40 OpenDaylight_Controller This *really* needs to be immutable [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/messages/NotifyProducerCreated.java+refs-changes-43-44943-53 26 OpenDaylight_Controller This same code is there in AbstractMeteredUntypedActor Can we put them at single location? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-65-10665-8 176 OpenDaylight_Controller Why this switch to String? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-60-16160-6 109 OpenDaylight_Controller Does this need to be part of this commit? [not_related_to_checkstyle] opendaylight/md-sal/clustering-service/src/main/java/clusteringservice/ClusteringServiceFactory.java+refs-changes-13-17513-2 8 OpenDaylight_Controller This is not used anymore. We are using getShardIdentifier(final MemberName memberName final DOMDataTreeIdentifier prefix) instead. Added warn log to that util method. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ClusterUtils.java+refs-changes-09-50609-30 74 OpenDaylight_Controller This could be static. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ChildDataTreeCandidateNode.java+refs-changes-91-18591-10 43 OpenDaylight_Controller return a singleton future? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataCommitCohort.java+refs-changes-12-12912-9 99 OpenDaylight_Controller Why are you reading here? It appears that you are doing nothing with the result of the read. [not_related_to_checkstyle] opendaylight/md-sal/inventory-manager/src/main/java/org/opendaylight/controller/md/inventory/manager/NodeChangeCommiter.java+refs-changes-71-9771-4 153 OpenDaylight_Controller binary or decimal? 1048576 might make more sense. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ConfigParams.java+refs-changes-69-50769-11 27 OpenDaylight_Controller Forgot to update them during movement. [not_related_to_checkstyle] opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java+refs-changes-88-39288-13 85 OpenDaylight_Controller Done but we have a problem that Checkstyle hasn't caught this I'll dig into and address that issue through separate Gerrit(s) [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/xtendbeans/XtendBuilderExtensions.java+refs-changes-99-44099-15 35 OpenDaylight_Controller by doing so I believe we could end up in a undesirable restart loop where the container is never able to retrieve a dependency thus will keep restarting every 5 minutes. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/BlueprintBundleTracker.java+refs-changes-20-42320-1 214 OpenDaylight_Controller In my opinion you should use one style of mock setup. In createActorContextMock you are using when-then here you are using doReturn-when. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ModuleShardBackendResolverTest.java+refs-changes-96-53596-2 72 OpenDaylight_Controller Addressed with https://git.opendaylight.org/gerrit/#/c/28663/ [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-9 175 OpenDaylight_Controller "As a convention such wrapper elements are tagged as \""list\"" so that it is consistent with JSON and makes it convenient for the clients to parse.\nPlease refer to Switch manager northbound changes.\n\nThis comment is applicable for all the custom List elements defined in this gerrit request. " [not_related_to_checkstyle] opendaylight/northbound/statistics/src/main/java/org/opendaylight/controller/statistics/northbound/AllFlowStatistics.java+refs-changes-01-1001-2 20 OpenDaylight_Controller Null check before log makes more sense when we are throwing exception in this case we are returning value. \ndebug statements is there to make sure we are entering the method [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/xml/codec/XmlUtils.java+refs-changes-43-10443-4 114 OpenDaylight_Controller remove this line [not_related_to_checkstyle] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessTest.java+refs-changes-35-53135-2 8 OpenDaylight_Controller Oh ok then. But I think Failure is more appropriate here than success since follower cannot transfer leadership to another follower. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-42-53542-3 280 OpenDaylight_Controller looks like we lost some debug ability here -- likely because the uriInfo can be null internally. Can we do a null check and add the path if is null? [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfImpl.java+refs-changes-56-23856-7 871 OpenDaylight_Controller This method is removed completely in following patches as we are not using distributed data anymore. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManager.java+refs-changes-29-46829-69 365 OpenDaylight_Controller "message text: \""RestconfError getErrorTag()\"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/input/to/cnsn/test/RestPutListDataTest.java+refs-changes-89-8889-1 135 OpenDaylight_Controller Right - I missed that you're looking for the absence of the message. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/FollowerTest.java+refs-changes-54-15954-1 191 OpenDaylight_Controller oops - I think this is not intended. Oh or maybe it is because blueprint will shutdown those EventLoopGroup for you?\n\nOr is this about the restart config modules patch bellow that will take care of cleaning up those resources? [not_related_to_checkstyle] opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java+refs-changes-80-38280-5 278 OpenDaylight_Controller This is created using the IntelliJ generate option itself [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RouteIdentifierImpl.java+refs-changes-60-9460-2 82 OpenDaylight_Controller Why are these all commented out? [not_related_to_checkstyle] opendaylight/md-sal/statistics-manager/src/test/java/test/mock/FlowStatisticsTest.java+refs-changes-80-11780-9 70 OpenDaylight_Controller This should be called DataTreeCohortActor. However you really don't need this class - you could call Props.create(DataTreeCohortActor.class cohort). [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortActor.java+refs-changes-02-32602-15 276 OpenDaylight_Controller this check could be better. I should probably introduce can*Operation* methods. They would be the least ambiguous. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-11-15611-3 428 OpenDaylight_Controller I'm unclear as to your intent wrt synchronization. In general synchronized methods should be avoided. Outside of that this method is synchronized as well as read yet put merge. exists are not. This seems inconsistent.\n\nHowever do we need synchronization at all? I don't think the MD-SAL transaction APIs guarantee thread safety. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/legacy/sharded/adapter/ShardedDOMDataBrokerDelegatingReadWriteTransaction.java+refs-changes-13-43613-6 86 OpenDaylight_Controller The contents of the dictionary is the sum of all previous messages. Each raft term starts with a clean dictionary so we can recover it for each term by replaying the messages from the start of the term.\n\nThe only case where I am not certain this is going to work is mid-term snapshots where the leader would have to send the current dictionary along with the snapshot.\n\nAm I missing something? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-56-30856-18 353 OpenDaylight_Controller I had the serialize-messages=on in the test/resources/application.conf\nto test serialization. \nHence all messages needed to be Serializable for the tests to pass.\nI have now made serialize-messages=off. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/base/messages/InitiateInstallSnapshot.java+refs-changes-15-12515-2 16 OpenDaylight_Controller that is a good question my best guess is they prbably end up being the same. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionProxy.java+refs-changes-36-17536-2 667 OpenDaylight_Controller I added this b/c the ShardManager will forward the message to a remote ShardManager if no local Shard is found. We don't want the remote ShardManager returning its local shard DataTree. I wasn't crazy about adding this flag - another option would be to add a RemoteFindPrimary message. I could do that if you think that would be cleaner. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/FindPrimary.java+refs-changes-97-19097-3 23 OpenDaylight_Controller "You mean it should use the \""real\"" NonPersistentJournal? If so is the purpose of this test to verify the NonPersistentJournal/NonPersistentSnapshot impls interact with akka correctly? " [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTest.java+refs-changes-61-12061-2 1099 OpenDaylight_Controller So self address is not an actor path right? It's an Address instance so it always has host/port? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-00-12700-4 407 OpenDaylight_Controller I figured it was autosave. It's fine - no need to revert. [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/NormalizedNodeOutputStreamWriter.java+refs-changes-90-16690-14 63 OpenDaylight_Controller Sure more defensiveness does not hurt :) [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohort.java+refs-changes-97-42497-7 159 OpenDaylight_Controller If an rpc is supposed to be routed should this throw an exception or log an error/warning if no appropriate getter method is found to obtain the context IID? Are their valid cases for the NULL_EXTRACTOR to be returned? [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/ContextReferenceExtractor.java+refs-changes-46-19146-1 64 OpenDaylight_Controller which is fine. we can reconcile when we rebase. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java+refs-changes-76-15476-1 68 OpenDaylight_Controller Preconditions.checkNotNull() [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-58 80 OpenDaylight_Controller Can you explain why you removed the specific error information here? [not_related_to_checkstyle] opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/OpendaylightToaster.java+refs-changes-68-8168-1 168 OpenDaylight_Controller Are local operations throttled via this? They should not be and we should really not be wrapping them in Runnables.\n\nI think we only need to complete the future stemming from commit the final commit ... [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java+refs-changes-80-20680-1 44 OpenDaylight_Controller There are 2 parts to snapshotting \na. Saving an akka persistence snapshot so that we can recover from disk\nb. Trimming the in-memory log and setting the snapshotIndex on the log. The snapshotIndex allows us to create the logical index for a log entry (in code it's called the adjusted index)\n\nWhile we coordinate the two they are not really dependent on each other which is evidenced by the fact that we do fake snapshotting where we trim the log without actually saving the snapshot to disk.\n\nThis code get's invoked when doing real snapshotting. A real snapshot happens when we reach the batch count or when we are low on memory. It get's triggered when we append an entry to the log. Since we introduced the replicatedToAllIndex we try to trim the in-memory log based on the replicatedToAllIndex. The replicatedToAllIndex is always behind lastApplied because lastApplied moves forward even when all the replicas do not have an index. So when we are low on memory we still trim the in-memory log based on the lastApplied index. \n\nSo now we come to the case where I encountered this bug. It happens if replicateToAllIndex is -1 which happens iff replicatedToAllIndex == -1 or replicatedToAllIndex is not found in the log. It replicatedToAllIndex is not in the log then it means that it has to be in the snapshot. That is why I do the snapshotPrecommit without advancing the snapshotIndex because it's already where it's supposed to be. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java+refs-changes-04-15604-1 693 OpenDaylight_Controller Do we even need to do the next operation if a previous operation had failed? I was thinking more in terms of return if(operationError != null). I'm ok to merge this though - because these issues would most likely get caught in development. Let me know what you think. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java+refs-changes-56-22656-3 47 OpenDaylight_Controller "I think \""merge(TOP/BAR=1)\"" should be \""merge(TOP/BAR 1)\"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java+refs-changes-46-8046-6 253 OpenDaylight_Controller right - missed that - caching would be overkill. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-70-14870-1 471 OpenDaylight_Controller good to have one case for {member-1 inventory config} and/or {member-2 inventory config} [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/FixedLeaderElectionStrategyTest.java+refs-changes-66-19266-2 21 OpenDaylight_Controller Concurrent programming especially use of the Google Guava UI needs to be demo'd here or we need to link to sites that provide best practices. Coming in cold to this heavy use of futures can seem overwhelming unless you are aware of the helper classes that exist to make your life easier. [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java+refs-changes-30-8330-1 81 OpenDaylight_Controller Include underlying exception with the RestconfDocumentedException? [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlNormalizedNodeBodyReader.java+refs-changes-17-19417-1 113 OpenDaylight_Controller This should technically be volatile but can be changed in another patch. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardManagerTest.java+refs-changes-96-28596-8 1337 OpenDaylight_Controller Correct. Will remove in follow-up. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RoutedRpcRegistrationConverter.java+refs-changes-85-36485-19 31 OpenDaylight_Controller invert the condition make the 'else' branch the short one [not_related_to_checkstyle] opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/frm/FlowCookieManager.java+refs-changes-74-8174-2 128 OpenDaylight_Controller No need to cast now. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/IsolatedLeaderTest.java+refs-changes-08-15208-2 50 OpenDaylight_Controller From where is this expecting an NPE thrown?\n\nNegative tests are fine but we also need a positive test for onNotification i.e. verify DOMNotificationPublishService#putNotification is called with the correct data. [not_related_to_checkstyle] opendaylight/md-sal/messagebus-impl/src/test/java/org/opendaylight/controller/messagebus/app/impl/NetconfEventSource_01_Test.java+refs-changes-01-16401-4 117 OpenDaylight_Controller This should be configurable via Config susbystem probably. [not_related_to_checkstyle] opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSource.java+refs-changes-31-15031-2 96 OpenDaylight_Controller Is Duration#Zero safe? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortFailureTest.java+refs-changes-75-9975-1 130 OpenDaylight_Controller final? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java+refs-changes-29-46829-69 21 OpenDaylight_Controller What I meant was: is the Activator that calls DatastoreSnapshotRestore.createInstance() guaranteed to have already been run before this module gets loaded? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/config/yang/config/distributed_datastore_provider/DistributedConfigDataStoreProviderModule.java+refs-changes-43-29243-12 76 OpenDaylight_Controller Non-null? [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/AbortSlicing.java+refs-changes-67-55767-22 28 OpenDaylight_Controller Leaking a thread with each instance. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/ShardFrontend.java+refs-changes-43-44943-53 34 OpenDaylight_Controller Please remove all commented out code or add there description why it is commented out and not removed. [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/nn/to/json/test/NnAndYangWithJsonReaderEmptyDataTest.java+refs-changes-09-21209-2 162 OpenDaylight_Controller Ok - maybe a little explanation. To do a fair distribution of ownership we need to delay a little bit before candidate registrations come in. Now if I set the delay to 5 seconds I'd be waiting 5 seconds before I can hand out ownership. To speeden it up I'm making an assumption here that if I have received that max possible candidate registrations then I can hand out the ownership immediately. Now if only 2 nodes out of the 3 nodes were registering candidates we would fall back to the assign ownership after delay logic. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/EntityOwnershipShard.java+refs-changes-94-33494-2 334 OpenDaylight_Controller if (first) {\n first = false; [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shard/ShardStats.java+refs-changes-86-38086-4 321 OpenDaylight_Controller Injecting is better for testing - thus their recommendation. Here is where I got my info from http://doc.akka.io/docs/akka/snapshot/java/testing.html [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTest.java+refs-changes-04-29804-2 2675 OpenDaylight_Controller %d should be %s [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-96-28596-4 902 OpenDaylight_Controller Again this is existing code just moved here. Same reason as above. [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataInput.java+refs-changes-74-30274-27 240 OpenDaylight_Controller Should this be named LatestEntryComparator? [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/utils/LatestEntryRoutingLogic.java+refs-changes-62-9862-3 41 OpenDaylight_Controller I think we want to check FollowerState == VOTING_NOT_INITIALIZED here [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java+refs-changes-18-28018-2 431 OpenDaylight_Controller I am a little confused now based on your comment on the general comments area about always getting update view.\n\nUltimately I would provide a simple walk through of the expected behavior. i.e. Create transaction. Read value someone else updates it read value again... and? what happens [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadTransaction.java+refs-changes-46-8046-2 25 OpenDaylight_Controller Do we send AppendEntries when we just need to send InstallSnapshot? If we do not then we may also need to use InstallSnapshotReply as a way to recognize if the follower is active. Also we may not want to send snapshot chunks to a follower that was not active. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java+refs-changes-15-12515-4 383 OpenDaylight_Controller inocybe technologies [not_related_to_checkstyle] opendaylight/md-sal/mdsal-cli/src/main/java/org/opendaylight/mdsal/cli/MdSALTransactionInfo.java+refs-changes-51-36751-1 2 OpenDaylight_Controller Does this timer need to be cleaned up from the registry when the actor goes away? [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java+refs-changes-65-10665-12 48 OpenDaylight_Controller duration expressed as a string? How is the string formatted and why? What are the units? Can it ever be null? [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/jmx/CommitStatsMXBean.java+refs-changes-27-10327-8 20 OpenDaylight_Controller Could you please correct this nit too? [not_related_to_checkstyle] opendaylight/networkconfiguration/neutron/northbound/src/main/java/org/opendaylight/controller/networkconfig/neutron/northbound/NeutronSubnetsNorthbound.java+refs-changes-83-13183-1 219 OpenDaylight_Controller The name is fine - it's misspelled :) sic -> spelling incorrect [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/CompositeDataTreeCohort.java+refs-changes-97-42497-7 141 OpenDaylight_Controller Is getData() == null a failure case or does it mean there's no data? If the latter then we shouldn't count it as a failure. [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/StatisticsRestconfServiceWrapper.java+refs-changes-23-17823-3 98 OpenDaylight_Controller I think it would be good to add more tests with specific percentile value scenarios and edge cases so we have an idea how it will behave. We'll have to think of some. But we can do that in another patch. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/CommitCallbackTest.java+refs-changes-98-15798-1 94 OpenDaylight_Controller We should just get rid of this class entirely and use the one from raft. Also the DoNothing actor class. I've been meaning to do this. Most of the usages have been converted anyway. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/MessageCollectorActor.java+refs-changes-47-29947-2 22 OpenDaylight_Controller So the problem was that even when we use LLCS most of the time we saw that the first registered candidate was getting ownership which was due to our previous logic where we assign ownership based on statistics collected using a DCL. This was because we were seeing a burst of registrations - for example all openflow switches connected to the controller at about the same time. \n\nEssentially we were assigning ownership based on stale statistics and we therefore got it wrong. In this patch I introduced local statistics for the strategy which the strategy updates when a newOwner request is made. \n\nAdditionally I added logic to look up the passed in statistics and go with the higher value of the local and passed in statistics. \n\nIn a subsequent patch I have simplified all this to simply rely on localStatistics only with global statistics being passed in to the strategy when it is constructed. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/LeastLoadedCandidateSelectionStrategy.java+refs-changes-94-33494-2 47 OpenDaylight_Controller More readable when you have the method split into logical chunks instead of a huge wall of code. [not_related_to_checkstyle] opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/WriteTransactionsHandler.java+refs-changes-07-53007-4 106 OpenDaylight_Controller You don't need to read here - just return the success and failure counts. [not_related_to_checkstyle] opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/CarProvider.java+refs-changes-95-43095-4 212 OpenDaylight_Controller 100 ms timeout may be fragile on jenkins. We know the Future is immediate so we can use no timeout or a long one (5 sec) to be safe. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/ActorContextTest.java+refs-changes-55-15955-1 382 OpenDaylight_Controller Too much refactoring :) We really need to split our refactoring and fix patches. I'd hate to hold up a fix because I couldn't wade through the refactoring fast enough. If it's not too much trouble could you please split this. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java+refs-changes-25-15125-2 77 OpenDaylight_Controller I am not sure if this code should be present in netconf-api. It would fit somewhere in NetconfMessageUtil where it could use utility code from netconf-util (XmlUtil + XmlElement).\n\n(Or even use jaxB to do the xml <-> NetconfDocumentedException translation)\n\nAlso the Netconf xml constants could stay in the netconf-util that way. [not_related_to_checkstyle] opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/controller/netconf/api/NetconfDocumentedException.java+refs-changes-08-7608-1 194 OpenDaylight_Controller The Wrapper is a little more than just a strategy - it also has state info like the timer task Cancellable. So the EntityOwnerSelectionStrategyWrapper would be permanently cached - we wouldn't be able to dynamically change EntityOwnerSelectionStrategy the config.\n\nBut beyond that you're caching EntityOwnerSelectionStrategyWrapper instances by entity type. They should be cached per entity path. Then we would clean them up when owner is selected [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfig.java+refs-changes-88-28188-3 26 OpenDaylight_Controller This is distributed-data related and is removed in https://git.opendaylight.org/gerrit/#/c/50609/21 [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ClusterUtils.java+refs-changes-69-48869-39 89 OpenDaylight_Controller Minor thing but this should be 'else if'. [not_related_to_checkstyle] opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/ComponentProcessor.java+refs-changes-63-48263-3 130 OpenDaylight_Controller Enunciate is not generating documents properly if the whitespaces are not escaped. Please refer to switchmanager and do your changes accordingly\n\nThis comment is applicable for all the APIs in this gerrit request. [not_related_to_checkstyle] opendaylight/northbound/statistics/src/main/java/org/opendaylight/controller/statistics/northbound/StatisticsNorthbound.java+refs-changes-01-1001-2 120 OpenDaylight_Controller This bulleted list was added twice [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java+refs-changes-46-8046-7 35 OpenDaylight_Controller As you pointed out this should be separate discussion. [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java+refs-changes-46-8046-2 48 OpenDaylight_Controller I assume you catch TimeoutException only to rethrow a new instance of TimeoutException because you want contextual info in the ex message. This is fine but to be consistent the second catch clause should do the same [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-64-9964-2 173 OpenDaylight_Controller There is also String.equalsIgnoreCase() which I think would work. [not_related_to_checkstyle] opendaylight/config/config-util/src/main/java/org/opendaylight/controller/config/util/xml/DocumentedException.java+refs-changes-26-48326-4 93 OpenDaylight_Controller "I thought it made sense for NetconfDocumentedEx to have the logic for marshaling itself to/from XML rather than being buried in some utility class somewhere. \n\nIt is is unfortunate that such util classes as XmlUtil and XmlElement couldn't be used in NetconfDocumentedEx. My thought on that is why such general XML utility/helper classes are in netconf-util and not in a more common bundle that netconf-api could reference?\n\nI think NetconfXmlXonstants belongs in api. I could move XmlUtil and XmlElement to the api bindle as well. \n\nBetter yet I propose we eliminate the netconf-util bundle altogther and move the classes into netconf-api. I'm not sure what the distinction is between \""api\"" and \""util\"". Eg NetconfHelloMessage derives from NetconfMessage and thus is a type of NetconfMessage so why is NetconfHelloMessage in util and not api?\n\nMerging util and api simplifies everything. " [not_related_to_checkstyle] opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/controller/netconf/api/NetconfDocumentedException.java+refs-changes-08-7608-1 194 OpenDaylight_Controller you can remove this test [not_related_to_checkstyle] opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessTest.java+refs-changes-35-53135-3 19 OpenDaylight_Controller I think passing a schemaContext to the RpcManager is not going to be good enough. Over time as new modules are added and such the schemaContext can change. You need to send an update to this actor with the new schema context. See how we do this in DistributedDataStore and ShardManager. [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcManager.java+refs-changes-15-9515-1 49 OpenDaylight_Controller I know what you mean - it's legacy :) [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-25-9825-2 123 OpenDaylight_Controller Just in case keyScheme is not set in config.ini wouldn't it be better to set it to IP scheme by default here? [not_related_to_checkstyle] opendaylight/hosttracker/api/src/main/java/org/opendaylight/controller/hosttracker/HostIdFactory.java+refs-changes-17-2817-9 21 OpenDaylight_Controller I'm not sure if ActorPath is Serializable. In other places we serialize it to a String - see CreateTransactionReply. Please add a unit test to verify serialization/de-serialization. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/RegisterTreeChangeListener.java+refs-changes-90-16690-14 17 OpenDaylight_Controller What if child type isn't a container or augmentation? Throw IllegalArgumentEx or return null? The former is probably too harsh - I think I'd go with the latter. [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/DataObjectModification.java+refs-changes-27-17527-1 86 OpenDaylight_Controller Splitted in several methods which throws TransactionCommitFailedException.\n\nWhen fail occurs abort is triggered.\n\nClient failure notifications are done via Future listener now. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMDataCommitCoordinatorImpl.java+refs-changes-95-7395-9 127 OpenDaylight_Controller @return an RpcRegistration instance that should be used to unregister the RPC implementation when no longer needed by calling {@link RpcRegistration#close()} [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java+refs-changes-30-8330-1 114 OpenDaylight_Controller You can just eliminate the canStartElection checks here. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Follower.java+refs-changes-88-41088-1 71 OpenDaylight_Controller I initially thought of that but the shard may not be created right away i.e. SchemaContext may not be set yet in which case it's created later. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipService.java+refs-changes-74-25174-1 45 OpenDaylight_Controller You want to convert to Sets for the comparison. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardManagerTest.java+refs-changes-70-29370-3 1526 OpenDaylight_Controller "\""to the new accumulated rate limit\""? " [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/CommitCallback.java+refs-changes-98-15798-1 57 OpenDaylight_Controller Didnt get why we are allowing the trimming of log when the state is Persisting\n\nDuring a rollback we do swap the journals and the snapshot index.\n\nAs i gather till the state changes from Persisting to Idle a snapshot is not done and is in progress. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/SnapshotManager.java+refs-changes-10-15610-3 100 OpenDaylight_Controller documentation should be updated it's also adding timeout task now [not_related_to_checkstyle] opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/KeepaliveSalFacade.java+refs-changes-99-34399-5 258 OpenDaylight_Controller To add [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/NormalizedNodeAggregatorTest.java+refs-changes-50-18050-1 1 OpenDaylight_Controller > in the order that submit is called\n\nOh I forgot we are using a single thread executor thus the order of submits is deterministic already. [not_related_to_checkstyle] opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/WriteTransactionsHandler.java+refs-changes-07-53007-4 153 OpenDaylight_Controller "Missing \""or\"" - that is \""Node is considered updated if it contents was replaced OR one of its children was created removed or updated.\"" " [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataChangeEvent.java+refs-changes-46-8046-2 64 OpenDaylight_Controller I probably could call put or remove here appropriately here but I was trying to keep the code simpler with less code paths. So only have the ActorContext put. The ShardManager is only responsible for removing b/c it has the knowledge of when shard leadership changes and that must be done in an actor. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-71-20571-6 224 OpenDaylight_Controller What happens if a ShardTransaction Actor throws an exception -- runtime -- most likely the default supervisor strategy of restarting the actor takes place? Do we know if the restart actor will have the shardContext.. This is a general clarification that applies to all actors. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-75-10175-9 205 OpenDaylight_Controller I agree about easy lookup of author. I used to put author's name in previous projects just because of this reason. [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcErrorsException.java+refs-changes-43-10443-4 24 OpenDaylight_Controller Can you provide the link so I can add it? [not_related_to_checkstyle] opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java+refs-changes-30-8330-5 19 OpenDaylight_Controller Ugh this is quite ugly. This is a perfectly good class findbugs should not be warning us about this...\n\nMichael: can we fix these on FindBugs side? It should notice based on class hierarchy that writeReplace() exists and writeObject() has not been overridden -- objects of this class are provably not going to be serialized. [not_related_to_checkstyle] opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java+refs-changes-73-47473-3 32 OpenDaylight_Controller A DataTreeModification can be applied to a different DataTree. I will make the message serializable which will solve this particular problem. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-55-19255-3 455 OpenDaylight_Controller Comment out of sync with code? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTest.java+refs-changes-91-15091-1 1155 OpenDaylight_Controller What are your thoughts on changing this interface as follows \n\nvoid ownershipChanged(OwnershipChange change);\n\nwhere the entity was is and has owner are attributes of the OwnershipChange. This way we can add more attributes over time. [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/clustering/EntityOwnershipListener.java+refs-changes-58-26858-2 38 OpenDaylight_Controller I'm finding it difficult to follow why this method was removed in this commit about updating the primary shard cache. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionChainProxy.java+refs-changes-71-20571-6 176 OpenDaylight_Controller The EntityOwnerSelectionStrategyConfigReader needs it to get the ConfigAdmin service. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/config/yang/config/distributed_entity_ownership_service/DistributedEntityOwnershipServiceProviderModule.java+refs-changes-01-35501-2 59 OpenDaylight_Controller Please add 409 too [not_related_to_checkstyle] opendaylight/networkconfiguration/neutron/northbound/src/main/java/org/opendaylight/controller/networkconfig/neutron/northbound/NeutronNetworksNorthbound.java+refs-changes-83-13183-5 185 OpenDaylight_Controller Please advise if this comment was still correct or not. (As I mentioned in commit message it didn't seem this was true.) [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java+refs-changes-03-15003-1 41 OpenDaylight_Controller The dataStore context and peer resolve are common to all in a given datastore - so how about in the datastore config module where the datastorecontext is built? [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardManager.java+refs-changes-06-27606-2 134 OpenDaylight_Controller ok i'll name it timeSinceLastActive? [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/FollowerLogInformation.java+refs-changes-68-14868-5 82 OpenDaylight_Controller Removing not needed [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ConcurrentDOMDataBrokerTest.java+refs-changes-24-19024-1 515 OpenDaylight_Controller can do. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/jmx/mbeans/shard/ShardStats.java+refs-changes-19-16519-3 99 OpenDaylight_Controller understand the safety aspect of returning an unmodifiable list but I don't think we need the overhead of being that defensive here. This is not a public API and no callers modify the list and it wouldn't make sense for them to do so. I'd rather add a javadoc stating not to modify the list rather than incurring the unnecessary overhead of an intermediate object on every call. \n\nThere are other internal classes where we pass/return lists which technically should be immutable but being defensive everywhere gets to be overkill and reduces efficiency. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntries.java+refs-changes-23-34623-16 98 OpenDaylight_Controller Same as missing capabilities but the reconnect is now performed by reconnecting strategy passed to client dispatcher. [not_related_to_checkstyle] opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusher.java+refs-changes-14-5514-1 99 OpenDaylight_Controller Shouldn't unless writeExternal is incorrect. You have to cast it anyway - same on line 108. [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlice.java+refs-changes-67-55767-15 112 OpenDaylight_Controller has to be @GuardedBy [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/AbstractDOMForwardedTransactionFactory.java+refs-changes-95-7395-11 203 OpenDaylight_Controller can these be null? If not Preconditions.checkNotNull() [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestLeadership.java+refs-changes-42-53542-3 25 OpenDaylight_Controller can we move to using the new data store APIs please? the name 'modifTran' seems to imply modification but we use it for a single read. [not_related_to_checkstyle] opendaylight/md-sal/forwardingrules-manager/src/main/java/org/opendaylight/controller/frm/FlowNodeReconcilListener.java+refs-changes-74-8174-5 58 OpenDaylight_Controller This class probably belongs in the messages package [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/Monitor.java+refs-changes-68-8768-4 13 OpenDaylight_Controller No proper index checking will crash if references[0] is null.. also ServiceReferences can come and go at any time I recommend using service tracker.. or blueprint..\n\nRead this: http://www.knopflerfish.org/osgi_service_tutorial.html#best\n\nand make changes accordingly [not_related_to_checkstyle] opendaylight/northbound/featuresservice/src/main/java/org/opendaylight/controller/featuresservice/Activator.java+refs-changes-49-7749-2 17 OpenDaylight_Controller Done. Also modified getMemberShardNames to return shards available for the given member. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/MockConfiguration.java+refs-changes-42-27742-9 92 OpenDaylight_Controller } else if [not_related_to_checkstyle] opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/FlowComparator.java+refs-changes-74-8174-9 59 OpenDaylight_Controller Adding this method to IConfigurationServiceCommon requires the ConfigurationService.java also to implement this method as ConfigurationService implements IConfigurationService which is the child class of IConfigurationServiceCommon. As of now getConfigurationRoot() is not required in ConfigurationService. \n\nThe other option is to add this method in IConfigurationContainerService class. That way only ContainerConfigurationService.java has to implement the method as is required to fix this bug. \n\nI am adding it to IConfigurationContainerService for now. Please let me know if it should be moved to IConfigurationServiceCommon as mentioned in your comment above. Thanks. [not_related_to_checkstyle] opendaylight/configuration/implementation/src/main/java/org/opendaylight/controller/configuration/internal/ContainerConfigurationService.java+refs-changes-38-5238-5 115 OpenDaylight_Controller You should not cache this timeout at all as config params can dynamically change. Just create a new instance where it's needed. [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorServerConfigurationSupport.java+refs-changes-18-28018-7 53 OpenDaylight_Controller Sounds good although I don't want to make this too complicated. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxy.java+refs-changes-70-14870-1 203 OpenDaylight_Controller BTW - if listeners were registered by advertising their registrations as OSGi instances then there's no explicit need to unregister on bundle shutdown - this would happen automatically. This is how I've done it in the past - you can't rely on people doing the right thing and unregistering - having it automatic saves a lot of bugs. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeChangeService.java+refs-changes-42-14542-6 42 OpenDaylight_Controller I think we should derive this from TransactionCommitFailedException. \n\nAlso I don't think we should leak shard information here - I don't see how a client could/would use that information. I think all they need to know is that this is a transient datastore error and re-trying may succeed. [not_related_to_checkstyle] opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataStoreUnavailableException.java+refs-changes-78-20678-1 14 OpenDaylight_Controller I'm not a fan of throwing unchecked exceptions to users where the API docs don't indicate failures can occur. Such a practice is littered though out mdsal and yang tools code and has caused latent bugs in callers. I know others have noted frustration about this as well. As a user you basically have to be paranoid and put try/catch RuntimeException around all calls to gracefully handle it just in case.\n\nThe createProducer API only documents:\n\n @throws IllegalArgumentException if subtrees is empty.\n\nIn that case it's fine to throw an IEA b/c it's documented and is a caller error. But the internal errors above should not be blindly propagated. If we want to propagate such errors then it should at least be documented in the API and preferably define a throws clause with a specific exception like DOMDataTreeServiceException either checked or unchecked but I prefer the former. Either that or just log the error and return a noop DOMDataTreeProducer that throws a checked exception somewhere down the line when accessed. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardedDOMDataTree.java+refs-changes-43-44943-1 118 OpenDaylight_Controller perhaps info() instead of warn() would be more appropriate for this? Just a thought. [not_related_to_checkstyle] opendaylight/md-sal/mdsaltrace/impl/src/main/java/org/opendaylight/controller/mdsaltrace/impl/TracingBroker.java+refs-changes-38-45538-1 255 OpenDaylight_Controller It will be better if you initialize all the above variables after actorSystemReference null check because in that case no initialization is required. Also for creation you may move out the code outside to new private method just to make it more readable. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreFactory.java+refs-changes-61-12061-2 57 EclipsePlatformUI Just wondering if the above change would be required here as well. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java+refs-changes-49-40449-10 706 EclipsePlatformUI Unnecessary whitespace. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java+refs-changes-75-66975-1 104 EclipsePlatformUI Is there a special reason for not combining this with another OR with the above if statement? [not_related_to_checkstyle] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheet.java+refs-changes-18-75318-7 154 EclipsePlatformUI remove [not_related_to_checkstyle] bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyList.java+refs-changes-15-90515-2 399 EclipsePlatformUI Unnecessary blank line. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/sideeffect/SideEffectFactory.java+refs-changes-82-68282-23 26 EclipsePlatformUI Rename to setResult sorry. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/SelectionDialog.java+refs-changes-01-34701-6 165 EclipsePlatformUI I'm not sure what semantic impact this would have. The modification simply checks before casting which should be always be done prior casting. You suggestion would mean to not perform any code in such a case which not necessarily needs to be correct. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java+refs-changes-49-41249-3 250 EclipsePlatformUI For anonymous classes this is not possible with Java 7 [not_related_to_checkstyle] examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/model/AggregateObservableValue.java+refs-changes-53-52453-4 36 EclipsePlatformUI Need to check project != null. And this move will fail if the CN is not showing an Adaptable in the top level [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java+refs-changes-90-34990-10 94 EclipsePlatformUI line break [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkNavigator.java+refs-changes-13-90613-5 536 EclipsePlatformUI Not sure how likely it is but this might the IDE to freeze if the saving takes a very long time. I upload a new revision of your change using the new JobGroup API. This should ensure that Jobs are queued but not blocking [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java+refs-changes-51-36151-4 1275 EclipsePlatformUI Paul I think/hope I've now got it - see the next patch. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java+refs-changes-03-38803-9 622 EclipsePlatformUI The description isn't copied into the tooltip. It appears we don't copy that into the model [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ShowViewDialog.java+refs-changes-85-23785-10 433 EclipsePlatformUI had to move this into constructor to get it to compile [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/MappedSet.java+refs-changes-84-90684-1 74 EclipsePlatformUI Why's this required? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/AbstractControlSelectionBackgroundCustomizationElement.java+refs-changes-55-45555-4 64 EclipsePlatformUI Accepted second proposal [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/ArchiveFileExportOperation.java+refs-changes-96-61796-6 384 EclipsePlatformUI Can be removed [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/filesystem/FileSystemSupportRegistry.java+refs-changes-58-34658-1 182 EclipsePlatformUI "I would test against \""3.\"" to avoid matching e.g. 30. " [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/viewers/ViewerTestCase.java+refs-changes-37-73137-1 51 EclipsePlatformUI This part comes from the https://git.eclipse.org/r/#/c/40794/ review. I started my work upon it. I admit that I didn't search to check if this part was useful or not. With all modifications I've done It seems this part is useless now. So I remove it. [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/addons/SaveAllDirtyPartsAddon.java+refs-changes-42-66742-3 97 EclipsePlatformUI Used in CPD. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Perspective.java+refs-changes-34-38634-6 97 EclipsePlatformUI Wouldn't this be getActiveWindowService()... just like the others? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ApplicationPartServiceImpl.java+refs-changes-38-60038-3 72 EclipsePlatformUI IBM? [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/markers/MarkerViewUtilTest.java+refs-changes-05-79605-3 2 EclipsePlatformUI Better: DelegateCache cache : delegateCache.values() [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/DelegatingCache.java+refs-changes-99-50299-9 180 EclipsePlatformUI I think this is obvious here and therefore an unnecessary comment. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/JFaceResources.java+refs-changes-30-34330-1 581 EclipsePlatformUI Option to use try with resources to avoid the final block? [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/EasymportWizard.java+refs-changes-33-61233-3 85 EclipsePlatformUI Redundant type information. Should be \n\nList newList = new ArrayList<>(Arrays.asList(array)); [not_related_to_checkstyle] examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/ModelObject.java+refs-changes-53-52453-1 69 EclipsePlatformUI This was static before. IMHO safer to keep as class member. I have run into synchronization issues using pattern.matcher in the past. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/fragment/impl/StringModelFragmentImpl.java+refs-changes-06-32506-10 59 EclipsePlatformUI dot missing [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java+refs-changes-25-70825-8 221 EclipsePlatformUI inline [not_related_to_checkstyle] bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/dialog/TitleAreaDialogSupport.java+refs-changes-12-90512-2 113 EclipsePlatformUI I know it is pseudo code since there is no actual implementation in this method but I suggest to directly use IObservableValue as correct return type [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ISideEffect.java+refs-changes-51-56751-10 280 EclipsePlatformUI Can be removed [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/DefaultBrowser.java+refs-changes-11-53511-2 39 EclipsePlatformUI The driving use-case is to prevent leaks in CompositeSideEffect. Unless it gets some kind of notification there's no way to free up the memory when a side-effect is disposed externally or via the consumeOnce method.\n\nThat's the only concrete use-case we have at the moment but it seems important. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ISideEffect.java+refs-changes-82-68282-23 202 EclipsePlatformUI This can be removed. I heard Simon wrote nice tooling for that. ;-) [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/BrowserDescriptor.java+refs-changes-11-53511-1 26 EclipsePlatformUI make it a method ref: StructuredViewer.this::handleOpen [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredViewer.java+refs-changes-81-54381-1 1271 EclipsePlatformUI I will open another bug to convert these to @Inject method registrations. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/util/BindingProcessingAddon.java+refs-changes-45-57345-1 313 EclipsePlatformUI Why nl ? Why not ws ? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/CSSRenderingUtils.java+refs-changes-61-52061-1 53 EclipsePlatformUI Why not moving this at the very beginning of this mehtod? IHMO having the elt variable is not necessary here. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java+refs-changes-16-83416-1 884 EclipsePlatformUI This line is probably unnecessary since job creation is very fast. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java+refs-changes-37-37437-1 2805 EclipsePlatformUI Same as above maybe we should only support Lists? [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/SelectionDialog.java+refs-changes-01-34701-12 183 EclipsePlatformUI Oops I see that DecorationOverlayDescriptor is a class available in EGit not in the platform. Crazy.\nThere is also org.eclipse.ui.internal.ide.misc.OverlayIcon... Mistery. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workbench/ResourceExtensionLabelProvider.java+refs-changes-99-82899-1 78 EclipsePlatformUI Sorry after reviewing a few more dialogs I think we should stay with getResult() I see it commonly used. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/SelectionDialog.java+refs-changes-01-34701-6 121 EclipsePlatformUI Add Bug ID to the copyright [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java+refs-changes-09-37709-7 9 EclipsePlatformUI Use diamond notation ? (like above) [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java+refs-changes-46-65246-2 2426 EclipsePlatformUI Already did before providing that change. The expression context resolves the Service to null. That's why I needed the application context. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/CommandProvider.java+refs-changes-07-79307-1 58 EclipsePlatformUI Unnecessary blank line. [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/layout/GridLayoutFactoryTest.java+refs-changes-28-75128-3 89 EclipsePlatformUI IMHO here is not needed extra check for mostDirectParentProject.getLocation() == null because the same check was done actually in lines 136-139. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectManager.java+refs-changes-55-58555-1 147 EclipsePlatformUI Please avoid unnecessary ws changes. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java+refs-changes-64-46964-5 190 EclipsePlatformUI closing of shell is not actually called much in this workflows because it either become invisible of get disposed. I added it in dispose listener in patch 7 [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java+refs-changes-19-34419-6 218 EclipsePlatformUI "could this be \""return ((IStructuredSelection) sel)::iterator\"" " [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/SelectionAdapterFactory.java+refs-changes-45-57345-1 59 EclipsePlatformUI "Yes it is saved. I can maybe add a test for it too.\nshellClosed is not actually called in normal workflows at least on linux I cannot make shell without title close (i.e. call close method). Some other magic kicks in and makes shell invisible without actual \""closing\"" workflow. " [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java+refs-changes-19-34419-7 216 EclipsePlatformUI In Ubuntu Linux under some circumstances this execute() is called twice. \nI agree the check should go deeper in the stack but the event.time is the only thing I can use to check it is the second execution [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/FullScreenHandler.java+refs-changes-28-72228-5 66 EclipsePlatformUI OK. BTW we can replace the instanceof URL check with null check (paranoia) and just return value.toString(). URL.toString() returns toExternalForm() anyway. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java+refs-changes-20-84520-4 156 EclipsePlatformUI The code change seems reasonable since you wouldn't want to have callers accidentally marked as dependent upon something that was invoked as part of firing the stale event.\n\nHowever this reasonable refactoring does not appear to be necessary to support the addition of generics so I'll revert it from this change. We can bring it back later.\n\nAlso: the fact that this fires a stale event is almost certainly a bug. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/masterdetail/SetDetailValueObservableMap.java+refs-changes-99-50299-9 111 EclipsePlatformUI Ok. I'll do it in next patch set [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/OpenFolderAsProjectAction.java+refs-changes-28-39228-5 72 EclipsePlatformUI We do not translate error messages you can replace this with constant values (use the NLS tag). [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.services/src/org/eclipse/e4/ui/services/internal/events/EventBroker.java+refs-changes-28-81628-1 176 EclipsePlatformUI Better to use subMonitor.setWorkRemaining(1) after the 'if' statement. This would result in smoother progress. [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java+refs-changes-40-72040-1 508 EclipsePlatformUI Maybe add this as a comment in the code? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressManager.java+refs-changes-02-79602-2 676 EclipsePlatformUI A disposed side-effect will never execute again and doesn't retain any references to other observables. A non-disposed observable has some possibility of executing again and retaining references to other observables. Is it the contract that seems vague or the way we documented it in ISideEffect? [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/sideeffect/ICompositeSideEffect.java+refs-changes-82-68282-21 34 EclipsePlatformUI Spurious empty line but then I don't know what the formatting conventions in UI are. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java+refs-changes-13-93613-1 102 EclipsePlatformUI comma missing [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java+refs-changes-25-70825-8 215 EclipsePlatformUI "Rewrite: In case of \""initial\"" do not do any styling " [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java+refs-changes-71-40271-1 710 EclipsePlatformUI The timerExec call below may result in a call to refreshJobInfo occurring after the job has been removed. This could potentially cause problems in some listeners. Suggest checking the return value of remove(...) to determine if the job was still present in scheduledUpdates. Abort early if it is missing.\n\nYou could then remove the job from scheduledUpdates when the job is removed in order to protect against this possibility. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressManager.java+refs-changes-86-80386-4 638 EclipsePlatformUI improve [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help/ViewContextComputer.java+refs-changes-03-89203-1 80 EclipsePlatformUI "I wouldn't match the \"".\"" here. When using the open resource dialog using \"".\"" is most often used as the actual dot not as the replacement for any character. " [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java+refs-changes-59-63459-1 2310 EclipsePlatformUI Wrong version. Please set up the API baseline to Eclipse 4.5 in preferences. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java+refs-changes-40-28240-19 31 EclipsePlatformUI disposed -> closed [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java+refs-changes-19-34419-11 581 EclipsePlatformUI "Please replace FormUtil.getWidthHint() with the single line \""return wHint\"". Once you do that there will be no remaining callers of FormUtil.isWrapControl and it should be deleted. " [not_related_to_checkstyle] bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/SizeCache.java+refs-changes-64-60264-17 191 EclipsePlatformUI Should that name be a little bit more specific? Like PART_ON_TOP? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IWorkbench.java+refs-changes-25-68725-6 129 EclipsePlatformUI Why not inline this variable? [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/concurrency/SyncExecWhileUIThreadWaitsForLock.java+refs-changes-87-83487-2 27 EclipsePlatformUI Revert changes unrelated to the bug this patch is addressing. There are many throughout this file. [not_related_to_checkstyle] examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java+refs-changes-55-46455-3 52 EclipsePlatformUI In ThemeEngine:148 themeId=id+version hence we should check if the activeTheme.getId().startsWith(DEFAULT_THEME) [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbookEditorsHandler.java+refs-changes-48-91548-2 90 EclipsePlatformUI It's probably better to make org.eclipse.e4.ui.workbench.renderers.swt a friend of org.eclipse.e4.ui.css.swt [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java+refs-changes-77-41877-3 666 EclipsePlatformUI make it a method ref this::clearCaches [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorRegistry.java+refs-changes-81-54381-1 82 EclipsePlatformUI Better: @deprecated This is always false. Don't use it. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/SashLayout.java+refs-changes-60-90460-1 64 EclipsePlatformUI (since 3.2) is wrong please remove [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/AbstractSelectionDialog.java+refs-changes-01-34701-15 55 EclipsePlatformUI You must not cache the ImageData. ImageDescriptors are required to be lightweight and ImageData objects retain a lot of memory. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/SuppliedImageDescriptor.java+refs-changes-28-62028-3 21 EclipsePlatformUI No I do not know other parts that could be fixed. I needed that fix to make the ToggleFilterAction work. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorFilterService.java+refs-changes-48-70848-1 298 EclipsePlatformUI Moved the code to check for GTK3 to testcase setup. the system property is not always available when the static block gets executed. [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/viewers/ViewerTestCase.java+refs-changes-37-73137-1 48 EclipsePlatformUI I mean if that's what we're showing in the dialog? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java+refs-changes-85-23785-9 160 EclipsePlatformUI Add @TrackedGetter as described in ObservableTracker.getterCalled [not_related_to_checkstyle] examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/SnippetSideEffectTwoWayBinding.java+refs-changes-77-66977-1 61 EclipsePlatformUI Looks like typing leftover. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/JFaceColors.java+refs-changes-59-86259-5 138 EclipsePlatformUI I've moved this to another patch after all. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java+refs-changes-85-83185-1 2208 EclipsePlatformUI Break the line before 'implements' [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/MapDelegatingValueObservableMap.java+refs-changes-99-50299-9 47 EclipsePlatformUI This should first use disposableWidget.getData(ICompositeSideEffect.class.getName()) to check if there is already a composite side effect attached to the widget before it tries to create and attach a new one. [not_related_to_checkstyle] bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/swt/WidgetSideEffects.java+refs-changes-82-68282-5 45 EclipsePlatformUI We're generally not including these non-javadoc comments [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java+refs-changes-35-43335-3 281 EclipsePlatformUI You have not answered my question why you have this static methods. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java+refs-changes-16-34716-3 85 EclipsePlatformUI Remove call to pack [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java+refs-changes-85-62585-1 653 EclipsePlatformUI Non-wrapping labels are generally set to align(SWT.FILL SWT.CENTER) alignment. Was BEGIN BEGIN intentional or a bug? [not_related_to_checkstyle] tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/widgets/SizeCacheTest.java+refs-changes-64-60264-20 211 EclipsePlatformUI {@code null} [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java+refs-changes-25-70825-8 227 EclipsePlatformUI "Remove \""for the creation of an {@link ISideEffectFactory} and the following comma. " [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/sideeffect/ISideEffectFactory.java+refs-changes-82-68282-9 50 EclipsePlatformUI This comment has not been addressed. [not_related_to_checkstyle] examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java+refs-changes-55-46455-3 52 EclipsePlatformUI Iterators are useful if you want to modify the Collection during the iteration with the Iterator's .remove(); method:\n\nit.remove()\n\nAs this is not the case here I would propose to use a new foreach loop:\n\nfor(MethodCall methodCall : previousCallHistory){\n [...]\n} [not_related_to_checkstyle] tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/Mocks.java+refs-changes-80-34580-5 236 EclipsePlatformUI rename 'affectedChild' [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workbench/ResourceExtensionContentProvider.java+refs-changes-15-90515-2 172 EclipsePlatformUI Why not using ArrayContentProvider.getInstance? [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java+refs-changes-33-61233-5 137 EclipsePlatformUI I believe it's the piece of advice I needed to improve greatly the reporting. I'll give it a try thanks. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressManager.java+refs-changes-33-61233-14 173 EclipsePlatformUI Whitespace [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java+refs-changes-11-21111-10 89 EclipsePlatformUI this does nothing [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java+refs-changes-11-90511-3 161 EclipsePlatformUI "Please change \""true\"" to \""false\"" since if we are going into 4.5 we will not change the default behavior. " [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java+refs-changes-41-46341-4 266 EclipsePlatformUI It fixes a warning. [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java+refs-changes-97-56797-1 87 EclipsePlatformUI I think it was. But it seems to recognize Assert now so I'll revert. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java+refs-changes-44-62344-3 155 EclipsePlatformUI whitespace [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WWinPluginAction.java+refs-changes-36-38636-8 281 EclipsePlatformUI I'm not sure if application is the correct parent. For context menus the parent should be the part. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java+refs-changes-44-58344-2 202 EclipsePlatformUI The clear button should be done as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/dialogs/FilteredTree.java#n384 [not_related_to_checkstyle] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetViewer.java+refs-changes-82-19982-5 270 EclipsePlatformUI "Consider using the new Java stream APIs with \"".filter\"". " [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/StackDropAgent.java+refs-changes-93-76893-5 114 EclipsePlatformUI This refactoring makes sense but doesn't belong as part of this change which is purely about adding generics. We can clean that up in another change. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapDiff.java+refs-changes-99-50299-9 245 EclipsePlatformUI use split here instead of newChild. [not_related_to_checkstyle] examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/wizard/Snippet072WizardWithProgressSubtasksAndCancel.java+refs-changes-87-84287-3 91 EclipsePlatformUI <> would do. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java+refs-changes-00-50300-8 51 EclipsePlatformUI The problem is that setRootEntry(null) will require more code changes javadoc changes (it is a public API) AND it will change behavior => much more possible side effects.\n\nRemoving a listener here is not that much of code duplication. [not_related_to_checkstyle] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetViewer.java+refs-changes-86-77686-2 1422 EclipsePlatformUI extra new line? [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/DecorationOverlayIcon.java+refs-changes-99-82899-6 140 EclipsePlatformUI Yes it is the intended behavior. I don't see the value to use getClass().hashCode() instead. Please elaborate why you think it should be replaced.\n\nHowever I see that I've used Objects.hash instead of Objects.hashCode() (the later takes an object while the former an array). While it does not change the behavior it creates an array for nothing. Will change that in an upcoming review [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredSelection.java+refs-changes-80-81580-10 162 EclipsePlatformUI The default formatter prefers no line break. Using that version to make it easier for future maintainers. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java+refs-changes-99-50299-9 124 EclipsePlatformUI This code is deliberately updating the UIElement (that's any menu contribution that is referencing this command). It's been that way since before 3.7. I don't think removing this code is the way. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/WizardHandler.java+refs-changes-57-38757-1 345 EclipsePlatformUI Remove ws [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java+refs-changes-53-39353-1 217 EclipsePlatformUI Diamand operator [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolItemUpdater.java+refs-changes-64-52064-2 23 EclipsePlatformUI As you touching this area please also remove this whitespace [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindowConfigurer.java+refs-changes-42-34042-1 160 EclipsePlatformUI This comment doesn't seem to be true? [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/HandlerActivationTest.java+refs-changes-31-50531-6 140 EclipsePlatformUI layoutBar is the thing that changed so do layoutBar.requestLayout() -- remove the getParent() call. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java+refs-changes-08-72108-1 237 EclipsePlatformUI Would <> work? [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java+refs-changes-44-51944-6 97 EclipsePlatformUI A JobGroup does limit the number of jobs that can run concurrently but that functionality is intended for throttling not mutual exclusion. I'm going to update JobGroup JavaDoc to emphasize this fact. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java+refs-changes-51-36151-8 1302 EclipsePlatformUI agree - corrected [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/wizards/preferences/PreferencesImportWizard.java+refs-changes-44-46544-1 50 EclipsePlatformUI it self -> itself [not_related_to_checkstyle] tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java+refs-changes-51-56751-3 279 EclipsePlatformUI line break [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/tasklist/TaskList.java+refs-changes-13-90613-5 1248 EclipsePlatformUI "I think in URLs the delimiter is always \""/\"" (as opposed to file paths). Also in the iconPath variable above \""/\"" has been used with no problem. The JVM probably takes care of converting it in the right way when going from URL to file path.\n\nThe Javadoc of getEntry also says \""A path value of \""/\"" indicates the root of this bundle.\"" " [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/TestPlugin.java+refs-changes-73-55273-2 97 EclipsePlatformUI Not sure what you mean I will update the copyright header for you no worries. This potentially will result in a minor merge conflict with the following bug but I can also solve that for you. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java+refs-changes-01-38801-6 11 EclipsePlatformUI I'm pretty sure it's SWT's computeSize method that lies about small control sizes - not SizeCache. [not_related_to_checkstyle] tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/widgets/SizeCacheTest.java+refs-changes-64-60264-17 153 EclipsePlatformUI If I look at APITestUtils this still looks correct. Is the test failing without this change? I think the isFastView method checks now if the view is minimized. Maybe simply rename the method to isViewMinimized? [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IWorkbenchPageTest.java+refs-changes-33-40833-8 3146 EclipsePlatformUI There will likely be cases where it is appropriate to run the code that manages the SWT widget hierarchy but not the code that propogates visibilty flags so a single set of guards at the start of the method may be risky. \n\nSee my comments below. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java+refs-changes-64-46964-5 158 EclipsePlatformUI agree - corrected [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/wizards/preferences/PreferencesExportWizard.java+refs-changes-44-46544-1 49 EclipsePlatformUI also here [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/progress/PendingUpdateAdapter.java+refs-changes-88-77088-1 51 EclipsePlatformUI Just inject the IEventBroker [not_related_to_checkstyle] org.eclipse.e4.ui.swt.gtk/src/org/eclipse/e4/ui/swt/gtk/DarkThemeProcessor.java+refs-changes-21-45921-7 30 EclipsePlatformUI Diamond operator <> is sufficient. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListDiff.java+refs-changes-99-50299-3 69 EclipsePlatformUI Ack merge removed the debugging log message that went here; need to add it back in. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java+refs-changes-40-28240-14 328 EclipsePlatformUI Ah please remove. (non-Javadoc) were useful before we had @Override [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/markerProject.java+refs-changes-67-79967-1 81 EclipsePlatformUI Why are these notifications unreliable? Do we have a bug for that? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/internal/css/swt/dom/scrollbar/StyledTextThemedScrollBarAdapter.java+refs-changes-36-69936-5 67 EclipsePlatformUI Half of the convolution (basically all of EvaluationReference) can be dropped if we are willing to weakly reference the keys rather than softly reference them. In that case we can just you WeakHashMap which will take care of handling the keys for us; should I do that? [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java+refs-changes-40-28240-19 66 EclipsePlatformUI These comments should be removed [not_related_to_checkstyle] tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/widgets/ExpandableCompositeTest.java+refs-changes-55-59855-2 196 EclipsePlatformUI This should be EMacroService. The context is to do with playback (and recording) of a macro.\n\nAh I think I see the tension here now. This class does two things:\n - it provides state info on macros and manages playback\n - it records information about the current macro being recorded\n\nPerhaps we can separate this into:\n - EMacroService\n - IMacroContext: should be accessed via @Optional @Inject äóî will be set during macro recording or playback. isPlayingBack isRecording and addMacroCommand would be moved to that object. [not_related_to_checkstyle] bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/EMacroContextService.java+refs-changes-53-89953-9 37 EclipsePlatformUI Update year [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java+refs-changes-09-37709-7 2 EclipsePlatformUI This is problematic as explained above... [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/MarkerViewUtil.java+refs-changes-31-79331-1 111 EclipsePlatformUI Why are you removing this method ? We may want to re-use it in other cases... [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java+refs-changes-83-24483-4 140 EclipsePlatformUI Should be Bug [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/UiTestSuite.java+refs-changes-50-53050-2 10 EclipsePlatformUI Suggest using two Semaphores rather than a shared mutex + state. Then this synchronized block could be replaced by one line:\n\nuiSemaphore.release(); [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/AccumulatingProgressMonitorTest.java+refs-changes-78-79578-8 210 EclipsePlatformUI I think this should be an internal package. I have some reservations about this being API which I'll expand on in the bug report. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/ISecondarySaveableSource.java+refs-changes-18-75318-9 12 EclipsePlatformUI in worst case this can be null. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/part/StatusPart.java+refs-changes-44-62344-3 202 EclipsePlatformUI Describe.\n\nSame below. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java+refs-changes-99-50299-3 87 EclipsePlatformUI "You may also add your name too: \""Thibault Le Ouay - Bug 443094\"" " [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CssSwtTestSuite.java+refs-changes-78-36278-1 9 EclipsePlatformUI This method should be parameterized similar to Collections.emptyList()\n\nSame for other emptyObservable* methods. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java+refs-changes-99-50299-3 257 EclipsePlatformUI This looks wrong how can IFile be casted to the requested T? [not_related_to_checkstyle] examples/org.eclipse.e4.demo.e4photo/src/org/eclipse/e4/demo/e4photo/AdapterFactory.java+refs-changes-73-42273-1 41 EclipsePlatformUI Reformat [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/EditorsPreferencePage.java+refs-changes-72-90272-2 256 EclipsePlatformUI Please file a formatter bug using this example. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/QuickAccessContents.java+refs-changes-05-56805-2 216 EclipsePlatformUI Okay then I will apply a patch for your proposed bug report. [not_related_to_checkstyle] examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet053StartEditorWithContextMenu.java+refs-changes-74-32074-1 157 EclipsePlatformUI No need to cache this. ImageDescriptor#getImageData() is almost always called from within a ResourceManager which does this sort of caching automatically. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/LazyImageDescriptor.java+refs-changes-28-62028-1 35 EclipsePlatformUI Not anymore. I fixed the warnings. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidirectionalMap.java+refs-changes-99-50299-9 34 EclipsePlatformUI I realize we should be opening an error dialog here: there's nothing as frustrating as opening a browser and have nothing shown up. The code in org.eclipse.ui.browser uses WebBrowserUtil.openError() to report errors to the user. [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/OpenBrowserHandler.java+refs-changes-57-70357-3 65 EclipsePlatformUI Unnecessary blank line unrelated to the rest of the change. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/Properties.java+refs-changes-44-51944-6 42 EclipsePlatformUI The whole class is package protected so I don't think it matters... but I'll change it anyway. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java+refs-changes-51-56751-13 229 EclipsePlatformUI Unnecessary blank line. [not_related_to_checkstyle] tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java+refs-changes-51-56751-3 28 EclipsePlatformUI I'd document here that we use the IEB explicitly because the annotation is unpredictable with processors within the debugger [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.swt.gtk/src/org/eclipse/e4/ui/swt/internal/gtk/DarkThemeProcessor.java+refs-changes-21-45921-9 36 EclipsePlatformUI trailing space [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/QuickStartAction.java+refs-changes-95-65695-4 10 EclipsePlatformUI can be null too [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectsContentProvider.java+refs-changes-65-71865-1 105 EclipsePlatformUI This callback should be registered closer to where the image is actually created (i.e. in getViewMenuImage()). After all the viewMenuImage may never actually be created and so viewMenuImage would be null. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java+refs-changes-06-71106-1 567 EclipsePlatformUI "BUG: this line removes the \""Team\"" menu forever.\nHowever without this line many (but not all) action set contribution menu entries aren't shown under the CustomizePerspectiveDailog / Command Group Availability / Menubar details. " [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java+refs-changes-65-25565-5 1151 EclipsePlatformUI We should use SafeRunner to do the dispose. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ServiceLocator.java+refs-changes-29-78429-6 155 EclipsePlatformUI This should be Collections.emptySet(). You can change the type of prefs. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java+refs-changes-52-27352-1 1496 EclipsePlatformUI Why is that test not failing? [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dialogs/UIDialogs.java+refs-changes-94-25694-4 160 EclipsePlatformUI Please add a test for a nested GridLayout containing a fill-aligned wrapping text control. I suspect this may uncover interesting corner cases since GridLayout it will be a wrapping control that doesn't implement ILayoutExtension or have the SWT.WRAP. [not_related_to_checkstyle] tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/widgets/ExpandableCompositeTest.java+refs-changes-64-60264-17 37 EclipsePlatformUI Here integrate the JavaDoc explaining the overload with buttonLabelToIdMap: Map. The client should easily understand the difference between this method and the other one. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialogWithToggle.java+refs-changes-81-90281-2 123 EclipsePlatformUI Maybe combined the two if statements with || ? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ActionSetFilter.java+refs-changes-01-38801-6 36 EclipsePlatformUI This code doesn't seem quite right.\n\n1. I think only MPartStacks get tagged with MINIMIZED or MINIMIZED_BY_ZOOM so checking isMinimized() for anything else is a no-op. I guess it doesn't hurt to check though.\n\n2. The values we're interested in checking are on the MPlaceholders so I think we need to check isMinimized(element) and not isMinimized(part).\n\n2. MParts/MPlaceholders in a minimized MPartStack continue to have visible=true. But MParts/MPlaceholders in an MPartSashContainer have visible=false.\n\nI expected to see something like:\n\n> if(parent instanceof MPartStack && ((MPartStack)parent).getSelectedElement() != element) {\n> return false;\n> }\n> if(isMinimized(parent) || isMinimized(element)) {\n> return false;\n> }\n> return element.isVisible();\n\n(which passes the tests) [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java+refs-changes-89-67089-3 484 EclipsePlatformUI If you don't use @EventTopic you should have a @PreDestroy to remove the handler. [not_related_to_checkstyle] bundles/org.eclipse.ui.gtk/src/org/eclipse/ui/gtk/DarkThemeProcessor.java+refs-changes-21-45921-6 35 EclipsePlatformUI Inline methods with only one statement do not add a lot of value [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/filteredtree/FilteredTreeTests.java+refs-changes-66-62566-1 181 EclipsePlatformUI Why don't we handle that via the Filter? I dislike having a special treatment of certain stacktraces. I think it is OK to add them to the filter (with wildcards) but hard-coding them seems wrong. [not_related_to_checkstyle] bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/EventLoopMonitorThread.java+refs-changes-90-36090-1 664 EclipsePlatformUI "That's actually what's implemented: if showlocation is set it's used unconditionally which is honored by a disabled toggle. If it's not set the pref takes control. We can discuss how the UI should behave in the former case:\n* Be disabled like now\n* Disabled with a hint why (\""locked by showlocation\"")\n* Even invisible (which would create confusion I think)\n\nWe could go for the pref taking precedence but then users might wonder why they don't see the location although they have set showlocation (because they unchecked the toggle somewhen in the past). Which could only be made transparent by a third toggle value for \""default\"".\n\nThe two settings are related no matter what we do because they target the same title bar. I am not so concerned about the logic here but only what makes most sense for the users. " [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java+refs-changes-10-37510-3 201 EclipsePlatformUI Good point. I can't think of a use-case for it... and it's probably safer to treat it as an error until we think of one. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ISideEffect.java+refs-changes-82-68282-24 157 EclipsePlatformUI You don't need the argument nor the context fetch [not_related_to_checkstyle] org.eclipse.e4.ui.swt.gtk/src/org/eclipse/e4/ui/swt/gtk/DarkThemeProcessor.java+refs-changes-21-45921-7 66 EclipsePlatformUI Oops sorry this won't work.\n\nif(productUrl == null || (url != null && !url.toString().equals(productUrl.toString())) [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/QuickStartAction.java+refs-changes-95-65695-3 128 EclipsePlatformUI The accessibleListenersSize method is not defined in the GTK version of Accessible. [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/ProgressAnimationItemTest.java+refs-changes-69-43269-2 120 EclipsePlatformUI has -> have [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributedPartRenderer.java+refs-changes-40-82440-20 87 EclipsePlatformUI ;-) You should know what is expected here by now.... [not_related_to_checkstyle] tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/NavigatorTestSuite.java+refs-changes-96-39996-4 2 EclipsePlatformUI You're not using UISynchronize which you probably should. But you could use @UIEventTopic instead.\n\nBut UISynchronize is to isolate code from explicitly knowing the UI subsystem (e.g. SWT vs Swing vs Vaadin) whereas this code is very explicitly for SWT it might just be best to get the corresponding Display (available in the event as IThemeEngine.Events.DEVICE) and do an asyncExec(). [not_related_to_checkstyle] bundles/org.eclipse.ui.gtk/src/org/eclipse/ui/gtk/DarkThemeProcessor.java+refs-changes-21-45921-2 33 EclipsePlatformUI The code is not thread safe. Adding managers checking for the collection size can colide with clearing the collecton creating copy can collide with adding to collection.\nAll this operations should be inside synchronized(mgrsToUpdate) blocks. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java+refs-changes-19-48919-2 1162 EclipsePlatformUI Why is this not necessary? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/filteredtree/FilteredTree.java+refs-changes-24-35924-4 517 EclipsePlatformUI "\""B\""ug " [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/JobInfoTest.java+refs-changes-50-53050-2 11 EclipsePlatformUI I think we should leave this check it to give early feedback is someone uses it incorrect. Javadoc alone is not sufficient IHMO [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java+refs-changes-83-24483-1 139 EclipsePlatformUI I think we should not leave commented code in master [not_related_to_checkstyle] bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceImpl.java+refs-changes-98-40098-1 56 EclipsePlatformUI make it a method ref: listener::getSegments [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/util/BidiUtils.java+refs-changes-81-54381-1 337 EclipsePlatformUI "\""if the files should be opened with external application if there is one configured for this file type by the operating system.\"" " [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java+refs-changes-41-46341-4 263 EclipsePlatformUI "This is not necessarily the case. I use this for example to open *any* shell files without extension with shell script editor.\n\nI would add this check for pre-selecting the values of external programs only because of the special \""system default\"" case we have there. " [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java+refs-changes-06-70006-3 587 EclipsePlatformUI "Remove \""2010 \"" " [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Diffs.java+refs-changes-99-50299-10 2 EclipsePlatformUI This seems like it might be worth separating out into a persisting class [not_related_to_checkstyle] bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/ComposableMacro.java+refs-changes-53-89953-5 89 EclipsePlatformUI Why would the MenuManager not be visible if the MMenu element is visible? [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributionRecord.java+refs-changes-65-25565-5 142 EclipsePlatformUI I think it depends on the model type. If it's a DirectMenuItem with the OPAQUE_TAG set then we probably shouldn't dispose of it ourselves. I guess the way to check would be item.getTags().contains(org.eclipse.e4.ui.internal.workbench.OpaqueElementUtil.OPAQUE_TAG) [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java+refs-changes-53-43253-1 452 EclipsePlatformUI Why did you remove the tab? [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java+refs-changes-90-86790-8 101 EclipsePlatformUI I think the preference name (and value) should be OPEN_UNKNOWN_TEXT_FILES_WITH_TEXT_EDITOR [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java+refs-changes-41-46341-4 271 EclipsePlatformUI Should that not be vogella GmbH? [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/SelectionDialog.java+refs-changes-01-34701-1 2 EclipsePlatformUI Just List<> [not_related_to_checkstyle] bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroManager.java+refs-changes-53-89953-4 281 EclipsePlatformUI change [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/help/DialogPageContextComputer.java+refs-changes-03-89203-2 80 EclipsePlatformUI This format seems inflexible. That can be an advantage but given that you think storing in JavaScript form is an advantage it may be worth coming up with a different representation here from the get-go. [not_related_to_checkstyle] bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/IMacroCommand.java+refs-changes-53-89953-5 38 EclipsePlatformUI Break the line before 'extends' [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java+refs-changes-99-50299-9 41 EclipsePlatformUI It's an extra object for no reason. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java+refs-changes-52-27352-1 1509 EclipsePlatformUI Line break after ( is preferable to line break before dot. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java+refs-changes-00-50300-8 274 EclipsePlatformUI This could be replaced with Boolean.parseBoolean(...) instead since we're just getting the boolean value. However it's in a legacy pre-3.0 RCP method so I'm not sure it's worth it? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorDescriptor.java+refs-changes-31-50231-1 443 EclipsePlatformUI I don't know the saveables API in detail but looking at the sources this is not null safe. So I would add a null check before the for-each iteration. [not_related_to_checkstyle] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheet.java+refs-changes-26-75126-8 154 EclipsePlatformUI this method do not need to be public and it is also can be made static.\n\nThe return value type does not need to be reference it can be just primitive boolean.\n\nThe name is better be isMruEnabled because it reads more natural this way. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbookEditorsHandler.java+refs-changes-17-91417-4 53 EclipsePlatformUI System.arraycopy(parameters 0 commandArray 1 parameters.length) [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java+refs-changes-70-45270-3 98 EclipsePlatformUI o -> of\n.. -> . [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/keys/KeyBindingDispatcher.java+refs-changes-53-89953-5 61 EclipsePlatformUI I don't think that is required [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ExtendedMarkersView.java+refs-changes-22-80222-3 1508 EclipsePlatformUI @version tag is not needed. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java+refs-changes-40-28240-19 26 EclipsePlatformUI "Sorry the code uses all the nice additions to the Java 8 but because of this it is not debuggable anymore.\n\nThe snippet below does exact same and allows debugging:\n\nfor (MMenuContribution menuModel : application.getMenuContributions()) {\n\tString positionInParent = menuModel.getPositionInParent();\n\tif (positionInParent.startsWith(\""popup:toolbar\"")) { // NON-NLS-1 \n\t\tfor (MMenuElement itemModel : menuModel.getChildren()) {\n\t\t\tif (itemModel instanceof MItem) {\n\t\t\t\tfinal IEclipseContext lclContext = getContext(itemModel);\n\t\t\t\tHandledContributionItem itemRenderer = ContextInjectionFactory\n\t\t\t\t\t\t.make(HandledContributionItem.class lclContext);\n\t\t\t\titemRenderer.setModel((MItem) itemModel);\n\t\t\t\titemRenderer.fill(toolControlMenu 0);\n\t\t\t}\n\t\t}\n\t}\n} " [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolControlRenderer.java+refs-changes-99-60199-3 255 EclipsePlatformUI make this a method and use a method reference [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java+refs-changes-47-57347-1 447 EclipsePlatformUI Please remove redundant type information in another follow up commit [not_related_to_checkstyle] bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserPreferencePage.java+refs-changes-11-53511-2 93 EclipsePlatformUI <> would do. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Realm.java+refs-changes-99-50299-3 82 EclipsePlatformUI rename 'otherContext' or 'assignedContext'? [not_related_to_checkstyle] bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java+refs-changes-11-90511-3 568 EclipsePlatformUI Can I add a solution for this within this gerrit review or do I have to create a new bug and gerrit review since this is already merged? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java+refs-changes-39-39639-3 2509 EclipsePlatformUI The behavior change occurs right here. It attaches a height hint to the tree control which had previously been set to SWT.DEFAULT. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java+refs-changes-08-47508-3 897 EclipsePlatformUI I would first check other preconditions and delay resolving the adapter until really needed because it is not for free [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workbench/ResourceExtensionLabelProvider.java+refs-changes-99-82899-1 63 EclipsePlatformUI Whitespace please remove [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/viewers/Bug242231Test.java+refs-changes-30-24230-2 99 EclipsePlatformUI Unnecessary blank line. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java+refs-changes-40-28240-21 51 EclipsePlatformUI They should (the arrow size is not dependent on the size of the font as far as I know).\n\nAlso these values are being used in LiClipse: http://www.liclipse.com/ for quite a while already and no one complained so far :) [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/custom/CSSPropertyTreeArrowsSWTHandler.java+refs-changes-69-45169-1 58 EclipsePlatformUI Oops! Good catch. [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java+refs-changes-64-54264-2 45 EclipsePlatformUI awt? I think that is wrong [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java+refs-changes-68-40968-1 13 EclipsePlatformUI No it is not the same because the returned image will not be null if you do that ;) [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewLabelProvider.java+refs-changes-85-23785-20 97 EclipsePlatformUI "Here also \""2008 2014\"" would also be sufficient. " [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/IdClassLabelColorTest.java+refs-changes-78-36278-1 2 EclipsePlatformUI Fits into previous line. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/UnionSet.java+refs-changes-99-50299-9 84 EclipsePlatformUI not sure if this is gerrit but please check indentation. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/FileEditorsPreferencePage.java+refs-changes-87-89187-1 225 EclipsePlatformUI handleMenuToBeRenderedChange [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java+refs-changes-18-43618-5 466 EclipsePlatformUI Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=450187\n\nBut still using contains is better than iterate yourself. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java+refs-changes-85-23785-20 183 EclipsePlatformUI getAdapter -> adapt [not_related_to_checkstyle] bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/ResourceUtil.java+refs-changes-20-57120-3 245 EclipsePlatformUI This causes a SWTException because the shell is null when running the test.\nTherefore a new Shell should be created here and should be disposed in a @After tearDown method. [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/SWTPartRendererTest.java+refs-changes-13-37313-1 54 EclipsePlatformUI "Hard for me to decode maybe use: \""warnUserAboutWorkspaceChanges\"". A bit long but more descriptive " [not_related_to_checkstyle] bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java+refs-changes-52-31252-2 411 EclipsePlatformUI "The patch has been updated based on https://bugs.eclipse.org/bugs/show_bug.cgi?id=405542#c5\n\nJobGroup ensures only one job (cleanAndSaveJob) to run at one moment that is in accordance with the Eclipse Job Groups proposal (https://docs.google.com/document/d/1iayTYP2KMz13EeJP9uMpBlL93ZFND5apG-rJG-7kjSU/edit?usp=sharing):\n\n\""A JobGroup can be configured with a throttling parameter that determines the number of jobs from the group that are allowed to run in parallel or more accurately the maximum number of worker threads that may be used to run the jobs belonging to the group.\"" " [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java+refs-changes-51-36151-8 1302 EclipsePlatformUI The check for not null parameter is there [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java+refs-changes-83-24483-1 148 EclipsePlatformUI Independently how many saveables are returned we should not continue if the list contains our instance because otherwise we might start an endless loop. [not_related_to_checkstyle] bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheet.java+refs-changes-26-75126-7 150 EclipsePlatformUI Should we handle the case of editor.getProgram() == null ? [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistry.java+refs-changes-34-82334-5 687 EclipsePlatformUI "Remove \""2007 \""\n\nSimilar in other files. " [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/IListChangeListener.java+refs-changes-99-50299-10 2 EclipsePlatformUI Google Inc. and others. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/resource/SuppliedImageDescriptor.java+refs-changes-28-62028-3 2 EclipsePlatformUI "Usually we would only write \""Copyright (c) 2009 2014 Remy Chi Jian Suen and others.\"" and avoid too many year references. " [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java+refs-changes-78-36278-1 2 EclipsePlatformUI There seems to be a lot of duplication between methods of this interface and static methods of ISideEffect. Do we really need two sets of similar methods? If so what are the use cases for each set? [not_related_to_checkstyle] bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/sideeffect/ISideEffectFactory.java+refs-changes-82-68282-21 36 EclipsePlatformUI Ok I though you were suggesting that the synchronization was only needed in the throttler. I will run some bench with this. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressManager.java+refs-changes-86-80386-7 145 EclipsePlatformUI Since IConverter hasn't been generified yet you should not specify the generic arguments to Function. Otherwise we'll be stuck with forever and we don't want that. [not_related_to_checkstyle] bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/IConverter.java+refs-changes-11-60611-1 68 EclipsePlatformUI I had left the code as formatted by the formatter (eventhough I too dislike the line breaking). Some projects insist on not changing the automatic formatting so in doubt I left it. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/sac/CSSOneOfAttributeConditionImpl.java+refs-changes-58-40358-1 56 EclipsePlatformUI Remove ws [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/CommonNavigatorActionGroup.java+refs-changes-51-81751-1 239 EclipsePlatformUI The filter doesn't support wildcards. Adding full wildcard support (as opposed to class prefix only) to the filter class would be a major effort. [not_related_to_checkstyle] bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/EventLoopMonitorThread.java+refs-changes-90-36090-1 664 EclipsePlatformUI ? The @return javadoc says it is OK to return null [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IEditorInput.java+refs-changes-44-62344-3 70 EclipsePlatformUI I answered there. [not_related_to_checkstyle] bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java+refs-changes-53-39353-3 304 EclipsePlatformUI AFAIK (http://www.vogella.com/tutorials/JUnit/article.html#junitadvanced_parameterizedtests) a parameterized test is only allowed to contain one test method. [not_related_to_checkstyle] tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java+refs-changes-64-54264-2 159 EclipsePlatformUI Should be called 'testCreateParameterArray()' [not_related_to_checkstyle] tests/org.eclipse.ui.tests.browser/src/org/eclipse/ui/tests/browser/internal/WebBrowserUtilTestCase.java+refs-changes-70-45270-3 21 EclipsePlatformUI "I am getting a compile error here because the \""resume\"" method is void. " [not_related_to_checkstyle] tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java+refs-changes-51-56751-4 208 EclipsePlatformUI The code would be easier to read if the second argument was changed to Boolean.TRUE. [not_related_to_checkstyle] bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/SplitFeedbackOverlay.java+refs-changes-24-77924-2 46 EclipsePlatformUI That's a habit of mine to be less picky about user-inputs but since e3 does not do it e.g. a tab is read as part of the id and makes it not-found in e3 I could be just as 'mean' if that is preferred. [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/e4/ui/workbench/addons/perspectiveswitcher/PerspectiveSwitcher.java+refs-changes-07-58607-1 421 EclipsePlatformUI Or maybe create a helper method for checking if descriptor is null and if the collection contains is not null e.g. removeDescriptorFromList(descriptor list). [not_related_to_checkstyle] bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Perspective.java+refs-changes-34-38634-8 160 EclipsePlatformUI if this will be not a field anymore this call would be unneeded too. [not_related_to_checkstyle] bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectsContentProvider.java+refs-changes-65-71865-3 139 Vaadin "Escalator has traditionally been very strict about the user doing something that's even slightly \""illegal\"". I.e. there are no silent falls everything is explicitly thrown. Mostly because Escalator is so low level and complex that it's so easy for a faulty state to propagate and hide itself deep into the system.\n\nGrid could be thought to be the abstraction on top of that that's user friendly and more lenient. " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/EditorRow.java+refs-changes-32-4332-4 99 Vaadin I'm not entirely convinced but made the change. Probably something that should be discussed further. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/EditorRow.java+refs-changes-23-4723-3 310 Vaadin You probably want to use propertyGenerators.entrySet() instead. [not_related_to_checkstyle] server/src/com/vaadin/data/util/GeneratedPropertyContainer.java+refs-changes-51-4751-2 266 Vaadin Shouldn't this also call handleAriaAttributes? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VPopupCalendar.java+refs-changes-03-903-8 256 Vaadin Ok thought I had added them but a few were left out [not_related_to_checkstyle] server/src/com/vaadin/ui/DateField.java+refs-changes-08-1008-3 386 Vaadin OK will fix [not_related_to_checkstyle] server/tests/src/com/vaadin/ui/AbstractMediaTest.java+refs-changes-96-2796-4 31 Vaadin This import will cause compile errors for the client-side package as it is built by build.xml. [not_related_to_checkstyle] shared/src/com/vaadin/shared/ui/grid/GridState.java+refs-changes-18-2118-15 23 Vaadin Queue? [not_related_to_checkstyle] client/src/com/vaadin/client/communication/MessageHandler.java+refs-changes-48-11948-7 208 Vaadin Again use ReflectTools.findMethod :) [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-40-10940-3 556 Vaadin Are there any other cases that need to be taken into account than that some other element than the root should be used for some widgets? If there is I guess it's sensible to add an interface for taking care of it and just use a default implementation for other widgets. [not_related_to_checkstyle] client/src/com/vaadin/client/ComponentConnector.java+refs-changes-50-850-2 159 Vaadin Name doesn't say much. Maybe hideAfterDelay() or hideLater() or something else [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VNotification.java+refs-changes-70-4170-1 265 Vaadin Or double clicking [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Renderer.java+refs-changes-59-3559-3 88 Vaadin Yes yes we do. [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-14-11014-2 1280 Vaadin Yes i believe it would. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/SelectionModelNone.java+refs-changes-93-3893-2 61 Vaadin I don't really see the benefit of bringing this to a method. \n- Calling this or new are equally long\n- One argument might be that you can keep the same implementation for both calls but you can just as well just change one of the calls to this method and you have the same issue.\n- Gives more API. Does anyone need this API? [not_related_to_checkstyle] server/src/com/vaadin/navigator/Navigator.java+refs-changes-36-5736-11 1036 Vaadin Changed to call tracker.cleanStreamVariable directly [not_related_to_checkstyle] server/tests/src/com/vaadin/tests/server/TestStreamVariableMapping.java+refs-changes-09-1009-1 71 Vaadin Argh choices choices. Having this an inner class in Grid would make less ugly public api but the file itself would be uglier (for us maintainers).\n\nCoin toss? :D [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/MultiSelectionRenderer.java+refs-changes-72-3672-1 207 Vaadin Should this maybe round instead of truncate? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/ScrollbarBundle.java+refs-changes-49-2649-1 125 Vaadin nit: Remove by index would is faster that remove by instance in ArrayList. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-18-2118-11 322 Vaadin This should be needed no more. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/widgetset/client/grid/GridClientColumnRendererConnector.java+refs-changes-96-4396-8 297 Vaadin State classes should not have any methods only public members. [not_related_to_checkstyle] shared/src/com/vaadin/shared/ui/tabsheet/TabState.java+refs-changes-27-2727-3 22 Vaadin "Would \""left\"" make more sense? " [not_related_to_checkstyle] server/src/com/vaadin/ui/declarative/ShortcutKeyMapper.java+refs-changes-31-6231-1 51 Vaadin Is this still needed or was it just a workaround to already fixed bugs in Esacalator? Same for removeColumn. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-87-2187-10 517 Vaadin (the null parameter could theoretically break some custom serializers but in practice there was never any real use for the connector tracker at this point) [not_related_to_checkstyle] server/src/com/vaadin/server/LegacyCommunicationManager.java+refs-changes-42-6742-1 122 Vaadin "The same as above.\nThe logic of the code hasn't been changed. Just optimized (probably) and less \""talkative\"". " [not_related_to_checkstyle] server/src/com/vaadin/data/util/MethodProperty.java+refs-changes-30-3030-1 644 Vaadin rename; not guaranteed to be a mouse down event. [not_related_to_checkstyle] client/src/com/vaadin/client/widget/grid/GridDragAndDropHandler.java+refs-changes-58-7358-3 137 Vaadin Becomes unreachable. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-05-3605-1 1550 Vaadin i wouldn't have put this as public but meh. [not_related_to_checkstyle] client/src/com/vaadin/client/WidgetUtil.java+refs-changes-66-8666-5 1475 Vaadin Debug logging [not_related_to_checkstyle] server/src/com/vaadin/server/communication/JSR356WebsocketInitializer.java+refs-changes-27-8027-8 156 Vaadin "getSubPart(\""#footer\"") same reason as before " [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/grid/GridElement.java+refs-changes-78-4178-2 255 Vaadin "Well you are totally correct what can I say :)\n\nLess efficient of course. But main purpose of this method: produce \""good enough\"" hash value. So efficiency is not a priority here (of course it should not too bad).\n\nPrevious impl loses to the impl \""return 0\"". That's the most efficient. But very bad for hash function. " [not_related_to_checkstyle] server/src/com/vaadin/data/util/filter/Between.java+refs-changes-80-4380-3 69 Vaadin why not iterate from j+1 to l-1? Then can eliminate extra if below and rescanning the beginning many times. [not_related_to_checkstyle] client/src/com/vaadin/client/componentlocator/VaadinFinderLocatorStrategy.java+refs-changes-17-2317-9 759 Vaadin I don't like this if/else if sequence I think it should be replaced with some polymorphism. I'll update the patch [not_related_to_checkstyle] server/src/com/vaadin/ui/declarative/converters/DesignResourceConverter.java+refs-changes-89-8589-8 89 Vaadin Move out of if and use\n\nRoles.getButtonRole().setAriaDisabledState(getElement() !enabled) [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VButton.java+refs-changes-80-980-3 360 Vaadin "personal taste: i'd like this method to be called \""columnHasBeenGrouped\"" to make the if-statement read more naturally " [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/ColumnGroupRow.java+refs-changes-87-2187-5 100 Vaadin Yes ComboBox contain an input with text type [not_related_to_checkstyle] client/src/com/vaadin/client/Util.java+refs-changes-59-4259-10 1267 Vaadin Why do we need to use chameleon for testing? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/textfield/TextFieldEmptyingPrompt.java+refs-changes-78-6678-1 30 Vaadin Seems like functionality with java.sql.Date is never tested. [not_related_to_checkstyle] server/tests/src/com/vaadin/data/fieldgroup/FieldGroupDate.java+refs-changes-65-965-1 40 Vaadin not 100% sure if this works as intended probably does [not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/ScreenshotTB3Test.java+refs-changes-81-11981-6 443 Vaadin Then remove it [not_related_to_checkstyle] uitest/src/main/java/com/vaadin/tests/components/checkbox/CheckBoxRpcCount.java+refs-changes-58-14058-5 49 Vaadin Should be 7.0.1 [not_related_to_checkstyle] client/src/com/vaadin/client/communication/StateChangeEvent.java+refs-changes-37-737-1 111 Vaadin Should be setEnabled [not_related_to_checkstyle] client/src/com/vaadin/client/ui/calendar/schedule/MonthGrid.java+refs-changes-18-818-4 185 Vaadin Ditto here [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-19-4019-3 321 Vaadin i pulled up this special case handling. if the value was an invisible component it would return null (encoded) and then line 99 would add the null to paramjson.\n\nhowever I think it is quite doubtful that this is really wanted. maybe in case of not visible we do not want to add it? [not_related_to_checkstyle] server/src/com/vaadin/server/communication/ClientRpcWriter.java+refs-changes-83-3583-1 93 Vaadin Yes IE8 & IE9 don't have CSS transition support.\n\nI have a written approval from Joonas that this is okay for our customers. See end of document: https://docs.google.com/a/vaadin.com/document/d/1KTB4bZa8lcSgZmBG3xH9EN-fXQoMVjOKvCDGmxcI1b4/edit#heading=h.oezl8l9vsky3 [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VNotification.java+refs-changes-87-3287-1 268 Vaadin Alternatively could use a JUL logger instead of a PrintStream. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/handler/SCSSErrorHandler.java+refs-changes-84-2084-7 26 Vaadin Because uIs.remove(id) was already autoboxing and the comparison with windowNameMap.get(windowName) would otherwise have to handle null and unbox [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinSession.java+refs-changes-62-1662-1 793 Vaadin This should not be shown to the end user. Log instead of throwing [not_related_to_checkstyle] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-13-1913-4 2392 Vaadin should perhaps update the javadoc or even extract and rename the interface from ShortcutActionHandler as no longer specific to it [not_related_to_checkstyle] client/src/main/java/com/vaadin/client/ui/ShortcutActionHandler.java+refs-changes-16-14116-1 64 Vaadin Please elaborate? How? for what? [not_related_to_checkstyle] shared/src/com/vaadin/shared/ui/grid/GridState.java+refs-changes-13-3713-4 94 Vaadin If a new type of renderer isn't created i don't see why this field should exist anymore. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/GridStaticSection.java+refs-changes-05-4105-14 193 Vaadin Use getState(false) to prevent unnecessary marking the state as dirty. [not_related_to_checkstyle] server/src/com/vaadin/ui/DateField.java+refs-changes-08-1008-5 439 Vaadin no >:( [not_related_to_checkstyle] client/src/com/vaadin/client/widget/dragger/DragHandler.java+refs-changes-36-12136-7 6 Vaadin This should use designContext for reading. [not_related_to_checkstyle] server/src/com/vaadin/ui/DragAndDropWrapper.java+refs-changes-37-7237-1 477 Vaadin "Convention is to use third-person indicative (\""sets\"") instead of imperative. Also sentences should end with periods but apparently that's not followed too well in this file... " [not_related_to_checkstyle] client/src/com/vaadin/client/connectors/GridConnector.java+refs-changes-06-8106-1 169 Vaadin The doubt could be eliminated with some creative abuse of the assert keyword.\n\nAnother approach could be to use TreeMap instead of LinkedHashMap. I would guess that it would keep the implementation slightly shorter and simpler even though the theoretical runtime performance would be slightly worse. [not_related_to_checkstyle] server/src/com/vaadin/ui/ConnectorTracker.java+refs-changes-05-1805-1 797 Vaadin Should there still be a deprecated class at the old location that would just delegate to LegacyComponentLocator? [not_related_to_checkstyle] client/src/com/vaadin/client/componentlocator/ComponentLocator.java+refs-changes-06-1806-1 23 Vaadin should be reworded as client.updateComponent has nothing to do with VFilterSelect.resetSelection [not_related_to_checkstyle] client/src/main/java/com/vaadin/client/ui/VFilterSelect.java+refs-changes-38-14038-1 2146 Vaadin @Test ??? [not_related_to_checkstyle] server/tests/src/com/vaadin/data/util/sqlcontainer/query/FreeformQueryTest.java+refs-changes-28-8828-2 726 Vaadin Why is super called before the value is modified? [not_related_to_checkstyle] server/src/com/vaadin/ui/Slider.java+refs-changes-53-753-1 275 Vaadin This will require a new VSlider implementation for @DelegateToWidget to work. Worth it or just use SliderOrientation for now? [not_related_to_checkstyle] server/src/main/java/com/vaadin/tokka/ui/components/fields/Slider.java+refs-changes-53-13753-6 226 Vaadin ditto [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/datefield/DateFieldWhenChangingValueAndEnablingParentTest.java+refs-changes-91-8591-2 110 Vaadin This looks really useful and reusable but only for table related tests IMO it should be in Table related abstract class. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-18-4718-1 268 Vaadin the mention of it being a flyweight object probably can be omitted since it's an unnecessary detail.\n\nSimply saying that the reference may not be stored without going into the specifics should be enough. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/renderers/ComplexRenderer.java+refs-changes-95-3595-2 37 Vaadin @Past is not applicable to LocalDateTime.\nOnly Date and Calendar. [not_related_to_checkstyle] server/src/test/java/com/vaadin/tests/data/bean/BeanToValidate.java+refs-changes-64-14064-6 35 Vaadin Done with screenshot on failure. Discussing with Jonatan on a better solution. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-64-7364-10 271 Vaadin I warn you this causes object duplication. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/SelectionModelMulti.java+refs-changes-05-3605-3 82 Vaadin @since [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTabsheetBase.java+refs-changes-98-4598-3 182 Vaadin see comments below and for buildFilter() [not_related_to_checkstyle] server/src/com/vaadin/ui/ComboBox.java+refs-changes-04-12904-4 840 Vaadin addParameters...() - typo [not_related_to_checkstyle] client/src/com/vaadin/client/extensions/BrowserWindowOpenerConnector.java+refs-changes-20-420-1 64 Vaadin @since [not_related_to_checkstyle] client/src/com/vaadin/client/event/PointerMoveEvent.java+refs-changes-16-3116-4 22 Vaadin "Captializing \""Sorting\"" implies that there's a class with that name. " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-82-3782-17 2094 Vaadin Should these also return a Registration object instead of having the separate remove methods? [not_related_to_checkstyle] server/src/main/java/com/vaadin/tokka/ui/components/fields/AbstractTextField.java+refs-changes-52-13752-2 158 Vaadin Isn't there a setting that the text field is not writeable so only the items from the menu can be selected? In this case the button needs to be reachable. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VFilterSelect.java+refs-changes-99-999-4 1057 Vaadin As also noted in Grid.setSelectionModel I call into question the raison d'etre of this event. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/SelectionModelChangeEvent.java+refs-changes-05-3605-6 34 Vaadin

[not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Row.java+refs-changes-81-2081-1 46 Vaadin "\""the current\"" -> \""this\"". Repeat below. " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/RowContainer.java+refs-changes-07-1907-7 52 Vaadin It doesn't silently fail.\n\nThis functionality is bit overengineered. \n\nconvertToModel() method signature states that it should return Collection (not exactly instance of provided class).\nThis method TRIES to respects class which is passed as an argument. But it doesn't have to. \n\nIt does what it should: return a collection. If it fails to respect the class argument then ArrayList is returned. No fail.\n\nStringToDateConverter doesn't respect targetType argument at all f.e. [not_related_to_checkstyle] server/src/com/vaadin/data/util/converter/StringToCollectionConverter.java+refs-changes-35-6735-4 212 Vaadin Ditto [not_related_to_checkstyle] server/src/com/vaadin/server/DeploymentConfiguration.java+refs-changes-60-4860-1 177 Vaadin not really a fan of these kinds of boolean arguments. It's hard to understand what the true/false does when reading the code in Escalator.\n\nI'd suggest splitting this into two descriptive methods instead and internally use the boolean distinction if so desired. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/FlyweightCell.java+refs-changes-54-3654-2 87 Vaadin Use the class literal instead of getClass() so that logging points to the right java file even if getClass() is a subclass. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/GridConnector.java+refs-changes-92-3892-3 462 Vaadin (this test would not have to be a legacy test when the new Grid is available) [not_related_to_checkstyle] compatibility-server/src/test/java/com/vaadin/tests/server/component/grid/GridChildrenTest.java+refs-changes-56-14156-3 0 Vaadin Moved ticket number and description from comments to methods [not_related_to_checkstyle] uitest/src/com/vaadin/tests/fieldgroup/MultipleValidationErrors.java+refs-changes-53-6053-13 65 Vaadin @author Vaadin Ltd.\n@since 7.0 [not_related_to_checkstyle] server/src/com/vaadin/server/communication/PublishedFileHandler.java+refs-changes-09-1009-1 32 Vaadin Yes it is the same. Remove? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/HandlesAriaRequired.java+refs-changes-99-999-4 20 Vaadin "The same \""boolean width\""-pattern here " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VGridLayout.java+refs-changes-45-3345-2 386 Vaadin iOS shows no scrollbars at all while scrolling and Android I don't know. The pixels are taken from OSX (Mavericks) thus the constant mentions OSX specifically.\n\nAll platforms hiding their scrollbars get (currently) the same treatment. If separate behavior is required for different platforms this code needs to be changed and profiled for those platforms. However AFAIK all touch platforms may be treated the same way for now.\n\nFeel free to disagree with examples :) [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/ScrollbarBundle.java+refs-changes-68-2268-2 35 Vaadin "I think future maintainers would appreciate a comment here why this is being done as \""deferred\"". " [not_related_to_checkstyle] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-63-7063-1 890 Vaadin I was surely working on the file and left this in. Will remove. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VDateFieldCalendar.java+refs-changes-51-851-2 37 Vaadin Could elaborate (using a comment or by renaming) that this used to get *cell* measurements (as opposed to the other listener that's for the table/widget element) [not_related_to_checkstyle] client/src/com/vaadin/client/ui/formlayout/FormLayoutConnector.java+refs-changes-34-11934-7 49 Vaadin Please don't make me write new Grid.GridColumn() or try to get Eclipse to understand how to do the import. One ugly way of doing this is to include a dummy top level GridColumn class that just extends Grid.GridColumn [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-18-2118-5 55 Vaadin "This comment doesn't make sense any more. Based on the comment it might even be that the entire check for \""VAADIN/\"" is also redundant. " [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinServlet.java+refs-changes-28-12528-2 141 Vaadin If execution reaches there the timing issue that caused tests to _randomly_ fail with complaints about nonexistent columns has struck again. [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-25-11825-3 5443 Vaadin You probably want to use Widget.addHandler instead [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-05-3605-1 1588 Vaadin does this handle correctly attempting to move out of the available region? [not_related_to_checkstyle] client/src/com/vaadin/client/widget/grid/DefaultEditorEventHandler.java+refs-changes-74-11874-5 155 Vaadin windows? [not_related_to_checkstyle] server/src/com/vaadin/server/communication/ServerRpcHandler.java+refs-changes-04-1104-2 97 Vaadin How is it tested here that an empty details gets visible anyways? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridDetailsServerTest.java+refs-changes-13-8113-2 98 Vaadin 7.1 ?\nShould it be removed at all ? [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/util/converter/AbstractStringToNumberConverter.java+refs-changes-76-14076-3 47 Vaadin Why is Event capitalized? It would imply that there's a (relevant) class with that name. Kind of the same with Sort as well. There is indeed a Sort class but it's not directly related to this. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/sort/SortEventHandler.java+refs-changes-82-3782-17 24 Vaadin It was moved to before the enclosing if instead [not_related_to_checkstyle] client/src/com/vaadin/client/communication/RpcManager.java+refs-changes-55-1555-3 107 Vaadin It's not generated. It's updated to use logger. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/parser/LocatorImpl.java+refs-changes-53-2553-2 37 Vaadin protected is probably good enough like getFalseString() [not_related_to_checkstyle] server/src/com/vaadin/data/util/converter/StringToBooleanConverter.java+refs-changes-31-11531-2 131 Vaadin Good point. I assumed the element was just created. Will add check. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/AriaHelper.java+refs-changes-50-850-3 36 Vaadin Isn't the ordering defined by the order of the underlying columns and then all the grouped headers and footers follow that?\n\nIt would be quite strange if there would be an explicit A B ordering in one column group in one header row and then B A on another row.\n\nExplicit ordering in the column groups also implies that all column groups would need to be updated when the order at any other level is changed and that the ordering should be verified when a new column group is created. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/ColumnGroup.java+refs-changes-87-2187-13 37 Vaadin This component should be added to the content layout. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/datefield/AriaDisabled.java+refs-changes-49-2849-2 31 Vaadin Comment removed but I still think the workaround is not nice but it was the only one that crossed my mind. :) And it's funny to read those comments later. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTabsheet.java+refs-changes-05-4205-12 1422 Vaadin This was the ticket: http://dev.vaadin.com/ticket/9986\n\nIndeed there's also the case where the poor container is not an ItemSetChangeNotifier at all. So it's quite impossible to make this work automatically in *all* cases. [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-45-6845-5 2457 Vaadin Yeah after some discussion with Johannes D I also came to the conclusion that this method is better off here than as a public API in VFilterSelect. It's also more in line with how the rest of ComboBoxConnector is implemented.\n\nThe multiple getWidget() calls are not an issue IMOäó_ It could be cleaned up by extracting a variable but that's just a nice to have.\n\nThe only issue with this patch set as I see it is the failed verification by TeamCity (due to checkstyles errors). [not_related_to_checkstyle] client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java+refs-changes-48-3348-5 219 Vaadin Just making sure this is a textbox added by the test and not native to the editor row? then it's ok. If it's native then it should probably be re-classed [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/grid/basicfeatures/client/GridEditorRowClientTest.java+refs-changes-23-4723-1 111 Vaadin "this seems wrong (or at least \""happens to work\"" code). The epsilon should be used only when doing comparisons. " [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Escalator.java+refs-changes-50-7250-8 819 Vaadin What do these comments mean? [not_related_to_checkstyle] server/tests/src/com/vaadin/tests/server/component/grid/declarative/GridHeaderFooterDeclarativeTest.java+refs-changes-80-12080-8 35 Vaadin add correct @since value if using the tag [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTabsheet.java+refs-changes-27-2727-3 981 Vaadin what is variable.substring(1)? [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/tree/ListModifyNode.java+refs-changes-79-2479-2 39 Vaadin "More minor details: The style of this javadoc is not consistent with the one for removeBlurHandler and neither follows the official recommendations from http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html.\n\n* \""The description is in 3rd person declarative rather than 2nd person imperative\"" i.e. \""Adds\"" rather than \""Add\"".\n* First Sentence: \""This sentence ends at the first period\"".\n* @param: \""When writing a phrase do not capitalize and do not end with a period\"" and \""If you prefer starting with a sentence capitalize it and end it with a period\"". A sentence should however have verbs and stuff... " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VRichTextArea.java+refs-changes-98-1398-3 425 Vaadin PostLayoutListener is used here to clean up the temporary inline styles that are required to force the element to shrink. \n\nOther layouts do not use
for positioning its children and does therefore not need this kind of workaround. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/formlayout/FormLayoutConnector.java+refs-changes-34-11934-6 44 Vaadin It's confusing with different overloads of setThreadLocals with opposite functionality. I would suggest suggest these signatures instead:\npublic static void restoreThreadLocals(Map Object> old);\npublic static Map Object> setThreadLocals(UI ui);\npublic static Map Object> setThreadLocals(VaadinSession session); [not_related_to_checkstyle] server/src/com/vaadin/util/CurrentInstance.java+refs-changes-15-1015-1 183 Vaadin "Actually what it intends to test is that there was no navigation due to the backspace by comparing also buttons behind the \""curtain\"". " [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/window/BackspaceKeyWithModalOpenedTest.java+refs-changes-59-4259-13 41 Vaadin I'll have to come back to this part of the code later on... [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-56-1956-10 1168 Vaadin use JSR356WI.getAttributeName() [not_related_to_checkstyle] server/src/com/vaadin/server/communication/PushRequestHandler.java+refs-changes-27-8027-9 120 Vaadin Have tried doing that but there have been some bad problems with said mechanic. Will take another attempt at it. [not_related_to_checkstyle] server/src/com/vaadin/ui/ComboBox.java+refs-changes-21-2521-3 647 Vaadin Why is this required? Haven't we already agreed that any access to VaadinSession should already be protected by the lock? [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinSession.java+refs-changes-94-794-1 859 Vaadin This is due to change in the next task anyway because of showing the column options so I won't change it now. [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-57-7957-2 7139 Vaadin This class was supposed to be deleted.. [not_related_to_checkstyle] server/tests/src/com/vaadin/data/util/sqlcontainer/query/ConnectionDelegate.java+refs-changes-28-8828-2 37 Vaadin Will this ever happen though? Afaik we're creating literally new cell elements here so if there's something in there it sounds like someone's doing something nasty and unsupported... This should however be the very first listener being called for a cell during its entire lifetime? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-59-3659-1 791 Vaadin Should probably be ValueChangeMode [not_related_to_checkstyle] shared/src/main/java/com/vaadin/shared/tokka/ui/components/fields/TextChangeEventMode.java+refs-changes-30-13930-2 22 Vaadin "The old false meant that a repaint is required - not quite the same thing. This event sent in the case of a conversion error feels like a borderline case to me - whether it should be marked as user originated or not depends perhaps on whether another \""user originated\"" event has been fired for a change that is being rolled back or why is this event sent in the first place " [not_related_to_checkstyle] server/src/main/java/com/vaadin/ui/DateField.java+refs-changes-81-14081-8 323 Vaadin "replace id with id.getAttribute(\""id\""). id is DateFieldElement object not a textual id. " [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/datefield/DateFieldWhenChangingValueAndEnablingParentTest.java+refs-changes-91-8591-2 106 Vaadin Should maybe be a test here as well? [not_related_to_checkstyle] server/tests/src/com/vaadin/server/VaadinServletTest.java+refs-changes-30-5730-1 60 Vaadin same as for handleRenderRequest [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinPortletSession.java+refs-changes-94-794-1 196 Vaadin Actual and expected wrong way around. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/calendar/SetFirstVisibleHourOfDayTest.java+refs-changes-84-5184-4 65 Vaadin @return should come before @see [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/FlyweightRow.java+refs-changes-54-3654-2 202 Vaadin Would it make sense to send one String containing all the json instead of parsing each row separately? [not_related_to_checkstyle] client/src/com/vaadin/client/data/RpcDataSourceConnector.java+refs-changes-72-3072-1 60 Vaadin But why did it work when using org.json? Is this some kind of incompatibility between the libraries are we using it in the wrong way or is there something else going on? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/serialization/SerializerTestTest.java+refs-changes-38-4238-4 89 Vaadin This setter is a bit problematic as currently there's nothing that tells the Grid to re-render itself if the null representation changes after the initial rendering (until eg. the user scrolls.) Of course this is probably a rather uncommon use case.\n\nI think I would prefer removing the setter for now (here and in the subclasses) we can always add them if needed. [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-91-10991-7 3338 Vaadin Implemented it like that at least for now. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/GridColumn.java+refs-changes-47-3747-1 295 Vaadin This field was a bit unintuitively named. My initial thought was a rolling index keeping count of asynchronous stuff or something. But apparently it's the first index of the data we are expecting to receive next.\n\nI can't figure out a better name so maybe a simple javadoc stating this intent would suffice. [not_related_to_checkstyle] client/src/com/vaadin/client/data/AbstractRemoteDataSource.java+refs-changes-48-3148-3 45 Vaadin "Side note it's a bit less to write if you leave out \""test\"" for @Test methods " [not_related_to_checkstyle] server/src/test/java/com/vaadin/data/BinderTest.java+refs-changes-15-14015-1 44 Vaadin (strange formatting) [not_related_to_checkstyle] client/src/main/java/com/vaadin/client/widgets/Escalator.java+refs-changes-39-14139-1 1054 Vaadin These classes should probably not be directly referenced from client code. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-13-3713-4 29 Vaadin could table.getValue() be stored in temp variable since its used much [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/table/TableDeleteSelectedRow.java+refs-changes-83-4383-5 67 Vaadin There is the chance of an exception causing the flag to not be removed but such an exception would then also leave the new session in an inconsistent state so we would most likely be equally screwed even if the flag was to be removed. [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-46-1646-2 989 Vaadin Would also encapsulate the touchStartXY fields that are pretty horrible to have in ACC. However at this point IMO we should have as little API exposed as possible since there isn't really time to think it through before 7.6.\n\nI think this whole thing should probably look like the ConnectorFocusBlurHandler thingy I wrote earlier - it encapsulates all the handler registration details and other stuff. That refactor will have to wait for post-7.6 obviously. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/AbstractComponentConnector.java+refs-changes-36-12336-9 165 Vaadin This copy paste fix don't really relate to commit message but excellent changes as well! [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-68-3568-1 949 Vaadin Nice catch. Fixed by always clearing the entire map if receiving -1. [not_related_to_checkstyle] server/src/com/vaadin/ui/ConnectorTracker.java+refs-changes-35-3835-1 864 Vaadin I borrowed logic from if/else here. It worked so I kept it.\nI can try to refactor this to be simpler. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/handler/SCSSDocumentHandlerImpl.java+refs-changes-25-1825-1 264 Vaadin This will blow up if the grid has no default header row. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-19-4919-1 874 Vaadin "Another option would be to refactor so that there's no new public API that would only be intended for internal use. \n\nOne way of doing this would be to instead introduce an ErrorHandlingRunnable extends Runnable with a method taking some exception as a parameter. Next FutureAccess could be changed to have a similar method that delegates the handling to the ErrorHandlingRunnable if present otherwise it handles the error in some default way. In that way UIRunnable would not need to be public and the \""internal use only\"" FutureAccess.getRunnable() method could also be removed. " [not_related_to_checkstyle] server/src/com/vaadin/ui/UI.java+refs-changes-79-1979-5 97 Vaadin whoops. This was a wrong assumption. (facepalm) [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-42-8042-5 6263 Vaadin ah missed the ||Œæunder the comment. My mistake.\n\nI too had to look up SharedUtils.equals() (and it is not the first time I do so) since it is not very descriptive in what it does and is not related to anything with the shared state. Renaming/Moving it somewhere else (Util?) would probably be a good idea. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VCalendarPanel.java+refs-changes-97-2097-1 2218 Vaadin space could also be left unescaped [not_related_to_checkstyle] buildhelpers/src/com/vaadin/buildhelpers/FetchReleaseNotesTickets.java+refs-changes-25-5125-6 151 Vaadin getClass().getName()? [not_related_to_checkstyle] client/src/com/vaadin/client/connectors/AbstractSelectionModelConnector.java+refs-changes-56-11856-7 77 Vaadin "Change \""the column\"" to \""this column\"" whenever it refers to the same instance. Repeat at least 11 times below. " [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/GridColumn.java+refs-changes-18-2118-15 37 Vaadin Extra javadoc [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/ui/UiAccess.java+refs-changes-70-1370-2 17 Vaadin mention the false condition as well for completeness' sake [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-96-7896-2 3655 Vaadin @since without a version number. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/tabsheet/NewSelectionAfterTabRemove.java+refs-changes-73-4273-2 30 Vaadin Huh indeed. I swear it did have locking at some point... [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinSession.java+refs-changes-34-1034-2 803 Vaadin The static helper binds only form labels together so far. Would need to be extended for other bindings. Can do after holiday. [not_related_to_checkstyle] client/src/com/vaadin/client/VErrorMessage.java+refs-changes-51-851-4 36 Vaadin Done. It does look a bit clearer that way. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/parser/SassList.java+refs-changes-79-2479-2 132 Vaadin I would probably consider whether it is possible to unify the variable replacing logic of the different nodes.\n\nHowever I am already doing such work in another patch so there is no need to do it here. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/tree/RuleNode.java+refs-changes-61-2561-1 0 Vaadin There's an extra @param hiding here. [not_related_to_checkstyle] server/src/com/vaadin/server/communication/JSONSerializer.java+refs-changes-94-2394-1 56 Vaadin Will implement cache in a separate change [not_related_to_checkstyle] server/src/com/vaadin/server/communication/LegacyUidlWriter.java+refs-changes-09-1009-1 30 Vaadin "Nit: I'd like an \""assert isObject != null\"" here for the refactorings that break this isObject assumption. It's nicer to debug things on the client side when you have a descriptive exception and doubly so when you can ctrl-f for the broken place. " [not_related_to_checkstyle] client/src/com/vaadin/client/connectors/GridConnector.java+refs-changes-47-6247-3 107 Vaadin (issues here addressed in later changesets) [not_related_to_checkstyle] client/src/com/vaadin/client/communication/ReconnectingCommunicationProblemHandler.java+refs-changes-18-8618-10 66 Vaadin This file doesn't need to be in the change set [not_related_to_checkstyle] uitest/src/com/vaadin/tests/accessibility/WindowWaiAriaRolesTest.java+refs-changes-28-4228-3 35 Vaadin This class should probably be in the uitest source folder? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/TestGridConnector.java+refs-changes-07-1907-7 0 Vaadin Should probably check for IE >= 11 since we might expect IE 12 to behave in the same way. [not_related_to_checkstyle] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-97-3797-1 2493 Vaadin If this is something that only this renderer uses then I'd suggest adding the attribute on the cell element instead of the row element. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/MultiSelectionRenderer.java+refs-changes-55-3655-5 187 Vaadin Shouldn't this be the other way around? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-48-2448-9 1530 Vaadin could mention what happens if you use both this and withStatusChangeHandler or one of the methods twice [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-07-14107-2 284 Vaadin see the comments in setItemCaptionMode() and setContainerDataSource() [not_related_to_checkstyle] server/src/com/vaadin/ui/ComboBox.java+refs-changes-04-12904-4 475 Vaadin True. Marked the flag as volatile - the message might still get logged more than once but that's okay IMO. [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/validator/BeanValidator.java+refs-changes-14-14114-3 72 Vaadin There is no JSONValue on org.json so unfortunately the only reasonable type to return is Object. One thing that could be mentioned here is that the returned value should be something that is supported by e.g. org.json.JSONObject. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Renderer.java+refs-changes-47-3747-3 47 Vaadin Shouldn't the unlocking only be done if an exception is actually thrown? [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-94-1694-1 596 Vaadin Yes the API is a bit raw but it's meant mostly for special cases not for general usage. Could/should link to https://github.com/Atmosphere/atmosphere/wiki/jQuery.atmosphere.js-API with a note that this can be used to tweak Atmosphere if the user knows what they're doing.\n\nI suppose we could follow the TooltipConfiguration pattern at least for symmetry's sake. [not_related_to_checkstyle] server/src/com/vaadin/ui/UI.java+refs-changes-21-1421-1 1411 Vaadin could handle exception better [not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-74-4174-4 1193 Vaadin There is no param [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VRichTextArea.java+refs-changes-98-1398-2 386 Vaadin "Just as a FYI _currently_ Escalator only supports uniformly tall rows (and details rows aren't in the header). So this could also be done by asking escalator.getHeader().getDefaultRowHeight(). \n\nBut this is good - futureproofing without a tangiable performance hit.\n\nAlso as a tangent that escalator method name is stupid. There should be no \""default\"" there :( " [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-21-7621-2 2936 Vaadin Should probably be made aware - this is especially useful when we implement the server-side to blindly push some initial data when initialized assuming that the first n rows are most likely visible. [not_related_to_checkstyle] client/src/com/vaadin/client/data/AbstractRemoteDataSource.java+refs-changes-16-2116-3 189 Vaadin (not really dates) [not_related_to_checkstyle] server/tests/src/com/vaadin/data/util/sqlcontainer/filters/BetweenTest.java+refs-changes-80-4380-3 160 Vaadin And the doc is completely wrong too; I'll fix it [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/SortOrderChangeEvent.java+refs-changes-19-4319-5 65 Vaadin Is this @since accurate? [not_related_to_checkstyle] client/src/com/vaadin/client/componentlocator/ComponentLocator.java+refs-changes-06-1806-1 59 Vaadin "I'm probably missing the design details again but how is this a \""Renderer\"" when the class is \""ColumnGroup\""? Is it just because we only support string literals in the footer and header for now? " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/ColumnGroup.java+refs-changes-78-2378-2 47 Vaadin Weird to have this here when the other concrete implementations have their own files [not_related_to_checkstyle] client/src/com/vaadin/client/connectors/AbstractSelectionModelConnector.java+refs-changes-56-11856-5 88 Vaadin Why was this removed? [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-25-11925-3 1986 Vaadin Does not exist or exists but is not sortable. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-20-3820-7 1171 Vaadin The comment was only about the placement of the method in the file [not_related_to_checkstyle] server/src/main/java/com/vaadin/ui/AbstractTextField.java+refs-changes-54-14054-11 114 Vaadin What's the performance impact of this hack? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/ui/UIConnector.java+refs-changes-58-11358-3 1058 Vaadin Well EscalatorUpdater exposes this class as well and Escalator is intended to work stand-alone (or as a base class for a composite) I think it would be best to _at least_ mention Escalator. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/FlyweightCell.java+refs-changes-95-3595-3 28 Vaadin The name doesn't sound consistent with the rest of the public API - maybe setComponentLocalId? And then the parameters should probably be swapped [not_related_to_checkstyle] server/src/com/vaadin/ui/declarative/DesignContext.java+refs-changes-95-8295-1 182 Vaadin "This is a temporary backwards-compatibility adapter class and the \""quiet mode\"" will be renamed AND this naming comes from the interface. But sure I can do that... ;-) " [not_related_to_checkstyle] client/src/com/vaadin/client/debug/internal/ConsoleAdapter.java+refs-changes-06-1106-1 120 Vaadin "Use toUpperCase(Locale.ENGLISH) to avoid potential issues with eg. Turkish locale where \""file\"".toUpperCase().equals(\""FÛÁLE\"") " [not_related_to_checkstyle] server/src/com/vaadin/ui/declarative/converters/DesignResourceConverter.java+refs-changes-89-8589-13 60 Vaadin The documentation assumes that VaadinSession will always be stored in an HTTP session. It might well be that this always how things work in practice but we might still keep the door open for e.g. storing the session in a database instead. [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-45-12245-3 1886 Vaadin What is the reason that closeNow() doesn't set justClosed and schedule the timer to reset this? [not_related_to_checkstyle] client/src/com/vaadin/client/VTooltip.java+refs-changes-18-3718-5 474 Vaadin This should probably not refer to MixinNode but some suitable superclass. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/tree/FunctionDefNode.java+refs-changes-88-1888-2 56 Vaadin Should maybe still also do removeAllComponents() here in case there is some thrid party code using ViewDisplay that isn't aware of ClearableViewDisplay. This would just be a no-op in the case that clearView() has already been invoked. [not_related_to_checkstyle] server/src/com/vaadin/navigator/Navigator.java+refs-changes-26-5026-1 191 Vaadin Maybe write a description here as well? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/page/PageTitle.java+refs-changes-90-2790-3 55 Vaadin also remove unnecessary space before end parentheses [not_related_to_checkstyle] server/src/com/vaadin/ui/Table.java+refs-changes-51-5451-1 1032 Vaadin Should integrate into com.vaadin.tests.server.navigator.NavigatorTest instead. [not_related_to_checkstyle] server/tests/src/com/vaadin/navigator/NavigatorTest.java+refs-changes-39-7939-1 28 Vaadin At least for now I've not seen a reason to make any modifications to this code. [not_related_to_checkstyle] client/src/com/vaadin/client/widget/escalator/ScrollbarBundle.java+refs-changes-97-12797-2 422 Vaadin Don't declare @since and @author for inner classes when the value is the same as the enclosing class. Repeat below. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/widgetset/client/grid/GridBasicClientFeatures.java+refs-changes-04-4004-2 62 Vaadin "no comma needed. \n\nSince true/false doesn't really work well in this case (one is not the natural opposite of the other) you need to specify the false case as well.\n\nHow about skipping the true/false problem altogether and use an enum instead? like Origin.API and Origin.UI or similar? Then the method would probably be renamed to \""getEventOrigin\"" or something more suitable " [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/SortOrderChangeEvent.java+refs-changes-19-4319-3 67 Vaadin @since 7.1 [not_related_to_checkstyle] client/src/com/vaadin/client/ui/calendar/VCalendarAction.java+refs-changes-18-818-4 29 Vaadin Can't we just do a selectedRowKeys.clear(); selectedRowKeys.addAll(selectedKeys)? (or just selectedRowKeys=selectedKeys if both were either Set or HashSet)\n\nIf I read Table.java correctly it always sends the union of all selected keys and visible rows so all visible rows that should be selected are in this set. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VScrollTable.java+refs-changes-75-2475-1 1114 Vaadin should this javadoc still be updated? it has some remnants of the old approach [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/validator/NullValidator.java+refs-changes-64-14064-5 24 Vaadin TODO review the replacements of the removed code [not_related_to_checkstyle] client/src/com/vaadin/client/communication/ServerCommunicationHandler.java+refs-changes-15-8615-8 181 Vaadin #NAME? [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-54-7754-1 6389 Vaadin Can we say that min-width and max-width through CSS are not supported for columns? [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-50-7250-8 2700 Vaadin Yes I meant to provide one but submitted too hastily. Will do. [not_related_to_checkstyle] server/src/com/vaadin/ui/UI.java+refs-changes-85-2885-2 662 Vaadin It is internal API and adding it to the interface would make it public. I'd rather not. [not_related_to_checkstyle] shared/src/com/vaadin/shared/ui/grid/GridColumn.java+refs-changes-94-2094-1 28 Vaadin (old profiler string) [not_related_to_checkstyle] client/src/com/vaadin/client/communication/ServerMessageHandler.java+refs-changes-08-8608-7 811 Vaadin "In my opinion merging the previous test with this one would make one test case that is more meaningful than the two separate tests. If there is overflow:hidden there are certainly no scroll bars and this method should pass. Otherwise there are no scroll bars if the content fits in the scrollable container which is checked below.\n\nWhen written as two tests the first test would reject any implementation that does not use the \""overflow: hidden\"" method even if no scrollbars appear. I am not 100 % sure about this second test either: could say rounding errors in VScrollTable.lazyAdjustColumnWidths() after checking whether to hide the scroll bars lead to slightly too wide contents? By combining these two tests one might only check the widths if the scroll bars are not hidden. " [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/table/UnnecessaryScrollbarWhenZoomingTest.java+refs-changes-25-6825-2 43 Vaadin "Both actually :p It's called \""request\"" in Atmosphere but I suppose we should call it \""config\"" consistently as we don't actually expose the part of the API that looks like a request. " [not_related_to_checkstyle] client/src/com/vaadin/client/communication/PushConnection.java+refs-changes-34-1034-5 108 Vaadin end with a dot [not_related_to_checkstyle] client/src/main/java/com/vaadin/client/widget/escalator/events/RowHeightChangedHandler.java+refs-changes-46-14046-2 21 Vaadin "You're absolutely correct in identifying the three distinct yet intertwined indices. *pat on the head*. I'll find a place to document the distinctions somewhere since it indeed is a very important and core feature (if you will) of Escalator and of utter importance to understand for future Escalator maintainers.\n\nOn your last observation let me clarify the structure of the RowContainers as they currently stand that's far from obvious reading this diff'ed code.\n\n AbstractRowContainer\n |-- AbstractStaticRowContainer\n | |-- HeaderRowContainer\n | `-- FooterContainer\n `-- BodyRowContainer\n\nAbstractRowContainer is intended to contain all common logic between RowContainers. It manages the bookkeeping of row amounts makes sure that all individual cells are rendered the same way and so on.\n\nAbstractStaticRowContainer has some special logic that is required by all RowContainers that don't scroll (hence the word \""static\""). HeaderRowContainer and FooterRowContainer are pretty thin special cases of a StaticRowContainer (mostly relating to positioning of the root element).\n\n(The comment above should probably be added as a JavaDoc - I'll get right on that.)\n\nBodyRowContainer could also be split into an additional \""AbstractScrollingRowContainer\"" but I felt that no more inner classes were needed. So it contains both logic required for making things scroll about and equivalent special cases for layouting as are found in Header/FooterRowContainers.\n\nThat being said you are also correct in noticing that this method appears to use the visual index as a physical index. In the case of an AbstractStaticRowContainer they are always the same number by design. BodyRowContainer overrides the behavior as is needed and there it will behave as an actual visual index. \n\nIt could be argued whether some of the code that relies on visualindex == physicalindex in this snippet should be moved up to the AbstractStaticRowContainer. I already did one such refactoring but it was pretty ad-hoc and wouldn't be surprised if a lot of code is still misplaced. I'll make a mental note about this look into this at a later point. " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-56-1956-5 550 Vaadin Is there any point in mentioning a list of attributes that can be changed when that list is inevitably never completely up to date (right now width is mentioned but not supported). [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/GridColumn.java+refs-changes-18-2118-15 23 Vaadin Need to figure out adding and removing [not_related_to_checkstyle] server/src/main/java/com/vaadin/server/communication/data/typed/DataProvider.java+refs-changes-54-13754-2 378 Vaadin IMO this should not be here. This is datasource related logic and grid has no means to verify anything on data integrity. it can only count on user Doing The Right Thing. I'm pretty sure we should enforce use of RowHandles or similar to prevent data changes from breaking stuff. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-74-5174-2 1544 Vaadin why does it eliminate caching? it is a regular get parameter which does not affect caching if it stays the same.\nI have this patched in Production already here it looks like this:\nhttps://public.centerdevice.de/7cbbc5d8-880d-4907-bbdd-727a2d6a5815\n\n(the app hosting the screenshot is also vaadin 7.2.5 with this patch so you can see live that multiple loads of the page will not re-load these files) [not_related_to_checkstyle] server/src/com/vaadin/server/BootstrapHandler.java+refs-changes-60-4060-2 403 Vaadin This will be triggered if i first press on a header and then touch with another finger as well. You need a check for how many touches there currently are. (this pattern repeats itself everywhere. Makes me think if it could be wrapped into some utility. but that's not something for this patch ;) )\n\nSame goes with touchend/touchcancel [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-38-3838-3 430 Vaadin Might be a good idea to specify that browsers.* are system properties [not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/TB3Runner.java+refs-changes-34-2934-2 139 Vaadin Numbers were listed as a special case with 0 as the default. [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-85-5985-4 2279 Vaadin should use null instead of defaultSize so that the null check on the next line always triggers if there is nothing in the element. [not_related_to_checkstyle] client/src/com/vaadin/client/LayoutManagerIE8.java+refs-changes-06-12606-4 71 Vaadin Maybe also the inside of the outer loop here could be refactored to a common implementation taking as parameters e.g. the variable name the LexicalUnitImpl used as its value the node to replace and possibly the list of child nodes to iterate over. That way the decision could be made later in one location only. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/visitor/ForNodeHandler.java+refs-changes-25-1825-1 78 Vaadin wrong logger category? [not_related_to_checkstyle] client/src/com/vaadin/client/communication/XhrConnection.java+refs-changes-15-8615-9 102 Vaadin This looks partly like MultiBrowserThemeTest in https://dev.vaadin.com/review/#/c/8835/ so they should be merged into one [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/uitest/ThemeTest.java+refs-changes-30-8730-5 20 Vaadin will address this in the next patch set. [not_related_to_checkstyle] uitest/src/main/java/com/vaadin/tests/components/textarea/TextAreaTest.java+refs-changes-68-14068-10 8 Vaadin Is there a good reason not to provide getters for these? Of course you can get the new selection via getSource() but it's a bit roundabout way plus it's not a snapshot of the state when the event was fired. OTOH it wouldn't help the single select case where you'd have to do \n\n event.getNewSelection().iterator().next() \n\nto get the selected item unless more API is added to the event... [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/selection/SelectionChangeEvent.java+refs-changes-54-3554-5 36 Vaadin Make this clearer or is the deprecation warning enough? [not_related_to_checkstyle] server/src/com/vaadin/data/util/AbstractProperty.java+refs-changes-71-1171-3 76 Vaadin Method no longer exists repeat below [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/ScrollbarBundle.java+refs-changes-56-2756-4 123 Vaadin End with period. Repeat for all the methods below. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-07-1907-7 617 Vaadin Seems like this would belong in TreeConnector? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTree.java+refs-changes-51-1751-3 1852 Vaadin Debug output remove this [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-95-12195-1 5552 Vaadin If I have eg.\n\n x x\n x _\n\nwhere x are components and _ is a free cell I'd expect the cursor to be in _ that is the first free place after all the components [not_related_to_checkstyle] server/src/com/vaadin/ui/GridLayout.java+refs-changes-39-8239-1 1300 Vaadin It would be nice to have at least some class level javadoc about what this node is doing - although other nodes probably don't have any either. [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/tree/ContentNode.java+refs-changes-48-848-4 18 Vaadin it seems you're right. Done. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-74-2274-2 459 Vaadin What is this doing here? [not_related_to_checkstyle] server/src/com/vaadin/server/Constants.java+refs-changes-70-1170-2 68 Vaadin this could have correct content (one line description @since 7.2) [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/parser/function/AbsFunctionSerializer.java+refs-changes-50-2550-2 20 Vaadin Seems like an unintentional change [not_related_to_checkstyle] client/src/com/vaadin/client/ApplicationConnection.java+refs-changes-84-1284-6 0 Vaadin This is not supported [not_related_to_checkstyle] server/tests/src/com/vaadin/tests/server/component/abstractselect/TestReadDesign.java+refs-changes-76-6576-3 117 Vaadin Like in the date field change should be handled elsewhere [not_related_to_checkstyle] server/src/com/vaadin/ui/AbstractSelect.java+refs-changes-76-6576-2 2238 Vaadin The magic string could be defined as a constant somewhere [not_related_to_checkstyle] client/src/com/vaadin/client/ui/calendar/CalendarConnector.java+refs-changes-18-1418-1 376 Vaadin "\""...when the available data in the DataSource changes.\"" " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-24-4324-2 2397 Vaadin Could do remove and check its return value to save a lookup [not_related_to_checkstyle] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-42-12242-1 144 Vaadin nit: how can an object be inside a method? [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-54-3554-7 1126 Vaadin Use Grid.eventCell CellReference instead of index. [not_related_to_checkstyle] client/src/com/vaadin/client/widget/grid/events/EditorCloseEvent.java+refs-changes-42-8842-3 27 Vaadin Shouldn't this use GridColum instead? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-18-2118-6 258 Vaadin This is not semantically correct but I guess there is no other suitable unchecked exception to avoid introducing API changes. Might however make sense to change this method to throw SessionExpiredException in Vaadin 7.2? [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-94-1694-1 568 Vaadin Do you have a suggestion how to fix this? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VOptionGroup.java+refs-changes-03-903-2 280 Vaadin haha OK how do I get this online? I asked the question in the meeting but didn't concluded. [not_related_to_checkstyle] server/src/com/vaadin/ui/AbstractTextField.java+refs-changes-16-3916-1 152 Vaadin You should consider using TB4 ComboBoxElement [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/combobox/ComboBoxScrollingWithArrowsTest.java+refs-changes-48-3348-2 45 Vaadin (ideally avoid randomness in test - could produce inconsistent results as seed is not set) [not_related_to_checkstyle] server/tests/src/com/vaadin/data/util/sqlcontainer/ReadOnlyRowIdTest.java+refs-changes-91-4891-2 52 Vaadin why not static anymore? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTabsheet.java+refs-changes-27-2727-3 309 Vaadin indeed. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/ColumnGroup.java+refs-changes-87-2187-5 138 Vaadin Could assert ensurePushAvailable() or throw [not_related_to_checkstyle] server/src/com/vaadin/ui/UI.java+refs-changes-21-1121-1 1251 Vaadin Slider? [not_related_to_checkstyle] server/tests/src/com/vaadin/tests/server/component/window/WindowDeclarativeTest.java+refs-changes-27-8227-5 33 Vaadin For CellReference getRow() returns List and getColumn() returns GridColumn>. This will not work. it used to compare that the two indices match but as of now it will never break. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/widgetset/client/grid/GridBasicClientFeaturesWidget.java+refs-changes-17-6317-2 708 Vaadin Shouldn't this actually do getPage().init(request)? I would rather leave out the fragment change event completely (like init()) does because I can't figure out the case when you would get a reinit at the same time as a fragment change. [not_related_to_checkstyle] server/src/com/vaadin/ui/UI.java+refs-changes-85-2885-1 656 Vaadin Can't see how getLastPathParameter can ever return null - if there is a path parameter in the last path segment then that parameter is returned otherwise it returns an empty string. [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinServlet.java+refs-changes-00-2000-3 267 Vaadin Still broken for PhantomJS. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/fieldgroup/BasicCrudGridEditorRowTest.java+refs-changes-92-7092-5 72 Vaadin "Start with \""Sets\"". Add @param.\n\nRepeat below. " [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-18-2118-12 105 Vaadin PropertyType instead of V? [not_related_to_checkstyle] server/src/main/java/com/vaadin/tokka/data/Binder.java+refs-changes-30-13830-7 80 Vaadin "\""to make room to make room\"" - phrase \""to make room\"" three times in the sentence " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/orderedlayout/VAbstractOrderedLayout.java+refs-changes-74-574-1 433 Vaadin Missed that fixing it now. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Renderer.java+refs-changes-59-3559-2 67 Vaadin Remove link to class outside the client module [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VCalendar.java+refs-changes-18-818-4 44 Vaadin Is this constructor needed? Side effects may make it hard to understand what this does in code using this constructor.\n\nTo be discussed in API review. [not_related_to_checkstyle] server/src/com/vaadin/server/Responsive.java+refs-changes-63-2863-1 119 Vaadin The click RPC transmits column index and mapping that to property id might be nontrivial --- the RPC should probably send column id instead. Anyway just added a TODO for now. [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/renderers/ClickableRenderer.java+refs-changes-65-5565-2 64 Vaadin Remove this and handle in the first if [not_related_to_checkstyle] server/src/com/vaadin/ui/GridLayout.java+refs-changes-39-8239-5 1407 Vaadin True it doesn't make sense to mention this in a public API as it should never return null when called from client code only in internal Escalator code when the element is not yet created and assigned. What has actually changed from the client perspective is that the returned element may now have hasParent()==false (in EU.preAttach/postDetach) [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/FlyweightCell.java+refs-changes-54-3654-2 77 Vaadin typo: minumum [not_related_to_checkstyle] client/src/com/vaadin/client/event/PointerEvent.java+refs-changes-16-3116-4 75 Vaadin "here the word \""normalize\"" isn't very descriptive - this is rather concatenating/appending/combining paths (ignoring the filename segment) " [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/resolver/AbstractResolver.java+refs-changes-95-1795-1 108 Vaadin why no @Ignore on this but on the other ones\n\nalso see the comment on LegacyDateFieldElement [not_related_to_checkstyle] uitest/src/test/java/com/vaadin/testbench/legacy/elements/LegacyInlineDateFieldElement.java+refs-changes-66-14066-10 26 Vaadin "Still not quite sure about this. If \""newSize\"" is the size of the data set (eg. one billion zillion items) surely we don't want to insert that many escalator rows (as there should be only so many as fits into the view)? But OTOH BodyRowContainer.insertRows seems like it is concerned with logical rows but still it calls paintInsertRows with the same arguments which would insert those billion zillion physical tr elements into the table right? And I don't know what getRowCount is actually supposed to return. I'm very confused right now. " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-03-5103-5 1857 Vaadin seems redundant [not_related_to_checkstyle] server/src/com/vaadin/util/ConnectorHelper.java+refs-changes-48-8748-3 55 Vaadin "Why is the API for \""input prompt\"" changed? " [not_related_to_checkstyle] server/src/main/java/com/vaadin/ui/AbstractTextField.java+refs-changes-54-14054-7 96 Vaadin Right but this comment should be in the code :) That way people looking at the code in the future will know what has changed and why and won't be tempted to undo the changes unnecessarily. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VSlider.java+refs-changes-53-3553-7 198 Vaadin * @param getter\n * the function to get the value of the property to the\n * field not null\n * @param setter\n * the function to save the field value to the property or\n * null if read-only\n\nused above should use the same [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-15-14015-1 224 Vaadin why is this part of code commented out? is it needed for something or could it be removed? [not_related_to_checkstyle] client-compiler/tests/src/com/vaadin/tools/BundleGeneratorConsistencyTest.java+refs-changes-20-5020-7 58 Vaadin setEditorUnbuffered for consistency [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-94-10994-1 6030 Vaadin Should this be getElement() or checkBoxElement? If it should actually be getElement() then why is this done once for each option? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VOptionGroup.java+refs-changes-03-903-8 133 Vaadin Yes it is tested on IE. \n\nNo reversing (pos) and (pos+length) does not work on Firefox. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VFilterSelect.java+refs-changes-94-3194-6 967 Vaadin could the default date be saved in a variable instead of calculated many times? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/themes/valo/DateFields.java+refs-changes-63-4863-2 196 Vaadin Remove FIXME fix in this patch or create an issue [not_related_to_checkstyle] server/src/main/java/com/vaadin/ui/AbstractField.java+refs-changes-11-14011-2 118 Vaadin This could be a non-javadoc comment or the javadoc could start with a paragraph on what the method does [not_related_to_checkstyle] theme-compiler/src/com/vaadin/sass/internal/tree/FunctionDefNode.java+refs-changes-88-1888-2 41 Vaadin "add \""Index\"" suffix to make it uniform with the two other local variables as well. " [not_related_to_checkstyle] client/src/com/vaadin/client/widgets/Grid.java+refs-changes-96-7496-3 2988 Vaadin Why is this changed from array to object? [not_related_to_checkstyle] server/src/com/vaadin/server/JsonCodec.java+refs-changes-38-4238-4 796 Vaadin Bikeshed [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/GridStaticSection.java+refs-changes-16-4016-1 32 Vaadin Add a descriptive failure message [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/ui/TooltipConfigurationTest.java+refs-changes-20-3320-1 53 Vaadin "\""a list...\"" " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/renderers/ComplexRenderer.java+refs-changes-96-4396-5 75 Vaadin Some optimization could be made where if the cache grows absurdly large by time and time again requesting adjacent data. The oldest/furthest-away data could be purged once some limit (~megabyte?) is hit. [not_related_to_checkstyle] client/src/com/vaadin/client/data/AbstractRemoteDataSource.java+refs-changes-16-2116-3 113 Vaadin it this place currentNavigationState contains previous navigation state value. (which had place before BACK button was clicked)\n\nfor example we have:\n1) mainview -> 2) prompted -> BACK -> in this place we revert (CANCEL navigation) state to prompted (== currentNavigationState) from mainview (which has place after BACK button was clicked) [not_related_to_checkstyle] server/src/com/vaadin/navigator/Navigator.java+refs-changes-34-6234-1 557 Vaadin where is this set? [not_related_to_checkstyle] uitest/src/com/vaadin/tests/integration/AbstractServletIntegrationTest.java+refs-changes-86-11986-2 73 Vaadin True. Don't do that the current solution is better even though we know too much about details of AbstractOrderedLayoutConnector. [not_related_to_checkstyle] client/src/com/vaadin/client/LayoutManager.java+refs-changes-11-3411-4 841 Vaadin Remove [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/Grid.java+refs-changes-85-4885-1 413 Vaadin Commit fail [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinServletService.java+refs-changes-04-1104-2 296 Vaadin "\""set\"" in method name would imply that old value overwritten but this method adds something instead " [not_related_to_checkstyle] client/src/com/vaadin/client/metadata/TypeDataStore.java+refs-changes-61-2261-1 321 Vaadin I think it's debatable. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-32-4332-1 2061 Vaadin "if (top != 0) i think that the height of the element will still be \""\"" as set on line 147. should there be an else{ setHeight(offsetHeight) }-clause ? " [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VContextMenu.java+refs-changes-23-5223-3 167 Vaadin Implement this properly [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/selection/MultiSelectionRenderer.java+refs-changes-13-3713-4 282 Vaadin this is no longer true - now the counter is incremented when finished with writing a response [not_related_to_checkstyle] server/src/com/vaadin/ui/ConnectorTracker.java+refs-changes-36-11336-1 594 Vaadin quietDebugMode -> quietMode [not_related_to_checkstyle] client/src/com/vaadin/client/debug/internal/ConsoleAdapter.java+refs-changes-06-1106-1 120 Vaadin What rebuild is this referring to? Is the DOM somehow rebuilt from for certain operations or is there some other rebuilding going on? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTree.java+refs-changes-83-983-6 1564 Vaadin Why here? Add support to GridBasicFeatures and add test [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/grid/GridColspans.java+refs-changes-90-12190-2 0 Vaadin Indeed. Just as we don't allow ListIterators we should not allow iterator.remove() either. Thankfully iterator.remove() is an optional method in the Iterator interface so we can just throw an UnsupportedOperationException if iterator.remove() is called.\n\nWrapping the iterator and returning an iterator that does not support iterator.remove() [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/datasources/ListDataSource.java+refs-changes-98-2398-4 77 Vaadin Better to use some other waiting method. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/menubar/MenuBarsWithNestingTest.java+refs-changes-28-5428-1 71 Vaadin Suggestion for what I should add? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/AriaHelper.java+refs-changes-50-850-3 12 Vaadin Good idea but there is a problem as tbody .getAbsoluteTop() returns a huge negative number depending on how far you've scrolled.\n\nthead and tfoot seem to work as you'd expect and could be used in a more direct way. [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Grid.java+refs-changes-19-4019-6 343 Vaadin Is it legal to move to index 10 if there are 10 rows? [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-56-1956-14 1100 Vaadin nit: ending period [not_related_to_checkstyle] server/src/com/vaadin/ui/Grid.java+refs-changes-64-7664-2 6287 Vaadin Empty comment could be removed. [not_related_to_checkstyle] server/tests/src/com/vaadin/tests/design/DeclarativeTestBaseBase.java+refs-changes-80-12080-8 46 Vaadin should this be ordered (List)? [not_related_to_checkstyle] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-07-11407-3 962 Vaadin Add error message. [not_related_to_checkstyle] uitest/src/com/vaadin/tests/components/table/UpdateTableWhenUnfocusedTest.java+refs-changes-32-5232-1 48 Vaadin That's just plain wrong. Please add a suitable entry (preferably for the same version that the sass compiler uses) to server/ivy.xml instead then. [not_related_to_checkstyle] server/src/com/vaadin/data/RpcDataProviderExtension.java+refs-changes-13-3713-15 29 Vaadin handler [not_related_to_checkstyle] server/src/main/java/com/vaadin/data/Binder.java+refs-changes-07-14107-5 394 Vaadin Not related to this ticket [not_related_to_checkstyle] server/src/com/vaadin/server/AbstractClientConnector.java+refs-changes-52-352-1 987 Vaadin "Add assert to verify that it is not \""called more than once when the lock is initialized for the session.\"" " [not_related_to_checkstyle] server/src/com/vaadin/server/VaadinService.java+refs-changes-16-1016-2 409 Vaadin the readonly property has already been set above in another way. You probably need to merge the two [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/EditorRow.java+refs-changes-70-4670-3 337 Vaadin

[not_related_to_checkstyle] uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java+refs-changes-21-12021-1 909 Vaadin Could we instead simplify things by documenting that subgroups are resolved when creating a group and that subsequent changes to the source group does not affect the new group? [not_related_to_checkstyle] server/src/com/vaadin/ui/components/grid/ColumnGroup.java+refs-changes-87-2187-5 63 Vaadin Code not using Vaadin's code conventions. [not_related_to_checkstyle] server/src/com/vaadin/ui/DateField.java+refs-changes-08-1008-3 386 Vaadin Move this to after row 1303 to be cleaner and to take modifier keys into account [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VTabsheet.java+refs-changes-30-4230-10 1286 Vaadin Yep this is not a constant so it should not be changed [not_related_to_checkstyle] client/src/com/vaadin/client/ui/VNotification.java+refs-changes-06-3006-2 70 Vaadin ...and NOW you tell me D:\n\ni.e. no I did not :) [not_related_to_checkstyle] client/src/com/vaadin/client/ui/grid/Escalator.java+refs-changes-07-2207-4 435 Eclipse_CDT I don't see a test case for UNCPathConverter at all. Are you asking me to create a new test case? I think someone will need to stub out a test before I can add it. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/UNCPathConverter.java+refs-changes-77-34077-1 68 Eclipse_CDT Won't be any existing configurations to scrap so you can remove comments such as the above. [not_related_to_checkstyle] build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/wizards/AutotoolsProjectImportWizardPage.java+refs-changes-55-43155-1 151 Eclipse_CDT Why not use String.trim()? [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/macho/AR.java+refs-changes-81-37781-3 75 Eclipse_CDT "I changed the code to call IGDBControl.terminate() when there is no IProcessDMContexts and it works for the case you described but not sure if this is enough in general. If an extension of GdbLaunch has \""ITerminate\"" elements that are not controlled by GDB they need to be terminated separately by calling ITerminate.terminate(). Extra processes for instance. Unfortunately we can't differentiate between the processes that are controlled by the IProcesses service or GDB and others. At the moment I have no idea how to handle this. What do you think? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/DsfTerminateCommand.java+refs-changes-18-26318-7 209 Eclipse_CDT Should the default value be different for each of the three above? I realize it does not matter but it makes it look like a typo... [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/src/org/eclipse/cdt/dsf/gdb/tests/PersistentSettingsManagerTest.java+refs-changes-01-44001-2 93 Eclipse_CDT When this class uses the IModules service it can probably be moved to DSF directly. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/DsfLoadSymbolsCommandHandler.java+refs-changes-16-39716-2 25 Eclipse_CDT Should this job be hidden from the user to avoid too much flicker in the Progress view? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/InternalFileContentProvider.java+refs-changes-82-9982-2 80 Eclipse_CDT OK you persuaded me. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/CContentAssistInvocationContext.java+refs-changes-84-30584-2 51 Eclipse_CDT Please convert end-line characters to unix format [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/launch/CApplicationLaunchShortcutPMD.java+refs-changes-53-17853-2 1 Eclipse_CDT For GDB Harware we don't need to worry about the 'restart' case? [not_related_to_checkstyle] jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java+refs-changes-75-28575-2 715 Eclipse_CDT The logic expression it too complecated can you split it?\nIs this the same as\nif (isDeaulted) return null;\nif (isMoveConstructor) return null;\nif (isCopyConstructor) return null;\nif (isUnion) return null;\nreturn contructor;\n? [not_related_to_checkstyle] codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java+refs-changes-59-9059-3 260 Eclipse_CDT I didn't do this manually. Java did when it complained about the ones below and I hit a quick fix. I have removed it and it doesn't complain. So done. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfConstants.java+refs-changes-31-17431-4 16 Eclipse_CDT I'd use a more verbose name isCallableWithNumberOfArguments and rename the second parameter to numArguments [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/ClassTypeHelper.java+refs-changes-59-9059-2 952 Eclipse_CDT InterruptedException is likely an indication that the activity was canceled. It should not be rethrown or logged. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/export/GeneratePDOM.java+refs-changes-22-9522-1 144 Eclipse_CDT Please remove it is no longer needed. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/GdbPlugin.java+refs-changes-72-5972-3 63 Eclipse_CDT This is used in GDBRunControl but not in GDBRunControl_NS. I think we should be consistent whichever way you prefer. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/service/control/StepIntoSelectionUtils.java+refs-changes-05-11305-5 80 Eclipse_CDT This one should be before the debugger tab above if you want to keep the same order as the other launch config types [not_related_to_checkstyle] launch/org.eclipse.cdt.docker.launcher/src/org/eclipse/cdt/docker/launcher/ContainerLaunchConfigurationTabGroup.java+refs-changes-71-46471-3 40 Eclipse_CDT I don't think this restriction is necessary. It narrows the applicability of this class down to a subset of its capabilities. Consider the following:\n- We have two independent interfaces I1 and I2.\n- We have a class C that implements both interfaces I1 and I2\n- W have an array of I1 objects A.\n- An instance of C could be an element of A.\n\nWe could not create an InstanceOfPredicate for filtering I2 (new InstanceOfPredicate(I2.class) which might be a desired filter. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/util/InstanceOfPredicate.java+refs-changes-55-22555-7 20 Eclipse_CDT Unspecified visibility is not needed. Default visibility is private for classes and public for structs. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/cpp/ICPPClassType.java+refs-changes-01-11901-1 37 Eclipse_CDT "What are the consequences of \""groupId\"" \""addr\"" or \""length\"" being null? Wouldn't it be better to log an error in this case? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBMemory_7_6.java+refs-changes-62-9662-1 131 Eclipse_CDT It makes sense to put general purpose refactoring helper methods like this one in a place where they can be used by other refactorings. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpHelper.java+refs-changes-77-22177-3 304 Eclipse_CDT I think bytes.length should be changed like it was in GdbMemoryBlock [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlock.java+refs-changes-18-22118-1 666 Eclipse_CDT An EnumSet would be more appropriate here. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/NodeWriter.java+refs-changes-55-22555-2 44 Eclipse_CDT This object is not a linkage. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/db/PDOMExternalReferencesList.java+refs-changes-72-20972-1 123 Eclipse_CDT Please update the copyright header to put your name and company name in the same way as is done already. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBBackend.java+refs-changes-01-8401-1 555 Eclipse_CDT the method is SemanticUtil.getNestedType(..).\nI thought it means someone trying to get to the underlying type can call this method.\nIf type is a typedef or a plain alias then the method does exactly that so far. What I added isn't it just the same functionality for an alias that happens to contain template parameters?\nI'm asking because the solution for your comment in CPPASTBaseSpecifier would look slightly different.\n\nThe other thing what is an unconditional expansion? Doesn't 'while(...)' boil \ndown to a condition? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/SemanticUtil.java+refs-changes-79-38379-2 272 Eclipse_CDT Accessibility -> Visibility.\n\nSame below. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPMemberBlock.java+refs-changes-01-11901-2 148 Eclipse_CDT If I'm reading the implementation of getSpecializationContext() correctly in addition to walking up from an enumeration specialization to a class specialization it also walks further up the chain of class specializations. Do you know what the purpose of that is? Do we want that to happen here? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.java+refs-changes-94-39994-1 1375 Eclipse_CDT I know. This is due to the result of CPPVariableReadWriteFlags.isReadOnly which seems to make a very defensive assumption of whether there is a write access. [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/refactoring/inlinetemp/InlineTempTest.java+refs-changes-77-22177-3 690 Eclipse_CDT "What is the point of this test exactly? The original comment says \""[we] will verify that we can find the file LaunchConfigurationAndRestartTestApp.cpp\"" but we cd in the bin directory. " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/LaunchConfigurationAndRestartTest.java+refs-changes-68-38068-5 146 Eclipse_CDT All instances of fBinding in this code fragment should be replaced with binding. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalBinding.java+refs-changes-57-9057-3 355 Eclipse_CDT could be left-over breakpoints in the workspace like it happened in the GDBConsoleBreakpointsTest [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_4/TraceFileTest_7_4.java+refs-changes-06-9006-5 161 Eclipse_CDT A minor point: I'd put pos first since it's a more defining property \nwhereas connected is a state flag. Also can you even have an IO block where you're not setting the position? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/model/EpiphanyModelIO.java+refs-changes-33-25133-6 42 Eclipse_CDT Done - good catch [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/src/org/eclipse/cdt/dsf/gdb/tests/PersistentSettingsManagerTest.java+refs-changes-01-44001-2 80 Eclipse_CDT The include is not needed since everything is in the same file. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/pdom/tests/Bug426648_MultipleClassSpecializations.java+refs-changes-99-21299-1 61 Eclipse_CDT Please add a comment explaining this condition. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTQualifiedName.java+refs-changes-30-38730-4 406 Eclipse_CDT Now that 'currentTraceFrame' and 'tracepointIndexForCurrentTraceRecord' are part of ITraceStatusDMData2 we no longer need TraceStatusData so I removed it. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepoints/TraceControlModel.java+refs-changes-97-7997-5 79 Eclipse_CDT "Why not use null instead of \""\""? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBTraceControl_7_2.java+refs-changes-97-7997-3 264 Eclipse_CDT Since these lines are the same between both methods you added I suggest factoring them out into a separate method called by both of them. [not_related_to_checkstyle] memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/AbstractPane.java+refs-changes-49-11349-1 475 Eclipse_CDT Should we set fStackDepthCache here too? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIStack.java+refs-changes-75-40075-2 976 Eclipse_CDT Too bad Jenkins didn't pick up the error. I wonder if it should? [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/commands/ReverseToggleCommandHandler.java+refs-changes-44-56344-2 30 Eclipse_CDT Add a space before ( [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/RebuildIndexAction.java+refs-changes-34-34434-1 21 Eclipse_CDT Please add a copyright comment. [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/search/SearchReferencesAcrossLanguagesTest.java+refs-changes-01-50301-6 1 Eclipse_CDT "Did you mean #include \""test\\\\r_icu_init.h\"" ? " [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/HeaderFileReferenceAdjuster.java+refs-changes-60-44360-1 122 Eclipse_CDT See comments in DsfExectuable [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/ImmediateExecutor.java+refs-changes-68-6768-1 37 Eclipse_CDT Please update copyright header [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/GdbPlugin.java+refs-changes-72-5972-3 32 Eclipse_CDT Done.\nAnd added a comment about command enablement. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBTraceControl_7_2.java+refs-changes-76-19876-1 760 Eclipse_CDT Sizes may not be known if CDT is used with a compiler other than GCC. In situations like this we know for fact that some of the conversions are narrowing for example char32_t to char16_t. Some other conversions are narrowing in most environments for example int to char. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ArithmeticConversion.java+refs-changes-58-9058-3 394 Eclipse_CDT Yes thread ids start at 1. They are the same ids are what GDB returns. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/GDBProcessesTest.java+refs-changes-70-36870-20 171 Eclipse_CDT Fair enough. Our subclass of MIExpression is yucky anyway for other reasons. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIExpressions.java+refs-changes-64-17464-2 825 Eclipse_CDT "shall it say \""from an earlier line ...\"" " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/StepIntoSelectionTest.java+refs-changes-40-13840-2 300 Eclipse_CDT Throw an exception if member is not a member. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/cpp/ICPPClassType.java+refs-changes-01-11901-1 139 Eclipse_CDT Are these two new methods used elsewhere than in MIMemoryTest? They are just one-liners effectively so why not put the call to the service directly in the test?\n\nI'm asking because 'SyncUtil' is meant to hold asynchronous calls and make them synchronous. The two below calls are synchronous already... [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java+refs-changes-50-42150-3 906 Eclipse_CDT You're right let's keep the API the same for Luna since the release is close. We can revisit later if needed. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlock.java+refs-changes-94-24994-4 61 Eclipse_CDT Copy/paste laziness. I'll phrase it as an if statement for more concise code. [not_related_to_checkstyle] launch/org.eclipse.cdt.launchbar.ui/src/org/eclipse/cdt/launchbar/ui/internal/controls/TargetSelector.java+refs-changes-19-31319-2 241 Eclipse_CDT If you keep this code no need to check for the second null the equals() will do that. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlock.java+refs-changes-94-24994-4 273 Eclipse_CDT This new ID is never actually used in the patch so I'm having trouble understanding how it is meant to be used. So I'm thinking that maybe the above extraction is overly complicated.\n\nWhy not keep the full String with the prefix? If we need a unique ID it does not have to be an integer so as long as it is unique it should be fine. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizer.java+refs-changes-36-42636-2 284 Eclipse_CDT Replace fExecutor (which does not exist) with getExecutor() [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS_7_10.java+refs-changes-41-45541-1 53 Eclipse_CDT Please add your name to the copyright header of the file. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/IProblem.java+refs-changes-67-24367-4 229 Eclipse_CDT Unnecessary blank line. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/IndexerBlock.java+refs-changes-94-11194-3 368 Eclipse_CDT I think this should be initializing fContainerDmc above [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java+refs-changes-80-13980-4 167 Eclipse_CDT "I don't (yet) understand what \""connected\"" means in this context -- in the hardware both ends of the link are always connected right? Or do we use this in the drawing code to draw \""edge\"" links differently? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/utils/Parallella16Constants.java+refs-changes-33-25133-6 75 Eclipse_CDT "Don't replace with '*'. Eclipse does that automatically so you have to change a preference. Preferences->Java->Code style->Organize imports: increase the number for \""Number of imports needed for .*\"" " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java+refs-changes-18-22118-1 47 Eclipse_CDT Maybe this should be getNotes() [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/IGDBTraceControl2.java+refs-changes-97-7997-3 23 Eclipse_CDT I think the above comment is out-of-date [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java+refs-changes-94-24994-5 344 Eclipse_CDT Whats is up with \\r in this file? I have never seem it before\nAnd other files in the patch does not seem to have this issue [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.examples.dsf.gdb/src/org/eclipse/cdt/examples/dsf/gdb/service/command/GdbExtendedCommandFactory_6_8.java+refs-changes-60-30660-2 11 Eclipse_CDT "Is it future-proof to look for the second element? In the future couldn't MI insert an element before the one we are looking for. Maybe it would be safer to look for the name of the field \""col0\"" or \""col2\"". I'm assuming MI must keep these fields the same for backwards-compatibility? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MIInfoOsInfo.java+refs-changes-35-5835-3 62 Eclipse_CDT Turns out that this wasn't needed because both Memory and Memory Browser view have a way to ask the user for the memory space id and then call IMemorySpaceAwareMemoryBlockRetrieval#getMemoryBlock()\n\nHowever with the changes you propose it will possible for some debuggers to use memory spaces even when not specified by the user but implicitly specified in an expression. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java+refs-changes-94-24994-4 128 Eclipse_CDT This event triggers the re-built of available register groups needed after the addition or removal of a group.\n I have updated the comment to reflect this. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIRegisters.java+refs-changes-80-13980-4 197 Eclipse_CDT Is there value in having this method? Can we do the below logic directly in DSFSessionState? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/DSFDebugModel.java+refs-changes-26-26726-5 467 Eclipse_CDT instanceof checks for null so you can remove the null check [not_related_to_checkstyle] visualizer/org.eclipse.cdt.visualizer.ui/src/org/eclipse/cdt/visualizer/ui/canvas/GraphicCanvas.java+refs-changes-10-25410-3 56 Eclipse_CDT "Why do need to use regex for this? Is this not the\nsame as str.contains(delimeter)?\nAnd you using capturing group that just wastes cpu cycles for no reason. \nIn you regex \""a:\"" is good but \"":a\"" is not is this correct? " [not_related_to_checkstyle] core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/core/cdtvariables/EnvironmentVariableSupplier.java+refs-changes-00-30000-4 115 Eclipse_CDT Another nice optimization. I had to think about it for a while :)\n\nCan you put a comment that we don't actually need to fetch the frames from GDB in this case but can create them ourselves as long as we known how many they are which is why we check the depth [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIStack.java+refs-changes-56-40656-5 487 Eclipse_CDT Please use IStack instead of MIStack. Someday we may use a different instance of the IStack service and this would break. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIRegisters.java+refs-changes-66-16566-1 540 Eclipse_CDT Also never used [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepoints/TracepointImageRegistry.java+refs-changes-97-7997-3 45 Eclipse_CDT And we cannot have the globals of the base AbstractCLaunchDelegate2.\n\nAll these things could be a problem if we launch two launches exactly at the same time. Maybe using a LaunchGroup we could trigger a bug.\n\nI'll open a bug about this. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunchDelegate.java+refs-changes-79-38679-3 75 Eclipse_CDT This is a hack to follow an internal API that is not needed. You can move the code of LoadModuleSymbolsActionDelegate here and remove that old internal API [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/commands/LoadSymbolsCommandHandler.java+refs-changes-16-39716-6 30 Eclipse_CDT Since some of these constants are used with putByte method it makes sense to define them as byte instead of short. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/db/TypeMarshalBuffer.java+refs-changes-78-10578-3 38 Eclipse_CDT @since tag [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS_7_5.java+refs-changes-35-5835-3 12 Eclipse_CDT Done. Hope I didn't miss anything (IndexTests pass). IP stuff is on bugzilla. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPDependentEvaluation.java+refs-changes-78-10578-1 124 Eclipse_CDT Simpler to use getQualifier. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.java+refs-changes-51-15451-2 1715 Eclipse_CDT Don't actually need 'block' you can use 'memoryBlock' directly. This could have been done in the original code also. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java+refs-changes-22-37922-1 448 Eclipse_CDT A CoreException doesn't necessarily indicate that the member is not owned by the class. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPClassType.java+refs-changes-01-11901-3 429 Eclipse_CDT "Yes the runControl part is not really needed here.\nI removed this \""if\"" from here. " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/DSFDebugModel.java+refs-changes-00-41200-1 310 Eclipse_CDT please provide a short example here of code [not_related_to_checkstyle] codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/InitializationInCaseChecker.java+refs-changes-62-57362-1 20 Eclipse_CDT Again if you don't need ordering equals() would be more readable.\nAlso it optimizes the case where the two strings happen to be\nthe same string reference. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/utils/EpiphanyConstants.java+refs-changes-33-25133-6 91 Eclipse_CDT This could be done more efficiently since the desired size of the array is known at this point. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/util/ArrayUtil.java+refs-changes-90-19890-1 776 Eclipse_CDT This comment belongs together with the getDefinitions() call and subsequent loop (i.e. it belongs in the 'else' branch of this function). [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/c/hover/CSourceHover.java+refs-changes-07-31807-4 267 Eclipse_CDT Ok. I'll just set this to pull the option from the debug options class during the constructor and then only use the dynamic options where I can. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/concurrent/DefaultDsfExecutor.java+refs-changes-68-6768-1 82 Eclipse_CDT I think it should be in its own plugin because it serves as an example of how to integrate a toolchain outside cdt.core [not_related_to_checkstyle] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/build/GCCToolChain.java+refs-changes-24-54924-1 32 Eclipse_CDT This was confusing when using it. The command does do anything when there is already such an expression and if the user does not know what this command is supposed to do they might get confused.\n\nWe could actually allow to create more than one of such commands just to let the user really notice what is happening. They'll learn not to use it more than once after. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/actions/AddLocalsExpressionCommandHandler.java+refs-changes-05-39905-1 18 Eclipse_CDT /** Whether this object is selected. */ [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/view/EpiphanyVisualizerCPU.java+refs-changes-33-25133-6 155 Eclipse_CDT This assertion is detrimental to troubleshooting if anything goes wrong. Remove it and make the code below work with arrays of different sizes. [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-10 220 Eclipse_CDT I don't think you need to create a new map. getLaunchConfiguration().getAttributes() already returns a copy that can be modified. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbDebugNewExecutableCommand.java+refs-changes-38-7438-2 312 Eclipse_CDT Surprisingly I've seen that once in a while (1 in 5 or 10 times) this method does not get called at all and the launch is not removed as expected. Then the 1 minute timeout hits.\n\nI don't understand why this is happening. Maybe a bug in platform? From what I see the WaitForTerminationJob is properly started but the launchesTerminated() is not called at all in those cases. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/DsfTerminateCommand.java+refs-changes-51-5751-1 99 Eclipse_CDT I changed the code as you suggested but it doesn't really matter. Even my (incorrect) code worked because no data is passed to the monitor. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbConnectCommand.java+refs-changes-45-10345-1 273 Eclipse_CDT -1 for fixing this specific warnings. Eclipse generates code with public in interface methods. Why sonar is even complaining about it? +1 for turning this off [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/IProcessExtendedInfo.java+refs-changes-19-53519-1 23 Eclipse_CDT "} and the following 'else\"" have to be on the same line. " [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java+refs-changes-46-41346-9 601 Eclipse_CDT "I don't think \""sending\"" is the right word here. Maybe \""launching\"" to make it consistent with the other message? \nHow does that sound:\n\""Could not determine GDB version after launching command:\"" " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java+refs-changes-26-20326-1 320 Eclipse_CDT "Sorry to keep bugging you about this but I was thinking you would include this check in the shared function as it is repeated (except for the call to the superClass function) among them.\n\nIt's trickier but you could do something like this:\n\n\tprivate enum SuperEnum { SUCCESS FAIL LOOK_IN_SUPER }\n\t\n\tprivate SuperEnum checkEnumOrTree(String v) throws BuildException {\n\t\t// Sanity\n\t\tif (id == null) return SuperEnum.FAIL;\n\n\t\t// Does this option instance have the list of values?\n\t\tif (applicableValuesList == null) {\n\t\t\tif (superClass != null) {\n\t\t\t\treturn SuperEnum.LOOK_IN_SUPER;\n\t\t\t} else {\n\t\t\t\treturn SuperEnum.FAIL;\n\t\t\t}\n\t\t}\n\t\tif (getValueType() != ENUMERATED && getValueType() != TREE) {\n\t\t\tthrow new BuildException(ManagedMakeMessages.getResourceString\n\t\t\t\t\t(\""Option.error.bad_value_type\"")); // NON-NLS-1 \n\t\t}\n\n\t\treturn SuperEnum.SUCCESS;\n\t}\n\nand in each of the three actual methods:\n\n\t\tswitch (checkEnumOrTree(id)) {\n\t\tcase LOOK_IN_SUPER:\n\t\t\treturn superClass.getCommand(id);\n\t\tcase FAIL:\n\t\t\treturn EMPTY_STRING;\n\t\tcase SUCCESS:\n\t\t}\n\nchanging the return values appropriately. " [not_related_to_checkstyle] build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Option.java+refs-changes-93-7693-2 1349 Eclipse_CDT Should it be ON or OF? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/IProblem.java+refs-changes-67-24367-1 230 Eclipse_CDT Why not use NodeCommentMap.getEndOffsetIncludingComments(IASTNode)? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/changegenerator/ChangeGenerator.java+refs-changes-77-22177-3 1054 Eclipse_CDT same comment as above about dealing with null [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizerEventListener.java+refs-changes-26-26726-5 248 Eclipse_CDT "I have renamed to \""supportsProcPseudoFS\"" as not just CPU info is read but proc stats as well. " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-38-33438-2 343 Eclipse_CDT Really? You will open file for every variable? This is so bad.\nOpen file once and write everything in the loop [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java+refs-changes-58-29958-1 607 Eclipse_CDT "Before the string please another parameter:\n INTERNAL_ERROR\n\nand remove the \""Internal error: \"" part of the error message " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-77-10077-4 717 Eclipse_CDT Removed the unnecessary code as suggested. [not_related_to_checkstyle] build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/wizards/AutotoolsProjectImportWizardPage.java+refs-changes-55-43155-1 117 Eclipse_CDT I think this should be removed and canBuildWithConfigParm be its own test. This should be fine as long as the initConfigParm is part of beforeClass so --enable-jeff is always performed. [not_related_to_checkstyle] build/org.eclipse.cdt.autotools.ui.tests/src/org/eclipse/cdt/autotools/ui/tests/SetConfigurationParameter.java+refs-changes-08-29608-2 103 Eclipse_CDT Do you expect to use these elsewhere later on? If not then I think we can inline them as they don't save much space in the code and allows to read the logic directly within the test using them. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/MemoryReadQuery.java+refs-changes-02-42302-4 20 Eclipse_CDT yes - kind of obvious when you think of it :) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/PersistentSettingsManager.java+refs-changes-01-44001-2 147 Eclipse_CDT Why put 'abstract'?\n\nYou can even remove public in an interface [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/IDSFTargetDataProxy.java+refs-changes-00-41200-1 30 Eclipse_CDT Unnecessary blank line [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/comenthandler/CommentHandlingWithRewriteTest.java+refs-changes-61-21761-3 70 Eclipse_CDT getSuffix() -> suffix\n\nSame below. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTLiteralExpression.java+refs-changes-67-24367-1 274 Eclipse_CDT Done \nTrue no need to pass on the memorySpaceID as we have resolved the memory context earlier :-) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java+refs-changes-94-24994-4 468 Eclipse_CDT Ditto. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/index/tests/IndexCPPBindingResolutionTest.java+refs-changes-05-36605-4 181 Eclipse_CDT I think we need to complete the RequestMonitor (rm) here not the IDebugCommandRequest (request) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/DsfTerminateCommand.java+refs-changes-18-26318-6 243 Eclipse_CDT Get -> Returns [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/StringType.java+refs-changes-67-24367-1 108 Eclipse_CDT No longer needed? [not_related_to_checkstyle] visualizer/org.eclipse.cdt.visualizer.ui/src/org/eclipse/cdt/visualizer/ui/canvas/VirtualBoundsGraphicObject.java+refs-changes-79-25079-5 304 Eclipse_CDT This change does not work.\nThe idea is that as soon as the user presses the 'toggle reverse' button all other reverse button should appear. When the change above is made this no longer works. Note that with 4.2 this is broken altogether but in 3.8 it still works before this proposed change. See Bug 290572. [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/commands/ReverseToggleCommandHandler.java+refs-changes-35-5535-1 135 Eclipse_CDT Infinite recursion is possible if the inheritance hierarchy is malformed. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpHelper.java+refs-changes-77-22177-3 234 Eclipse_CDT It's only one space. I think the gerrit diff view breaks after 100 characters therefore { is always on a new line. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/cpp/ICPPASTAliasDeclaration.java+refs-changes-55-22555-2 28 Eclipse_CDT Might as well store the session passed in the constructor in a member fSession since you will need it later [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/actions/DsfStepIntoSelectionCommand.java+refs-changes-05-11305-5 41 Eclipse_CDT "I meant to add\n if (! isSuccess()) {\n fakeChildren.add(childVar.exprInfo);\n }\njust before the first addRealChildrenOfFake(...).\nIn the review I was checking that each time\na fake was added to the LRU it is also added\nto fakeChildren.\nBecause of this the surrounding \""if (! isSuccess())\""is\nneeded. " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 1544 Eclipse_CDT Why did the whitespace change. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/replace/WhitespaceHandlingTest.java+refs-changes-25-30525-2 40 Eclipse_CDT I do not understand this statement without concrete examples. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/UNCPathConverter.java+refs-changes-77-34077-1 68 Eclipse_CDT Same comment as above about the remote case [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbDebugNewExecutableCommand.java+refs-changes-38-7438-2 210 Eclipse_CDT We should probably return v_private since this is the default for classes and getKey returns k_class in case of a CoreException. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPClassSpecialization.java+refs-changes-01-11901-4 492 Eclipse_CDT "I don't understand this area very well -- how does IConfigurationEnvironmentVariableSupplier relate to IEnvironmentVariableManager?\n\nAlso I find the javadoc for IConfigurationEnvironmentVariableSupplier.getVariables confusing. Do you know if \""If the array contains any {@code null} it will be ignored.\"" means that the array is ignored or just the invalid entry?\n\nIf IConfigurationEnvironmentVariableSupplier.getVariables is somehow related to IEnvironmentVariableManager.getVariables then should this loop be changed to search for null entries first so that it can ignore the array if nulls are found? " [not_related_to_checkstyle] build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/build/core/scannerconfig/ScannerConfigBuilder.java+refs-changes-20-15820-2 176 Eclipse_CDT @since 4.1 missing [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 585 Eclipse_CDT This will not work because a core file (which is elements[0]) is an IBinary but we don't want to use that as the program for the debug session. We need to make sure (probably in super.searchAndLaunch()) that no core file is selected as part of the list of binaries. You can use IBinary.isCore() for that. [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/launch/CApplicationLaunchShortcutPMD.java+refs-changes-53-17853-5 40 Eclipse_CDT Agreed regarding the exception. I have created an exception when an unsigned value is treated as negative (so it can be used elsewhere for 8-byte values as well). To do it properly does require an overhaul and the 8-byte situation is more difficult. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/Dwarf.java+refs-changes-31-17431-2 599 Eclipse_CDT "Only a single '\\' although \""test\\\\r_icu_init.h\"" does work as well. " [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/HeaderFileReferenceAdjuster.java+refs-changes-60-44360-1 122 Eclipse_CDT "Please use a Vector instead or some List that can grow instead of doing it ourselves. Then you can also remove the existing comment and put a comment to explain why we need to store the fake children; something along the lines of \""we need to keep track of fake children because they are in the LRU and need to be removed in some cases\"" " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 373 Eclipse_CDT drawed -> drawn [not_related_to_checkstyle] visualizer/org.eclipse.cdt.visualizer.ui/src/org/eclipse/cdt/visualizer/ui/canvas/VirtualBoundsGraphicObject.java+refs-changes-79-25079-5 113 Eclipse_CDT Since you factored out the checkCorrectOrder code there's no need for the hasCorrectBuilderCommands boolean (or the 2nd if statement) -- simply inline the checkCorrectOrder call into this if statement after an &&. [not_related_to_checkstyle] build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/autotools/core/AutotoolsNewProjectNature.java+refs-changes-18-10918-1 87 Eclipse_CDT Don't initialize: compiler will set to null and we'll avoid having to step into that code when debugging [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/model/VisualizerCPU.java+refs-changes-77-10077-4 36 Eclipse_CDT I've set the checked state of fDisconnectedTracingAction here so that it updates when we change between multiple debug sessions. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepoints/TraceControlView.java+refs-changes-97-7997-12 873 Eclipse_CDT It is supposed to inform the user when request fails. '-info-os' failure is something that would be reasonable to report in obvious way since it's not supposed to fail at all. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/osview/SessionOSData.java+refs-changes-35-5835-3 188 Eclipse_CDT We should probably pass in sourceFile lineNumber and selectedFunction too [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/IRunControl3.java+refs-changes-05-11305-3 32 Eclipse_CDT I have tried to clarify the comment... The idea is that this is to simulate a single parameter shared between multiple view instances. So they would automatically share the same default value. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/src/org/eclipse/cdt/dsf/gdb/tests/PersistentSettingsManagerTest.java+refs-changes-01-44001-2 93 Eclipse_CDT Comment e.g.\n /** Processes an element of the tree view.\n\t * Returns true if children of this element should be processed \n\t * and false if they can be skipped.\n\t */ [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/view/EpiphanyVisualizerSelectionFinder.java+refs-changes-33-25133-6 40 Eclipse_CDT To be consistent with others can we call this IRegisterGroupActionsTarget? [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/IRegisterGroupActions.java+refs-changes-80-13980-4 20 Eclipse_CDT I think we still need to complete the rm here. Probably with an error status or an empty array. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbDisconnectCommand.java+refs-changes-18-26318-5 238 Eclipse_CDT The purpose of extending IASTAttribute is not clear. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/ICPPASTAttributeSpecifier.java+refs-changes-55-22555-2 23 Eclipse_CDT Please move up a bit the methods are in alphabetical order. I know with an IDE it is not a big deal but it can be nice when skimming the file. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java+refs-changes-16-39716-2 222 Eclipse_CDT you can call getData() directly in the above line [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java+refs-changes-18-53418-3 690 Eclipse_CDT Why do we need to check that it is an IFile? [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/launch/CApplicationLaunchShortcutPMD.java+refs-changes-53-17853-2 59 Eclipse_CDT Trailing white space. I wouldn't mention it but might as well fix it at the same time as fixing the API errors. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/Dwarf.java+refs-changes-31-17431-2 610 Eclipse_CDT Returning null from this method is likely to call an NPE in the caller code. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalBinding.java+refs-changes-64-18064-3 106 Eclipse_CDT Yes and now so is this 'cache' variable. Which BTW was preventing the CPPClassSpecializations from getting cleaned up which led to a pretty massive number of objects not getting cleaned up :). [not_related_to_checkstyle] qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/pdom/QtPDOMLinkage.java+refs-changes-64-25064-2 61 Eclipse_CDT finality of fromIndex is redundant. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/util/CharArrayUtils.java+refs-changes-67-24367-1 321 Eclipse_CDT "Sorry Jens but I am not sure I have understood you properly. Did you really mean to add:\n\tif (! isSuccess()) {\n\t\tfakeChildren.add(childVar.exprInfo);\n\t}\nat line 1522 (before the \""} else if (childVar.currentState == STATE_CREATION_FAILED) {\"" line)?\nOr maybe the following line:\n\taddFakeChild(childVar.exprInfo);\nshould be added at line 1512 (before the \""addRealChildrenOfFake(...)\"" line)? " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 1544 Eclipse_CDT "The error message says: \""Declaration/Definition for member 'foo() : void' could not be resolved uniquely\"". It's not clear what the message means. " [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/refactoring/pullup/PullUpRefactoringTest.java+refs-changes-77-22177-3 173 Eclipse_CDT Prefer line breaks at higher level here after the equal sign. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/inlinetemp/InlineTempRefactoring.java+refs-changes-77-22177-3 155 Eclipse_CDT Extra space after * [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java+refs-changes-46-41346-8 154 Eclipse_CDT We don't usually have such methods in DSF where we return the data for all existing groups. The problem is that each element of resulting array are not mapped to its corresponding RegisterGroupDMC.\n\nInstead we should use IRegisters.getRegisterGroupData multiple times. It does seem less efficient but that above API is not solid. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/IRegisters2.java+refs-changes-80-13980-11 38 Eclipse_CDT In theory the asyncExec() could be executed after the dispose() but I think this is just an academic possibility.\n\nI was actually more worried about the fact that a DebugCommandHandler can be associated with multiple windows and how we could leverage the DebugCommandHandler base class for triggering the refresh. But that would be a separate issue. [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/commands/ReverseToggleCommandHandler.java+refs-changes-44-56344-2 73 Eclipse_CDT This should be INVALID_COREFILE_NAME [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/PostMortemCoreTest.java+refs-changes-68-38068-5 61 Eclipse_CDT The only change this makes is it allows the authority section to be used in addition to the host section. The authority section needs to be used for remote implementations that use a connection name rather than a host name for the URI. Since o.e.remote is the only implementation that actually uses this remote functionality (that I know about at least) and it uses connection names this change is needed to make remote support work with CDT.\n\nThe behavior is the same as the current version unless the authority section is used. I don't know what the behavior is supposed to be for a local path but this patch doesn't change it. I think it's unreasonable to require a test case to cover functionality that is already there if there is not already one provided. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/UNCPathConverter.java+refs-changes-77-34077-1 68 Eclipse_CDT This is the Qt plugin. [not_related_to_checkstyle] qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/parser/QtParser.java+refs-changes-72-19672-1 8 Eclipse_CDT I think it would be safer to check sysrootDirectory is not null before using it. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/GdbServerDebuggerPage.java+refs-changes-70-15470-2 156 Eclipse_CDT Change 2013 to 2104. We only keep the first and last date and we update the last date to the current year when making a change. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MIThread.java+refs-changes-57-36057-7 2 Eclipse_CDT I may need help with this. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2Tests.java+refs-changes-67-24367-1 7859 Eclipse_CDT The current code on master is really bad as it creates files in whatever happens to be the current directory. This will fix the issue.\nNote that ResourceHelper cleans up the resources it creates when ResourceHelper.cleanUp() is called from tearDown(). [not_related_to_checkstyle] build/org.eclipse.cdt.managedbuilder.core.tests/tests/org/eclipse/cdt/managedbuilder/language/settings/providers/tests/BuiltinSpecsDetectorTest.java+refs-changes-79-17179-3 818 Eclipse_CDT Instead of introducing a new ITranslationUnitProvider interface it's simpler to get the editor's input and check if it is an instance of ITranslationUnitEditorInput. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/ASTProvider.java+refs-changes-26-20026-2 236 Eclipse_CDT Probably slightly better: projectName == null || projectName.isEmpty() ? null ...\n\nWhy is projectName empty instead of null for projectless debugging? Should this itself be changed? [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/DebugStringVariableSubstitutor.java+refs-changes-14-16414-1 102 Eclipse_CDT API tooling complains about this class being new API also. Looking at it now I think it should actually be an internal class. If that is true then it should be moved to the org.eclipse.cdt.internal.core or even org.eclipse.cdt.internal.errorparsers. When the class is moved to an internal plugin it won't need any @since tags.\n\nIt also won't need the @noextend tag -- after it is an internal class it will implicitly be @noextend. [not_related_to_checkstyle] core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/ProblemMarkerFilterManager.java+refs-changes-81-20581-4 21 Eclipse_CDT Better to remove lines 69-72 and add\n\nif (host == 0) {\n host = uri.getAuthority();\n}\n\nafter line 75. [not_related_to_checkstyle] core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/UNCPathConverter.java+refs-changes-29-33929-2 71 Eclipse_CDT IDockerImage.repoTags() is deprecated. It comes from Linux Tools which makes me think we should be able to use whatever replacement there is for it. [not_related_to_checkstyle] launch/org.eclipse.cdt.docker.launcher/src/org/eclipse/cdt/internal/docker/launcher/ContainerTab.java+refs-changes-71-46471-4 344 Eclipse_CDT IASTName -> IASTName or ICPPASTNameSpecifier [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/cpp/ICPPASTQualifiedName.java+refs-changes-51-15451-5 25 Eclipse_CDT "IASTLiteralExpression.toString() should return \""aaamacro\"". " [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java+refs-changes-05-36605-7 7888 Eclipse_CDT (...continued) I'm unsure of what is a typical return value for findBindings that's why I was confused as to why it returned both PDOMNodes and AST nodes. If it is indicative that a lookup failed how would I investigate further? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-05-36605-2 3062 Eclipse_CDT Return the last statement by a @throws clause. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/cpp/ICPPClassType.java+refs-changes-01-11901-3 130 Eclipse_CDT Should be 'if' instead of 'of'. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBPatternMatchingExpressions.java+refs-changes-81-8881-3 564 Eclipse_CDT I think you should put your name:\nPhilippe Gil (AdaCore) - Initial API and implementation [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/CLISetLanguage.java+refs-changes-71-18371-1 9 Eclipse_CDT No need to pass skipBreakpoints [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java+refs-changes-05-11305-3 370 Eclipse_CDT This method can be be pushed to VariableReadWriteFlags to be available for both C and C++. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPVariableReadWriteFlags.java+refs-changes-77-22177-3 50 Eclipse_CDT Done \naddRegGroup takes the context from any of the provided registers but you are right that an extension may want to have a different type of context so I have added it. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/IRegisters2.java+refs-changes-80-13980-4 38 Eclipse_CDT Use diamond operator. Same below. [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/ParameterGuessingTests.java+refs-changes-46-41346-8 67 Eclipse_CDT I thought the line limit that gained consensus on the cdt-dev thread about code style was 110 characters. I deliberately wrapped my comments at 110 for that reason. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/TemplateIdStrategy.java+refs-changes-73-41373-2 29 Eclipse_CDT Unnecessary blank line. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTChildProvider.java+refs-changes-67-11267-2 22 Eclipse_CDT Yes as we discussed I was settling for simplicity. \nBut I see your point so the new patch reflects the re-factoring. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java+refs-changes-18-53418-1 102 Eclipse_CDT @author [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/StepIntoSelectionTest.java+refs-changes-05-11305-5 53 Eclipse_CDT Well we can remove it and add this to our long list of test failures we get all the time. Not sure how that helps. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/pdom/tests/PDOMNameTests.java+refs-changes-02-19602-2 49 Eclipse_CDT I kept this method so it could be called from the FinalLaunchSequence [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbConnectCommand.java+refs-changes-16-6816-2 295 Eclipse_CDT This method can be removed when using a Vector [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 726 Eclipse_CDT I don't think so. Current behavior is to display all parameters. Setting the default value to false here would hide them. We could argue whether we want display of the default arguments (next line) since this changes the current behavior. But I expect the new feature gets lost for most people if it has to be enabled explicitly. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/preferences/CodeAssistPreferencePage.java+refs-changes-46-30646-2 193 Eclipse_CDT Since the two if-clauses are shared between getId and hasId it would be better to factor them out into a private method avoiding the duplication. [not_related_to_checkstyle] build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Option.java+refs-changes-93-7693-1 1476 Eclipse_CDT I have removed the overload. There's been an overload in the base class that fits well. If useGCCExtensions is a better name we should change it in the corresponding methods in AST2TestBase:\n- parse()\n- parseAndCheckBindings() [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java+refs-changes-55-22555-5 167 Eclipse_CDT I think it would be more efficient to do:\n\nfor (Entry> e: fLoadInfoRequestCache.entrySet()) {\n\tprocessLoads(e.getKey() e.getValue() fCachedLoads);\n} [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-77-10077-5 718 Eclipse_CDT So this one seems to update the name as well but I think we shouldn't send this unless the list of registers has changed. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRegisters.java+refs-changes-80-13980-13 665 Eclipse_CDT Indeed it seems it was just touched so the formatting was affected. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/GNUCSourceParser.java+refs-changes-73-54573-1 16 Eclipse_CDT rm.done()? Or this service disposes monitor? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.examples.dsf.gdb/src/org/eclipse/cdt/examples/dsf/gdb/launch/GdbExtendedFinalLaunchSequence_7_7.java+refs-changes-60-30660-2 87 Eclipse_CDT I don't quite understand why this check is limited to child statements as opposed to any child nodes. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/MacroExpansionHandler.java+refs-changes-42-52942-1 76 Eclipse_CDT You're right this seems too dangerous. I haven't found any way to pass the separator to transformer directly but I'll try to find an alternate solution. Thanks! [not_related_to_checkstyle] core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/xml/XmlProjectDescriptionStorage.java+refs-changes-99-15399-1 544 Eclipse_CDT I've special checked the case where the max is 0 since setMaximum would get ignored in that case and the slider would be small. I've made it so the slide would take then entire bar in that case. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/tracepoints/TraceControlView.java+refs-changes-97-7997-12 545 Eclipse_CDT Done \nMuch better to include it at the beginning of a child message.\nThanks ! [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/viewmodel/numberformat/detail/NumberFormatDetailPane.java+refs-changes-17-53517-2 366 Eclipse_CDT Exception message contains backend message extracted from GDB-MI error reply. See org.eclipse.cdt.dsf.mi.service.command.AbstractMIControl.RxThread.processMIOutput(String) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBBreakpoints_7_0.java+refs-changes-11-22511-1 173 Eclipse_CDT Better to use CharArrayUtils.EMPTY_CHAR_ARRAY [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTAttributeSpecifier.java+refs-changes-55-22555-2 25 Eclipse_CDT add if (! isSuccess) { addFakeChild(...) } also at line 1522 ? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIVariableManager.java+refs-changes-02-5602-1 1544 Eclipse_CDT excepected -> expected [not_related_to_checkstyle] core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/contentassist2/AbstractContentAssistTest.java+refs-changes-46-41346-8 223 Eclipse_CDT I was under an impression that before http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=8e5a31e714d28d2760b36168d48aa01bf828e211 the CPPTemplates.instatiateType method had always been called with 'within' parameter obtained by calling getSpecializationContext(). Upon closer examination it turned out not to be true. There was was at least one exception.\n\nI've modified the patch to avoid walking up the chain of specializations. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.java+refs-changes-94-39994-1 1375 Eclipse_CDT Can't we use ITypeMarshalBuffer.BASIC_TYPE | shiftedKind | ITypeMarshalBuffer.LAST_FLAG and not write kind separately? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPBasicType.java+refs-changes-78-10578-4 233 Eclipse_CDT As we talked the interface IDSFTargetDataProxy referes to CPU Core Thread etc.. which in a way is a target for a Debug session or trace.\n Since we have the name target all over and does not collide with the interface. Lets skip the renaming until the interface becomes more generic. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizer.java+refs-changes-00-41200-1 127 Eclipse_CDT Meh this line should not be removed but I don't want to start a new build now. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_0/GDBRemoteTracepointsTest_7_0.java+refs-changes-68-38068-5 863 Eclipse_CDT Isn't this line redundant? [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/internal/index/tests/IndexCPPBindingResolutionTest.java+refs-changes-18-26418-1 1832 Eclipse_CDT Good point I actually hadn't considered multi-threading in this context. However I wonder if it would really be an issue since you'll\ngenerally be looking up string resources for code that updates the UI \nwhich should always be running on the event thread anyway. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/EpiphanyVisualizerUIPlugin.java+refs-changes-33-25133-6 84 Eclipse_CDT Please use StringUtil.join with 'args' like you did in GDBBackend [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java+refs-changes-52-34052-2 341 Eclipse_CDT Not worth respining the change to fix. [not_related_to_checkstyle] qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/parser/QtParser.java+refs-changes-72-19672-1 47 Eclipse_CDT runToLocation() is named like that because we can run to a line or an address. For stepIntoSelection I think we will not share the operation so naming it stepIntoLocation does not seem right. How about stepIntoSelection() (overloaded) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java+refs-changes-05-11305-3 974 Eclipse_CDT This method should behave exactly like DsfPlugin.debug() used to behave or else we will affect different printouts.\n\nTherefore I suggest moving the line splitting stuff back to CommandCache and leaving this one with\nif (DEBUG) {\n sysout.println\n}\nand the tracing to the file [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/internal/DsfDebugOptions.java+refs-changes-68-6768-1 78 Eclipse_CDT I suppose that if handleSuccess is called isSuccess is always true. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java+refs-changes-18-53418-2 689 Eclipse_CDT Done\nVery important catch !! \nI should have noticed this \n\nThanks [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRegisterManager.java+refs-changes-80-13980-4 315 Eclipse_CDT Remove duplicate blank line. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/IndexerBlock.java+refs-changes-94-11194-3 215 Eclipse_CDT I think we need to complete the RequestMonitor (rm) here not the IDebugCommandRequest (request) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbDisconnectCommand.java+refs-changes-18-26318-6 243 Eclipse_CDT Remove this line. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/pullup/PullUpInformation.java+refs-changes-77-22177-3 178 Eclipse_CDT In the plug-in.xml file I set the count as 1. So there can only be one element. [not_related_to_checkstyle] debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/launch/CApplicationLaunchShortcutPMD.java+refs-changes-40-18640-1 36 Eclipse_CDT The case where the remote session is towards a non-linux target is not distinguished. There is no easy way to know the OS for a remote session I think? \n\nOTOH there was already a similar case in the existing code where one could use a linux host towards a windows target. So this is probably acceptable. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-38-33438-2 350 Eclipse_CDT this should be private since it has lazy getter\nAnd come to think about it results and values should be private too if somebody\nresets it directly you will have issue since name2value will be out of sync [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MITuple.java+refs-changes-90-37090-5 28 Eclipse_CDT "Better to break before \""implements\"". " [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/CASTBaseDeclSpecifier.java+refs-changes-47-43847-1 24 Eclipse_CDT "Long.decode cannot decode 0xb - so we just lost this?\nLong.decode also states that \""This sequence of characters must represent a positive value\"". So am not sure what is \nhandling of negative values is about since it will throw NumberFormatException.\n\nJunit tests would be nice here. I don't think we can refactor this code now though because of what I mentioned.\nWe do however have address factories in cdt Addr64 which may be able to deal with parsing of this " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java+refs-changes-23-37923-2 181 Eclipse_CDT We should probably check the attribute itself too.\n\nIt is somewhat unnatural that we navigate from the attribute to its parent not the other way around. [not_related_to_checkstyle] core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPAttributeTests.java+refs-changes-55-22555-2 132 Eclipse_CDT Agree \nThe solution has changed to use a new memory space service method. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/model/IMemoryBlockRetrievalManager.java+refs-changes-94-24994-4 12 Eclipse_CDT The comment doesn't add any value. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTAttributeSpecifier.java+refs-changes-55-22555-2 33 Eclipse_CDT "I am not sure about this one \none implementation may be ok with null for some parameters but another one may not i.e. I think they should not be documented as the behavior may vary.\n This is best to leave it to the implementation as they can return IStatus with a corresponding error as needed.\n For the gdb implementation of \""editRegisterGroup\"" I don't expect null arguments although I am protecting the implementation against null pointer exceptions. " [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/IRegisters2.java+refs-changes-80-13980-4 61 Eclipse_CDT Shouldn't delete method be overridden as you proposed earlier? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPParameterSpecialization.java+refs-changes-99-26499-2 34 Eclipse_CDT "Actually to replicate the original behavior we need not to draw the container which contains the bars. The default value is \""true\"" so if we remove that line the container would it would be drawn. " [not_related_to_checkstyle] visualizer/org.eclipse.cdt.visualizer.examples/src/org/eclipse/cdt/visualizer/examples/problemvisualizer/ProblemVisualizer.java+refs-changes-85-25685-2 110 Eclipse_CDT This was left-over from my initial implementation it shouldn't have been submitted in the first patch set either. I'll remove it. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/PDOMWriter.java+refs-changes-67-11267-2 475 Eclipse_CDT inline last var too while you at it... [not_related_to_checkstyle] codan/org.eclipse.cdt.codan.core.cxx/src/org/eclipse/cdt/codan/core/cxx/internal/model/cfg/ControlFlowGraphBuilder.java+refs-changes-01-42001-1 154 Eclipse_CDT Because of the false positive of isConvenienceVariable int 123 can't be right-clicked Watch. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/viewmodel/GdbVariableVMNode.java+refs-changes-77-15377-7 251 Eclipse_CDT This file does not seem to need updates any longer. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.tests/src/org/eclipse/cdt/dsf/gdb/tests/AllTests.java+refs-changes-59-45759-3 0 Eclipse_CDT Don't extend TestCase or else you will run JUnit3 which does not respect any of the annotations. This explains why your @Before and such methods didn't work. No need to extend anything. You might have copied this from LaunchUtilsTest which turns out to be wrong (I have fixed that one in Bug 400350).\n\nYou will then need to add \n import static org.junit.Assert.assertEquals;\nat the top of the file. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/ProcStatParserTest.java+refs-changes-77-10077-4 24 Eclipse_CDT I think it is important to retain exactly the old behaviour. The new code is used only in the fallback case where the editor is something other than a CEditor. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/ASTProvider.java+refs-changes-26-20026-2 280 Eclipse_CDT Too many blank lines. [not_related_to_checkstyle] core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java+refs-changes-46-41346-5 347 Eclipse_CDT I usually use arrays to prevent clients from adding/removing elements but this is exactly the case when we need it. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/GdbSessionAdapters.java+refs-changes-20-44220-6 166 Eclipse_CDT Trimming should only be done in the preference page. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/indexer/PDOMIndexerTask.java+refs-changes-33-19033-1 168 Eclipse_CDT "We shall talk about this one once more as we have now moved StepIntoSelectionOperation to an internal package to be used by the \""all stop\"" as well as for \""non-stop\"" implementation.\n \nWe decided to move it to an internal package to avoid the maintenance of this new interface.\n\nThe private setting for this field is also consistent with the one above for RunToLineActiveOperation " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java+refs-changes-05-11305-3 468 Eclipse_CDT Does it make sense to add an assert? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPNodeFactory.java+refs-changes-55-26555-1 232 Eclipse_CDT I mentioned this in a comment in the other review but it turns out you can't override delete() for PDOMCPPParameterSpecialization because it inherits from PDOMBinding which declares delete() as final.\n\nI don't know why PDOMCPPParameterSpecialization inherits from PDOMCPPBinding but PDOMCPPParameter does not - do you? [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPParameterSpecialization.java+refs-changes-99-26499-2 34 Eclipse_CDT Done - True I had only cases where the macro in the conditional expression was at the end. Middle and begin cases were missing. I've added them. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/MacroExpansionHandler.java+refs-changes-42-52942-2 81 Eclipse_CDT Better: size.compareTo(otherSize) [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/Cost.java+refs-changes-43-34543-1 268 Eclipse_CDT "Suggestion: I use // comments for \""section headers\"" like this.\nIf I need to make them stand out more I use // --- comment ---. " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/ui/view/MulticoreVisualizerCanvasFilter.java+refs-changes-38-12138-4 169 Eclipse_CDT Empty comments. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/utils/EpiphanyConstants.java+refs-changes-33-25133-6 52 Eclipse_CDT fCachedLoads could be null here. You should probably put a guard in processLoads() to be covered in all cases.\n\nIt could be null if fetching the loads failed for the first time. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-77-10077-4 651 Eclipse_CDT I'm not sure what this preference does?\n\nAlso maybe a browse button would be more user friendly [not_related_to_checkstyle] launch/org.eclipse.cdt.docker.launcher/src/org/eclipse/cdt/internal/docker/launcher/ui/preferences/DockerLaunchPreferencePage.java+refs-changes-71-46471-4 39 Eclipse_CDT I don't think we should use fWordSize directly. We should use getAddressableSize() as you have done elsewhere in case it gets overridden. [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/model/DsfMemoryBlock.java+refs-changes-18-22118-1 720 Eclipse_CDT "Instead of \""null\"" you can put \""sessionState.getDsfSession().getExecutor()\"" " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/internal/utils/DSFDebugModel.java+refs-changes-00-41200-1 344 Eclipse_CDT I'm not sure this still does what it used to. I think before it was getting the thread context now it will get the process context? Maybe Alvaro can answer that. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java+refs-changes-14-36814-22 395 Eclipse_CDT Please remove commented out code. [not_related_to_checkstyle] core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java+refs-changes-05-36605-3 3145 Eclipse_CDT "I have seen discussions on this type of change some people do prefer to keep \""public\"" \n I don't have a strong opinion on this one but it would be nice to be consistent. \n The Eclipse \""Extract Interface\"" action creates the interface with \""public\"" and \""abstract\"". " [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/IProcessExtendedInfo.java+refs-changes-19-53519-1 23 Eclipse_CDT Why the 'continue'? [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/ProcStatParser.java+refs-changes-77-10077-4 78 Eclipse_CDT Here you can just call 'new GdbDebugOptions(context);' without assigning it to anything. The object won't be garbage collected because the constructor registers it with the context. This is what JDT does.\n\nIf you don't like that please make the global flag private so we can modify/remove it later on. If it is not private it becomes API. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/GdbPlugin.java+refs-changes-72-5972-3 64 Eclipse_CDT Maybe use a HashSet here and convert back to a list at the end? (Unless you need to preserve order?) [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb.multicorevisualizer.epiphany.ui/src/org/eclipse/cdt/dsf/gdb/multicorevisualizer/epiphany/ui/model/EpiphanyModel.java+refs-changes-33-25133-6 103 Eclipse_CDT Let's only use DsfDebugOptions... as mentioned above [not_related_to_checkstyle] dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/service/DsfSession.java+refs-changes-68-6768-1 386 Eclipse_CDT This method will be removed and all related changes reverted in the next version of the patch. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunch.java+refs-changes-51-5751-1 325 Eclipse_CDT This class is a DSF service and therefore can only be called using the DSF executor. So you can run the code directly without submitting it to the executor. [not_related_to_checkstyle] dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBHardwareAndOS.java+refs-changes-35-5835-3 514 Couchbase should be args[0] array out of bounds exception [not_related_to_checkstyle] src/test/manual/com/couchbase/client/test/CouchbaseMoxiTest.java+refs-changes-85-14485-3 72 Couchbase same comment. [not_related_to_checkstyle] src/main/java/com/couchbase/client/CouchbaseClient.java+refs-changes-88-13688-2 414 Couchbase "This seems slightly confusing. We should explain a bit more here and have a bit more common language with the views manual perhaps?\n\nThis isn't so much about \""getting\"" a view it's more about accessing a view. " [not_related_to_checkstyle] src/main/java/com/couchbase/client/CouchbaseClient.java+refs-changes-88-13688-2 236 Couchbase should be a warning here that the return string could be massive and that it's colon delimited [not_related_to_checkstyle] src/main/java/com/couchbase/client/protocol/views/ViewResponseNoDocs.java+refs-changes-88-13688-2 45 Couchbase ick. it seems like status if tracking states should always have a state-- not just be null and when you try to get it's status the get runs.\n\nThis is actually probably a bug because what if I take the future reference the operation from the future and call status while the other get is in flight? [not_related_to_checkstyle] src/main/java/com/couchbase/client/internal/HttpFuture.java+refs-changes-88-13688-2 104 Couchbase If this is an issue it shouldn't be addressed here. The way do this is done in other places in the code and was committed over 6 months ago. If this is an issue it should be addressed in another change set. Also I haven't heard of anyone experiencing any issues with this yet. Matt let's discuss this as a separate issue next week. [not_related_to_checkstyle] src/main/java/com/couchbase/client/internal/HttpFuture.java+refs-changes-88-13688-2 104 Couchbase I'm pretty sure this class doesn't belong here at all. It looks like it's for testing?? [not_related_to_checkstyle] src/main/java/com/couchbase/client/JSONPopulator.java+refs-changes-88-13688-2 17 Couchbase whitespace! [not_related_to_checkstyle] src/test/manual/com/couchbase/client/test/CouchbaseMoxiTest.java+refs-changes-85-14485-2 42 Couchbase Don't need got data. Since the return type of the future is Boolean this gets filled in when receivedStatus is called. [not_related_to_checkstyle] src/main/java/com/couchbase/client/CouchbaseClient.java+refs-changes-07-12907-1 302 OpenDaylight_Controller possible null pointer exception add check! [not_related_to_checkstyle] opendaylight/sal/yang-prototype/code-generator/binding-generator-util/src/main/java/org/opendaylight/controller/binding/generator/util/generated/type/builder/GeneratedTOBuilderImpl.java+refs-changes-46-546-5 49 OpenDaylight_Controller "This leaves the objectTest file on disk so it is picked up by git - obviously we don't want people to accidentally check it in. We could delete the file after the test or put it in \""target/objectTest\"" so it's ignored. However it would be easiest to avoid files and their related errors altogether by streaming to a ByteArrayOutputStream and using a ByteArrayInputStream to read it back. " [not_related_to_checkstyle] opendaylight/md-sal/sal-clustering-commons/src/test/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/DDSNormalizedNodeStreamTest.java+refs-changes-25-12125-5 33 OpenDaylight_Controller Please do not use sneakyThrow. Declare exceptions as throws as close to public entrypoints as possible then decide to either make them public or encapsulate them either in a sublass of RuntimeException or an API exception (RestConfException?). [not_related_to_checkstyle] opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/ControllerContext.java+refs-changes-21-6821-1 453 OpenDaylight_Controller Instead of null use ActorRef.noSender() [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/ActorContext.java+refs-changes-65-9965-6 200 OpenDaylight_Controller Yup that makes sense. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ConcurrentDOMDataBroker.java+refs-changes-49-35849-20 62 OpenDaylight_Controller I have added the return but the poison pill should not be sent I think. Unless I am mistaken the pill does not take precedence and will be enqueued to the end of the mailbox and hence we can see client requests sent closing the transaction before we see the pill. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java+refs-changes-98-18498-26 87 OpenDaylight_Controller Being a community effort in this project we are following a general approach to not add @author tag in any of the source-files. Anyone interested in it can refer to the Commit logs. It would be awesome if this can be removed. [not_related_to_checkstyle] opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/TableConverter.java+refs-changes-18-418-5 18 OpenDaylight_Controller Why do while cycle not iterating through foreach loop? [not_related_to_checkstyle] opendaylight/sal/yang-prototype/code-generator/binding-java-api-generator/src/main/java/org/opendaylight/controller/sal/java/api/generator/GeneratorUtil.java+refs-changes-46-546-5 310 OpenDaylight_Controller "That's likely a good suggestion.\n\nBut even in that case I don't think it shows wrong state of the edge.\n\nAnd throughout the code ToplogyManagerImpl class uses only NodeConnector Edge information to update its topology information and does not depend on Node information.\nTo keep this policy I would like to leave \""// NOP\"" here. " [not_related_to_checkstyle] opendaylight/adsal/topologymanager/implementation/src/main/java/org/opendaylight/controller/topologymanager/internal/TopologyManagerImpl.java+refs-changes-76-12876-6 1108 OpenDaylight_Controller More docs here would be good. [not_related_to_checkstyle] opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/ClusteredDOMDataChangeListener.java+refs-changes-96-24496-4 12 OpenDaylight_Controller These changes will be re-implemented in a cleaner way. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java+refs-changes-99-35199-5 374 OpenDaylight_Controller I will change it in another patch. \n\nAbout timeouts I think Await time should be higher than Ask time just to cover the corner case of Ask completing at the end of timeout but the control could not be passed to Await and it times out. Yeah the chances are slim but its possible. [not_related_to_checkstyle] opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/utils/ActorUtil.java+refs-changes-67-10267-2 28 OpenDaylight_Controller I presume this will be called from an AppendEntriesReply handler [not_related_to_checkstyle] opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/consensus/ConsensusStrategy.java+refs-changes-32-12832-1 46 OpenDaylight_Controller can this be private and final. Also we can do with a Hashset too i guess. [not_related_to_checkstyle] opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/FixedLeaderElectionStrategy.java+refs-changes-66-19266-2 19 OpenDaylight_Controller "Using try{} catch{} fail(); is more suitable for negative tests. \""Expected\"" does not provide any useful information in case expected exception does not occur or a different type of exception is thrown. " [not_related_to_checkstyle] opendaylight/config/config-persister-directory-autodetect-adapter/src/test/java/org/opendaylight/controller/config/persist/storage/directory/autodetect/AutodetectDirectoryPersisterTest.java+refs-changes-16-5016-3 44 EclipsePlatformUI Thanks for the tip done. [not_related_to_checkstyle] tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/ProgressAnimationItemTest.java+refs-changes-69-43269-2 120