[ { "repository" : "https://github.com/android/architecture-samples", "sha1" : "8e1e0527a0d043b41da58925a39fb8e03d62829a", "url" : "https://github.com/android/architecture-samples/commit/8e1e0527a0d043b41da58925a39fb8e03d62829a", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.tasks.TasksFragmentTest is Rename to com.example.android.architecture.blueprints.todoapp.tasks.TasksScreenTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "720da617c258cac1e2a341f6e72aa6dd93ca771e", "url" : "https://github.com/android/architecture-samples/commit/720da617c258cac1e2a341f6e72aa6dd93ca771e", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method drawNavigationFromTasksToStatistics() in class AppNavigationTest is renamed to drawerNavigationFromTasksToStatistics()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "82503b7ecc3fca5110bdd6eb824b7a029de2ad7f", "url" : "https://github.com/android/architecture-samples/commit/82503b7ecc3fca5110bdd6eb824b7a029de2ad7f", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clickAddTaskButton_opensAddTaskUi() in class TasksScreenTest is renamed to createTask()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "0aba5dc1240238fa8ed32bb745db6b5a61671466", "url" : "https://github.com/android/architecture-samples/commit/0aba5dc1240238fa8ed32bb745db6b5a61671466", "refactorings" : [ { "refactoringType" : "RenameField", "description" : "RenameField: Field _editTaskCommand in class TaskDetailViewModel is rename to _editTaskEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field statisticsViewModel in class StatisticsFragment is rename to viewModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field _deleteTaskCommand in class TaskDetailViewModel is rename to _deleteTaskEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field _taskUpdated in class AddEditTaskViewModel is rename to _taskUpdatedEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getVmFactory() in class FragmentExt is renamed to getViewModelFactory()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "0870f15b4985ea743cef403047f418d75fe56fb9", "url" : "https://github.com/android/architecture-samples/commit/0870f15b4985ea743cef403047f418d75fe56fb9", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method resetState() in class TasksActivityTest is renamed to init()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "17da41e50e9fc9e005abf3164eeef2cec05afea6", "url" : "https://github.com/android/architecture-samples/commit/17da41e50e9fc9e005abf3164eeef2cec05afea6", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DefaultTasksRepository(TasksDataSource,TasksDataSource,CoroutineDispatcher) in class DefaultTasksRepository is changed to DefaultTasksRepository(TasksDataSource,TasksDataSource)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method TasksLocalDataSource(TasksDao,CoroutineDispatcher) in class TasksLocalDataSource is changed to TasksLocalDataSource(TasksDao)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method completeTask(Task) in class DefaultTasksRepository is inlined to method completeTask(String) in class DefaultTasksRepository", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideTasksRepository(TasksDataSource,TasksDataSource,CoroutineDispatcher) in class RepositoryModule is changed to provideTasksRepository(TasksDataSource,TasksDataSource)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideTasksLocalDataSource(ToDoDatabase,CoroutineDispatcher) in class DataSourceModule is changed to provideTasksLocalDataSource(ToDoDatabase)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "1bfd69c01d4b52e5af548133daca62445ba266b0", "url" : "https://github.com/android/architecture-samples/commit/1bfd69c01d4b52e5af548133daca62445ba266b0", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onActivityCreated(Bundle) in class TasksFragment is renamed to onViewCreated(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onActivityCreated(Bundle) in class AddEditTaskFragment is renamed to onViewCreated(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onActivityCreated(Bundle) in class TaskDetailFragment is renamed to onViewCreated(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onActivityCreated(Bundle) in class StatisticsFragment is renamed to onViewCreated(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner"], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onViewCreated(Bundle) in class TasksFragment is changed to onViewCreated(View,Bundle)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onViewCreated(Bundle) in class AddEditTaskFragment is changed to onViewCreated(View,Bundle)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onViewCreated(Bundle) in class TaskDetailFragment is changed to onViewCreated(View,Bundle)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onViewCreated(Bundle) in class StatisticsFragment is changed to onViewCreated(View,Bundle)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method launchFragment(NavController) in class AddEditTaskFragmentTest is changed to launchFragment(TestNavHostController)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "48bb7b5fefe0b9da8e2fa3bb39868af4f32f5f57", "url" : "https://github.com/android/architecture-samples/commit/48bb7b5fefe0b9da8e2fa3bb39868af4f32f5f57", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onRefresh() in class TaskDetailViewModel is renamed to refresh()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method start(String) in class TaskDetailViewModel is changed to start(String,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "498dde087909261b277578edd1c689a61efd8fc9", "url" : "https://github.com/android/architecture-samples/commit/498dde087909261b277578edd1c689a61efd8fc9", "refactorings" : [ { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass BaseViewModel is extracted from children classes AddEditTaskViewModel,StatisticsViewModel,TaskDetailViewModel,TasksViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "4aff2473f2247237ead641e702530762536f50a0", "url" : "https://github.com/android/architecture-samples/commit/4aff2473f2247237ead641e702530762536f50a0", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method loadTasksFromNetwork() in class DefaultTaskRepository is renamed to refresh()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The references to loadTasksFromNetwork() are replaced with refresh(). The behaviour of the method is changed, but it is acceptable as it is a floss refactoring.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DefaultTaskRepository(NetworkDataSource,TaskDao,CoroutineDispatcher) in class DefaultTaskRepository is changed to DefaultTaskRepository(NetworkDataSource,TaskDao,CoroutineDispatcher,CoroutineScope)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method refreshTasks() in class FakeTaskRepository is renamed to refresh()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The body of the method is empty, references are also replaced.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.di.NetworkTaskDataSource is Rename to com.example.android.architecture.blueprints.todoapp.di.DefaultDispatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "515e82c93a69423e831e58948e1e537fa50aee1f", "url" : "https://github.com/android/architecture-samples/commit/515e82c93a69423e831e58948e1e537fa50aee1f", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method start(String,Boolean) in class TaskDetailViewModel is changed to start(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "570c0b592e00fea0319e44e7a46ab23a7e03369c", "url" : "https://github.com/android/architecture-samples/commit/570c0b592e00fea0319e44e7a46ab23a7e03369c", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onResume() in class TasksFragment is renamed to setupSnackbar()", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method handleActivityResult(Int,Int) in class TasksViewModel is renamed to showEditResultMessage(Int,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method showEditResultMessage(Int,Int) in class TasksViewModel is changed to showEditResultMessage(Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The method has been renamed, and its parameter has been changed. RefDetect identifies these refactorings individually.", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method setupSnackbar() in class AddEditTaskFragment is extracted from method onActivityCreated(Bundle) in class AddEditTaskFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method onResume() in class TasksFragment is inlined to method onResume() in class TaskDetailFragment", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "5dec53b48b7dce677f9c2a99dec42166b0d97ddb", "url" : "https://github.com/android/architecture-samples/commit/5dec53b48b7dce677f9c2a99dec42166b0d97ddb", "refactorings" : [ { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method viewAllTasks() in class TasksActivityTest is inlined to method createTwoTasks_deleteOneTask() in class TasksActivityTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method viewAllTasks() in class TasksActivityTest is inlined to method createOneTask_deleteTask() in class TasksActivityTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method createTask(String,String) in class TasksActivityTest is inlined to method createTwoTasks_deleteOneTask() in class TasksActivityTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method createTask(String,String) in class TasksActivityTest is inlined to method createOneTask_deleteTask() in class TasksActivityTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method showAllTasks() in class TasksActivityTest is moved to class TasksFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Tests are moved to a new class in package test.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method showActiveTasks() in class TasksActivityTest is moved to class TasksFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Tests are moved to a new class in package test.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method showCompletedTasks() in class TasksActivityTest is moved to class TasksFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Tests are moved to a new class in package test.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method clearCompletedTasks() in class TasksActivityTest is moved to class TasksFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Tests are moved to a new class in package test.", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "a3d0c076e6aab1abcf403a903a8dc077ef332ed9", "url" : "https://github.com/android/architecture-samples/commit/a3d0c076e6aab1abcf403a903a8dc077ef332ed9", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method filterItems(List,TasksFilterType) in class TasksViewModel is renamed to filterTasks(List,TasksFilterType)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.Result.Error is Move to com.example.android.architecture.blueprints.todoapp.util.Async.Error", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method produceStatisticsUiState(Async) in class StatisticsViewModel is changed to produceStatisticsUiState(Async)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "produceStatisticsUiState(taskLoad: Async>>) is changed to produceStatisticsUiState(taskLoad: Async>)", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Error(Exception) in class Error is changed to Error(Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setReturnError(Boolean) in class FakeRepository is renamed to setShouldThrowError(Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field shouldReturnError in class FakeRepository is rename to shouldThrowError", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getTasks_WithDirtyCache_remoteUnavailable_error() in class DefaultTasksRepositoryTest is renamed to getTasks_WithDirtyCache_remoteUnavailable_throwsException()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getTasks_WithBothDataSourcesUnavailable_returnsError() in class DefaultTasksRepositoryTest is renamed to getTasks_WithBothDataSourcesUnavailable_throwsError()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "b5d947c4ab4867e65d9fc110b404a6fd964c4ef1", "url" : "https://github.com/android/architecture-samples/commit/b5d947c4ab4867e65d9fc110b404a6fd964c4ef1", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method loadTasksFromNetwork() in class DefaultTaskRepository is renamed to refresh()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DefaultTaskRepository(NetworkDataSource,TaskDao,CoroutineDispatcher) in class DefaultTaskRepository is changed to DefaultTaskRepository(NetworkDataSource,TaskDao,CoroutineDispatcher,CoroutineScope)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method refreshTasks() in class FakeTaskRepository is renamed to refresh()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.di.NetworkTaskDataSource is Rename to com.example.android.architecture.blueprints.todoapp.di.DefaultDispatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "c531c353d874f6f863181f9eaea4ef78a4a90b60", "url" : "https://github.com/android/architecture-samples/commit/c531c353d874f6f863181f9eaea4ef78a4a90b60", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.remote.TaskStatus is Move to com.example.android.architecture.blueprints.todoapp.data.source.network.TaskStatus", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.NetworkDataSource is Move to com.example.android.architecture.blueprints.todoapp.data.source.network.NetworkDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.DefaultTasksRepository is Move to com.example.android.architecture.blueprints.todoapp.data.DefaultTasksRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.remote.NetworkTask is Move to com.example.android.architecture.blueprints.todoapp.data.source.network.NetworkTask", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.TasksRepository is Move to com.example.android.architecture.blueprints.todoapp.data.TasksRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.example.android.architecture.blueprints.todoapp.data.source.FakeRepository is MoveAndRename to com.example.android.architecture.blueprints.todoapp.data.FakeTasksRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.FakeNetworkDataSource is Move to com.example.android.architecture.blueprints.todoapp.data.source.network.FakeNetworkDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.FakeTasksDao is Move to com.example.android.architecture.blueprints.todoapp.data.source.local.FakeTasksDao", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.DefaultTasksRepositoryTest is Move to com.example.android.architecture.blueprints.todoapp.data.DefaultTasksRepositoryTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "These classes are defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.source.remote.TasksNetworkDataSource is Move to com.example.android.architecture.blueprints.todoapp.data.source.network.TasksNetworkDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "These classes are defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "d402dae442a482923e0e45d2eb82046777ff1742", "url" : "https://github.com/android/architecture-samples/commit/d402dae442a482923e0e45d2eb82046777ff1742", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method markTaskAsAcompleteAndActiveOnDetailScreen_taskIsActiveInList() in class TasksScreenTest is renamed to markTaskAsCompleteAndActiveOnDetailScreen_taskIsActiveInList()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clickOnAndroidHomeIcon_OpensNavigation() in class AppNavigationTest is renamed to statsScreen_clickOnAndroidHomeIcon_OpensNavigation()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "clickOnAndroidHomeIcon_OpensNavigation() is replaced with two methods. So, both can be accepted as Rename.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clickOnAndroidHomeIcon_OpensNavigation() in class AppNavigationTest is renamed to tasksScreen_clickOnAndroidHomeIcon_OpensNavigation()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "clickOnAndroidHomeIcon_OpensNavigation() is replaced with two methods. So, both can be accepted as Rename.", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "e43a301c2a247ab957dae8100d789d8b5238195c", "url" : "https://github.com/android/architecture-samples/commit/e43a301c2a247ab957dae8100d789d8b5238195c", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.tasks.TasksScreenTest is Rename to com.example.android.architecture.blueprints.todoapp.tasks.TasksActivityTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.addedittask.AddEditTaskScreenTest is Rename to com.example.android.architecture.blueprints.todoapp.addedittask.AddEditTaskFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The class is defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.statistics.StatisticsScreenTest is Rename to com.example.android.architecture.blueprints.todoapp.statistics.StatisticsFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The class is defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.taskdetail.TaskDetailScreenTest is Rename to com.example.android.architecture.blueprints.todoapp.taskdetail.TaskDetailFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The class is defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.tasks.TasksSingleScreenTest is Rename to com.example.android.architecture.blueprints.todoapp.tasks.TasksFragmentTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The class is defined in the folder test. Need to allow RefDetect to check classes in folder test as well.", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "f01fcad4193091f41352e8575d10f7718f61240e", "url" : "https://github.com/android/architecture-samples/commit/f01fcad4193091f41352e8575d10f7718f61240e", "refactorings" : [ { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method saveTask(Task) in class TasksDataSource is changed to saveTask(NetworkTask) and moved to class NetworkDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Abstract method defined in the interface.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DefaultTasksRepository(TasksDataSource,TasksDataSource) in class DefaultTasksRepository is changed to DefaultTasksRepository(NetworkDataSource,TasksDao)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method insertTask(Task) in class TasksDao is changed to insertTask(LocalTask)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method updateTask(Task) in class TasksDao is changed to updateTask(LocalTask)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class NetworkDataSource is extracted from class TasksDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It is a rename class.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method clearCompletedTasks() in class TasksDataSource is moved to class NetworkDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method deleteTask(String) in class TasksDataSource is moved to class NetworkDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.example.android.architecture.blueprints.todoapp.di.LocalTasksDataSource is MoveAndRename to com.example.android.architecture.blueprints.todoapp.data.source.local.LocalTask", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.data.source.TasksDataSource is Rename to com.example.android.architecture.blueprints.todoapp.data.source.NetworkDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.example.android.architecture.blueprints.todoapp.data.source.local.TasksLocalDataSource is MoveAndRename to com.example.android.architecture.blueprints.todoapp.data.source.FakeNetworkDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "FakeDataSource is renamed to FakeNetworkDataSource", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.android.architecture.blueprints.todoapp.data.source.remote.TasksRemoteDataSource is Rename to com.example.android.architecture.blueprints.todoapp.data.source.remote.TasksNetworkDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "TasksRemoteDataSource is defined as object.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getTasks() in class TasksNetworkDataSource is renamed to loadTasks()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class FakeTasksDao is extracted from class TasksLocalDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getTasks() in class NetworkDataSource is renamed to loadTasks()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/architecture-samples", "sha1" : "ffda0f1102e1e929e9c19b051af650519efea67d", "url" : "https://github.com/android/architecture-samples/commit/ffda0f1102e1e929e9c19b051af650519efea67d", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.android.architecture.blueprints.todoapp.data.TasksLocalDataSourceTest is Move to com.example.android.architecture.blueprints.todoapp.data.source.local.TasksLocalDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.example.android.architecture.blueprints.todoapp.data.source.local.TasksPersistenceContract is MoveAndRename to com.example.android.architecture.blueprints.todoapp.util.AppExecutors", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "07647f9c5bc0aa7923522cdfa7837266bb053d00", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/07647f9c5bc0aa7923522cdfa7837266bb053d00", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HomeAdapter(MutableList) in class HomeAdapter is changed to HomeAdapter(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method success(List) in class RequestCallBack is changed to success(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getItemViewType(Int,List) in class HomeTopHeaderAdapter is changed to getItemViewType(Int,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "1b6c801385ad8461fcede8d2a91338ff7bb60617", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/1b6c801385ad8461fcede8d2a91338ff7bb60617", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method addData(Collection) in class BaseQuickAdapter is renamed to addAll(Collection)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setData(Int,T) in class BaseQuickAdapter is renamed to set(Int,T)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method hasEmptyView() in class BaseQuickAdapter is renamed to displayEmptyView()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setEmptyView(Int) in class BaseQuickAdapter is renamed to setEmptyViewLayout(Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.OnItemChildClickListener is Move to com.chad.library.adapter.base.BrvahAdapter.OnItemChildClickListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.AnimationType is Move to com.chad.library.adapter.base.BrvahAdapter.AnimationType", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.OnItemClickListener is Move to com.chad.library.adapter.base.BrvahAdapter.OnItemClickListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.OnItemLongClickListener is Move to com.chad.library.adapter.base.BrvahAdapter.OnItemLongClickListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.OnViewAttachStateChangeListener is Move to com.chad.library.adapter.base.BrvahAdapter.OnViewAttachStateChangeListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.BaseQuickAdapter.OnItemChildLongClickListener is Move to com.chad.library.adapter.base.BrvahAdapter.OnItemChildLongClickListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onItemChildClick(BaseQuickAdapter,View,Int) in class OnItemChildClickListener is changed to onItemChildClick(BrvahAdapter,View,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onItemClick(BaseQuickAdapter,View,Int) in class OnItemClickListener is changed to onItemClick(BrvahAdapter,View,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onItemLongClick(BaseQuickAdapter,View,Int) in class OnItemLongClickListener is changed to onItemLongClick(BrvahAdapter,View,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onItemChildLongClick(BaseQuickAdapter,View,Int) in class OnItemChildLongClickListener is changed to onItemChildLongClick(BrvahAdapter,View,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface BrvahAdapter is extracted from classes BaseQuickAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method bindViewClickListener(VH,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method addAnimation(ViewHolder) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method setAnimationWithDefault(AnimationType) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onViewAttachedToWindow(ViewHolder) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onBindViewHolder(ViewHolder,Int,MutableList) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getViewByPosition(Int,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onCreateViewHolder(ViewGroup,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method setStaggeredGridFullSpan(ViewHolder) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemViewType(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onAttachedToRecyclerView(RecyclerView) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onItemChildClick(View,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onItemChildLongClick(View,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method addOnViewAttachStateChangeListener(OnViewAttachStateChangeListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemPosition(T) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onBindViewHolder(ViewHolder,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method displayEmptyView() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemCount() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getOnItemClickListener() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getOnItemLongClickListener() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItem(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method removeOnItemChildClickListener(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method removeOnItemChildLongClickListener(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method addOnItemChildClickListener(Int,OnItemChildClickListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method addOnItemChildLongClickListener(Int,OnItemChildLongClickListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onBindViewHolder(VH,Int,T) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onCreateViewHolder(Context,ViewGroup,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onBindViewHolder(VH,Int,T,List) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method clearOnViewAttachStateChangeListener() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemCount(List) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemId(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onDetachedFromRecyclerView(RecyclerView) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method setEmptyViewLayout(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method setOnItemClickListener(OnItemClickListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method setOnItemLongClickListener(OnItemLongClickListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onItemClick(View,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onItemLongClick(View,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method startAnim(Animator,Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method isFullSpanItem(Int) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onViewDetachedFromWindow(ViewHolder) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method removeOnViewAttachStateChangeListener(OnViewAttachStateChangeListener) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mOnItemChildClickArray in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mOnItemChildLongClickArray in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field onViewAttachStateChangeListeners in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field recyclerViewOrNull in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field EMPTY_VIEW in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mOnItemClickListener in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mOnItemLongClickListener in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field adapterAnimation in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field animationEnable in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field isAnimationFirstOnly in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field isUseEmpty in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mDraggableModule in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field mLastPosition in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getItemCount(List) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getItemViewType(Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onBindViewHolder(RecyclerView.ViewHolder,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onBindViewHolder(RecyclerView.ViewHolder,Int,MutableList) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getItemId(Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onViewAttachedToWindow(RecyclerView.ViewHolder) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onViewDetachedFromWindow(RecyclerView.ViewHolder) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onAttachedToRecyclerView(RecyclerView) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onDetachedFromRecyclerView(RecyclerView) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method bindViewClickListener(VH,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onItemClick(View,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onItemLongClick(View,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onItemChildClick(View,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getItemPosition(T?) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method isFullSpanItem(Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method setStaggeredGridFullSpan(RecyclerView.ViewHolder) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getViewByPosition(Int,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method addAnimation(RecyclerView.ViewHolder) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method startAnim(Animator,Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method setAnimationWithDefault(AnimationType) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method setOnItemClickListener(OnItemClickListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method setOnItemLongClickListener(OnItemLongClickListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method addOnItemChildClickListener(Int,OnItemChildClickListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method removeOnItemChildClickListener(Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method addOnItemChildLongClickListener(Int,OnItemChildLongClickListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method removeOnItemChildLongClickListener(Int) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method addOnViewAttachStateChangeListener(OnViewAttachStateChangeListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method removeOnViewAttachStateChangeListener(OnViewAttachStateChangeListener) in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method clearOnViewAttachStateChangeListener() in class BaseQuickAdapter is moved to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is PullUp Method. KotlinRMiner detects some of PullUP correctly, but detect some of them as move method.", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method checkModule() in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getItemViewType(Int,List) in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field draggableModule in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field recyclerView in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field context in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field isEmptyViewHolder in class BaseQuickAdapter is pulled up to class BrvahAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "207198911c1ee1783751161c73b4f869c538932d", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/207198911c1ee1783751161c73b4f869c538932d", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setStaggeredGridFullSpan(ViewHolder) in class BaseQuickAdapter is renamed to asStaggeredGridFullSpan(ViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by Both.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method asStaggeredGridFullSpan(ViewHolder) in class BaseQuickAdapter is changed to asStaggeredGridFullSpan()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by Both.", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "2587c1476efe93a10a75debccac7d3191ac1849a", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/2587c1476efe93a10a75debccac7d3191ac1849a", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clearfooter() in class QuickAdapterHelper is renamed to clearFooter()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QuickAdapterHelper(BaseQuickAdapter,LeadingLoadStateAdapter,TrailingLoadStateAdapter,Config,DragAndSwipeImpl) in class QuickAdapterHelper is changed to QuickAdapterHelper(BaseQuickAdapter,LeadingLoadStateAdapter,TrailingLoadStateAdapter,Config)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class Builder is extracted from class DefaultDragAndSwipe", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "An inner class is created.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field _dragMoveFlags in class DefaultDragAndSwipe is moved to class Builder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field _swipeMoveFlags in class DefaultDragAndSwipe is moved to class Builder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method startDrag(Int) in class QuickAdapterHelper is inlined to method startDrag(RecyclerView.ViewHolder) in class DefaultDragAndSwipe", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method startDrag(Int) in class QuickAdapterHelper is inlined to method startDrag(Int) in class DefaultDragAndSwipe", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method startSwipe(Int) in class QuickAdapterHelper is inlined to method startSwipe(RecyclerView.ViewHolder) in class DefaultDragAndSwipe", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method startSwipe(Int) in class QuickAdapterHelper is inlined to method startSwipe(Int) in class DefaultDragAndSwipe", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "2870bd0272d0b9c8dd801d54b1050331d748c225", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/2870bd0272d0b9c8dd801d54b1050331d748c225", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.HomeAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.home.adapter.HomeAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass BaseActivity2 is extracted from children classes BaseViewBindingActivity", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no information about intermediate changes, it is not possible to say the refactoring is true or false.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(QuickViewHolder,Int,String) in class HeaderDragAndSwipeAdapter is changed to onBindViewHolder(QuickViewHolder,Int,String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(RecyclerView.ViewHolder,Int,T) in class BaseMultiItemQuickAdapter is changed to onBindViewHolder(RecyclerView.ViewHolder,Int,T?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(RecyclerView.ViewHolder,Int,T,List) in class BaseMultiItemQuickAdapter is changed to onBindViewHolder(RecyclerView.ViewHolder,Int,T?,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(VH,Int,T,List) in class BaseQuickAdapter is changed to onBindViewHolder(VH,Int,T?,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass BaseViewBindingActivity is extracted from children classes AnimationUseActivity,EmptyViewUseActivity,HeaderAndFooterUseActivity,ItemClickActivity", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "29dc3c5fd1642a028e34ba847f3299fe3581431a", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/29dc3c5fd1642a028e34ba847f3299fe3581431a", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.FooterAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.headerfooter.adapter.FooterAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.CustomLoadMoreAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.loadmore.adapter.CustomLoadMoreAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.HeaderAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.headerfooter.adapter.HeaderAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.activity.HomeActivity is Move to com.chad.baserecyclerviewadapterhelper.activity.home.HomeActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.HeaderDragAndSwipeAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.dragswipe.adapter.HeaderDragAndSwipeAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.baserecyclerviewadapterhelper.adapter.HomeTopHeaderAdapter is Move to com.chad.baserecyclerviewadapterhelper.activity.home.adapter.HomeTopHeaderAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "2d1dbaac06e650bed845e794236ee1ea4b488200", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/2d1dbaac06e650bed845e794236ee1ea4b488200", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setAnimationWithDefault(AnimationType) in class BaseQuickAdapter is renamed to setItemAnimation(AnimationType)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startAnim(Animator,Int) in class BaseQuickAdapter is changed to startAnim(Animator,ViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field adapterAnimation in class BaseQuickAdapter is rename to itemAnimation", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "53644d00014beeec5f339942f96c7096cdbd8331", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/53644d00014beeec5f339942f96c7096cdbd8331", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expandAndCollapseOther(Int,Boolean,Boolean,Boolean,Boolean) in class BaseNodeAdapter is changed to expandAndCollapseOther(Int,Boolean,Boolean,Boolean,Boolean,Any,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expand(Int,Boolean,Boolean,Boolean) in class BaseNodeAdapter is changed to expand(Int,Boolean,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method collapse(Int,Boolean,Boolean,Boolean) in class BaseNodeAdapter is changed to collapse(Int,Boolean,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expandOrCollapse(Int,Boolean,Boolean) in class BaseNodeAdapter is changed to expandOrCollapse(Int,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method collapse(Int,Boolean,Boolean) in class BaseNodeAdapter is changed to collapse(Int,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method collapseAndChild(Int,Boolean,Boolean) in class BaseNodeAdapter is changed to collapseAndChild(Int,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expand(Int,Boolean,Boolean) in class BaseNodeAdapter is changed to expand(Int,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expandAndChild(Int,Boolean,Boolean) in class BaseNodeAdapter is changed to expandAndChild(Int,Boolean,Boolean,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method expandAndCollapseOther(Int,Boolean,Boolean,Boolean,Boolean,Any?) in class BaseNodeAdapter is changed to expandAndCollapseOther(Int,Boolean,Boolean,Boolean,Boolean,Any?,Any?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "8c5573f5d122296c5712a12d6a1cc5485d6cc090", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/8c5573f5d122296c5712a12d6a1cc5485d6cc090", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getItemPosition(T) in class BaseQuickAdapter is renamed to itemIndexOfFirst(T)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method itemIndexOfFirst(T?) in class BaseQuickAdapter is changed to itemIndexOfFirst(T)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "8feacd1efe25a7af2874e09c340546f728fadfe7", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/8feacd1efe25a7af2874e09c340546f728fadfe7", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method TrailingLoadMoreVH(ViewGroup,BrvahTrailingLoadMoreBinding) in class TrailingLoadMoreVH is renamed to TrailingLoadStateVH(ViewGroup,BrvahTrailingLoadMoreBinding)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.chad.library.adapter.base.loadState.LeadingLoadStateAdapter is Move to com.chad.library.adapter.base.loadState.leading.LeadingLoadStateAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.loadState.trailing.TrailingLoadMoreVH is Rename to com.chad.library.adapter.base.loadState.trailing.TrailingLoadStateVH", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "aa1ed6ebf896411bef0b7650a0603729e9c66ebc", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/aa1ed6ebf896411bef0b7650a0603729e9c66ebc", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method loadMoreAction() in class TrailingLoadStateAdapter is renamed to loadAction()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass DefaultTrailingLoadStateAdapter is extracted from parent class TrailingLoadStateAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getStateViewType(LoadState) in class TrailingLoadStateAdapter is pushed down to class DefaultTrailingLoadStateAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QuickAdapterHelper(Adapter,LoadStateAdapter,TrailingLoadStateAdapter,Config) in class QuickAdapterHelper is changed to QuickAdapterHelper(BaseQuickAdapter,LeadingLoadStateAdapter,TrailingLoadStateAdapter,Config)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setLeadingLoadStateAdapter(LoadStateAdapter) in class Builder is changed to setLeadingLoadStateAdapter(LeadingLoadStateAdapter)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setTrailingLoadStateAdapter(TrailingLoadStateAdapter) in class Builder is changed to setTrailingLoadStateAdapter(TrailingLoadStateAdapter)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onViewAttachedToWindow(TrailingViewHolder) in class TrailingLoadStateAdapter is changed to onViewAttachedToWindow(VH)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class DefaultLeadingLoadStateAdapter is extracted from class TrailingLoadStateAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "bb45af37cb1f3cc0da4af9b8325620374e874f3b", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/bb45af37cb1f3cc0da4af9b8325620374e874f3b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreateViewHolder(ViewGroup,Int) in class HeaderAdapter is changed to onCreateViewHolder(Context,ViewGroup,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(VH,Int) in class HeaderAdapter is changed to onBindViewHolder(VH,Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setOnItemLongClickListener(OnItemClickListener?) in class BaseSingleItemAdapter is changed to setOnItemLongClickListener(((BaseSingleItemAdapter,View,T?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setOnItemClickListener(OnItemClickListener) in class BaseSingleItemAdapter is renamed to setOnItemLongClickListener(((BaseSingleItemAdapter,View,T?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "bbc5bd8e33db0a2d812992b491827936134b3787", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/bbc5bd8e33db0a2d812992b491827936134b3787", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method convert(BaseViewHolder,Int,LoadMoreStatus) in class BaseLoadMoreView is changed to convert(QuickViewHolder,Int,LoadMoreStatus)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadComplete(BaseViewHolder) in class SimpleLoadMoreView is changed to getLoadComplete(QuickViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadEndView(BaseViewHolder) in class SimpleLoadMoreView is changed to getLoadEndView(QuickViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadFailView(BaseViewHolder) in class SimpleLoadMoreView is changed to getLoadFailView(QuickViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadingView(BaseViewHolder) in class SimpleLoadMoreView is changed to getLoadingView(QuickViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadComplete(BaseViewHolder) in class BaseLoadMoreView is changed to getLoadComplete(QuickViewHolder)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadEndView(BaseViewHolder) in class BaseLoadMoreView is changed to getLoadEndView(QuickViewHolder)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadFailView(BaseViewHolder) in class BaseLoadMoreView is changed to getLoadFailView(QuickViewHolder)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getLoadingView(BaseViewHolder) in class BaseLoadMoreView is changed to getLoadingView(QuickViewHolder)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class QuickViewHolder is extracted from class BaseViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It is a rename class.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field views in class BaseViewHolder is moved to class QuickViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getViewOrNull(Int) in class BaseViewHolder is moved to class QuickViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getView(Int) in class BaseViewHolder is moved to class QuickViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method findView() in class BaseViewHolder is moved to class QuickViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.viewholder.BaseViewHolder is Rename to com.chad.library.adapter.base.viewholder.QuickViewHolder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "c1c027504d63e55784a671b0f45b23f1d938c381", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/c1c027504d63e55784a671b0f45b23f1d938c381", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.dragswipe.DragAndSwipeCallback is Rename to com.chad.library.adapter.base.dragswipe.DefaultDragAndSwipe", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QuickAdapterHelper(BaseQuickAdapter,LeadingLoadStateAdapter,TrailingLoadStateAdapter,Config) in class QuickAdapterHelper is changed to QuickAdapterHelper(BaseQuickAdapter,LeadingLoadStateAdapter,TrailingLoadStateAdapter,Config,DragAndSwipeImpl)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface DragAndSwipeImpl is extracted from classes DefaultDragAndSwipe", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field mItemTouchHelper in class DragAndSwipeCallback is rename to _itemTouchHelper", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field baseQuickAdapter in class DragAndSwipeCallback is rename to mBaseQuickAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field mRecyclerView in class DragAndSwipeCallback is rename to recyclerView", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field swipeMoveFlags in class DragAndSwipeCallback is rename to _swipeMoveFlags", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "c50965893a7ae7833940bda59d7f045d32cfa534", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/c50965893a7ae7833940bda59d7f045d32cfa534", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.BaseMultiItemQuickAdapter.OnViewHolderListener is Rename to com.chad.library.adapter.base.BaseMultiItemQuickAdapter.OnMultiItemAdapterListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method addItemType(Int,Class,OnViewHolderListener) in class BaseMultiItemQuickAdapter is changed to addItemType(Int,Class,OnMultiItemAdapterListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method addItemType(Int,OnViewHolderListener) in class BaseMultiItemQuickAdapter is changed to addItemType(Int,OnMultiItemAdapterListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "dbe23d122ebc0b0f6b6ac3b609aaef0a022f9463", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/dbe23d122ebc0b0f6b6ac3b609aaef0a022f9463", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setOnItemClick(View,Int) in class BaseQuickAdapter is renamed to onItemClick(View,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setOnItemLongClick(View,Int) in class BaseQuickAdapter is renamed to onItemLongClick(View,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setOnItemClickListener(OnItemClickListener) in class BaseQuickAdapter is changed to setOnItemClickListener(OnItemClickListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setOnItemLongClickListener(OnItemLongClickListener) in class BaseQuickAdapter is changed to setOnItemLongClickListener(OnItemLongClickListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method setOnItemChildLongClick(View,Int) in class BaseQuickAdapter is renamed to onItemChildLongClick(View,Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "dd42634ec1c2e642a32506014863cbcdde6d9200", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/dd42634ec1c2e642a32506014863cbcdde6d9200", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method add(T) in class BaseSingleItemAdapter is changed to add(Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method add(T) in class BaseSingleItemAdapter is changed to add(Int,Any)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" },{ "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method add(Int,T) in class BaseSingleItemAdapter is changed to add(Int,Any)", "detectionTools" : [ "KotlinRMiner", "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method addAll(Collection) in class BaseSingleItemAdapter is changed to addAll(Collection)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method remove(T) in class BaseSingleItemAdapter is changed to remove(Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method submitList(List) in class BaseSingleItemAdapter is changed to submitList(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method add(Int,T) in class BaseSingleItemAdapter is changed to add(Any)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method addAll(Int,Collection) in class BaseSingleItemAdapter is changed to addAll(Int,Collection)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method set(Int,T) in class BaseSingleItemAdapter is changed to set(Int,Any)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getItemCount(List) in class BaseSingleItemAdapter is changed to getItemCount(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(VH,Int,T,List) in class BaseSingleItemAdapter is changed to onBindViewHolder(VH,Int,Any,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(VH,Int,T?) in class BaseSingleItemAdapter is changed to onBindViewHolder(VH,Int,Any?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "dd523d04df1d6c4d3b7989b13806e205bf7db464", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/dd523d04df1d6c4d3b7989b13806e205bf7db464", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method addAnimation(ViewHolder) in class BaseQuickAdapter is renamed to runAnimator(ViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method startItemAnim(Animator,ViewHolder) in class BaseQuickAdapter is renamed to startItemAnimator(Animator,ViewHolder)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.animation.ItemAnimation is Rename to com.chad.library.adapter.base.animation.ItemAnimator", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "e4234c1287427c27d7b21d646a107da155b2c70c", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/e4234c1287427c27d7b21d646a107da155b2c70c", "refactorings" : [ { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method removeNodesAt(Int) in class BaseNodeAdapter is extracted from method removeAt(Int) in class BaseNodeAdapter", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method removeAt(Int) in class BaseQuickAdapter is extracted from method remove(Int) in class BaseQuickAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method remove(Int) in class BaseNodeAdapter is renamed to removeAt(Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method removeAt(Int) in class BaseNodeAdapter is renamed to removeNodesAt(Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper", "sha1" : "e77a6cacacf15e669bb5716ea55e1d39fd5e1f6f", "url" : "https://github.com/CymChad/BaseRecyclerViewAdapterHelper/commit/e77a6cacacf15e669bb5716ea55e1d39fd5e1f6f", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method animators(View) in class SlideInRightAnimation is renamed to animator(View)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method animators(View) in class SlideInLeftAnimation is renamed to animator(View)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method animators(View) in class SlideInBottomAnimation is renamed to animator(View)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method animators(View) in class AlphaInAnimation is renamed to animator(View)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method animators(View) in class ScaleInAnimation is renamed to animator(View)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.chad.library.adapter.base.animation.BaseAnimation is Rename to com.chad.library.adapter.base.animation.ItemAnimation", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScaleInAnimation(Float) in class ScaleInAnimation is changed to ScaleInAnimation(Long,Float)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method AlphaInAnimation(Float) in class AlphaInAnimation is changed to AlphaInAnimation(Long,Float)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "b6ed80b37e1de9aecdc9ba6b77f9bd8c749b517f", "url" : "https://github.com/square/leakcanary/commit/b6ed80b37e1de9aecdc9ba6b77f9bd8c749b517f", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.LeakSentryInstaller is Move to leakcanary.internal.LeakSentryInstaller", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AndroidHeapDumper is Move to leakcanary.AndroidHeapDumper", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.InstrumentationTestApplication is Move to leakcanary.InstrumentationTestApplication", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.InternalLeakSentry is Move to leakcanary.internal.InternalLeakSentry", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HeapDumpMemoryStore is Move to leakcanary.internal.HeapDumpMemoryStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.TestActivity is Move to leakcanary.TestActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakDirectoryProvider is Move to leakcanary.LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.LeakSentry is Move to leakcanary.LeakSentry", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.LeakCanarySingleThreadFactory is Move to leakcanary.internal.LeakCanarySingleThreadFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.GcTrigger is Move to leakcanary.GcTrigger", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.LeakCanaryFileProvider is Move to leakcanary.internal.LeakCanaryFileProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.RowElementLayout is Move to leakcanary.internal.RowElementLayout", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.LeakCanaryInternals is Move to leakcanary.internal.LeakCanaryInternals", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.HeapAnalyzerService is Move to leakcanary.internal.HeapAnalyzerService", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.AndroidOFragmentDestroyWatcher is Move to leakcanary.internal.AndroidOFragmentDestroyWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.Exclusion is Move to leakcanary.Exclusion", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.DebuggerControl is Move to leakcanary.DebuggerControl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.example.leakcanary.tests.TuPeuxPasTest is Move to leakcanary.tests.TuPeuxPasTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.MoreDetailsView is Move to leakcanary.internal.MoreDetailsView", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.FailTestOnLeakRunListener is Move to leakcanary.FailTestOnLeakRunListener", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.InternalLeakCanary is Move to leakcanary.internal.InternalLeakCanary", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.ViewLeakingFragment is Move to leakcanary.ViewLeakingFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakNode is Move to leakcanary.LeakNode", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AnalyzedHeap is Move to leakcanary.AnalyzedHeap", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.InstrumentationLeakDetectorTest is Move to leakcanary.InstrumentationLeakDetectorTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakTrace is Move to leakcanary.LeakTrace", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.FragmentLeakTest is Move to leakcanary.FragmentLeakTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HahaHelper is Move to leakcanary.HahaHelper", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakTraceElement is Move to leakcanary.LeakTraceElement", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.Reachability is Move to leakcanary.Reachability", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.DisplayLeakService is Move to leakcanary.DisplayLeakService", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.LeakCanaryReceiver is Move to leakcanary.internal.LeakCanaryReceiver", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HeapDumper is Move to leakcanary.HeapDumper", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AnalyzerProgressListener is Move to leakcanary.AnalyzerProgressListener", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakCanary is Move to leakcanary.LeakCanary", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.AbstractLeakSentryReceiver is Move to leakcanary.AbstractLeakSentryReceiver", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.SquigglySpan is Move to leakcanary.internal.SquigglySpan", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.FutureResult is Move to leakcanary.internal.FutureResult", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HeapDump is Move to leakcanary.HeapDump", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.FragmentDestroyWatcher is Move to leakcanary.internal.FragmentDestroyWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.DefaultLeakDirectoryProvider is Move to leakcanary.DefaultLeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.InstrumentationLeakDetector is Move to leakcanary.InstrumentationLeakDetector", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.CanaryLog is Move to leakcanary.CanaryLog", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AnalysisResult is Move to leakcanary.AnalysisResult", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.ForegroundService is Move to leakcanary.internal.ForegroundService", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.ActivityLifecycleCallbacksAdapter is Move to leakcanary.internal.ActivityLifecycleCallbacksAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.RefWatcher is Move to leakcanary.RefWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.SupportFragmentDestroyWatcher is Move to leakcanary.internal.SupportFragmentDestroyWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.VisibilityTracker is Move to leakcanary.internal.VisibilityTracker", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AndroidDebuggerControl is Move to leakcanary.AndroidDebuggerControl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.RequestStoragePermissionActivity is Move to leakcanary.internal.RequestStoragePermissionActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakReference is Move to leakcanary.LeakReference", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.ShortestPathFinder is Move to leakcanary.ShortestPathFinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.DisplayLeakAdapter is Move to leakcanary.internal.DisplayLeakAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.ServiceHeapDumpListener is Move to leakcanary.ServiceHeapDumpListener", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.LeakingFragment is Move to leakcanary.LeakingFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.DisplayLeakActivity is Move to leakcanary.internal.DisplayLeakActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HeapAnalyzer is Move to leakcanary.HeapAnalyzer", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.ExcludedRefs is Move to leakcanary.ExcludedRefs", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AndroidReachabilityInspectors is Move to leakcanary.AndroidReachabilityInspectors", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.internal.ActivityDestroyWatcher is Move to leakcanary.internal.ActivityDestroyWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.internal.DisplayLeakConnectorView is Move to leakcanary.internal.DisplayLeakConnectorView", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AbstractAnalysisResultService is Move to leakcanary.AbstractAnalysisResultService", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.HeapDumpTrigger is Move to leakcanary.HeapDumpTrigger", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.KeyedWeakReference is Move to leakcanary.KeyedWeakReference", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.AndroidExcludedRefs is Move to leakcanary.AndroidExcludedRefs", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.InstrumentationLeakResults is Move to leakcanary.InstrumentationLeakResults", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leaksentry.Clock is Move to leakcanary.Clock", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalyzer(ExcludedRefs,AnalyzerProgressListener,List,String) in class HeapAnalyzer is changed to HeapAnalyzer(ExcludedRefs,AnalyzerProgressListener,List,String,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalyzer(ExcludedRefs,AnalyzerProgressListener,List) in class HeapAnalyzer is changed to HeapAnalyzer(ExcludedRefs,AnalyzerProgressListener,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "01210bbbfaecb3bcb6057c62b2195366d3bfa4f9", "url" : "https://github.com/square/leakcanary/commit/01210bbbfaecb3bcb6057c62b2195366d3bfa4f9", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method computeLabels(HprofParser,LeakNode) in class ViewLabeler is renamed to invoke(HprofParser,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.AndroidReachabilityInspectors is Rename to leakcanary.AndroidLeakInspectors", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method htmlTitle(LeakTraceElement,Boolean,Reachability,Context) in class DisplayLeakAdapter is changed to htmlTitle(LeakTraceElement,Boolean,Context)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,Boolean,Int,..) in class Config is changed to Config(Boolean,Boolean,Int,ExclusionsFactory,Boolean,List,List,AnalysisResultListener)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakElement(LeakNode) in class PerflibHeapAnalyzer is changed to buildLeakElement(LeakNode,LeakNodeStatusAndReason)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method computeLabels(HprofParser,LeakNode) in class Labeler is renamed to invoke(HprofParser,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method computeLabels(HprofParser,LeakNode) in class AllFieldsLabeler is renamed to invoke(HprofParser,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method computeExpectedReachability(HprofParser,List,List) in class HeapAnalyzer is renamed to computeLeakStatuses(HprofParser,List,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Both Rename and Change Method Parameter happened.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.Labeler is Rename to leakcanary.InstanceDefaultLabeler", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.Labeler.AllFieldsLabeler is Move to leakcanary.AllFieldsLabeler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method checkForLeaks(File,...) in class HeapAnalyzer is changed to checkForLeaks(File,ExclusionsFactory,Boolean,List,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakElement(HprofParser,ChildNode,List) in class HeapAnalyzer is changed to buildLeakElement(HprofParser,ChildNode,List,LeakNodeStatusAndReason)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(HprofParser,List,LeakNode,List) in class HeapAnalyzer is changed to buildLeakTrace(HprofParser,List,LeakNode,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findPaths(HprofParser in class ShortestPathFinder is changed to findPaths(HprofParser,ExclusionsFactory,List,MutableList)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTraces(Boolean,List,List,List,HprofParser,MutableList,MutableMap) in class HeapAnalyzer is changed to buildLeakTraces(Boolean,List,List,List,HprofParser,MutableList,MutableMap)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findShortestPaths(HprofParser in class HeapAnalyzer is changed to findShortestPaths(HprofParser,ExclusionsFactory,List,MutableList)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakTraceElement(LeakReference,Holder,String,ExclusionDescription,List) in class LeakTraceElement is changed to LeakTraceElement(LeakReference,Holder,String,ExclusionDescription,List,LeakNodeStatusAndReason)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakTrace(List,List) in class LeakTrace is changed to LeakTrace(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method computeLeakStatuses(HprofParser,List,List) in class HeapAnalyzer is changed to computeLeakStatuses(HprofParser,List,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Both Rename and Change Method Parameter happened.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.Reachability is Rename to leakcanary.LeakNodeStatus", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "1a8957126a115d80e680de9b89daf23fdadfc1e1", "url" : "https://github.com/square/leakcanary/commit/1a8957126a115d80e680de9b89daf23fdadfc1e1", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,Boolean,Int,Set,List,AnalysisResultListener,Boolean,Int,Boolean) in class Config is changed to Config(Boolean,Boolean,Int,Set,List,AnalysisResultListener,Boolean,Int,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.LeakTraceInspector is Rename to leakcanary.ObjectInspector", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.LeakTraceElementReporter is Rename to leakcanary.ObjectReporter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.AndroidLeakTraceInspectors is Rename to leakcanary.AndroidObjectInspectors", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method computeLeakStatuses(RootNode,List) in class HeapAnalyzer is changed to computeLeakStatuses(RootNode,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "Class LeakTraceInspector is renamed to ObjectInspector. Therefore, parameter type is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(HprofGraph,List,LeakNode) in class HeapAnalyzer is changed to buildLeakTrace(HprofGraph,List,LeakNode)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "Class LeakTraceInspector is renamed to ObjectInspector. Therefore, parameter type is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method checkForLeaks(File,List,Boolean,List) in class HeapAnalyzer is changed to checkForLeaks(File,List,Boolean,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "Class LeakTraceInspector is renamed to ObjectInspector. Therefore, parameter type is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTraces(List,List,HprofGraph,MutableList,MutableMap,List) in class HeapAnalyzer is changed to buildLeakTraces(List,List,HprofGraph,MutableList,MutableMap,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "Class LeakTraceInspector is renamed to ObjectInspector. Therefore, parameter type is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method inspect(HprofGraph,List) in class AppSingletonInspector is changed to inspect(HprofGraph,ObjectReporter)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method resolveStatus(LeakTraceElementReporter) in class HeapAnalyzer is changed to resolveStatus(ObjectReporter)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class LeakTraceElementReporter is renamed to ObjectReporter", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface ObjectInspector is extracted from classes AppSingletonInspector", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "To me Class leakcanary.LeakTraceInspector is Rename to leakcanary.ObjectInspector", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "297fa59817fa8b9f751e57f2e059ba2f426ba68e", "url" : "https://github.com/square/leakcanary/commit/297fa59817fa8b9f751e57f2e059ba2f426ba68e", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Hprof(FileChannel,BufferedSource,HprofReader,Long,HprofVersion,Long) in class Hprof is changed to Hprof(File,HprofHeader)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method parseHeaderOf(File) in class HprofHeader is extracted from method open(File) in class Hprof", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface RandomAccessSourceProvider is extracted from classes DualSourceProvider", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface StreamingSourceProvider is extracted from classes DualSourceProvider", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface DualSourceProvider is extracted from classes ByteArraySourceProvider,FileSourceProvider", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we do not have access to the intermediate changes, we cannot say this refactoring is correct or not.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HprofRecordReader is extracted from class HprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class StreamingHprofReader is extracted from class HprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HprofHeader is extracted from class Hprof", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class shark.HprofVersion is extracted from class shark.Hprof.HprofVersion", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It is line Move Class, then Extract Class. However, class HprofVersion is still in Hprof but with some changes.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field BOOLEAN_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field BYTE_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field CHAR_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field DOUBLE_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field FLOAT_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field LONG_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field SHORT_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field BOOLEAN_SIZE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field BYTE_SIZE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field LONG_SIZE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field SHORT_SIZE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field BYTE_MASK in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field CHAR_SIZE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field supportedVersions in class Hprof is moved to class HprofHeader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field HEAP_DUMP in class HprofReader is moved to class StreamingHprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field HEAP_DUMP_END in class HprofReader is moved to class StreamingHprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field LOAD_CLASS in class HprofReader is moved to class StreamingHprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field STACK_TRACE in class HprofReader is moved to class StreamingHprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field STRING_IN_UTF8 in class HprofReader is moved to class StreamingHprofReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field INT_TYPE in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readClassDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readPrimitiveArrayDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readValue(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readId() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readInstanceDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readObjectArrayDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readInt() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readByteArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readUnsignedByte() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readByte() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readLong() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readShort() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readString(Int,Charset) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readHeapDumpInfoRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skipClassDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readBoolean() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method HprofVersion(String) in class shark.Hprof.HprofVersion is moved to class shark.HprofVersion", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "To me class is moved.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readDouble() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readFloat() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readUnsignedShort() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readBooleanArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readDoubleArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readFloatArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readIntArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readLongArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readShortArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readUtf8(Long) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readIdArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skip(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skip(Long) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readChar() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skipInstanceDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skipPrimitiveArrayDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildIndex(ProguardMapping) in class Builder is changed to buildIndex(ProguardMapping,HprofHeader)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method IndexedPrimitiveArray(Long,PrimitiveType) in class IndexedPrimitiveArray is changed to IndexedPrimitiveArray(Long,PrimitiveType,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method IndexedClass(Long,Long,Int) in class IndexedClass is changed to IndexedClass(Long,Long,Int,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Builder(Boolean,Long,Int,Int,Int,Int,Set) in class Builder is changed to Builder(Boolean,Long,Int,Int,Int,Int,Set,Int,Int,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HprofInMemoryIndex(Int,LongObjectScatterMap,LongLongScatterMap,SortedBytesMap,SortedBytesMap,SortedBytesMap,SortedBytesMap,List,ProguardMapping,Set) in class HprofInMemoryIndex is changed to HprofInMemoryIndex(Int,LongObjectScatterMap,LongLongScatterMap,SortedBytesMap,SortedBytesMap,SortedBytesMap,SortedBytesMap,List,ProguardMapping,Set,Int,Int,Int,Int,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method IndexedObjectArray(Long,Long) in class IndexedObjectArray is changed to IndexedObjectArray(Long,Long,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method IndexedInstance(Long,Long) in class IndexedInstance is changed to IndexedInstance(Long,Long,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface CloseableHeapGraph is extracted from classes HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method updateTrie(ReferencePathNode,List,Int,ParentNode) in class HeapAnalyzer is changed to updateTrie(ReferencePathNode,List,Int,ParentNode,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findResultsInTrie(ParentNode,MutableList) in class HeapAnalyzer is changed to findResultsInTrie(ParentNode,MutableList>)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method deduplicateShortestPaths(List) in class ParentNode is changed to deduplicateShortestPaths(List,List)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "A bug in RefDetect that need to be fixed.", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method findResultsInTrie(ParentNode,MutableList) in class HeapAnalyzer is inlined to method findResultsInTrie(ParentNode,MutableList>) in class HeapAnalyzer", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "ChangeMethodParameter happens.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readCharArray(Int) in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method readUnsignedInt() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skipObjectArrayDumpRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method skipHeapDumpInfoRecord() in class HprofReader is moved to class HprofRecordReader", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method close() in class HprofHeapGraph is extracted from method close() in class Hprof", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "2a8e7fb267732fae8930e613251136e1d593e63b", "url" : "https://github.com/square/leakcanary/commit/2a8e7fb267732fae8930e613251136e1d593e63b", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onLeakSentryInstalled(Application) in class InternalLeakCanary is renamed to invoke(Application)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method watchFragments(Activity) in class AndroidXFragmentDestroyWatcher is renamed to invoke(Activity)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method watchFragments(Activity) in class AndroidOFragmentDestroyWatcher is renamed to invoke(Activity)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method noOpDelegate() in class InternalHelper is moved to class InternalLeakSentry", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is moved in two classes.", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class leakcanary.internal.LeakSentryListener is MoveAndRename to leakcanary.OnInstanceRetainedListener", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method noOpDelegate() in class InternalHelper is moved to class InternalLeakCanary", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is moved in two classes.", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "34d5023720da3ce48641c1584e8c38f0d47a823b", "url" : "https://github.com/square/leakcanary/commit/34d5023720da3ce48641c1584e8c38f0d47a823b", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method createIntent(Context) in class LeakActivity is renamed to createHomeIntent(Context)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.internal.LeakCanaryProcesssAppWatcherInstaller is Rename to leakcanary.internal.LeakCanaryProcessAppWatcherInstaller", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.AndroidDebugHeapAnalyzer is Move to leakcanary.internal.AndroidDebugHeapAnalyzer", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalysisDone(T,PendingIntent) in class HeapAnalysisDone is changed to HeapAnalysisDone(T,Intent)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalysisFailed(HeapAnalysisFailure,PendingIntent) in class HeapAnalysisFailed is changed to HeapAnalysisFailed(HeapAnalysisFailure,Intent)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalysisSucceeded(HeapAnalysisSuccess,Set,PendingIntent) in class HeapAnalysisSucceeded is changed to HeapAnalysisSucceeded(HeapAnalysisSuccess,Set,Intent)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field backgroundHandler in class BackgroundThreadHeapAnalyzer is rename to heapAnalyzerThreadHandler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.internal.AppWatcherInstaller is Rename to leakcanary.internal.MainProcessAppWatcherInstaller", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class leakcanary.internal.StoppableFileSourceProvider is MoveAndRename to shark.ThrowingCancelableFileSourceProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method analyzeHeap(File,OnAnalysisProgressListener) in class AndroidDebugHeapAnalyzer is changed to analyzeHeap(File,OnAnalysisProgressListener,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "41c69a5d424b4236114c5ce1b077afdad38e57a5", "url" : "https://github.com/square/leakcanary/commit/41c69a5d424b4236114c5ce1b077afdad38e57a5", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method scheduleRetainedInstanceCheck(String,Long) in class HeapDumpTrigger is renamed to scheduleRetainedObjectCheck(String,Long)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method showNoMoreRetainedInstanceNotification() in class HeapDumpTrigger is renamed to showNoMoreRetainedObjectNotification()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method checkRetainedInstances(String) in class HeapDumpTrigger is renamed to checkRetainedObjects(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method scheduleRetainedInstanceCheck(String) in class HeapDumpTrigger is renamed to scheduleRetainedObjectCheck(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onReferenceRetained() in class InternalLeakCanary is renamed to onObjectRetained()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onReferenceRetained() in class HeapDumpTrigger is renamed to onObjectRetained()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method invoke(Application,HeapAnalysis) in class DefaultAnalysisResultListener is renamed to onHeapAnalyzed(Application,HeapAnalysis)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both detected by RefDetect.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.DefaultAnalysisResultListener is Rename to leakcanary.DefaultOnHeapAnalyzedListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onHeapAnalyzed(Application,HeapAnalysis) in class DefaultAnalysisResultListener is changed to onHeapAnalyzed(HeapAnalysis)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,Boolean,Int,List,List,AnalysisResultListener,Boolean,Int,Boolean,Boolean) in class Config is changed to Config(Boolean,Boolean,Int,List,List,OnHeapAnalyzedListener,Boolean,Int,Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface OnHeapAnalyzedListener is extracted from classes DefaultOnHeapAnalyzedListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field lastDisplayedRetainedInstanceCount in class HeapDumpTrigger is rename to lastDisplayedRetainedObjectCount", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method indexedClass(String) in class HprofGraph is renamed to findClassByClassName(String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method indexedObject(Long) in class HprofGraph is renamed to findObjectByObjectId(Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method objectIdExists(Long) in class HprofGraph is renamed to objectExists(Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.FieldValuesReader is Move to leakcanary.internal.FieldValuesReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.RefWatcherTest is Rename to leakcanary.ObjectWatcherTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.ReferencePathNode is Move to leakcanary.internal.ReferencePathNode", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ObjectWatcher is extracted from class RefWatcher", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems a rename class.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method watch(Any,String) in class RefWatcher is moved to class ObjectWatcher", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method moveToRetained(String) in class RefWatcher is moved to class ObjectWatcher", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.Serializables is Move to leakcanary.internal.Serializables", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "4d5992a28fe5d4b2940c28c47ce5e66ef37816cd", "url" : "https://github.com/square/leakcanary/commit/4d5992a28fe5d4b2940c28c47ce5e66ef37816cd", "refactorings" : [ { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method cleanupOldHeapDumps() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method requestWritePermissionNotification() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method externalStorageDirectory() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method appStorageDirectory() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method directoryWritableAfterMkdirs(File) in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method hasStoragePermission() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field context in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field permissionNotificationDisplayed in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field writeExternalStorageGranted in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method listFiles(FilenameFilter) in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method hasPendingHeapDump() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method newHeapDumpFile() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method clearLeakDirectory() in class DefaultLeakDirectoryProvider is pulled up to class LeakDirectoryProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "4fd47950f8d0f3c4583136b9a36144db1eb027bd", "url" : "https://github.com/square/leakcanary/commit/4fd47950f8d0f3c4583136b9a36144db1eb027bd", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.tests.FragmentLeakTest is Move to com.squareup.leakcanary.FragmentLeakTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.tests.LeakingFragment is Move to com.squareup.leakcanary.LeakingFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.tests.ViewLeakingFragment is Move to com.squareup.leakcanary.ViewLeakingFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.KeyedWeakReference is Move to leaksentry.KeyedWeakReference", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.RefWatcher is Move to leaksentry.RefWatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.tests.TestActivity is Move to com.squareup.leakcanary.TestActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.squareup.leakcanary.LeakCanaryInstaller is MoveAndRename to leaksentry.internal.LeakSentryInstaller", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.squareup.leakcanary.ActivityRefWatcher is MoveAndRename to leaksentry.internal.ActivityDestroyWatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.leakcanary.Clock is Move to leaksentry.Clock", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RefWatcher(Clock) in class RefWatcher is changed to RefWatcher(Clock,Executor", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method watchForLeaks() in class HeapDumpTrigger is renamed to registerToVisibilityChanges()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,Boolean,Boolean,Boolean,ExcludedRefs,List,Boolean) in class Config is changed to Config(Boolean,ExcludedRefs,List,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class InternalLeakCanary is extracted from class LeakCanaryInternal", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "It is a rename class", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method leakInfo(Context,HeapDump,AnalysisResult,Boolean) in class LeakCanaryInternal is moved to class InternalLeakCanary", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method isInAnalyzerProcess(Context) in class LeakCanaryInternal is moved to class InternalLeakCanary", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.squareup.leakcanary.internal.SupportFragmentRefWatcher is MoveAndRename to leaksentry.internal.SupportFragmentDestroyWatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.squareup.leakcanary.LeakCanaryInternal is MoveAndRename to leaksentry.internal.InternalLeakSentry", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onActivityStarted(Activity?) in class VisibilityTracker is changed to onActivityStarted(Activity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface FragmentDestroyWatcher is extracted from classes SupportFragmentDestroyWatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method testRunStarted() in class FailTestOnLeakRunListener is changed to testRunStarted(Description)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "50b3d17592d332df612daf18e04fdcea9651011c", "url" : "https://github.com/square/leakcanary/commit/50b3d17592d332df612daf18e04fdcea9651011c", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method indexHprof(Hprof,ProguardMapping) in class HprofHeapGraph is changed to indexHprof(Hprof,ProguardMapping,Set)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method elementMayBeLeakCause(Int) in class LeakTrace is renamed to referencePathElementIsSuspect(Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method computeLeakStatuses(RootNode,List) in class HeapAnalyzer is changed to computeLeakStatuses(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method resolveStatus(ObjectReporter) in class HeapAnalyzer is changed to resolveStatus(ObjectReporter,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method NormalNode(Long,ReferencePathNode,LeakReference) in class NormalNode is changed to NormalNode(Long,ReferencePathNode,ReferenceType,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ApplicationLeak(String,LeakTrace,Int) in class ApplicationLeak is changed to ApplicationLeak(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LibraryLeak(String,LeakTrace,Int,ReferencePattern,String) in class LibraryLeak is changed to LibraryLeak(List,ReferencePattern,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakTrace(List) in class LeakTrace is changed to LeakTrace(GcRootType,List,LeakTraceObject,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LibraryLeakChildNode(Long,ReferencePathNode,LeakReference,LibraryLeakReferenceMatcher) in class LibraryLeakChildNode is changed to LibraryLeakChildNode(Long,ReferencePathNode,ReferenceType,String,LibraryLeakReferenceMatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field leakTrace in class Leak is rename to leakTraces", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field retainedHeapByteSize in class Leak is rename to totalRetainedHeapByteSize", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method displayLeakTrace(LeakDetails) in class LeakScreen is renamed to onLeakTraceSelected(LeakDetails)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Both Rename and changeMethodParameter applied. RefDetect both.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onSuccessRetrieved(HeapAnalysisSuccess,Map,Boolean) in class HeapDumpScreen is changed to onSuccessRetrieved(HeapAnalysisSuccess,Map,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onGroupsRetrieved(List) in class LeaksScreen is changed to onGroupsRetrieved(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onLeakTraceSelected(LeakDetails) in class LeakScreen is changed to onLeakTraceSelected(HeapAnalysisSuccess,Long,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Both Rename and changeMethodParameter applied. RefDetect both.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onLeaksRetrieved(List,Int) in class LeakScreen is changed to onLeaksRetrieved(LeakProjection,Int,HeapAnalysisSuccess)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method leakToString(Leak,HeapAnalysisSuccess) in class LeakScreen is changed to leakToString(LeakTrace,HeapAnalysisSuccess)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakProjection(Long,Long,String,String,Long,Boolean,Boolean) in class LeakProjection is changed to LeakProjection(String,Boolean,Boolean,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method markAsRead(SQLiteDatabase,Long) in class LeakTable is changed to markAsRead(SQLiteDatabase,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method deleteByHeapAnalysisId(SQLiteDatabase,Long) in class LeakTraceTable is extracted from method deleteByHeapAnalysisId(SQLiteDatabase,Long) in class LeakTable", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field createGroupHashIndex in class LeakTable is rename to createSignatureIndex", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method computeGroupHash(String,String) in class LeakStatusTest is renamed to computeSignature(String,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method differentLeakTraceDifferentGroup() in class LeakStatusTest is renamed to differentLeakTraceDifferentSignature()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method sameCausesSameGroup() in class LeakStatusTest is renamed to sameCausesSameSignature()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method sameLeakTraceSameGroup() in class LeakStatusTest is renamed to sameLeakTraceSameSignature()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method findMultipleLeaks() in class HeapAnalyzerTest is renamed to findMultipleIdenticalLeaks()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method retrieveLeakById(SQLiteDatabase,Long) in class LeakTable is renamed to retrieveLeakBySignature(SQLiteDatabase,String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "retrieveLeaksByHash is renamed to retrieveLeakBySignature", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "6c2ee609efda323e88a4964d31fc5a5f0532f776", "url" : "https://github.com/square/leakcanary/commit/6c2ee609efda323e88a4964d31fc5a5f0532f776", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.internal.LabelTest is Rename to leakcanary.internal.LabelerTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.Exclusion.ExclusionType.ThreadExclusion is Rename to leakcanary.Exclusion.ExclusionType.JavaLocalExclusion", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findPaths(HprofParser,ExclusionsFactory,MutableList,MutableList,Boolean,AnalyzerProgressListener) in class ShortestPathFinder is changed to findPaths(HprofParser,ExclusionsFactory,MutableList,MutableList,Boolean,AnalyzerProgressListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findShortestPaths(HprofParser,ExclusionsFactory,MutableList,MutableList,Boolean) in class HeapAnalyzer is changed to findShortestPaths(HprofParser,ExclusionsFactory,MutableList,MutableList,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RootNode(Long) in class RootNode is changed to RootNode(Long,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScanResult(MutableList,List,MutableList) in class ScanResult is changed to ScanResult(MutableList,List,MutableList)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method gcRoot(GcRoot) in class HprofWriterHelper is extracted from method clazz(String,Long,List>,List>>) in class HprofWriterHelper", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method enqueueGcRoots(HprofParser,MutableList,Map,Boolean) in class ShortestPathFinder is extracted from method findPaths(HprofParser,ExclusionsFactory,List,MutableList,Boolean,AnalyzerProgressListener) in class ShortestPathFinder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "enqueueGcRoots is not a new method.", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "6daac6d61cddbc501bd82c68f281fca72bd85a59", "url" : "https://github.com/square/leakcanary/commit/6daac6d61cddbc501bd82c68f281fca72bd85a59", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method computeExpectedReachability(HeapDump,List) in class HeapAnalyzer is changed to computeExpectedReachability(HprofParser,HeapDump,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(HeapDump,LeakNode) in class HeapAnalyzer is changed to buildLeakTrace(HprofParser,HeapDump,LeakNode)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method inspectElementReachability(List,LeakTraceElement) in class HeapAnalyzer is changed to inspectElementReachability(HprofParser,List,LeakTraceElement)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTraces(HeapDump,List,Snapshot,MutableList,MutableMap) in class HeapAnalyzer is changed to buildLeakTraces(HeapDump,List,HprofParser,MutableList,MutableMap)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readHeapDumpMemoryStore(Snapshot) in class HeapAnalyzer is changed to readHeapDumpMemoryStore(HprofParser,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakTraceElement(LeakReference,Holder,HydratedInstance,String,Exclusion,List) in class LeakTraceElement is changed to LeakTraceElement(LeakReference,Holder,List,String,Exclusion,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakElement(LeakNode) in class HeapAnalyzer is changed to buildLeakElement(HprofParser,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LeakReference(Type,String,Long) in class LeakReference is changed to LeakReference(Type,String,HeapValue)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method retrieveStringById(Long) in class HprofParser is extracted from method retrieveString(ObjectReference) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "7b66364ecb46c688398c03abd5d34c7ec626cb4f", "url" : "https://github.com/square/leakcanary/commit/7b66364ecb46c688398c03abd5d34c7ec626cb4f", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.updated.KeyedWeakReferenceMirror is Move to leakcanary.experimental.KeyedWeakReferenceMirror", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.updated.HeapAnalyzer is Move to leakcanary.experimental.HeapAnalyzer", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.updated.internal.LeakNode is Move to leakcanary.experimental.internal.LeakNode", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.updated.internal.ShortestPathFinder is Move to leakcanary.experimental.internal.ShortestPathFinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakElement(LeakNode) in class HeapAnalyzer is changed to buildLeakElement(LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class LeakNode is moved. So both LeakNode are the same.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakElement(HprofParser,LeakNode) in class HeapAnalyzer is changed to buildLeakElement(HprofParser,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class LeakNode is moved. So both LeakNode are the same.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(HprofParser,HeapDump,LeakNode) in class HeapAnalyzer is changed to buildLeakTrace(HprofParser,HeapDump,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class LeakNode is moved. So both LeakNode are the same.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(HeapDump,LeakNode) in class HeapAnalyzer is changed to buildLeakTrace(HeapDump,LeakNode)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class LeakNode is moved. So both LeakNode are the same.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,ExcludedRefs,List,Boolean) in class Config is changed to Config(Boolean,ExcludedRefs,List,Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HprofParserComparisonTest is extracted from class InstrumentationLeakDetector", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field firstMaxMemoryUsed in class InstrumentationLeakDetector is moved to class HprofParserComparisonTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field secondMaxMemoryUsed in class InstrumentationLeakDetector is moved to class HprofParserComparisonTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "7c149da778d585f3b4bc200a02c9c7e77071ea2f", "url" : "https://github.com/square/leakcanary/commit/7c149da778d585f3b4bc200a02c9c7e77071ea2f", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakDetectedMessage(List) in class FailTestOnLeakRunListener is changed to buildLeakDetectedMessage(HeapAnalysis,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method testRunFinished(Result) in class FailTestOnLeakRunListener is changed to testRunFinished(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findLeakTrace(String,String,Long,Snapshot,Instance,Boolean,Long) in class HeapAnalyzer is changed to findLeakTrace(HeapDump,String,String,Long,Snapshot,Instance,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findLeakingReferences(Snapshot,MutableList,MutableMap,Long,Long) in class HeapAnalyzer is changed to findLeakingReferences(Snapshot,MutableList,MutableMap,Long)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method computeExpectedReachability(List) in class HeapAnalyzer is changed to computeExpectedReachability(HeapDump,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTrace(LeakNode) in class HeapAnalyzer is changed to buildLeakTrace(HeapDump,LeakNode)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method checkForLeak(File,String,Boolean) in class HeapAnalyzer is changed to checkForLeak(HeapDump,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method inspectElementReachability(LeakTraceElement) in class HeapAnalyzer is changed to inspectElementReachability(List,LeakTraceElement)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildLeakTraces(HeapDump,List,Snapshot,MutableList,MutableMap) in class HeapAnalyzer is changed to buildLeakTraces(HeapDump,List,Snapshot,MutableList,MutableMap)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findShortestPaths(Snapshot,MutableList) in class HeapAnalyzer is changed to findShortestPaths(HeapDump,Snapshot,MutableList)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalyzer(ExcludedRefs,AnalyzerProgressListener,List) in class HeapAnalyzer is changed to HeapAnalyzer(AnalyzerProgressListener)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass WeakReferenceFound is extracted from children classes LeakingInstance,NoPathToInstance,WeakReferenceCleared", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "NC", "comment" : "As we have no information about intermediate changes it is not clear this refactoring is valid or invalid.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass HeapAnalysis is extracted from children classes HeapAnalysisFailure,HeapAnalysisSuccess", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no information about intermediate changes it is not clear this refactoring is valid or invalid.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass RetainedInstance is extracted from children classes WeakReferenceFound,WeakReferenceMissing", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no information about intermediate changes it is not clear this refactoring is valid or invalid.", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "84d97ed9d9c2127937bddb284b9fcbcdf571a1df", "url" : "https://github.com/square/leakcanary/commit/84d97ed9d9c2127937bddb284b9fcbcdf571a1df", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onProgressUpdate(Step) in class HeapAnalyzerService is renamed to onAnalysisProgress(Step)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method open(File,Int) in class HprofWriter is changed to open(File,Int,HprofVersion)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Hprof(FileChannel,BufferedSource,HprofReader,Long) in class Hprof is changed to Hprof(FileChannel,BufferedSource,HprofReader,Long,HprofVersion)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HprofReader(BufferedSource,Long,Int) in class HprofReader is changed to HprofReader(BufferedSource,Int,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HprofWriter(BufferedSink,Int) in class HprofWriter is changed to HprofWriter(BufferedSink,Int,HprofVersion)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readSize() in class HeapPrimitiveArray is renamed to readByteSize()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readFieldsSize() in class HeapClass is renamed to readFieldsByteSize()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readSize() in class HeapObjectArray is renamed to readByteSize()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass HprofHeapGraph is extracted from parent class HeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method wrapIndexedObject(IndexedObject,Long) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method createFieldValuesReader(InstanceDumpRecord) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method readObjectRecord(Long,IndexedObject in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method fieldName(FieldRecord) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method indexHprof(Hprof) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method staticFieldName(StaticFieldRecord) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method className(Long) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method readClassDumpRecord(Long,IndexedClass) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method readInstanceDumpRecord(Long,IndexedInstance) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method readObjectArrayDumpRecord(Long,IndexedObjectArray) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method readPrimitiveArrayDumpRecord(Long,IndexedPrimitiveArray) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapPrimitiveArray(HeapGraph,IndexedPrimitiveArray,Long) in class HeapPrimitiveArray is changed to HeapPrimitiveArray(HprofHeapGraph,IndexedPrimitiveArray,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapClass(HeapGraph,IndexedClass,Long) in class HeapClass is changed to HeapClass(HprofHeapGraph,IndexedClass,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapObjectArray(HeapGraph,IndexedObjectArray,Long,Boolean) in class HeapObjectArray is changed to HeapObjectArray(HprofHeapGraph,IndexedObjectArray,Long,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapInstance(HeapGraph,IndexedInstance,Long,Boolean) in class HeapInstance is changed to HeapInstance(HprofHeapGraph,IndexedInstance,Long,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field objectCache in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.Leak.LibraryLeak is Move to shark.LibraryLeak", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.Leak.ApplicationLeak is Move to shark.ApplicationLeak", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.AnalyzerProgressListener.Step is Move to shark.OnAnalysisProgressListener.Step", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.ReferenceMatcher.LibraryLeakReferenceMatcher is Move to shark.LibraryLeakReferenceMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.ReferenceMatcher.IgnoredReferenceMatcher is Move to shark.IgnoredReferenceMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findPaths(HeapGraph,List,Set,Boolean,AnalyzerProgressListener) in class ShortestPathFinder is changed to findPaths(HeapGraph,List,Set,Boolean,OnAnalysisProgressListener)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method inspect(HeapGraph,ObjectReporter) in class AppSingletonInspector is changed to inspect(ObjectReporter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method inspect(HeapGraph,ObjectReporter) in class ObjectInspector is changed to inspect(ObjectReporter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HeapAnalyzer(AnalyzerProgressListener) in class HeapAnalyzer is changed to HeapAnalyzer(OnAnalysisProgressListener)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LibraryLeakNode(Long,ReferencePathNode,LeakReference,LibraryLeakReferenceMatcher) in class LibraryLeakNode is changed to LibraryLeakNode(Long,ReferencePathNode,LeakReference,LibraryLeakReferenceMatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke((HeapGraph, ObjectReporter) -> Unit) in class ObjectInspector is changed to invoke((ObjectReporter) -> Unit)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onAnalysisProgress(shark.AnalyzerProgressListener.Step) in class HeapAnalyzerService is changed to onAnalysisProgress(OnAnalysisProgressListener.Step)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface OnAnalysisProgressListener is extracted from classes HeapAnalyzerService", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readObjectArrayDumpRecord(Long) in class HprofHeapGraph is changed to readObjectArrayDumpRecord(Long,IndexedObjectArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readClassDumpRecord(Long) in class HprofHeapGraph is changed to readClassDumpRecord(Long,IndexedClass)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readInstanceDumpRecord(Long) in class HprofHeapGraph is changed to readInstanceDumpRecord(Long,IndexedInstance)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method findObjectById(Long) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readPrimitiveArrayDumpRecord(Long) in class HprofHeapGraph is changed to readPrimitiveArrayDumpRecord(Long,IndexedPrimitiveArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method findClassByName(String) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method objectExists(Long) in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method staticFieldName(FieldRecord) in class HprofHeapGraph is changed to staticFieldName(StaticFieldRecord)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method fieldName(StaticFieldRecord) in class HprofHeapGraph is changed to fieldName(FieldRecord)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readClassDumpRecord(Long,IndexedObjectArray) in class HprofHeapGraph is changed to readClassDumpRecord(Long,IndexedClass)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readObjectArrayDumpRecord(Long,IndexedClass) in class HprofHeapGraph is changed to readObjectArrayDumpRecord(Long,IndexedObjectArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field context in class HeapGraph is pushed down to class HprofHeapGraph", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "9e84be4521f4e2f35516d7f9b89edb6697a8ba3e", "url" : "https://github.com/square/leakcanary/commit/9e84be4521f4e2f35516d7f9b89edb6697a8ba3e", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readClass(String) in class HprofGraph is renamed to indexedClass(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readClassDumpRecord(Long) in class HprofReader is changed to readClassDumpRecord()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readPrimitiveArrayDumpRecord(Long) in class HprofReader is changed to readPrimitiveArrayDumpRecord()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readInstanceDumpRecord(Long) in class HprofReader is changed to readInstanceDumpRecord()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readObjectArrayDumpRecord(Long) in class HprofReader is changed to readObjectArrayDumpRecord()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GraphInstanceRecord(HprofGraph,InstanceDumpRecord) in class GraphInstanceRecord is changed to GraphInstanceRecord(HprofGraph,IndexedInstance,Long,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GraphPrimitiveArrayRecord(PrimitiveArrayDumpRecord) in class GraphPrimitiveArrayRecord is changed to GraphPrimitiveArrayRecord(HprofGraph,IndexedPrimitiveArray,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method HprofGraph(HprofParser) in class HprofGraph is changed to HprofGraph(SeekableHprofReader,HprofInMemoryIndex)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GraphClassRecord(HprofGraph,ClassDumpRecord) in class GraphClassRecord is changed to GraphClassRecord(HprofGraph,IndexedClass,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GraphObjectArrayRecord(HprofGraph,ObjectArrayDumpRecord) in class GraphObjectArrayRecord is changed to GraphObjectArrayRecord(HprofGraph,IndexedObjectArray,Long,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass OnRecordListener is extracted from children classes Builder", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we do not have intermediate changes, we can not say the refactoring is correct or incorrect.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass IndexedObject is extracted from children classes IndexedClass,IndexedInstance,IndexedObjectArray,IndexedPrimitiveArray", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we do not have intermediate changes, we can not say the refactoring is correct or incorrect.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class Builder is extracted from class HprofParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HprofPushRecordsParser is extracted from class HprofParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HprofInMemoryIndex is extracted from class HprofParser", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class HprofParser is renamed to HprofInMemoryIndex", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field classNames in class HprofParser is moved to class Builder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field primitiveWrapperClassNames in class HprofParser is moved to class Builder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field primitiveWrapperTypes in class HprofParser is moved to class Builder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field objectCache in class HprofParser is moved to class HprofGraph", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field HEAP_DUMP in class HprofParser is moved to class HprofPushRecordsParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field HEAP_DUMP_END in class HprofParser is moved to class HprofPushRecordsParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field LOAD_CLASS in class HprofParser is moved to class HprofPushRecordsParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field STACK_TRACE in class HprofParser is moved to class HprofPushRecordsParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field STRING_IN_UTF8 in class HprofParser is moved to class HprofPushRecordsParser", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field PRIMITIVE_WRAPPER_TYPES in class HprofParser is moved to class HprofInMemoryIndex", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class HprofParser is renamed to HprofInMemoryIndex.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method hprofStringById(Long) in class HprofParser is moved to class HprofInMemoryIndex", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class HprofParser is renamed to HprofInMemoryIndex.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method classId(String) in class HprofParser is moved to class HprofInMemoryIndex", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class HprofParser is renamed to HprofInMemoryIndex.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScanResult(MutableList,List,MutableList) in class ScanResult is changed to ScanResult(HprofGraph,Closeable,MutableList,List,MutableList)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.ObjectIdMetadata is Rename to leakcanary.PrimitiveType", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readObjectArrayDumpRecord(Long) in class HprofGraph is changed to readObjectArrayDumpRecord(Long,IndexedObjectArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readGraphObjectRecord(Long) in class HprofGraph is renamed to readObjectArrayDumpRecord(Long,IndexedObjectArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "b4634453be60d5f3d988f6ef804f322633f2f302", "url" : "https://github.com/square/leakcanary/commit/b4634453be60d5f3d988f6ef804f322633f2f302", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Config(Boolean,Boolean,Int,List,List,OnHeapAnalyzedListener,MetadataExtractor,Boolean,Int,Boolean,LeakingObjectFinder,HeapDumper,List,Boolean,Boolean) in class Config is changed to Config(Boolean,Boolean,Int,List,List,MetadataExtractor,Boolean,Int,Boolean,LeakingObjectFinder,HeapDumper,List,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ObjectDominators is Move to shark.ObjectDominators", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "shark/shark/src/main/java/shark/internal/ObjectDominators.kt -> shark/shark/src/main/java/shark/ObjectDominators.kt", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class shark.internal.PathFinder is MoveAndRename to shark.PrioritizingShortestPathFinder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ClassReferenceReader is Move to shark.ClassReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.AndroidReferenceReaders is Move to shark.AndroidReferenceReaders", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.PathFinder.PathFindingResults is Move to shark.PathFindingResults", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ReferenceReader is Move to shark.ReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ReferenceReader.Factory is Move to shark.LeakTracer.Factory", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ReferenceLocationType is Move to shark.ReferenceLocationType", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ApacheHarmonyInstanceRefReaders is Move to shark.ApacheHarmonyInstanceRefReaders", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.HeapAnalyzer.InspectedObject is Move to shark.RealLeakTracerFactory.InspectedObject", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.HeapAnalyzer.ShortestPath is Move to shark.RealLeakTracerFactory.ShortestPath", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.Reference is Move to shark.Reference", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.AndroidNativeSizeMapper is Move to shark.AndroidNativeSizeMapper", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.GcRootProvider.GcRootReference is Move to shark.GcRootReference", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.JavaLocalReferenceReader is Move to shark.JavaLocalReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ChainingInstanceReferenceReader is Move to shark.ChainingInstanceReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.DominatorTree is Move to shark.DominatorTree", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.HeapAnalyzer.LeaksAndUnreachableObjects is Move to shark.LeaksAndUnreachableObjects", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.DelegatingObjectReferenceReader is Move to shark.DelegatingObjectReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.OpenJdkInstanceRefReaders is Move to shark.OpenJdkInstanceRefReaders", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.FieldInstanceReferenceReader is Move to shark.FieldInstanceReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.HeapAnalyzer.FindLeakInput is Move to shark.RealLeakTracerFactory.FindLeakInput", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.internal.ObjectArrayReferenceReader is Move to shark.ObjectArrayReferenceReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class shark.HeapAnalyzer.TrieNode is Move to shark.RealLeakTracerFactory.TrieNode", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method findUnreachableObjects(PathFindingResults,Set) in class HeapAnalyzer is changed to findUnreachableObjects(PathFindingResults,Set) and moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Move is correct, but ChangeMethodParameter is not correct.", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method sortedGcRoots() in class GcRootProvider is changed to sortedGcRoots(HeapGraph) and moved to class MatchingGcRootProvider", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FindLeakInput(HeapGraph,List,Boolean,List,ReferenceReader) in class FindLeakInput is changed to FindLeakInput(HeapGraph,ShortestPathFinder,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface GcRootProvider is extracted from classes MatchingGcRootProvider", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Class GcRootProvider as an inner class is moved and also now is the super interface of class MatchingGcRootProvider.", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface ShortestPathFinder is extracted from classes PrioritizingShortestPathFinder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass Factory is extracted from children classes Factory", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class RealLeakTracerFactory is extracted from class HeapAnalyzer", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class MatchingGcRootProvider is extracted from class GcRootProvider", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method computeLeakStatuses(List) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method resolveStatus(ObjectReporter,Boolean) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method deduplicateShortestPaths(List) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method updateTrie(ReferencePathNode,List,Int,ParentNode) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method findLeaks(Set) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method buildLeakTraces(List,List,Map) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method recordClassName(HeapObject) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method inspectObjects(List) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method computeRetainedSizes(List,DominatorTree) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method findResultsInTrie(ParentNode,MutableList) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method buildReferencePath(ShortestPath,List) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method buildLeakTraceObjects(List,Map) in class HeapAnalyzer is moved to class RealLeakTracerFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.InstrumentationLeakDetectorTest is Rename to leakcanary.AndroidDetectLeaksAssertTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "dc5ec42e725d77d1ae8bb83c7a5bab96eb2cd0c8", "url" : "https://github.com/square/leakcanary/commit/dc5ec42e725d77d1ae8bb83c7a5bab96eb2cd0c8", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.example.leakcanary.tv.BaseTvApplication is Rename to com.example.leakcanary.tv.ExampleTvApplication", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass RetainInstanceChange is extracted from children classes CountChanged", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.example.leakcanary.tv.ExampleTvApplication is MoveAndRename to leakcanary.internal.utils.FormFactor", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method showNotification(Screen,String) in class DefaultOnHeapAnalyzedListener is extracted from method onHeapAnalyzed(HeapAnalysis) in class DefaultOnHeapAnalyzedListener", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onHeapAnalyzed(HeapAnalysis) in class TvOnHeapAnalyzedListener is changed to onHeapAnalyzed()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "de00819e8c7d696400c2f377605252ef178c48ff", "url" : "https://github.com/square/leakcanary/commit/de00819e8c7d696400c2f377605252ef178c48ff", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method LongToPairOfLongBooleanSparseArray(Int) in class LongToPairOfLongBooleanSparseArray is renamed to LongToPairOfLongByteSparseArray(Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class leakcanary.internal.LongToPairOfLongBooleanSparseArray is Rename to leakcanary.internal.LongToPairOfLongByteSparseArray", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method insert(Long,Long,Boolean) in class LongToPairOfLongBooleanSparseArray is changed to insert(Long,Long,Byte)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method set(Long,Long,Boolean) in class LongToPairOfLongBooleanSparseArray is changed to set(Long,Pair)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field objectPositionsAndBoring in class HprofParser is rename to objectIndex", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method insertByte(BooleanArray,Int,Int,Byte) in class SparseArrayUtils is changed to insertByte(ByteArray,Int,Int,Byte)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameters are changed. Both detected by KotlinRMiner", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method insertBoolean(BooleanArray,Int,Int,Boolean) in class SparseArrayUtils is renamed to insertByte(ByteArray,Int,Int,Byte)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameters are changed. Both detected by KotlinRMiner", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method appendByte(BooleanArray,Int,Byte) in class SparseArrayUtils is changed to appendByte(ByteArray,Int,Byte)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameters are changed. Both detected by KotlinRMiner", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method appendBoolean(BooleanArray,Int,Boolean) in class SparseArrayUtils is renamed to appendByte(ByteArray,Int,Byte)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameters are changed. Both detected by KotlinRMiner", "validator" : "" } ] }, { "repository" : "https://github.com/square/leakcanary", "sha1" : "e5a07bd5015c15331b21307785066ba01b575136", "url" : "https://github.com/square/leakcanary/commit/e5a07bd5015c15331b21307785066ba01b575136", "refactorings" : [ { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method skipShort() in class HprofReader is inlined to method readClassDumpRecord(Long) in class HprofReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.internal.haha.Record.HeapDumpRecord.ClassDumpRecord is Move to leakcanary.internal.haha.Record.HeapDumpRecord.ObjectRecord.ClassDumpRecord", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "An outer class ObjectRecord is created and now the class is inside this newly created class.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.internal.haha.Record.HeapDumpRecord.InstanceDumpRecord is Move to leakcanary.internal.haha.Record.HeapDumpRecord.ObjectRecord.InstanceDumpRecord", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.internal.haha.Record.HeapDumpRecord.ObjectArrayDumpRecord is Move to leakcanary.internal.haha.Record.HeapDumpRecord.ObjectRecord.ObjectArrayDumpRecord", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class leakcanary.internal.haha.Record.HeapDumpRecord.PrimitiveArrayDumpRecord is Move to leakcanary.internal.haha.Record.HeapDumpRecord.ObjectRecord.PrimitiveArrayDumpRecord", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method hydrate(InstanceDumpRecord) in class HprofParser is renamed to hydrateInstance(InstanceDumpRecord)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method readObjectArrayDumpRecord(Long) in class HprofReader is extracted from method scan(RecordCallbacks) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method readPrimitiveArrayDumpRecord(Long) in class HprofReader is extracted from method scan(RecordCallbacks) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method skipInt() in class HprofReader is inlined to method scan(RecordCallbacks) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method skipLong() in class HprofReader is inlined to method scan(RecordCallbacks) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method skipShort() in class HprofReader is inlined to method scan(RecordCallbacks) in class HprofParser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "0d09dc123850a7cd3583ff2ccbde89cac0712275", "url" : "https://github.com/square/okhttp/commit/0d09dc123850a7cd3583ff2ccbde89cac0712275", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method prepareNewExchange(RealInterceptorChain) in class RealCall is renamed to initExchange(RealInterceptorChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method followUpRequest(Response,Route) in class RetryAndFollowUpInterceptor is changed to followUpRequest(Response,Exchange)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method recover(IOException,RealCall,Boolean,Request) in class RetryAndFollowUpInterceptor is changed to recover(IOException,RealCall,Request,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method prepareExchangeFinder(Request) in class RealCall is renamed to enterNetworkInterceptorExchange(Request)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Our tool cannot detect that as the body of method changed significantly.", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method exitNetworkInterceptorExchange(Boolean) in class RealCall is extracted from method intercept(Interceptor.Chain) in class RetryAndFollowUpInterceptor", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Method is called inside intercept. But the extracted method is doing something new. We cannot detect this as Extract Method.", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "1364ea44ae1f1c4b5a1cc32e4e7b51d23cb78517", "url" : "https://github.com/square/okhttp/commit/1364ea44ae1f1c4b5a1cc32e4e7b51d23cb78517", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class okhttp3.recipes.kt.DevServerAndroid is Rename to okhttp3.recipes.kt.DevServer", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class okhttp3.recipes.kt.JvmAllowlistedTrustManager is MoveAndRename to okhttp3.tls.internal.InsecureExtendedTrustManager", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method newTrustManager(String?,List) in class TlsUtil is changed to newTrustManager(String?,List,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method checkClientTrusted(Array,String?,SSLEngine?) in class InsecureExtendedTrustManager is changed to checkClientTrusted(Array,String,SSLEngine?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method checkClientTrusted(Array,String?,Socket?) in class InsecureExtendedTrustManager is changed to checkClientTrusted(Array,String,Socket?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "15339353c15878f35eb750f9653e0410937efa68", "url" : "https://github.com/square/okhttp/commit/15339353c15878f35eb750f9653e0410937efa68", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class Jdk8WithJettyBootPlatform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class OpenJSSEPlatform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class AndroidSocketAdapter is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class Android10SocketAdapter is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class ConscryptPlatform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class ConscryptSocketAdapter is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class Jdk9Platform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class SocketAdapter is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class DeferredSocketAdapter is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class Android10Platform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class AndroidPlatform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method configureTlsExtensions(SSLSocket,List) in class Platform is changed to configureTlsExtensions(SSLSocket,String,List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method configureTlsExtensions(SSLSocket,List) in class Android10Platform is inlined to method configureTlsExtensions(SSLSocket,String?,List) in class Android10Platform", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method configureTlsExtensions(SSLSocket,List<@JvmSuppressWildcards Protocol>) in class AndroidPlatform is inlined to method configureTlsExtensions(SSLSocket,String?,List<@JvmSuppressWildcards Protocol>) in class AndroidPlatform", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method configureTlsExtensions(SSLSocket,List) in class DeferredSocketAdapter is inlined to method configureTlsExtensions(SSLSocket,String?,List) in class DeferredSocketAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "34bb12533b56eacd7b03c13b87dede4204d48629", "url" : "https://github.com/square/okhttp/commit/34bb12533b56eacd7b03c13b87dede4204d48629", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onRequest(RecordedRequest,Http2Stream) in class MockDuplexResponseBody is renamed to handle(RecordedRequest,Http2Stream)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is also changed. RefDetect and KotlinRMiner print the refactorings separately.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class mockwebserver3.internal.duplex.MockDuplexResponseBody is Rename to mockwebserver3.internal.duplex.MockStreamHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setBody(Builder,DuplexResponseBody) in class MwsDuplexAccess is changed to setBody(Builder,StreamHandler)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method handle(RecordedRequest,Http2Stream) in class MockDuplexResponseBody is changed to handle(Stream)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is also changed. RefDetect and KotlinRMiner print the refactorings separately.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method serviceStreamTask(RecordedRequest,Http2Stream) in class MockDuplexResponseBody is changed to serviceStreamTask(Stream)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method cancelStream(ErrorCode) in class MockDuplexResponseBody is changed to cancelStream()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface Stream is extracted from classes RealStream", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no access to the intermediate changes, it is not possible to decide about this refactoring.", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface StreamHandler is extracted from classes MockStreamHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "3d3b0f64005f7d2dd7cde80a9eaf665f8df86fb6", "url" : "https://github.com/square/okhttp/commit/3d3b0f64005f7d2dd7cde80a9eaf665f8df86fb6", "refactorings" : [ { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method timeoutEnter() in class Transmitter is inlined to method execute() in class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "commits": "If we have a look at the method execute() in class okhttp3.Recall and then in execute() in class Transmitter, we can see the refactoring is correct", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method prepareToConnect(Request) in class Transmitter is renamed to prepareExchangeFinder(Request)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method transmitterAcquirePooledConnection(Address,Transmitter,List,Boolean) in class RealConnectionPool is renamed to callAcquirePooledConnection(Address,Transmitter,List,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class okhttp3.internal.connection.Transmitter is Rename to okhttp3.internal.connection.RealCall", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class okhttp3.RealCall.AsyncCall is Move to okhttp3.internal.connection.RealCall.AsyncCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method proceed(Request,Transmitter,Exchange) in class RealInterceptorChain is changed to proceed(Request,Exchange)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method executed(RealCall) in class Dispatcher is changed to executed(RealCall)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ExchangeFinder(Transmitter,RealConnectionPool,Address,Call,EventListener) in class ExchangeFinder is changed to ExchangeFinder(RealConnectionPool,Address,RealCall,EventListener)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RealInterceptorChain(List,Transmitter,Exchange,Int,Request,Call,Int,Int,Int) in class RealInterceptorChain is changed to RealInterceptorChain(List,RealCall,Exchange,Int,Request,Int,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Exchange(Transmitter,Call,EventListener,ExchangeFinder,ExchangeCodec) in class Exchange is changed to Exchange(RealCall,EventListener,ExchangeFinder,ExchangeCodec)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field transmitters in class RealConnection is rename to calls", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field request in class Transmitter is rename to exchangeFinderRequest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getResponseWithInterceptorChain() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method enqueue(Callback) in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method execute() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method toLoggableString() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method isExecuted() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method redactedUrl() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method request() in class RealCall is moved to class RealCall", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method callAcquirePooledConnection(Address,Transmitter,List,Boolean) in class RealConnectionPool is changed to callAcquirePooledConnection(Address,RealCall,List,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class Transmitter is renamed to RealCall. So the parameter type is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method recover(IOException,Transmitter,Boolean,Request) in class RetryAndFollowUpInterceptor is changed to recover(IOException,RealCall,Boolean,Request)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class Transmitter is renamed to RealCall. So the parameter type is not changed.", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method timeoutEarlyExit() in class Exchange is inlined to method processResponse(Response) in class RealEventSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "500ba31ada1ed156c5d2e8c5d90c818c5ea34cc4", "url" : "https://github.com/square/okhttp/commit/500ba31ada1ed156c5d2e8c5d90c818c5ea34cc4", "refactorings" : [ { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class okhttp3.internal.connection.ExchangeFinder.ConnectPlan is MoveAndRename to okhttp3.internal.connection.RealRoutePlanner.RealConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method initExchange() in class RealCall is changed to initExchange(RealInterceptorChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ExchangeFinder(OkHttpClient,Address,RealCall,RealInterceptorChain) in class ExchangeFinder is changed to ExchangeFinder(RoutePlanner)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method initExchange() in class AsyncCall is changed to initExchange(RealInterceptorChain)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Exchange(RealCall,EventListener,ExchangeFinder,ExchangeCodec) in class Exchange is changed to Exchange(RealCall,EventListener,RoutePlanner,ExchangeCodec)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface RoutePlanner is extracted from classes RealRoutePlanner", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no access to the intermediate changes, it is not possible to decide about this refactoring.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass Plan is extracted from children classes RealConnectPlan,ReusePlan", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no access to the intermediate changes, it is not possible to decide about this refactoring.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class RealRoutePlanner is extracted from class ExchangeFinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ReusePlan is extracted from class ReusePlan", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems more similar to Move Class, then Extract Class.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field eventListener in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field connectionShutdownCount in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field otherFailureCount in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field refusedStreamCount in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field nextRouteToTry in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field connectionPool in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field routeSelection in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field routeSelector in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method planReusePooledConnection(RealConnection,List) in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method planReuseCallConnection() in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method retryAfterFailure() in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method retryRoute() in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method trackFailure(IOException) in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method plan() in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ReusePlan(RealConnection) in class ReusePlan is moved to class ReusePlan", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "To Me class ReusePlan is moved. Therefore, the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method sameHostAndPort(HttpUrl) in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field doExtensiveHealthChecks in class ExchangeFinder is moved to class RealRoutePlanner", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "672e765cc8770ac4cb6f2919eb177e0cfeaafdbf", "url" : "https://github.com/square/okhttp/commit/672e765cc8770ac4cb6f2919eb177e0cfeaafdbf", "refactorings" : [ { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method connectFailed(Route,IOException) in class RealConnectionPool is changed to connectFailed(OkHttpClient,Route,IOException) and moved to class RealConnection", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method trackFailure(IOException) in class RealConnection is changed to trackFailure(OkHttpClient,IOException)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field routeDatabase in class RealConnectionPool is moved to class OkHttpClient", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "References show they are different Fields", "validator" : "" }] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "699a2122fc249dde55a7a0e5f1a9991a822fa822", "url" : "https://github.com/square/okhttp/commit/699a2122fc249dde55a7a0e5f1a9991a822fa822", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class okhttp3.internal.connection.FastFallbackExchangeFinder.ConnectResult is Move to okhttp3.internal.connection.RoutePlanner.ConnectResult", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "References show the refactoring is correct.", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method createTunnelRequest() in class RealConnection is changed to createTunnelRequest(Route) and moved to class RealRoutePlanner", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method connectSocket(Int,Int) in class RealConnection is changed to connectSocket() and moved to class ConnectPlan", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method createTunnel(Int,Int,Request,HttpUrl) in class RealConnection is changed to createTunnel() and moved to class ConnectPlan", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method trackFailure(IOException) in class RealConnectPlan is changed to trackFailure(RealCall,IOException) and moved to class Carrier", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Http1ExchangeCodec(OkHttpClient,RealConnection,BufferedSource,BufferedSink) in class Http1ExchangeCodec is changed to Http1ExchangeCodec(OkHttpClient,Carrier,BufferedSource,BufferedSink)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ConnectResult(Plan,Throwable) in class ConnectResult is changed to ConnectResult(Plan,Plan,Throwable)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ConnectPlan is extracted from class RealConnection", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class Carrier is extracted from class RealConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field sink in class RealConnection is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field eventListener in class RealRoutePlanner is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field connection in class RealConnectPlan is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field NPE_THROW_WITH_NULL in class RealConnection is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field source in class RealConnection is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field protocol in class RealConnection is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field connectionsToCancel in class RealCall is rename to plansToCancel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method connectTls(SSLSocket,ConnectionSpec) in class RealConnection is moved to class ConnectPlan", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method handleSuccess() in class RealConnectPlan is moved to class ConnectPlan", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class okhttp3.internal.connection.EquipPlanTest is Rename to okhttp3.internal.connection.RetryConnectionTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "RefDetect detects this refactoring if test directory is active.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startHttp2(Int) in class RealConnection is changed to startHttp2()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "6d040e06c132048599cd8c22e9d2fc71e22d3245", "url" : "https://github.com/square/okhttp/commit/6d040e06c132048599cd8c22e9d2fc71e22d3245", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method initExchange(RealInterceptorChain) in class RealCall is changed to initExchange()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method enterNetworkInterceptorExchange(Request,Boolean) in class RealCall is changed to enterNetworkInterceptorExchange(Request,Boolean,RealInterceptorChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ExchangeFinder(TaskRunner,RealConnectionPool,Address,RealCall,EventListener) in class ExchangeFinder is changed to ExchangeFinder(OkHttpClient,Address,RealCall,RealInterceptorChain)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method enterNetworkInterceptorExchange(Request,Boolean) in class AsyncCall is changed to enterNetworkInterceptorExchange(Request,Boolean,RealInterceptorChain)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method exceptionsAreReturnedAsSuppressed() in class CallKotlinTest is renamed to connectExceptionsAreReturnedAsSuppressed()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method tryReuseCallConnection(Boolean) in class ExchangeFinder is changed to tryReuseCallConnection()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "As return type is changed, RefDetect couldn't detect that.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method tryReuseCallConnection(Boolean) in class ExchangeFinder is renamed to planReuseCallConnection()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "As return type is changed, RefDetect couldn't detect that.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method routeNewConnection() in class ExchangeFinder is renamed to planConnect()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findPooledConnection(Boolean,RealConnection?,List) in class ExchangeFinder is changed to findPooledConnection(RealConnection?,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method findPooledConnection(Boolean,RealConnection?,List) in class ExchangeFinder is renamed to planReusePooledConnection(RealConnection?,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "6e8aa12dd6ffa66c3cf4afc2d68a503059ea88f6", "url" : "https://github.com/square/okhttp/commit/6e8aa12dd6ffa66c3cf4afc2d68a503059ea88f6", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Cache(File,Long,FileSystem) in class Cache is changed to Cache(Path,Long,FileSystem)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class okhttp3.internal.cache.FileSystemParamProvider is Rename to okhttp3.internal.cache.FilesystemParamProvider", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildCache(File,Long,FileSystem) in class NativeImageTestsAccessors is changed to buildCache(Path,Long,FileSystem)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method isCivilized(File) in class Util is changed to isCivilized(Path)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "737f00683b0620d4356692de1dee31a976f6798c", "url" : "https://github.com/square/okhttp/commit/737f00683b0620d4356692de1dee31a976f6798c", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method hasMoreRoutes() in class RealRoutePlanner is renamed to hasNext()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed as well.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method hasNext() in class RealRoutePlanner is changed to hasNext(RealConnection)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed as well.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Exchange(RealCall,EventListener,RoutePlanner,ExchangeCodec) in class Exchange is changed to Exchange(RealCall,EventListener,ExchangeFinder,ExchangeCodec)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method retryRoute() in class RealRoutePlanner is changed to retryRoute(RealConnection)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method hasNext() in class FakeRoutePlanner is changed to hasNext(RealConnection?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method hasMoreRoutes() in class FakeRoutePlanner is renamed to hasNext(RealConnection?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method find() in class ExchangeFinder is pushed down to class SequentialExchangeFinder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method hasMoreRoutes() in class RoutePlanner is renamed to hasNext(RealConnection?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method hasNext() in class RoutePlanner is changed to hasNext(RealConnection?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "9d464c32523f019a806fb08f7ff94f338e420ccd", "url" : "https://github.com/square/okhttp/commit/9d464c32523f019a806fb08f7ff94f338e420ccd", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findConnection(Int,Int,Int,Int,Boolean) in class ExchangeFinder is changed to findConnection(Boolean,Int,Int,Int,Int,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method tryReuseCallConnection() in class ExchangeFinder is changed to tryReuseCallConnection(Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findPooledConnection(RealConnection,List) in class ExchangeFinder is changed to findPooledConnection(Boolean,RealConnection,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method recoverFromOneRefusedStreamReusesConnection(Protocol,MockWebServer) in class HttpOverHttp2Test is renamed to recoverFromRefusedStreamWhenAnotherRouteExists(Protocol,MockWebServer)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The method is renamed to noRecoveryFromOneRefusedStream", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "f567e5446abfcd715da81f1744fb885fc5fa05a4", "url" : "https://github.com/square/okhttp/commit/f567e5446abfcd715da81f1744fb885fc5fa05a4", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method exchangeMessageDone(Exchange,Boolean,Boolean,E) in class RealCall is renamed to messageDone(Exchange,Boolean,Boolean,E)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method newExchange(Chain,Boolean) in class RealCall is renamed to prepareNewExchange(Chain,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method prepareNewExchange(Chain,Boolean) in class RealCall is changed to prepareNewExchange(RealInterceptorChain)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RealInterceptorChain(List,RealCall,Exchange,Int,Request,Int,Int,Int) in class RealInterceptorChain is changed to RealInterceptorChain(RealCall,List,Int,Exchange,Request,Int,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method newCodec(OkHttpClient,Chain) in class RealConnection is changed to newCodec(OkHttpClient,RealInterceptorChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Http2ExchangeCodec(OkHttpClient,RealConnection,Chain,Http2Connection) in class Http2ExchangeCodec is changed to Http2ExchangeCodec(OkHttpClient,RealConnection,RealInterceptorChain,Http2Connection)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method proceed(Request,Exchange?) in class RealInterceptorChain is inlined to method proceed(Request) in class RealInterceptorChain", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "f8065acac28a0b86f3bdbd854ac87af0789416d0", "url" : "https://github.com/square/okhttp/commit/f8065acac28a0b86f3bdbd854ac87af0789416d0", "refactorings" : [ { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method beforeEach() in class OkHttpClientTestRule is extracted from method apply(Statement,Description) in class OkHttpClientTestRule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method close() in class Resource is renamed to shutdownAll()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method isTestFlaky(Description) in class OkHttpClientTestRule is changed to isTestFlaky()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method isTestFlaky(Description) in class OkHttpClientTestRule is renamed to isFlaky()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "59b1dc7e7f78e12d854d9e69dad84920ecb1b782", "url" : "https://github.com/square/okhttp/commit/59b1dc7e7f78e12d854d9e69dad84920ecb1b782", "refactorings" : [ { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method routeNewConnection() in class ExchangeFinder is extracted from method findConnection(Int,Int,Int,Int,Boolean) in class ExchangeFinder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method tryReuseCallConnection() in class ExchangeFinder is extracted from method findConnection(Int,Int,Int,Int,Boolean) in class ExchangeFinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method findPooledConnection(RealConnection?,List) in class ExchangeFinder is extracted from method findConnection(Int,Int,Int,Int,Boolean) in class ExchangeFinder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "6ee3c89dabcf8574b10f1f8cafd5c2d7e942d8fe", "url" : "https://github.com/square/okhttp/commit/6ee3c89dabcf8574b10f1f8cafd5c2d7e942d8fe", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getSSLContext() in class AndroidPlatform is renamed to newSSLContext()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getSSLContext() in class Platform is renamed to newSSLContext()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getSSLContext() in class ConscryptPlatform is renamed to newSSLContext()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "14218871dfc0cf1a7ed3b2b165d4980d64574057", "url" : "https://github.com/square/okhttp/commit/14218871dfc0cf1a7ed3b2b165d4980d64574057", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method newTestConnection(RealConnectionPool,Route,Socket,Long) in class RealConnection is changed to newTestConnection(TaskRunner,RealConnectionPool,Route,Socket,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method start(Boolean,TaskRunner) in class Http2Connection is changed to start(Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method start(Boolean,TaskRunner) in class ReaderRunnable is changed to start(Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ExchangeFinder(RealConnectionPool,Address,RealCall,EventListener) in class ExchangeFinder is changed to ExchangeFinder(TaskRunner,RealConnectionPool,Address,RealCall,EventListener)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RealConnection(RealConnectionPool,Route) in class RealConnection is changed to RealConnection(TaskRunner,RealConnectionPool,Route)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "16173e2af93fe69ac39787e0e5d22649ff264cff", "url" : "https://github.com/square/okhttp/commit/16173e2af93fe69ac39787e0e5d22649ff264cff", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method log(Int,String,Throwable) in class Platform is changed to log(String,Int,Throwable)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method log(Int,String,Throwable) in class Android10Platform is changed to log(String,Int,Throwable)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method log(Int,String,Throwable) in class AndroidPlatform is changed to log(String,Int,Throwable)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "353a52b970dda692f36b94556027e78b27352340", "url" : "https://github.com/square/okhttp/commit/353a52b970dda692f36b94556027e78b27352340", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readValue(DerReader) in class BasicDerAdapter is renamed to fromDer(DerReader)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method writeValue(DerWriter,T) in class BasicDerAdapter is renamed to toDer(DerWriter,T)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readValue(DerReader) in class DerAdapter is renamed to fromDer(DerReader)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method writeValue(DerWriter,T) in class DerAdapter is renamed to toDer(DerWriter,T)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field ou in class Builder is rename to organizationalUnit", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field cn in class Builder is rename to commonName", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/okhttp", "sha1" : "334eb0072512155e57a809b2fa18861c0d68ec9f", "url" : "https://github.com/square/okhttp/commit/334eb0072512155e57a809b2fa18861c0d68ec9f", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class okhttp3.internal.sse.ServerSentEventReader is Move to okhttp3.sse.internal.ServerSentEventReader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class okhttp3.internal.sse.RealEventSource is Move to okhttp3.sse.internal.RealEventSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] },{ "repository" : "https://github.com/square/okhttp", "sha1" : "f934da0e82233c6c64ce9b9ea7f470561ac9c8c0", "url" : "https://github.com/square/okhttp/commit/f934da0e82233c6c64ce9b9ea7f470561ac9c8c0", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method connectTls(ConnectionSpecSelector) in class RealConnection is changed to connectTls(SSLSocket,ConnectionSpec)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method connectSocket(Int,Int,Call,EventListener) in class RealConnection is changed to connectSocket(Int,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "KotlinRMiner identifies two change method parameters. one for each parameter which is removed.", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method firstEquipPlan() in class RealConnection is extracted from method connect(Int,Int,Int,Int,Boolean,Call,EventListener) in class RealConnection", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/picasso", "sha1" : "01cfad966727151dbbfc94cc64edad714bcfb2e1", "url" : "https://github.com/square/picasso/commit/01cfad966727151dbbfc94cc64edad714bcfb2e1", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method cancelExistingRequestWithTarget() in class PicassoTest is renamed to cancelExistingRequestWithBitmapTarget()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method cancelExistingRequestWithTarget is replaced with two methods.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method cancelExistingRequestWithTarget() in class PicassoTest is renamed to cancelExistingRequestWithDrawableTarget()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method cancelExistingRequestWithTarget is replaced with two methods.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method mockTarget() in class TestUtils is renamed to mockBitmapTarget()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "2df8d854279480d5636c0ff266b85f9b0bd935ea", "url" : "https://github.com/square/picasso/commit/2df8d854279480d5636c0ff266b85f9b0bd935ea", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method cancelExistingRequestWithTarget() in class PicassoTest is renamed to cancelExistingRequestWithBitmapTarget()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method mockTarget() in class TestUtils is renamed to mockBitmapTarget()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "3ba6407da405c5435ddf95a5cc3d799e01aafb50", "url" : "https://github.com/square/picasso/commit/3ba6407da405c5435ddf95a5cc3d799e01aafb50", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(Picasso,String,Uri?,Any,Int,Priority?,String?) in class TestUtils is changed to mockAction(Picasso,String,Uri?,Any,Int,Priority?,String?,Map)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "e15caede1fcc9cab1896ec4c9c77b55352b27e57", "url" : "https://github.com/square/picasso/commit/e15caede1fcc9cab1896ec4c9c77b55352b27e57", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method placeholder(Drawable) in class RequestCreator is changed to placeholder(Drawable?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "18c5133e8883776944795dc0acc0f7433390bda0", "url" : "https://github.com/square/picasso/commit/18c5133e8883776944795dc0acc0f7433390bda0", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean) in class TestUtils is changed to mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean,Dispatcher)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method forRequest(Picasso,Dispatcher,PlatformLruCache,Action) in class BitmapHunter is changed to forRequest(Picasso,Dispatcher,PlatformLruCache,Action)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method BitmapHunter(Picasso,Dispatcher,PlatformLruCache,Action,RequestHandler) in class BitmapHunter is changed to BitmapHunter(Picasso,Dispatcher,PlatformLruCache,Action,RequestHandler)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/square/picasso", "sha1" : "85a427b0b019fcca6ef3d3a3c576dd988aed1f76", "url" : "https://github.com/square/picasso/commit/85a427b0b019fcca6ef3d3a3c576dd988aed1f76", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockRequestCreator() in class TestUtils is changed to mockRequestCreator(Picasso)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "a43068bceb918c33491990f6acb01ad6d6403278", "url" : "https://github.com/square/picasso/commit/a43068bceb918c33491990f6acb01ad6d6403278", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method transform(Result) in class GrayscaleTransformation is changed to transform(Result.Bitmap)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "b35e31b5510354dbb161f45d2cd203b0788f4ec2", "url" : "https://github.com/square/picasso/commit/b35e31b5510354dbb161f45d2cd203b0788f4ec2", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(String,Uri,Any,Int,Priority,String) in class TestUtils is changed to mockAction(Picasso,String,Uri,Any,Int,Priority,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockHunter(Result,Action,Exception,Boolean,Boolean) in class TestUtils is changed to mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockPicasso() in class TestUtils is changed to mockPicasso(Context)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(String,Uri,Any,String) in class TestUtils is changed to mockAction(Picasso,String,Uri,Any,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(Request,Any) in class TestUtils is changed to mockAction(Picasso,Request,Any)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "c867bb3f41faba5123d12bd58ae0166231473c42", "url" : "https://github.com/square/picasso/commit/c867bb3f41faba5123d12bd58ae0166231473c42", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method createWithConfigAndNotInJustDecodeBoundsOrInPurgeable() in class BitmapUtilsTest is renamed to createWithConfigAndNotInJustDecodeBounds()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method nullBitmapOptionsIfNoResizingOrPurgeable() in class BitmapUtilsTest is renamed to nullBitmapOptionsIfNoResizing()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "d059e87ee2af1a6d36a98c1be507049b09c3799b", "url" : "https://github.com/square/picasso/commit/d059e87ee2af1a6d36a98c1be507049b09c3799b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(Picasso,String,Uri?,Any,Int,Priority?,String?) in class TestUtils is changed to mockAction(Picasso,String,Uri?,Any,Int,Priority?,String?,Map)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "e754c179dd0211e30eebcbbfb9f5b18cea53db2b", "url" : "https://github.com/square/picasso/commit/e754c179dd0211e30eebcbbfb9f5b18cea53db2b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockRequestCreator() in class TestUtils is changed to mockRequestCreator(Picasso)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "f7f38007f78d52791fd8ff435641458e0c6163d7", "url" : "https://github.com/square/picasso/commit/f7f38007f78d52791fd8ff435641458e0c6163d7", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method placeholder(Drawable) in class RequestCreator is changed to placeholder(Drawable?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "6fee726ee2d80c9867f737d403ce4e66567f5988", "url" : "https://github.com/square/picasso/commit/6fee726ee2d80c9867f737d403ce4e66567f5988", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.picasso3.Dispatcher.DispatcherHandler is Move to com.squareup.picasso3.HandlerDispatcher.DispatcherHandler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.picasso3.Dispatcher.DispatcherThread is Move to com.squareup.picasso3.HandlerDispatcher.DispatcherThread", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass HandlerDispatcher is extracted from parent class Dispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchAirplaneModeChange(Boolean) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchCancel(Action) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchFailed(BitmapHunter) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchPauseTag(Any) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchResumeTag(Any) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchSubmit(Action) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchRetry(BitmapHunter) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchComplete(BitmapHunter) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method dispatchNetworkStateChange(NetworkInfo) in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field handler in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field AIRPLANE_MODE_CHANGE in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field AIRPLANE_MODE_ON in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field HUNTER_DECODE_FAILED in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field HUNTER_RETRY in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field REQUEST_CANCEL in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field REQUEST_SUBMIT in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field TAG_PAUSE in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field TAG_RESUME in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field dispatcherThread in class Dispatcher is pushed down to class HandlerDispatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is an inner class.", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "e040c93ade48855fbab7c73b9d1e57f59776c029", "url" : "https://github.com/square/picasso/commit/e040c93ade48855fbab7c73b9d1e57f59776c029", "refactorings" : [ ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "702b78bbe9be8fa6c016b72d054e38f23c27bd2c", "url" : "https://github.com/square/picasso/commit/702b78bbe9be8fa6c016b72d054e38f23c27bd2c", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.picasso3.StatsEventListener is Move to com.squareup.picasso3.stats.StatsEventListener", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "791059533f01325d1a41b78c3c3741336dc95f94", "url" : "https://github.com/square/picasso/commit/791059533f01325d1a41b78c3c3741336dc95f94", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(String,Uri,Any,Int,Priority,String) in class TestUtils is changed to mockAction(Picasso,String,Uri,Any,Int,Priority,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockHunter(Result,Action,Exception,Boolean,Boolean) in class TestUtils is changed to mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockPicasso() in class TestUtils is changed to mockPicasso(Context)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(String,Uri,Any,String) in class TestUtils is changed to mockAction(Picasso,String,Uri,Any,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockAction(Request,Any) in class TestUtils is changed to mockAction(Picasso,Request,Any)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "7a737fc6f912c022106f60ac48bc709226d5befa", "url" : "https://github.com/square/picasso/commit/7a737fc6f912c022106f60ac48bc709226d5befa", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean) in class TestUtils is changed to mockHunter(Picasso,Result,Action,Exception,Boolean,Boolean,Dispatcher)", "detectionTools" : [ "RefDetect","KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "7e047609d573fbd7c3512c68d7dd327163fb0319", "url" : "https://github.com/square/picasso/commit/7e047609d573fbd7c3512c68d7dd327163fb0319", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method createWithConfigAndNotInJustDecodeBoundsOrInPurgeable() in class BitmapUtilsTest is renamed to createWithConfigAndNotInJustDecodeBounds()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method nullBitmapOptionsIfNoResizingOrPurgeable() in class BitmapUtilsTest is renamed to nullBitmapOptionsIfNoResizing()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "f8188f058d722a85a588230129a16b5ee02a2bc8", "url" : "https://github.com/square/picasso/commit/f8188f058d722a85a588230129a16b5ee02a2bc8", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method updateThreadName(Request) in class BitmapHunter is renamed to getName(Request)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.squareup.picasso3.Dispatcher.NetworkBroadcastReceiver is Move to com.squareup.picasso3.BaseDispatcher.NetworkBroadcastReceiver", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass BaseDispatcher is extracted from parent class Dispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performPauseTag(Any) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performRetry(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performCancel(Action) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performSubmit(Action,Boolean) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performResumeTag(Any) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performComplete(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method flushFailedActions() in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method deliver(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method markForReplay(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method logDelivery(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method markForReplay(Action) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performBatchResumeMain(List) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performError(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performNetworkStateChange(NetworkInfo) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performAirplaneModeChange(Boolean) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method performCompleteMain(BitmapHunter) in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method NetworkBroadcastReceiver(Dispatcher) in class NetworkBroadcastReceiver is changed to NetworkBroadcastReceiver(BaseDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Class is moved and parameter of constructor is changed from Dispatcher to BaseDispatcher.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MainDispatcherHandler(Looper,Dispatcher) in class MainDispatcherHandler is changed to MainDispatcherHandler(Looper,HandlerDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method InternalCoroutineDispatcher(Context,ExecutorService,Handler,PlatformLruCache,CoroutineDispatcher) in class InternalCoroutineDispatcher is changed to InternalCoroutineDispatcher(Context,Handler,PlatformLruCache,CoroutineDispatcher,CoroutineDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getName(Request) in class BitmapHunter is changed to getName()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass BaseDispatcher is extracted from children classes HandlerDispatcher,InternalCoroutineDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "It can be true as well. These classes were inherited from Dispatcher and in the new version they are inherited from BaseDispatcher.", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field hunterMap in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field failedActions in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field pausedActions in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field pausedTags in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field airplaneMode in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field scansNetworkChanges in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field HUNTER_COMPLETE in class Dispatcher is moved to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field NETWORK_STATE_CHANGE in class Dispatcher is moved to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field REQUEST_BATCH_RESUME in class Dispatcher is moved to class HandlerDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field picassoDispatcher in class Builder is rename to backgroundDispatcher", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Filed is split in two fields.", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method shutdown() in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field receiver in class Dispatcher is pushed down to class BaseDispatcher", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/square/picasso", "sha1" : "188766abe0918e7267261c592f860aa057827a18", "url" : "https://github.com/square/picasso/commit/188766abe0918e7267261c592f860aa057827a18", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class BitmapTargetAction is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Seems a bug in PSI. It results FP for the below ones as well.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class ImageViewAction is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class RemoteViewsAction is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class FetchAction is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class Action is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method complete(Result) in class GetAction is changed to complete(Result)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface RequestHandler is extracted from classes AssetRequestHandler,ContactsPhotoRequestHandler,ContentStreamRequestHandler,ResourceDrawableRequestHandler,ResourceRequestHandler", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method transform(Result) in class GrayscaleTransformation is changed to transform(Result.Bitmap)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "07687bc7fe34119de87e0fe692ce27568d6fbc1a", "url" : "https://github.com/nickbutcher/plaid/commit/07687bc7fe34119de87e0fe692ce27568d6fbc1a", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ProductHuntRepository,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ProductHuntRepository,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method getInstance(List,SourcesLocalDataSource) in class SourcesRepository is extracted from method provideSourceRepository(Context) in class SourcesRepositoryModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method registerFilterChangedCallback(FiltersChangedCallback) in class FilterAdapter is moved to class SourcesRepository", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "26fb1a26d047cf332827d38ee1f9fcdbbc58c5a1", "url" : "https://github.com/nickbutcher/plaid/commit/26fb1a26d047cf332827d38ee1f9fcdbbc58c5a1", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method DesignerNewsSearchSource(String,Boolean) in class DesignerNewsSearchSource is renamed to DesignerNewsSearchSourceItem(String,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method loadMore() in class SearchUseCase is renamed to invoke()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.search.domain.SearchUseCase is Rename to io.plaidapp.search.domain.LoadSearchDataUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.designernews.data.DesignerNewsSearchSource is Rename to io.plaidapp.core.designernews.data.DesignerNewsSearchSourceItem", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DesignerNewsSourceItem(String,Int,String,Boolean) in class DesignerNewsSourceItem is changed to DesignerNewsSourceItem(String,String,Int,String,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SourceItem(String,Int,String,Int,Boolean,Boolean) in class SourceItem is changed to SourceItem(String,String,Int,String,Int,Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field searchUseCase in class SearchViewModel is rename to loadSearchData", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method loadMore() in class LoadSearchDataUseCase is renamed to invoke()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "3300952e4d2ffb310566e65ab8e966145724babc", "url" : "https://github.com/nickbutcher/plaid/commit/3300952e4d2ffb310566e65ab8e966145724babc", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getCommentsWithReplies(List) in class CommentsWithRepliesUseCase is renamed to invoke(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method CommentsWithRepliesUseCase(CommentsRepository) in class CommentsWithRepliesUseCase is renamed to GetCommentsWithRepliesUseCase(CommentsRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method CommentsWithRepliesAndUsersUseCase(CommentsWithRepliesUseCase,UserRepository) in class CommentsWithRepliesAndUsersUseCase is renamed to GetCommentsWithRepliesAndUsersUseCase(CommentsWithRepliesUseCase,UserRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsWithRepliesUseCase is Rename to io.plaidapp.designernews.domain.GetCommentsWithRepliesUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCaseTest is Rename to io.plaidapp.designernews.domain.GetCommentsWithRepliesAndUsersUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCase is Rename to io.plaidapp.designernews.domain.GetCommentsWithRepliesAndUsersUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCaseIntegrationTest is Rename to io.plaidapp.designernews.domain.GetCommentsWithRepliesAndUsersUseCaseIntegrationTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsWithRepliesUseCaseTest is Rename to io.plaidapp.designernews.domain.GetCommentsWithRepliesUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field commentsWithRepliesUseCase in class CommentsWithRepliesAndUsersUseCaseTest is rename to getCommentsWithReplies", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field commentsWithRepliesAndUsers in class StoryViewModelTest is rename to getCommentsWithRepliesAndUsers", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "368320d22212fd8bc202875f6ae179342962ba33", "url" : "https://github.com/nickbutcher/plaid/commit/368320d22212fd8bc202875f6ae179342962ba33", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method designerNewsSearchDataSourceFactory(StoriesRepository) in class SearchDataModule is renamed to searchDataSourceFactory(StoriesRepository)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getFactory() in class SearchFactoryProvider is changed to getFactory(Context)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getFactory() in class DesignerNewsSearchFactoryProvider is changed to getFactory(Context)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "4a0d3500285365b89a27308d603e773cac7e3066", "url" : "https://github.com/nickbutcher/plaid/commit/4a0d3500285365b89a27308d603e773cac7e3066", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.CommentsRemoteDataSource is Move to io.plaidapp.designernews.data.comments.CommentsRemoteDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.CommentsRemoteDataSourceTest is Move to io.plaidapp.designernews.data.comments.CommentsRemoteDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.CommentsRepository is Move to io.plaidapp.designernews.data.comments.CommentsRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.CommentsRepositoryTest is Move to io.plaidapp.designernews.data.comments.CommentsRepositoryTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method provideCommentsRepository(CommentsRemoteDataSource) in class DesignerNewsDataModule is moved to class StoryModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "58d5fbb8916e2627e6eb95a59139e547d0699b50", "url" : "https://github.com/nickbutcher/plaid/commit/58d5fbb8916e2627e6eb95a59139e547d0699b50", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method upvoteStory_whenUserLoggedIn_whenRequestFailed() in class DesignerNewsVotesRepositoryTest is renamed to upvoteStory_whenRequestFailed()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method upvoteStory_whenUserLoggedIn_whenRequestSuccessful() in class DesignerNewsVotesRepositoryTest is renamed to upvoteStory_whenRequestSuccessful()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DesignerNewsVotesRepository(DesignerNewsService,DesignerNewsLoginRepository,CoroutinesContextProvider) in class DesignerNewsVotesRepository is changed to DesignerNewsVotesRepository(DesignerNewsService,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getInstance(DesignerNewsService,DesignerNewsLoginRepository,CoroutinesContextProvider) in class DesignerNewsVotesRepository is changed to getInstance(DesignerNewsService,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method upvoteStory(Long,(result: Result) in class DesignerNewsVotesRepository is changed to upvoteStory(Long,Long,(result: Result)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDesignerNewsVotesRepository(DesignerNewsService,DesignerNewsLoginRepository,CoroutinesContextProvider) in class Injection is changed to provideDesignerNewsVotesRepository(DesignerNewsService,CoroutinesContextProvider)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "59b0db77b447b55763f7a5acd28d2893b1bdce0d", "url" : "https://github.com/nickbutcher/plaid/commit/59b0db77b447b55763f7a5acd28d2893b1bdce0d", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.CommentLinks is Move to io.plaidapp.designernews.data.comments.model.CommentLinks", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.PostCommentRequest is Move to io.plaidapp.designernews.data.comments.model.PostCommentRequest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.NewCommentRequest is Move to io.plaidapp.designernews.data.comments.model.NewCommentRequest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.CommentLinksResponse is Move to io.plaidapp.designernews.data.comments.model.CommentLinksResponse", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.CommentResponse is Move to io.plaidapp.designernews.data.comments.model.CommentResponse", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.CommentData is Move to io.plaidapp.designernews.data.comments.model.CommentData", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.comments.model.PostCommentResponse is Move to io.plaidapp.designernews.data.comments.model.PostCommentResponse", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideCommentsRemoteDataSource(DesignerNewsService) in class StoryModule is changed to provideCommentsRemoteDataSource(DNService)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getInstance(DesignerNewsService) in class CommentsRemoteDataSource is changed to getInstance(DNService)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method CommentsRemoteDataSource(DesignerNewsService) in class CommentsRemoteDataSource is changed to CommentsRemoteDataSource(DNService)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class DNService is extracted from class DesignerNewsService", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getComments(String) in class DesignerNewsService is moved to class DNService", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method comment(NewCommentRequest) in class DesignerNewsService is moved to class DNService", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "5d154ab9ee439ace783d1b5a996a86f13e6bb836", "url" : "https://github.com/nickbutcher/plaid/commit/5d154ab9ee439ace783d1b5a996a86f13e6bb836", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.CommentLinksResponse is Move to io.plaidapp.core.designernews.data.comments.model.CommentLinksResponse", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.data.LoginRepository is Move to io.plaidapp.core.designernews.data.login.LoginRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.ui.LoginViewModelTest is Move to io.plaidapp.core.designernews.ui.login.LoginViewModelTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.StoryLinks is Move to io.plaidapp.core.designernews.data.stories.model.StoryLinks", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.DesignerNewsAuthTokenLocalDataSource is Move to io.plaidapp.core.designernews.data.login.DesignerNewsAuthTokenLocalDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.DesignerNewsAuthTokenLocalDataSourceTest is Move to io.plaidapp.core.base.designernews.data.login.DesignerNewsAuthTokenLocalDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.DesignerNewsRepository is Move to io.plaidapp.core.designernews.data.stories.DesignerNewsRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.AccessToken is Move to io.plaidapp.core.designernews.data.login.model.AccessToken", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.User is Move to io.plaidapp.core.designernews.data.users.model.User", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class io.plaidapp.designernews.ui.login.data.DesignerNewsLoginDataSourceTest is MoveAndRename to io.plaidapp.core.base.designernews.data.login.LoginLocalDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.data.DesignerNewsLoginRemoteDataSourceTest is Move to io.plaidapp.core.designernews.data.login.DesignerNewsLoginRemoteDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.NewStoryRequest is Move to io.plaidapp.core.designernews.data.poststory.model.NewStoryRequest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.data.LoginRemoteDataSource is Move to io.plaidapp.core.designernews.data.login.LoginRemoteDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.data.LoginRepositoryTest is Move to io.plaidapp.core.designernews.data.login.LoginRepositoryTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.ui.LoginUiModel is Move to io.plaidapp.core.designernews.ui.login.LoginUiModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.Story is Move to io.plaidapp.core.designernews.data.stories.model.Story", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.CommentResponse is Move to io.plaidapp.core.designernews.data.comments.model.CommentResponse", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.ui.LoginViewModel is Move to io.plaidapp.core.designernews.ui.login.LoginViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.login.data.LoginLocalDataSource is Move to io.plaidapp.core.designernews.data.login.LoginLocalDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.ui.DesignerNewsStoryHolder is Move to io.plaidapp.core.designernews.ui.stories.DesignerNewsStoryHolder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.api.model.Comment is Move to io.plaidapp.core.designernews.domain.model.Comment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "608f7cd88ce14ef2dd9ae0f08c6df63b522f72a4", "url" : "https://github.com/nickbutcher/plaid/commit/608f7cd88ce14ef2dd9ae0f08c6df63b522f72a4", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.ui.login.LoginViewModel is Move to io.plaidapp.designernews.ui.login.LoginViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.ui.ViewModelFactory is Rename to io.plaidapp.designernews.ui.DesignerNewsViewModelFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.ui.login.LoginUiModel is Move to io.plaidapp.designernews.ui.login.LoginUiModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.util.LiveDataTestUtil is Move to io.plaidapp.test.shared.LiveDataTestUtil", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "69d64546d2de12dbf1b095917727451763eaee1e", "url" : "https://github.com/nickbutcher/plaid/commit/69d64546d2de12dbf1b095917727451763eaee1e", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,FilterAdapter)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,FilterAdapter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ShotsRepository,FilterAdapter) in class DataManagerModule is changed to provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ProductHuntRepository,ShotsRepository,FilterAdapter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method CoreDataModule(String,Factory) in class CoreDataModule is changed to CoreDataModule(String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SearchDataManager(Context,OnDataLoadedCallback,ShotsRepository) in class SearchDataManager is changed to SearchDataManager(OnDataLoadedCallback,ShotsRepository,SearchStoriesUseCase)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class OkHttpClientModule is extracted from class DribbbleDataModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method provideGson() in class DesignerNewsDataModule is moved to class CoreDataModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method provideOkHttpClient(HttpLoggingInterceptor) in class DribbbleDataModule is moved to class OkHttpClientModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "7e6c07fc08b6eb5e85cbdfaec74f685d2758c972", "url" : "https://github.com/nickbutcher/plaid/commit/7e6c07fc08b6eb5e85cbdfaec74f685d2758c972", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method DribbbleShotViewModel(Long,DribbbleRepository,GetShareShotInfoUseCase,CoroutinesContextProvider) in class DribbbleShotViewModel is renamed to ShotViewModel(Long,DribbbleRepository,GetShareShotInfoUseCase,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.base.designernews.data.login.LoginLocalDataSourceTest is Move to io.plaidapp.core.designernews.data.login.LoginLocalDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.base.designernews.data.login.AuthTokenLocalDataSourceTest is Move to io.plaidapp.core.designernews.data.login.AuthTokenLocalDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.dribbble.data.search.DribbbleSearchRemoteDataSource.SortOrder is Move to io.plaidapp.core.dribbble.data.search.SearchRemoteDataSource.SortOrder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The outer class is moved and so its inner class are moved as well.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.dribbble.ui.shot.DribbbleShotViewModelTest is Rename to io.plaidapp.dribbble.ui.shot.ShotViewModelTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.dribbble.ui.shot.DribbbleShotViewModelFactory is Rename to io.plaidapp.dribbble.ui.shot.ShotViewModelFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.dribbble.data.search.DribbbleSearchRemoteDataSourceTest is Rename to io.plaidapp.core.dribbble.data.search.SearchRemoteDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.dribbble.ui.shot.DribbbleShotActivity is Rename to io.plaidapp.dribbble.ui.shot.ShotActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.dribbble.ui.shot.DribbbleShotViewModel is Rename to io.plaidapp.dribbble.ui.shot.ShotViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.dribbble.data.DribbbleRepositoryTest is Rename to io.plaidapp.core.dribbble.data.ShotsRepositoryTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.dribbble.data.DribbbleRepository is Rename to io.plaidapp.core.dribbble.data.ShotsRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.dribbble.domain.DribbbleImageUriProvider is Rename to io.plaidapp.dribbble.domain.ImageUriProvider", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getInstance(DribbbleSearchRemoteDataSource,CoroutinesContextProvider) in class DribbbleRepository is changed to getInstance(SearchRemoteDataSource,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class is renamed", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class SearchRemoteDataSource is extracted from class DribbbleSearchRemoteDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method search(String,Int,SortOrder,Int) in class DribbbleSearchRemoteDataSource is moved to class SearchRemoteDataSource", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.dribbble.data.search.DribbbleSearchRemoteDataSource is Rename to io.plaidapp.core.dribbble.data.search.SearchRemoteDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "91f9cf247c1940a0323fd1f6cde84e63f4191687", "url" : "https://github.com/nickbutcher/plaid/commit/91f9cf247c1940a0323fd1f6cde84e63f4191687", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createRetrofit(Lazy,GsonConverterFactory,DeEnvelopingConverter,CoroutineCallAdapterFactory) in class ProductHuntModule is changed to createRetrofit(Lazy,GsonConverterFactory,DeEnvelopingConverter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDribbbleSearchService(Lazy,Factory,CoroutineCallAdapterFactory) in class DribbbleDataModule is changed to provideDribbbleSearchService(Lazy,Factory)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideProductHuntService(Lazy,GsonConverterFactory,DeEnvelopingConverter,CoroutineCallAdapterFactory) in class ProductHuntModule is changed to provideProductHuntService(Lazy,GsonConverterFactory,DeEnvelopingConverter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method createRetrofit(Lazy,GsonConverterFactory,DeEnvelopingConverter,CoroutineCallAdapterFactory) in class ProductHuntModule is inlined to method provideProductHuntService(Lazy,GsonConverterFactory,DeEnvelopingConverter) in class ProductHuntModule", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "9888c5b4a1518b62ac992535f45ad1dab3986fa8", "url" : "https://github.com/nickbutcher/plaid/commit/9888c5b4a1518b62ac992535f45ad1dab3986fa8", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getPosts(Int) in class ProductHuntService is renamed to getPostsAsync(Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to getDataManager(OnDataLoadedCallback,LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,ProductHuntRepository,SearchStoriesUseCase,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to provideDataLoadingSubject(OnDataLoadedCallback,LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,ProductHuntRepository,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to provideDataManager(OnDataLoadedCallback,LoadStoriesUseCase,SearchStoriesUseCase,LoadPostsUseCase,ShotsRepository,SourcesRepository)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Post(Long,String,String,String,String,String,String,Int,Int) in class Post is changed to Post(Long,String,String,String,String,String,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class LoadPostsUseCase is extracted from class ProductHuntRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field parentJob in class ProductHuntRepository is moved to class LoadPostsUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field scope in class ProductHuntRepository is moved to class LoadPostsUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method cancelAllRequests() in class ProductHuntRepository is moved to class LoadPostsUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "a3c35f3a0335ea8f663bfc4c6eb173ab4e5f356e", "url" : "https://github.com/nickbutcher/plaid/commit/a3c35f3a0335ea8f663bfc4c6eb173ab4e5f356e", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.interfaces.designernews.DesignerNewsSearchDataSourceFactory is Move to io.plaidapp.designernews.domain.search.DesignerNewsSearchDataSourceFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.interfaces.dribbble.DribbbleDataSource is Move to io.plaidapp.dribbble.domain.search.DribbbleDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.interfaces.designernews.DesignerNewsDataSource is Move to io.plaidapp.designernews.domain.search.DesignerNewsDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.interfaces.dribbble.DribbbleSearchDataSourceFactory is Move to io.plaidapp.dribbble.domain.search.DribbbleSearchDataSourceFactory", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SearchViewModel(SearchDataSourcesRegistry,CoroutinesDispatcherProvider) in class SearchViewModel is changed to SearchViewModel(SearchDataSourcesFactory,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SearchViewModelFactory(SearchDataSourcesRegistry,CoroutinesDispatcherProvider) in class SearchViewModelFactory is changed to SearchViewModelFactory(SearchDataSourcesFactory,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SearchUseCase(SearchDataSourcesRegistry,String) in class SearchUseCase is changed to SearchUseCase(SearchDataSourcesFactory,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface SearchFactoryProvider is extracted from classes DesignerNewsSearchFactoryProvider", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class SearchDataSourcesFactory is extracted from class SearchDataSourcesRegistry", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method buildSearchDataSources(String) in class SearchDataSourcesRegistry is moved to class SearchDataSourcesFactory", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.core.interfaces.SearchDataSourcesRegistry is Rename to io.plaidapp.core.interfaces.SearchDataSourcesFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "a6f85a27572085c3ab95fbb12dd7677c154109d5", "url" : "https://github.com/nickbutcher/plaid/commit/a6f85a27572085c3ab95fbb12dd7677c154109d5", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getDataManager(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to getDataManager(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataLoadingSubject(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to provideDataLoadingSubject(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideDataManager(LoadStoriesUseCase,SearchStoriesUseCase,LoadPostsUseCase,ShotsRepository,SourcesRepository) in class DataManagerModule is changed to provideDataManager(LoadStoriesUseCase,SearchStoriesUseCase,LoadPostsUseCase,ShotsRepository,SourcesRepository,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadPostsUseCase(ProductHuntRepository,CoroutinesDispatcherProvider) in class LoadPostsUseCase is changed to LoadPostsUseCase(ProductHuntRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method DataManager(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository) in class DataManager is changed to DataManager(LoadStoriesUseCase,LoadPostsUseCase,SearchStoriesUseCase,ShotsRepository,SourcesRepository,CoroutinesDispatcherProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field scope in class LoadPostsUseCase is moved to class DataManager", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field parentJobs in class LoadPostsUseCase is moved to class DataManager", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method cancelAllRequests() in class LoadPostsUseCase is inlined to method cancelLoading() in class DataManager", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "c0e560baf2d23bccc903cb476bea038904775446", "url" : "https://github.com/nickbutcher/plaid/commit/c0e560baf2d23bccc903cb476bea038904775446", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.database.LoggedInUserDao is Move to io.plaidapp.designernews.data.database.LoggedInUserDao", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.data.database.Converters is Move to io.plaidapp.designernews.data.database.Converters", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.database.DesignerNewsDatabase is Move to io.plaidapp.designernews.data.database.DesignerNewsDatabase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.data.ConvertersTest is Move to io.plaidapp.designernews.data.database.ConvertersTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.data.database.LoggedInUserDaoTest is Move to io.plaidapp.designernews.data.database.LoggedInUserDaoTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method provideLoggedInUserDao(Context) in class DesignerNewsDataModule is moved to class DataModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "d928a22a77034121cd3a4ab9ce11046e1465788c", "url" : "https://github.com/nickbutcher/plaid/commit/d928a22a77034121cd3a4ab9ce11046e1465788c", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Comment(Long,Long,String,Date,Int,Int,List,Long,String,String,Boolean) in class Comment is changed to Comment(Long,Long,String,Date,Int,Int,Long,String,String,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method match(List,Map) in class CommentsUseCase is inlined to method createComments(List,Set) in class CommentsUseCase", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method toComment(List,User?) in class CommentWithReplies is changed to toComment(User?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "db5ece6d8328e8184be4c47599d73c506f768b64", "url" : "https://github.com/nickbutcher/plaid/commit/db5ece6d8328e8184be4c47599d73c506f768b64", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method StoryViewModelFactory(Long,StoriesRepository,UpvoteStoryUseCase,UpvoteCommentUseCase,CoroutinesContextProvider) in class StoryViewModelFactory is changed to StoryViewModelFactory(Long,GetStoryUseCase,UpvoteStoryUseCase,UpvoteCommentUseCase,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getInstance(StoriesRemoteDataSource,CoroutinesContextProvider) in class StoriesRepository is changed to getInstance(StoriesRemoteDataSource)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method StoryViewModel(Long,StoriesRepository,UpvoteStoryUseCase,UpvoteCommentUseCase,CoroutinesContextProvider) in class StoryViewModel is changed to StoryViewModel(Long,GetStoryUseCase,UpvoteStoryUseCase,UpvoteCommentUseCase,CoroutinesContextProvider)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class SearchStoriesUseCase is extracted from class StoriesRepository", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class LoadStoriesUseCase is extracted from class StoriesRepository", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field parentJobs in class StoriesRepository is moved to class LoadStoriesUseCase", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method cancelAllRequests() in class StoriesRepository is moved to class LoadStoriesUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method cancelRequestOfSource(String) in class StoriesRepository is moved to class LoadStoriesUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getResult(Response>,()) in class StoriesRemoteDataSource is changed to getResult(Response>,())", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method cache(List) in class StoriesRepository is changed to cache(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method withStoriesSuccess(Int,List) in class StoriesRemoteDataSourceTest is changed to withStoriesSuccess(Int,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method withSearchSuccess(String,Int,List) in class StoriesRemoteDataSourceTest is changed to withSearchSuccess(String,Int,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method launchRequest(String,Int,LoadSourceCallback,String,()) in class StoriesRepository is changed to launchRequest(String,Int,LoadSourceCallback,String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method launchRequest(String,Int,LoadSourceCallback,String,() in class StoriesRepository is moved to class SearchStoriesUseCase", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "eabe8c47528f1b7e7f3e9277a17e81a974fbf1f8", "url" : "https://github.com/nickbutcher/plaid/commit/eabe8c47528f1b7e7f3e9277a17e81a974fbf1f8", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getComments() in class CommentsRepositoryTest is renamed to getComments_withError()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "The method is replaced with two methods.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method getComments() in class CommentsRepositoryTest is renamed to getComments_withSuccess()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The method is replaced with two methods.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class io.plaidapp.core.designernews.domain.CommentWithReplies is Move to io.plaidapp.core.designernews.domain.model.CommentWithReplies", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getInstance(DesignerNewsService) in class UserRepository is changed to getInstance(UserRemoteDataSource)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class UserRemoteDataSourceTest is extracted from class UserRepositoryTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class UserRemoteDataSource is extracted from class UserRepository", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method withUsersSuccess(String,List) in class UserRepositoryTest is moved to class UserRemoteDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method withUsersError(String) in class UserRepositoryTest is moved to class UserRemoteDataSourceTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideUserRepository(DesignerNewsService) in class Injection is changed to provideUserRepository(UserRemoteDataSource)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRminer.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method provideUsersRepository(DesignerNewsService) in class Injection is renamed to provideUserRepository(UserRemoteDataSource)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRminer.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method withUsersSuccess(List) in class UserRepositoryTest is changed to withUsersSuccess(List,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method withUsersSuccess(List) in class UserRepositoryTest is changed to withUsersSuccess(List,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/nickbutcher/plaid", "sha1" : "eac8bc3a53a657b1ee442d053060cecb7f9f4b23", "url" : "https://github.com/nickbutcher/plaid/commit/eac8bc3a53a657b1ee442d053060cecb7f9f4b23", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method CommentsUseCase(CommentsWithRepliesUseCase,UserRepository) in class CommentsUseCase is renamed to CommentsWithRepliesAndUsersUseCase(CommentsWithRepliesUseCase,UserRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsUseCase is Rename to io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsUseCaseTest is Rename to io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class io.plaidapp.designernews.domain.CommentsUseCaseIntegrationTest is Rename to io.plaidapp.designernews.domain.CommentsWithRepliesAndUsersUseCaseIntegrationTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field _uiState in class StoryViewModel is rename to _uiModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field commentsUseCase in class StoryViewModelTest is rename to commentsWithRepliesAndUsers", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method provideCommentsUseCase(Context) in class Injection is renamed to provideCommentsWithRepliesAndUsersUseCase(Context)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "0c3352935a45ba939034e7d707d16db28f4897a5", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/0c3352935a45ba939034e7d707d16db28f4897a5", "refactorings" : [ { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method getFile(String) in class Acl is inlined to method save(String,Acl) in class Acl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method getFile(String) in class Acl is inlined to method fromId(String) in class Acl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.github.shadowsocks.database.DBHelper is Rename to com.github.shadowsocks.database.PrivateDatabase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreate(Bundle,PersistableBundle) in class QuickToggleShortcut is changed to onCreate(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeState(Int,String) in class MainActivity is changed to changeState(Int,String,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method put(MutableSet) in class KeyValuePair is changed to put(Set)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "MutableSet is changed to Set", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method BoundedGridLayout(Context,AttributeSet) in class BoundedGridLayout is changed to BoundedGridLayout(Context,AttributeSet,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreate(Bundle,PersistableBundle) in class VpnRequestActivity is changed to onCreate(Bundle)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createNotification() in class Interface is changed to createNotification(String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method changeState(Int,Boolean) in class ServiceButton is extracted from method changeState(Int,String,Boolean) in class MainActivity", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method clear() in class Acl is extracted from method fromAcl(Acl) in class Acl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method clear() in class Acl is extracted from method fromReader(Reader,Boolean) in class Acl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method updateNotificationChannels() in class App is extracted from method onCreate() in class App", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class OrmLitePreferenceDataStore is extracted from class DataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field listeners in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field proxyHostnames in class Acl is rename to hostnames", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field PROFILE in class Key is rename to DB_PROFILE", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Clas Key is defined in mobile/src/main/java/com/github/shadowsocks/utils/Constants.kt", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method putString(String,String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method putStringSet(String,MutableSet) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method remove(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getBoolean(String,Boolean) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getString(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method fireChangeListener(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method registerChangeListener(OnPreferenceDataStoreChangeListener) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method unregisterChangeListener(OnPreferenceDataStoreChangeListener) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getFloat(String,Float) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getInt(String,Int) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getLong(String,Long) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getString(String,String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getStringSet(String,MutableSet) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getInt(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getLong(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getBoolean(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getFloat(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getStringSet(String) in class DataStore is moved to class OrmLitePreferenceDataStore", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method changeState(Int,String) in class Interface is moved to class Data", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onInitializePluginOptions(PluginOptions) in class HelpCallback is changed to onInitializePluginOptions(PluginOptions)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "While GitHub diff shows the class PluginOptions is deleted and new class is created, but classes are the same. So the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method saveChanges(PluginOptions) in class ConfigurationActivity is changed to saveChanges(PluginOptions)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "While GitHub diff shows the class PluginOptions is deleted and new class is created, but classes are the same. So the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onInitializePluginOptions(PluginOptions) in class HelpActivity is changed to onInitializePluginOptions(PluginOptions)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "While GitHub diff shows the class PluginOptions is deleted and new class is created, but classes are the same. So the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onInitializePluginOptions(PluginOptions) in class OptionsCapableActivity is changed to onInitializePluginOptions(PluginOptions)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "While GitHub diff shows the class PluginOptions is deleted and new class is created, but classes are the same. So the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method produceHelpMessage(PluginOptions) in class HelpCallback is changed to produceHelpMessage(PluginOptions)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "While GitHub diff shows the class PluginOptions is deleted and new class is created, but classes are the same. So the refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createNotification() in class ProxyService is changed to createNotification(String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createNotification() in class TransproxyService is changed to createNotification(String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createNotification() in class VpnService is changed to createNotification(String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "33e5d4ddc148eecd440f8839d09cce7853065e78", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/33e5d4ddc148eecd440f8839d09cce7853065e78", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method init(Application,KClass) in class Core is changed to init(T,KClass)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onConfigurationChanged(Configuration) in class App is changed to onConfigurationChanged(android.content.res.Configuration)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "0939f5b4b81a03b107a9cc03350f503d7a541469", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/0939f5b4b81a03b107a9cc03350f503d7a541469", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onCreatePreferencesFix(Bundle,String) in class ProfileConfigFragment is renamed to onCreatePreferences(Bundle,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onCreatePreferencesFix(Bundle,String) in class GlobalSettingsPreferenceFragment is renamed to onCreatePreferences(Bundle,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "141a3076a8c1cc4bcd4d2af4113007d64b5f83eb", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/141a3076a8c1cc4bcd4d2af4113007d64b5f83eb", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method init(Interface,HostsFile) in class ProxyInstance is changed to init(Interface)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startProcesses(HostsFile) in class VpnService is changed to startProcesses()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startProcesses(HostsFile) in class TransproxyService is changed to startProcesses()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method onActivityResult(Int,Int,Intent?) in class GlobalSettingsPreferenceFragment is inlined to method onActivityResult(Int,Int,Intent?) in class MainPreferenceFragment", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "The method is deleted and onActivityResult in superclass is called directly. We cannot say exactly this is extract method as no related instruction is deleted from method onActivityResult.", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "32aa80078e8ddfb3462820334ac3bfc1bb3c0a7a", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/32aa80078e8ddfb3462820334ac3bfc1bb3c0a7a", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onServiceConnected(IShadowsocksService) in class VpnRequestActivity is renamed to request(IShadowsocksService)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by both tools.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.github.shadowsocks.ShadowsocksConnection is Move to com.github.shadowsocks.aidl.ShadowsocksConnection", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method connect(Context) in class ShadowsocksConnection is changed to connect(Context,Callback)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ShadowsocksConnection(Callback,Boolean) in class ShadowsocksConnection is changed to ShadowsocksConnection(Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method request(IShadowsocksService) in class VpnRequestActivity is changed to request()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed. Both are detected by both tools.", "validator" : "" }] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "32e7d8d2b50e86b4d0951f14d659ce75a0d23922", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/32e7d8d2b50e86b4d0951f14d659ce75a0d23922", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method init(T,KClass) in class Core is changed to init(Application,KClass)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getWorkManagerConfiguration() in class Core is moved to class DeviceStorageApp", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onConfigurationChanged(android.content.res.Configuration) in class App is changed to onConfigurationChanged(Configuration)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "45fea9407c3d85d96c18a8c5c337a9d6d82e9f02", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/45fea9407c3d85d96c18a8c5c337a9d6d82e9f02", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method init(Interface) in class ProxyInstance is changed to init(Interface,HostsFile)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startProcesses() in class Interface is changed to startProcesses(HostsFile)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startProcesses() in class VpnService is changed to startProcesses(HostsFile)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startProcesses() in class TransproxyService is changed to startProcesses(HostsFile)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "6b9f224584dbca2e75be9b6dfed67fa22dcd7cc8", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/6b9f224584dbca2e75be9b6dfed67fa22dcd7cc8", "refactorings" : [ { "refactoringType" : "MoveAndInlineMethod", "description" : "MoveAndInlineMethod: Method SocketListener(String) in class SocketListener is inlined to method LocalSocketListener(String,File) in class LocalSocketListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Thread(name) is replaced.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method close() in class ProxyInstance is renamed to shutdown()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method shutdown() in class ProxyInstance is changed to shutdown(CoroutineScope)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "6ee97f6d2ac2c863da48c49a03af75ff720fa752", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/6ee97f6d2ac2c863da48c49a03af75ff720fa752", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onMenuItemClick(MenuItem) in class AppManager is renamed to onOptionsItemSelected(MenuItem)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onMenuItemClick(MenuItem) in class ProfileConfigFragment is renamed to onOptionsItemSelected(MenuItem)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onMenuItemClick(MenuItem) in class ScannerActivity is renamed to onOptionsItemSelected(MenuItem)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "78f021cd6b8766447168dc0389318502897057c3", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/78f021cd6b8766447168dc0389318502897057c3", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPreferenceDisplayDialog(PreferenceFragment,Preference) in class MainFragment is changed to onPreferenceDisplayDialog(PreferenceFragmentCompat,Preference)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onBindViewHolder(ViewHolder,Int) in class ProfilesAdapter is changed to onBindViewHolder(ProfileViewHolder,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPreferenceStartFragment(PreferenceFragment,Preference) in class MainFragment is changed to onPreferenceStartFragment(PreferenceFragmentCompat,Preference)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPreferenceStartScreen(PreferenceFragment,PreferenceScreen) in class MainFragment is changed to onPreferenceStartScreen(PreferenceFragmentCompat,PreferenceScreen)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onOptionsItemSelected(MenuItem?) in class ProfileConfigActivity is changed to onOptionsItemSelected(MenuItem)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Method now can accept null value", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreateView(LayoutInflater?,ViewGroup?,Bundle?) in class ProfilesDialogFragment is changed to onCreateView(LayoutInflater,ViewGroup?,Bundle?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreateView(LayoutInflater?,ViewGroup?,Bundle?) in class LeanbackSingleListPreferenceDialogFragment is changed to onCreateView(LayoutInflater,ViewGroup?,Bundle?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "9f240ec3fdf300880324d3400a2fc951f7546838", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/9f240ec3fdf300880324d3400a2fc951f7546838", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method registerDefaultNetworkListener() in class DefaultNetworkListener is renamed to register()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method unregisterDefaultNetworkListener() in class DefaultNetworkListener is renamed to unregister()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "d46f4a8614370b39608006a57a01d3a7d89f3344", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/d46f4a8614370b39608006a57a01d3a7d89f3344", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method init(suspend in class ProxyInstance is changed to init(suspend ", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : " InetAddress is changed to Array", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method SocketListener(String) in class SocketListener is extracted from method LocalSocketListener(String,File) in class LocalSocketListener", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass SocketListener is extracted from children classes LocalSocketListener", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method close() in class LocalSocketListener is pulled up to class SocketListener", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field running in class LocalSocketListener is pulled up to class SocketListener", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "dca0da09b4807b5db90292913dbaec9348741cdf", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/dca0da09b4807b5db90292913dbaec9348741cdf", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method stateChanged(Int,String,String) in class Callback is changed to stateChanged(State,String,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method stateChanged(Int,String) in class Binder is changed to stateChanged(State,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeState(Int,String,Boolean) in class MainActivity is changed to changeState(State,String,Boolean)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeState(Int) in class StatsBar is changed to changeState(State)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method stateChanged(Int,String,String) in class QuickToggleShortcut is changed to stateChanged(State,String,String)", "detectionTools" : [ "RefDetect","KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method stateChanged(Int,String,String) in class MainActivity is changed to stateChanged(State,String,String)", "detectionTools" : [ "RefDetect","KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeState(Int,String) in class MainPreferenceFragment is changed to changeState(State,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method stateChanged(Int,String,String) in class MainPreferenceFragment is changed to stateChanged(State,String,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method updateTile(Int,String?) in class TileService is changed to updateTile(BaseService.State,String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeState(Int,Boolean) in class ServiceButton is changed to changeState(BaseService.State,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method changeState(Int,Boolean) in class ServiceButton is inlined to method changeState(BaseService.State,Boolean) in class ServiceButton", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "ee11c896312f783ae69f7ba877349cf8f51334c3", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/ee11c896312f783ae69f7ba877349cf8f51334c3", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method shouldBypass(Inet4Address) in class AclMatcher is renamed to shouldBypassIpv4(Inet4Address)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method shouldBypass(Inet6Address) in class AclMatcher is renamed to shouldBypassIpv6(Inet6Address)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method shouldBypassIpv4(Inet4Address) in class AclMatcher is changed to shouldBypassIpv4(ByteArray)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method shouldBypassIpv6(Inet6Address) in class AclMatcher is changed to shouldBypassIpv6(ByteArray)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Method is renamed and its parameter is changed.", "validator" : "" }] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "f04106a48ce2d3fb651ef2d7e31250fe48238f28", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/f04106a48ce2d3fb651ef2d7e31250fe48238f28", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method unregisterCallback() in class ServiceNotification is renamed to updateCallback()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Both rename and ChangeMethod Parameter applied.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method updateCallback() in class ServiceNotification is changed to updateCallback(Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Both rename and ChangeMethod Parameter applied.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method update(String?,Boolean) in class ServiceNotification is changed to update(Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method update(String?,Boolean) in class ServiceNotification is renamed to updateCallback(Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method unregisterCallback() in class ServiceNotification is inlined to method updateCallback(Boolean) in class ServiceNotification", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The method unregisterCallback is renamed to updateCallback.", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "f053a62f779c8063d56e7de54fa1c9accec5a33d", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/f053a62f779c8063d56e7de54fa1c9accec5a33d", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method HackyTextView(Context,AttributeSet,Int) in class HackyTextView is renamed to AutoCollapseTextView(Context,AttributeSet,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onItemClick(View,Int,IDrawerItem) in class MainActivity is renamed to onNavigationItemSelected(View,Int,IDrawerItem)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Constructor is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class android.support.design.widget.SnackbarConsts is Move to com.google.android.material.snackbar.SnackbarConsts", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.github.shadowsocks.widget.HackyTextView is Rename to com.github.shadowsocks.widget.AutoCollapseTextView", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onNavigationItemSelected(View,Int,IDrawerItem) in class MainActivity is changed to onNavigationItemSelected(MenuItem)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Constructor is renamed and its parameter is changed. Both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onSetInitialValue(Boolean,Any) in class IconListPreference is changed to onSetInitialValue(Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "f3dcec5572c458325105f5d7dad4d15de49156d2", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/f3dcec5572c458325105f5d7dad4d15de49156d2", "refactorings" : [ { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method makeDirt() in class ProfileConfigFragment is extracted from method onPreferenceDataStoreChanged(PreferenceDataStore,String) in class ProfileConfigFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method makeDirt() in class ProfileConfigFragment is extracted from method onPreferenceChange(Preference,Any) in class ProfileConfigFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method makeDirt() in class ProfileConfigFragment is extracted from method onCreatePreferences(Bundle?,String?) in class ProfileConfigFragment", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method makeDirt() in class ProfileConfigFragment is extracted from method onViewCreated(View,Bundle?) in class ProfileConfigFragment", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "f7d504f1d85d31ddc37ff0837e977bf9e59ec114", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/f7d504f1d85d31ddc37ff0837e977bf9e59ec114", "refactorings" : [ { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method updateTraffic(Long,Long,Long,Long,Long) in class MainActivity is changed to updateTraffic(Long,Long,Long,Long) and moved to class StatsBar", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method testConnection(Int) in class MainActivity is changed to testConnection() and moved to class StatsBar", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method changeState(Int) in class StatsBar is extracted from method changeState(Int,String,Boolean) in class MainActivity", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class StatsBar is extracted from class MainActivity", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field rxRateText in class MainActivity is moved to class StatsBar", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field rxText in class MainActivity is moved to class StatsBar", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field testCount in class MainActivity is moved to class StatsBar", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field txRateText in class MainActivity is moved to class StatsBar", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field txText in class MainActivity is moved to class StatsBar", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field statusText in class MainActivity is moved to class StatsBar", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "fa240eaee407ad14b1587c60352f15179345d5aa", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/fa240eaee407ad14b1587c60352f15179345d5aa", "refactorings" : [ { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method clear() in class Acl is inlined to method fromAcl(Acl) in class Acl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method clear() in class Acl is inlined to method fromReader(Reader,Boolean) in class Acl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field hostnames in class Acl is rename to proxyHostnames", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/shadowsocks/shadowsocks-android", "sha1" : "fcdcbd14ff1a62d127b3bd4e2edea709034b5d67", "url" : "https://github.com/shadowsocks/shadowsocks-android/commit/fcdcbd14ff1a62d127b3bd4e2edea709034b5d67", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.github.shadowsocks.ShadowsocksConnection.Interface is Rename to com.github.shadowsocks.ShadowsocksConnection.Callback", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method connect() in class ShadowsocksConnection is changed to connect(Context)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ShadowsocksConnection(Interface) in class ShadowsocksConnection is changed to ShadowsocksConnection(Callback,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field connection in class Interface is moved to class VpnRequestActivity", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method binderDied() in class MainActivity is renamed to onBinderDied()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method binderDied() in class MainPreferenceFragment is renamed to onBinderDied()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method disconnect() in class ShadowsocksConnection is changed to disconnect(Context)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "1ee99d5ee0aa77371c6a0e1538e1c12b1a587df6", "url" : "https://github.com/android/sunflower/commit/1ee99d5ee0aa77371c6a0e1538e1c12b1a587df6", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.sunflower.PlantDetailComposeTest is Move to com.google.samples.apps.sunflower.compose.plantdetail.PlantDetailComposeTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startPlantDetails(Boolean) in class PlantDetailComposeTest is changed to startPlantDetails(Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method navigateToPlant(Plant) in class PlantViewHolder is moved to class PlantListFragment", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "2260621aab49ea29043ae43ae0ebe842f5e0fe7b", "url" : "https://github.com/android/sunflower/commit/2260621aab49ea29043ae43ae0ebe842f5e0fe7b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MainCoroutineRule(TestDispatcher) in class MainCoroutineRule is changed to MainCoroutineRule(TestCoroutineDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method navigateToPlant(Plant,View) in class PlantViewHolder is changed to navigateToPlant(Plant)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method starting(Description) in class MainCoroutineRule is changed to starting(Description?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method finished(Description) in class MainCoroutineRule is changed to finished(Description?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "28bb121bc1c18effe3afae6602ab426ec3b8e9a0", "url" : "https://github.com/android/sunflower/commit/28bb121bc1c18effe3afae6602ab426ec3b8e9a0", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PlantDetailsCallbacks(-,-,-,-) in class PlantDetailsCallbacks is changed to PlantDetailsCallbacks(-,-,String, Plant)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method HomeScreen((Plant) in class HomeScreen is renamed to HomePagerScreen((Plant)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "HomeScreen is still in the class, but its functionality is moved to HomePageScreen and it has new instruction. So, Rename can be true.", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "49e2b48fb64d76daa0424fcb2f3acbf8b128b55a", "url" : "https://github.com/android/sunflower/commit/49e2b48fb64d76daa0424fcb2f3acbf8b128b55a", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createShareIntent() in class PlantDetailFragment is changed to createShareIntent(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "4ea76fbed85086473e049dfee3f461b138e303a8", "url" : "https://github.com/android/sunflower/commit/4ea76fbed85086473e049dfee3f461b138e303a8", "refactorings" : [ { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass UnsplashSearchResult is extracted from children classes Error,Success", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method bindIsGone(FloatingActionButton,Boolean?) in class PlantDetailBindingAdapters is renamed to bindIsFabGone(FloatingActionButton,Boolean?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "5be6381a272156fbd3ccb3393cb28738725da931", "url" : "https://github.com/android/sunflower/commit/5be6381a272156fbd3ccb3393cb28738725da931", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MainCoroutineRule(TestCoroutineDispatcher) in class MainCoroutineRule is changed to MainCoroutineRule(TestDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method starting(Description?) in class MainCoroutineRule is changed to starting(Description)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method finished(Description?) in class MainCoroutineRule is changed to finished(Description)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "61b52c4700a4c55fc06d22a57b3c48e49fc01f14", "url" : "https://github.com/android/sunflower/commit/61b52c4700a4c55fc06d22a57b3c48e49fc01f14", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.sunflower.PlantDetailFragmentTest is Rename to com.google.samples.apps.sunflower.PlantDetailFragmentTest2", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "6291ad39d43c6c2dd4a12c29cc9797ceb347f050", "url" : "https://github.com/android/sunflower/commit/6291ad39d43c6c2dd4a12c29cc9797ceb347f050", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clickOnPlantListDrawerMenuItem_StartsPlantListActivity() in class GardenActivityTest is renamed to clickAddPlant_OpensPlantList()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method ViewHolder(ListItemPlantBinding) in class ViewHolder is renamed to PlantViewHolder(ListItemPlantBinding)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.sunflower.adapters.PlantAdapter.ViewHolder is Rename to com.google.samples.apps.sunflower.adapters.PlantAdapter.PlantViewHolder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "7990334ad654fc9347dd9ba0e71761232da56678", "url" : "https://github.com/android/sunflower/commit/7990334ad654fc9347dd9ba0e71761232da56678", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method subscribeUi() in class PlantListActivity is changed to subscribeUi(PlantAdapter)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "7b28c2563dcd177e0479f1324ea04fc0c91c301f", "url" : "https://github.com/android/sunflower/commit/7b28c2563dcd177e0479f1324ea04fc0c91c301f", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.sunflower.PlantDaoTest is Move to com.google.samples.apps.sunflower.data.PlantDaoTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "7ccb91995b88d4dbc7e9569da4e4dbc5fc77c937", "url" : "https://github.com/android/sunflower/commit/7ccb91995b88d4dbc7e9569da4e4dbc5fc77c937", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.sunflower.PlantListActivity is Rename to com.google.samples.apps.sunflower.PlantListFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "8ecd467ef729b43c212640025f99370fc7f41cb6", "url" : "https://github.com/android/sunflower/commit/8ecd467ef729b43c212640025f99370fc7f41cb6", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Plant(String,String,String) in class Plant is changed to Plant(String,String,String,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PlantListViewModelFactory(PlantRepository) in class PlantListViewModelFactory is changed to PlantListViewModelFactory(PlantRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "PlantRepository i changed from Java class to Kotlin class.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method runOnIoThread(Runnable) in class AppExecutors is changed to runOnIoThread(() -> Unit)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "917e41cf82302c8992a54ca8b390ce56bbc52ebb", "url" : "https://github.com/android/sunflower/commit/917e41cf82302c8992a54ca8b390ce56bbc52ebb", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.sunflower.PlantDaoTest is Move to com.google.samples.apps.sunflower.data.PlantDaoTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "99df6189af927b5cc477167923bbbd5a4ca1ece9", "url" : "https://github.com/android/sunflower/commit/99df6189af927b5cc477167923bbbd5a4ca1ece9", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method subscribeUi(GardenPlantingAdapter) in class GardenFragment is changed to subscribeUi(GardenPlantingAdapter,FragmentGardenBinding)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "bc496360f82d9b36ccffa2d83fe32fa83cbb4087", "url" : "https://github.com/android/sunflower/commit/bc496360f82d9b36ccffa2d83fe32fa83cbb4087", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createShareIntent(String) in class PlantDetailFragment is changed to createShareIntent()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PlantDetailViewModel(PlantRepository,GardenPlantingRepository,String) in class PlantDetailViewModel is changed to PlantDetailViewModel(SavedStateHandle,PlantRepository,GardenPlantingRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method bindIsGone(FloatingActionButton,Boolean?) in class PlantDetailBindingAdapters is renamed to bindIsFabGone(FloatingActionButton,Boolean?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "e9d51aa856bd49dc8d4813cf1172eec46e3865bc", "url" : "https://github.com/android/sunflower/commit/e9d51aa856bd49dc8d4813cf1172eec46e3865bc", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method test_default_values() in class GardenPlantingTest is renamed to testDefaultValues()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method provideRepository(Application) in class InjectorUtils is renamed to providePlantDetailViewModelFactory(Context,String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Method providePlantDetailViewModelFactory is not new and method provideRepository is renamed to getPlantRepository", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "f5efdb8aa448f5d8a153372694e50d86669a8966", "url" : "https://github.com/android/sunflower/commit/f5efdb8aa448f5d8a153372694e50d86669a8966", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setupNavigationDrawer(ActivityGardenBinding) in class GardenActivity is changed to setupNavigationDrawer()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setupToolbar(ActivityGardenBinding) in class GardenActivity is changed to setupToolbar()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "f99cf1829cae25f87b1d5fc922c24ff1ba3f9c71", "url" : "https://github.com/android/sunflower/commit/f99cf1829cae25f87b1d5fc922c24ff1ba3f9c71", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method shouldBeWatered(Calendar) in class Plant is changed to shouldBeWatered(Calendar,Calendar)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "d316e4c7fe7334ae29b37024ee85a0115f2306a1", "url" : "https://github.com/android/sunflower/commit/d316e4c7fe7334ae29b37024ee85a0115f2306a1", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PlantInformation(String,Int,String,(Float) in class PlantDetailView is changed to PlantInformation(String,Int,String,(Float)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/android/sunflower", "sha1" : "fae57f8c55c127985890352e8b9222e46c9eb9e8", "url" : "https://github.com/android/sunflower/commit/fae57f8c55c127985890352e8b9222e46c9eb9e8", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method test_default_values() in class GardenPlantingTest is renamed to testDefaultValues()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method provideRepository(Application) in class InjectorUtils is renamed to providePlantDetailViewModelFactory(Context,String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Method providePlantDetailViewModelFactory is not new and method provideRepository is renamed to getPlantRepository", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "07250d8b390c5a9827d3bce7483e0a748bf2e843", "url" : "https://github.com/google/iosched/commit/07250d8b390c5a9827d3bce7483e0a748bf2e843", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createUserEvent(String,Long,Long,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest) in class CompareOldAndNewUserEventsTest is changed to createUserEvent(String,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method toZonedTime(Long) in class SessionTest is extracted from method testIsOverlapping(Long,Long,Long,Long,Boolean) in class SessionTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "It is extracted from moved method (testIsOverlapping).", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class SessionTest is extracted from class UserEventTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testIsOverlapping(Long,Long,Long,Long,Boolean) in class UserEventTest is moved to class SessionTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method UserEvent(String,Long,Long,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest) in class UserEvent is changed to UserEvent(String,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findOverlappingReservationId(Session,ReservationRequestAction,List) in class DefaultSessionAndUserEventRepository is changed to findOverlappingReservationId(Session,ReservationRequestAction,Map,List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testIsOverlapping_bothHaveSameTime() in class UserEventTest is moved to class SessionTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testIsOverlapping_sessionEndInTheMiddle() in class UserEventTest is moved to class SessionTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testIsOverlapping_sessionStartsBeforeAndEndsAfter() in class UserEventTest is moved to class SessionTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testIsOverlapping_sessionStartsInTheMiddle() in class UserEventTest is moved to class SessionTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "0b932298009522edae72aaa7d426ff2b0ee3ee0b", "url" : "https://github.com/google/iosched/commit/0b932298009522edae72aaa7d426ff2b0ee3ee0b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadTagFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,TopicSubscriber) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadTagFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ReservationActionUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,TopicSubscriber)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,ReservationActionUseCase,StarEventUseCase,SnackbarMessageManager,MockableTime) in class SessionDetailViewModelTest is changed to createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,ReservationActionUseCase,StarEventUseCase,SnackbarMessageManager)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testCancelEvent() in class SessionDetailViewModelTest is moved to class ScheduleViewModelTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method testReserveEvent_notLoggedIn() in class SessionDetailViewModelTest is moved to class ScheduleViewModelTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadTagFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager) in class ScheduleViewModel is changed to ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadTagFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ReservationActionUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,StarEventUseCase,ReservationActionUseCase,SnackbarMessageManager,MockableTime) in class SessionDetailViewModel is changed to SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,StarEventUseCase,ReservationActionUseCase,SnackbarMessageManager)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.util.SetIntervalLiveData is Move to com.google.samples.apps.iosched.util.SetIntervalLiveData", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.time.MockableTime is Move to com.google.samples.apps.iosched.util.time.MockableTime", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.time.DefaultTime is Move to com.google.samples.apps.iosched.util.time.DefaultTime", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.time.WallclockTime is Move to com.google.samples.apps.iosched.util.time.WallclockTime", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "2ecec60d50bdaab478aac034b6d814a43e5ec811", "url" : "https://github.com/google/iosched/commit/2ecec60d50bdaab478aac034b6d814a43e5ec811", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class TestUserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "There are 3 classes with this name", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method starEvent(String,UserEvent) in class FakeUserEventDataSource is changed to starEvent(SessionId,UserEvent)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class FakeUserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createIntent(Context,String) in class SessionDetailActivity is changed to createIntent(Context,SessionId)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createIntent(Context,String) in class SessionPlayerActivity is changed to createIntent(Context,SessionId)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method loadSessionById(String) in class SessionDetailViewModel is changed to loadSessionById(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field speaker in class TestData is rename to speaker1", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeReservation(String,String,ReservationRequestAction) in class TestUserEventRepository is changed to changeReservation(String,SessionId,ReservationRequestAction)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class FailingUserEventRepository is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeReservation(String,String,ReservationRequestAction) in class FailingUserEventRepository is changed to changeReservation(String,SessionId,ReservationRequestAction)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method swapReservation(String,String,String) in class FailingUserEventRepository is changed to swapReservation(String,SessionId,SessionId)", "detectionTools" : [ "RefDetect" ,"KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getSession(String) in class FailingSessionRepository is changed to getSession(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class TestUserEventRepository is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method swapReservation(String,String,String) in class TestUserEventRepository is changed to swapReservation(String,SessionId,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class TestUserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "There are 3 classes with this name", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class TestUserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "There are 3 classes with this name", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method starterIntent(Context,String) in class SessionDetailActivity is changed to starterIntent(Context,SessionId)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method newInstance(String) in class SessionDetailFragment is changed to newInstance(SessionId)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openEventDetail(String) in class EventActions is changed to openEventDetail(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RemoveReservationDialogParameters(String,String,String) in class RemoveReservationDialogParameters is changed to RemoveReservationDialogParameters(String,SessionId,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openEventDetail(String) in class ScheduleViewModel is changed to openEventDetail(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openEventDetail(String) in class SessionDetailViewModel is changed to openEventDetail(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setSessionId(String) in class SessionDetailViewModel is changed to setSessionId(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface EventActionsViewModelDelegate is extracted from classes DefaultEventActionsViewModelDelegate,SpeakerViewModel", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "As we have no information about intermediate results, it is not possible to say the refactoring is correct or incorrect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeReservation(String,String,ReservationRequestAction) in class DefaultSessionAndUserEventRepository is changed to changeReservation(String,SessionId,ReservationRequestAction)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class DefaultSessionAndUserEventRepository is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method registerListenerForSingleEvent(String,String) in class FirestoreUserEventDataSource is changed to registerListenerForSingleEvent(SessionId,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(String) in class LoadSessionUseCase is changed to execute(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class FirestoreUserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getSession(String) in class DefaultSessionRepository is changed to getSession(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class SessionAndUserEventRepository is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method changeReservation(String,String,ReservationRequestAction) in class SessionAndUserEventRepository is changed to changeReservation(String,SessionId,ReservationRequestAction)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method swapReservation(String,String,String) in class SessionAndUserEventRepository is changed to swapReservation(String,SessionId,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method UserEvent(String,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest) in class UserEvent is changed to UserEvent(SessionId,Boolean,Boolean,ReservationStatus,ReservationRequestResult,ReservationRequest)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Speaker(String,String,String,String,String,String,String) in class Speaker is changed to Speaker(SpeakerId,String,String,String,String,String,String,String,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getSession(String) in class SessionRepository is changed to getSession(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionTemp(String,ZonedDateTime,ZonedDateTime,String,String,String,String,String,Boolean,String,List,Set,String,Set) in class SessionTemp is changed to SessionTemp(SessionId,ZonedDateTime,ZonedDateTime,String,String,String,String,String,Boolean,String,List,Set,String,Set)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Session(String,ZonedDateTime,ZonedDateTime,String,String,Room,String,String,Boolean,String,List,List,Set,String,Set) in class Session is changed to Session(SessionId,ZonedDateTime,ZonedDateTime,String,String,Room,String,String,Boolean,String,List,List,Set,String,Set)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvent(String,String) in class UserEventDataSource is changed to getObservableUserEvent(String,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ReservationRequestParameters(String,String,ReservationRequestAction) in class ReservationRequestParameters is changed to ReservationRequestParameters(String,SessionId,ReservationRequestAction)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SwapRequestParameters(String,String,String,String,String) in class SwapRequestParameters is changed to SwapRequestParameters(String,SessionId,String,SessionId,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method swapReservation(String,String,String) in class DefaultSessionAndUserEventRepository is changed to swapReservation(String,SessionId,SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openSessionDetail(String) in class ScheduleEventListener is changed to openSessionDetail(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openSessionDetail(String) in class ScheduleViewModel is changed to openSessionDetail(SessionId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openSessionDetail(String) in class ScheduleFragment is changed to openSessionDetail(SessionId)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" },{ "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(Pair) in class LoadUserSessionUseCase is changed to execute(Pair)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method loadSessionById(String) in class SearchableViewModel is changed to loadSessionById(SessionId)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openSessionDetail(String) in class ScheduleFragment is changed to openSessionDetail(SessionId)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createSessionSpeakerViews(LinearLayout,Set) in class SessionDetailDataBindingAdapters is changed to createSessionSpeakerViews(LinearLayout,Set,SessionDetailEventListener)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method sessionSpeakers(LinearLayout,Set) in class SessionDetailDataBindingAdapters is renamed to createSessionSpeakerViews(LinearLayout,Set,SessionDetailEventListener)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createRelatedSessionViews(LinearLayout,List,EventActions) in class SessionDetailDataBindingAdapters is changed to createRelatedSessionViews(LinearLayout,List,EventActions,RecycledViewPool?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method relatedEvents(LinearLayout,List,EventActions) in class SessionDetailDataBindingAdapters is renamed to createRelatedSessionViews(LinearLayout,List,EventActions,RecycledViewPool?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createEventView(ViewGroup,UserSession,EventActions) in class SessionDetailDataBindingAdapters is changed to createEventView(ViewGroup,UserSession,EventActions,RecycledViewPool?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method createRelatedEventView(ViewGroup,UserSession,EventActions) in class SessionDetailDataBindingAdapters is renamed to createEventView(ViewGroup,UserSession,EventActions,RecycledViewPool?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getUserId() in class ScheduleViewModel is moved to class FirebaseSignInViewModelDelegate", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getUserId() in class SessionDetailViewModel is moved to class FirebaseSignInViewModelDelegate", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "32cceb08633c233889b126ad039ef05c1cc271fd", "url" : "https://github.com/google/iosched/commit/32cceb08633c233889b126ad039ef05c1cc271fd", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadUserSessionsByDayUseCase) in class ScheduleViewModel is changed to ScheduleViewModel(LoadFilteredUserSessionsUseCase)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "class LoadUserSessionsByDayUseCase is renamed to LoadFilteredUserSessionsUseCase", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.day.SessionHeaderIndexerTest is Move to com.google.samples.apps.iosched.ui.schedule.SessionHeaderIndexerTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.day.TestUserEventDataSource is Move to com.google.samples.apps.iosched.ui.schedule.TestUserEventDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionsByDayUseCaseTest is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method logAnalyticsPageView(Int) in class ScheduleFragment is inlined to method onViewCreated(View,Bundle) in class ScheduleFragment", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.day.SessionViewHolder is Move to com.google.samples.apps.iosched.ui.schedule.SessionViewHolder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.day.SessionDiff is Move to com.google.samples.apps.iosched.ui.schedule.SessionDiff", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.day.ScheduleTimeHeadersDecoration is Move to com.google.samples.apps.iosched.ui.schedule.ScheduleTimeHeadersDecoration", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.schedule.day.ScheduleDayAdapter is MoveAndRename to com.google.samples.apps.iosched.ui.schedule.ScheduleAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModel is changed to ScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field labelsForDays in class ScheduleViewModel is rename to sessionTimeData", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method execute(LoadUserSessionsByDayUseCaseParameters) in class LoadUserSessionsByDayUseCase is changed to execute(LoadFilteredUserSessionsParameters) and moved to class LoadFilteredUserSessionsUseCase", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "class LoadUserSessionsByDayUseCaseParameters is renamed to LoadFilteredUserSessionsParameters", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class LoadFilteredUserSessionsUseCase is extracted from class LoadUserSessionsByDayUseCase", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field sessionsByDayResult in class DefaultSessionAndUserEventRepository is rename to sessionsResult", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionsByDayUseCase is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsUseCase", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionsByDayUseCaseParameters is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsParameters", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionsByDayUseCaseResult is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsResult", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method groupSessionsByTimeSlot(MutableLiveData>,ConferenceDay) in class ScheduleViewModel is changed to groupSessionsByTimeSlot(MutableLiveData>,ConferenceDay)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(LoadUserSessionsByDayUseCaseParameters) in class LoadFilteredUserSessionsUseCase is changed to execute(LoadFilteredUserSessionsParameters)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method findFirstUnfinishedSession(Map>,ZonedDateTime) in class LoadFilteredUserSessionsUseCase is changed to findFirstUnfinishedSession(List,ZonedDateTime)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method initializeList(SessionTimeData) in class ScheduleDayFragment is moved to class ScheduleFragment", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "37566f73a555997ea5ebd29a7e4bd6f61160e2fd", "url" : "https://github.com/google/iosched/commit/37566f73a555997ea5ebd29a7e4bd6f61160e2fd", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(Unit) in class FeedViewModelTest is changed to execute(Instant)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method feedItemsLoadedUnsuccessfully() in class LoadAnnouncementsUseCaseTest is renamed to announcementsLoadedUnsuccessfully()", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.usecases.repository.LoadAnnouncementsUseCaseTest is Move to com.google.samples.apps.iosched.shared.domain.feed.LoadAnnouncementsUseCaseTest", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method navigateToMapUsingMoment(Moment) in class FeedFragment is renamed to openMap(Moment)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method FeedAnnouncementViewHolder(ItemFeedAnnouncementBinding,LifecycleOwner,LiveData) in class FeedAnnouncementViewHolder is renamed to AnnouncementViewHolder(ItemFeedAnnouncementBinding,LifecycleOwner,LiveData)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.FeedAnnouncementViewHolder is Rename to com.google.samples.apps.iosched.ui.feed.AnnouncementViewHolder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.FeedAnnouncementViewBinder is Rename to com.google.samples.apps.iosched.ui.feed.AnnouncementViewBinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.FeedListItemViewBinder is Rename to com.google.samples.apps.iosched.ui.feed.FeedItemViewBinder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FeedViewModel(LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,SignInViewModelDelegate,AnalyticsHelper,GetTimeZoneUseCase,ThemedActivityDelegate,FeedHeaderLiveData) in class FeedViewModel is changed to FeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCase,ConferenceStartedLiveData,TimeProvider,AnalyticsHelper,SignInViewModelDelegate,ThemedActivityDelegate)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FeedSessions(String,String,Int,Int,List,ZoneId,Boolean) in class FeedSessions is changed to FeedSessions(String,Int,Int,List,ZoneId,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ConferenceStartedLiveData is extracted from class FeedHeaderLiveData", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field loadFeedResult in class FeedViewModel is rename to loadAnnouncementsResult", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(Unit) in class LoadAnnouncementsUseCase is changed to execute(Instant)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadAnnouncementsUseCase(FeedRepository,TimeProvider) in class LoadAnnouncementsUseCase is changed to LoadAnnouncementsUseCase(FeedRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.AnnouncementsPlaceholder is Rename to com.google.samples.apps.iosched.ui.feed.AnnouncementsEmpty", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.FeedHeader is Rename to com.google.samples.apps.iosched.ui.feed.EmptyViewHolder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.feed.FeedAnnouncementsPlaceholderViewBinder is Rename to com.google.samples.apps.iosched.ui.feed.MomentViewBinder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method bindViewHolder(Announcement,FeedAnnouncementViewHolder) in class AnnouncementViewBinder is changed to bindViewHolder(Announcement,AnnouncementViewHolder)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "4254360bb2d19f09ed477d0953a49d0617c26da6", "url" : "https://github.com/google/iosched/commit/4254360bb2d19f09ed477d0953a49d0617c26da6", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,ReservationActionUseCase,StarEventUseCase,SnackbarMessageManager) in class SessionDetailViewModelTest is changed to createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,ReservationActionUseCase,StarEventUseCase,SnackbarMessageManager)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method openSessionDetail(String) in class ScheduleViewModel is renamed to openEventDetail(String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,StarEventUseCase,ReservationActionUseCase,SnackbarMessageManager) in class SessionDetailViewModel is changed to SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,StarEventUseCase,ReservationActionUseCase,SnackbarMessageManager)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface EventActions is extracted from classes ScheduleEventListener,SessionDetailViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method onStarClicked(UserEvent) in class ScheduleEventListener is pulled up to class EventActions", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "4a734191bffe8cffe86e474c35dbdfcf3c3a60e4", "url" : "https://github.com/google/iosched/commit/4a734191bffe8cffe86e474c35dbdfcf3c3a60e4", "refactorings" : [ { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class mobile/src/test/java/com/google/samples/apps/iosched/ui/schedule/TestTagDataSource is extracted from class TestSessionDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Note we have two classes with name TestTagDataSource but in different folder", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field beginnerTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field codelabsTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field intermediateTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field sessionsTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getTags() in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class shared/src/test/java/com/google/samples/apps/iosched/shared/usecases/repository/TestTagDataSource is extracted from class TestSessionDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Note we have two classes with name TestTagDataSource but in different folder", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field beginnerTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field codelabsTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field intermediateTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field sessionsTag in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getTags() in class TestSessionDataSource is moved to class TestTagDataSource", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadSessionsByDayUseCase,LoadTagsByCategoryUseCase) in class ScheduleViewModel is changed to ScheduleViewModel(LoadSessionsByDayUseCase,LoadAgendaUseCase,LoadTagsByCategoryUseCase)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Block(String,String,String,ZonedDateTime,ZonedDateTime) in class Block is changed to Block(String,String,Int,Int,Boolean,ZonedDateTime,ZonedDateTime)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "4e6fd213aad9cb7b07eb08b0dc27b2b390262653", "url" : "https://github.com/google/iosched/commit/4e6fd213aad9cb7b07eb08b0dc27b2b390262653", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper,ThemedActivityDelegate) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field currentFirebaseUser in class FakeSignInViewModelDelegate is rename to currentUserInfo", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.util.signin.DefaultSignInHandler is Rename to com.google.samples.apps.iosched.util.signin.FirebaseAuthSignInHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper,ThemedActivityDelegate) in class ScheduleViewModel is changed to ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class MainActivityViewModel is extracted from class ScheduleViewModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Method onProfileClicked() is moved.", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field currentFirebaseUser in class FirebaseSignInViewModelDelegate is rename to currentUserInfo", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field currentFirebaseUser in class SignInViewModelDelegate is rename to currentUserInfo", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method onProfileClicked() in class ScheduleViewModel is moved to class MainActivityViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "5a8933641542d6e34edf53293844e5b0ae46f03e", "url" : "https://github.com/google/iosched/commit/5a8933641542d6e34edf53293844e5b0ae46f03e", "refactorings" : [ { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass StagingAuthenticatedUserInfo is extracted from children classes StagingLoggedOutFirebaseUserInfo", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class FirebaseLoginViewModelPluginTest is extracted from class DefaultLoginViewModelPluginTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field instantTaskExecutorRule in class DefaultLoginViewModelPluginTest is moved to class FirebaseLoginViewModelPluginTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field syncTaskExecutorRule in class DefaultLoginViewModelPluginTest is moved to class FirebaseLoginViewModelPluginTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionViewHolder(ItemSessionBinding,ScheduleEventListener) in class SessionViewHolder is changed to SessionViewHolder(ItemSessionBinding,ScheduleEventListener,LiveData,LiveData,LifecycleOwner)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method getUserId() in class ScheduleViewModel is extracted from method onStarClicked(Session,UserEvent) in class ScheduleViewModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method getUserId() in class ScheduleViewModel is extracted from method refreshUserSessions() in class ScheduleViewModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method getUserId() in class ScheduleViewModel is extracted from method onReservationClicked(Session,UserEvent) in class ScheduleViewModel", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface AuthenticatedUserInfoBasic is extracted from classes AuthenticatedUserInfo,FirebaseUserInfo", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface AuthenticatedUserInfoRegistered is extracted from classes AuthenticatedUserInfo", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getCreationTimestamp() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getDisplayName() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getEmail() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getLastSignInTimestamp() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getPhoneNumber() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getPhotoUrl() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getProviderData() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getProviderId() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getProviders() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getUid() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method isAnonymous() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method isEmailVerified() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method isLoggedIn() in class AuthenticatedUserInfo is pulled up to class AuthenticatedUserInfoBasic", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.login.DefaultLoginViewModelPlugin is Rename to com.google.samples.apps.iosched.ui.login.FirebaseLoginViewModelPlugin", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.login.DefaultLoginViewModelPluginTest is Rename to com.google.samples.apps.iosched.ui.login.FirebaseLoginViewModelPluginTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideLoginViewModelPlugin(AuthenticatedUser) in class LoginViewModelPluginModule is changed to provideLoginViewModelPlugin(ObserveUserAuthStateUseCase)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideLoginHandler(AuthenticatedUser) in class LoginModule is changed to provideLoginHandler(Context)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvents(String) in class DefaultSessionAndUserEventRepository is changed to getObservableUserEvents(String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method mapUserDataAndSessions(UserEventsResult,List) in class DefaultSessionAndUserEventRepository is changed to mapUserDataAndSessions(UserEventsResult?,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(Pair) in class LoadUserSessionsByDayUseCase is changed to execute(Pair)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvents(String) in class TestUserEventRepository is changed to getObservableUserEvents(String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvents(String) in class FailingUserEventRepository is changed to getObservableUserEvents(String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getObservableUserEvents(String) in class SessionAndUserEventRepository is changed to getObservableUserEvents(String?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "7221bfc6e5737546c6b21682b8348a6d8770e68b", "url" : "https://github.com/google/iosched/commit/7221bfc6e5737546c6b21682b8348a6d8770e68b", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FakePreferenceStorage(Boolean,Boolean,Boolean,Boolean,Boolean,Boolean,LiveData,Boolean,Boolean,String,String,LiveData) in class FakePreferenceStorage is changed to FakePreferenceStorage(Boolean,Boolean,Boolean,Boolean,Boolean,Boolean,LiveData,Boolean,Boolean,String,String,LiveData,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FakePreferenceStorage(Boolean,Boolean,Boolean,Boolean,Boolean,Boolean,LiveData,Boolean,Boolean,String,String,LiveData) in class FakePreferenceStorage is changed to FakePreferenceStorage(Boolean,Boolean,Boolean,Boolean,Boolean,Boolean,LiveData,Boolean,Boolean,String,String,LiveData,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.codelabs.CodelabViewHolder is MoveAndRename to com.google.samples.apps.iosched.ui.codelabs.CodelabsViewHolder.CodelabItemHolder", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method CodelabsAdapter(Bundle) in class CodelabsAdapter is changed to CodelabsAdapter(RecycledViewPool,CodelabsActionsHandler,Bundle)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface CodelabsActionsHandler is extracted from classes CodelabsFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.codelabs.CodelabViewHolder is Rename to com.google.samples.apps.iosched.ui.codelabs.CodelabsViewHolder", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method submitList(List) in class CodelabsAdapter is changed to submitList(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method bindCodelabItemHolder(CodelabViewHolder,Codelab) in class CodelabsAdapter is changed to bindCodelabItemHolder(CodelabItemHolder,Codelab)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "A close look shows both Rename and Change Parameter happens.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method onBindViewHolder(CodelabViewHolder,Int) in class CodelabsAdapter is renamed to bindCodelabItemHolder(CodelabItemHolder,Codelab)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "A close look shows both Rename and Change Parameter happens.", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method submitList(List) in class CodelabsAdapter is inlined to method submitList(List) in class CodelabsAdapter", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "9507a79119060468fbc3aa75ffe837414d06c2d7", "url" : "https://github.com/google/iosched/commit/9507a79119060468fbc3aa75ffe837414d06c2d7", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.filters.EventFilterDiff is Rename to com.google.samples.apps.iosched.ui.filters.FilterChipDiff", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.filters.EventFilterSpanSizeLookup is Rename to com.google.samples.apps.iosched.ui.filters.FilterChipSpanSizeLookup", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method insertCategoryHeadings(List) in class SelectableFilterChipAdapter is changed to insertCategoryHeadings(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method toggleFilter(EventFilter,Boolean) in class FiltersViewModelDelegate is changed to toggleFilter(FilterChip,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method bind(EventFilter) in class TagChipViewHolder is changed to bind(FilterChip)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method bind(EventFilter) in class FilterViewHolder is changed to bind(FilterChip)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method submitFilterList(List) in class SelectableFilterChipAdapter is changed to submitFilterList(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by Both.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method submitEventFilterList(List) in class SelectableFilterChipAdapter is renamed to submitFilterList(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by Both.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method selectedFilters(RecyclerView,List) in class FiltersFragment is changed to selectedFilters(RecyclerView,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "a593868de887c6521f26da4bfb8850ddc39559ff", "url" : "https://github.com/google/iosched/commit/a593868de887c6521f26da4bfb8850ddc39559ff", "refactorings" : [ { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.MainModule is MoveAndRename to com.google.samples.apps.iosched.di.ActivityBindingModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.sessioncommon.ViewPoolModule is Rename to com.google.samples.apps.iosched.ui.sessioncommon.SessionViewPoolModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class InfoFragmentsModule is extracted from class InfoModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ScheduleChildFragmentsModule is extracted from class ScheduleModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method sessionDetailActivity() in class SessionDetailModule is moved to class ActivityBindingModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeScheduleAgendaFragment() in class ScheduleModule is moved to class ScheduleChildFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeScheduleDayFragment() in class ScheduleModule is moved to class ScheduleChildFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeEventFragment() in class InfoModule is moved to class InfoFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeFaqFragment() in class InfoModule is moved to class InfoFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeSettingsFragment() in class InfoModule is moved to class InfoFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeTravelFragment() in class InfoModule is moved to class InfoFragmentsModule", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "b665e3d51104f119a1c51be6787b21f3cd4c3980", "url" : "https://github.com/google/iosched/commit/b665e3d51104f119a1c51be6787b21f3cd4c3980", "refactorings" : [{ "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.AgendaHeaderIndexerTest is Move to com.google.samples.apps.iosched.ui.agenda.AgendaHeaderIndexerTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadUserSessionsByDayUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.ScheduleAgendaAdapter is MoveAndRename to com.google.samples.apps.iosched.ui.agenda.AgendaAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.ScheduleAgendaFragment is MoveAndRename to com.google.samples.apps.iosched.ui.agenda.AgendaFragment", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.BlockDiff is Move to com.google.samples.apps.iosched.ui.agenda.BlockDiff", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.ScheduleAgendaHeadersDecoration is MoveAndRename to com.google.samples.apps.iosched.ui.agenda.AgendaHeadersDecoration", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.agenda.AgendaViewHolder is Move to com.google.samples.apps.iosched.ui.agenda.AgendaViewHolder", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadAgendaUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModel is changed to ScheduleViewModel(LoadUserSessionsByDayUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class AgendaViewModel is extracted from class ScheduleViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Two fields at least are moved.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class AgendaModule is extracted from class ScheduleChildFragmentsModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field loadAgendaResult in class ScheduleViewModel is moved to class AgendaViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method contributeScheduleAgendaFragment() in class ScheduleChildFragmentsModule is moved to class AgendaModule", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.shared.data.session.agenda.AgendaDataSource is MoveAndRename to com.google.samples.apps.iosched.shared.data.agenda.AgendaRepository", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class com.google.samples.apps.iosched.shared.data.session.agenda.AgendaRepository is MoveAndRename to com.google.samples.apps.iosched.shared.data.agenda.DefaultAgendaRepository", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "Look in class elements show the refactoring is correct.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadAgendaUseCase(AgendaRepository) in class LoadAgendaUseCase is changed to LoadAgendaUseCase(AgendaRepository)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.shared.data.session.agenda.AgendaDataSource is Move to com.google.samples.apps.iosched.shared.data.agenda.AgendaDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method updateFiltersUi(TransientUiState) in class ScheduleFragment is changed to updateFiltersUi(Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface AgendaRepository is extracted from classes DefaultAgendaRepository", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field agenda in class ScheduleViewModel is moved to class AgendaViewModel", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "c1572d53113effa0662f7c1c70afd039c0818245", "url" : "https://github.com/google/iosched/commit/c1572d53113effa0662f7c1c70afd039c0818245", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.schedule.ScheduleUiHintsDialogViewModelTest is Rename to com.google.samples.apps.iosched.ui.schedule.MarkScheduleUiHintsShownUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.prefs.ScheduleUiHintsShowActionUseCase is Rename to com.google.samples.apps.iosched.shared.domain.prefs.MarkScheduleUiHintsShownUseCase", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(Boolean) in class ScheduleUiHintsShowActionUseCase is changed to execute(Unit)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreateView(LayoutInflater,ViewGroup?,Bundle?) in class SignInDialogFragment is changed to onCreateView(ViewGroup?,Bundle?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onCreateView(LayoutInflater,ViewGroup?,Bundle?) in class SignInDialogFragment is changed to onCreateView(LayoutInflater,Bundle?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "c2189dfe82cf2bf93100d3a0ce398a943613a25e", "url" : "https://github.com/google/iosched/commit/c2189dfe82cf2bf93100d3a0ce398a943613a25e", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createSessionDetailViewModel(LoginViewModelPlugin,LoadUserSessionUseCase,StarEventUseCase) in class SessionDetailViewModelTest is changed to createSessionDetailViewModel(LoginViewModelPlugin,LoadUserSessionUseCase,ReservationActionUseCase,StarEventUseCase)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionDetailViewModel(LoginViewModelPlugin,LoadUserSessionUseCase,StarEventUseCase) in class SessionDetailViewModel is changed to SessionDetailViewModel(LoginViewModelPlugin,LoadUserSessionUseCase,StarEventUseCase,ReservationActionUseCase)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onStarClicked(UserEvent) in class SessionDetailViewModel is changed to onStarClicked()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface SessionDetailEventListener is extracted from classes SessionDetailViewModel", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getUserMessageFromChange(DocumentChange,UserEventsResult) in class FirestoreUserEventDataSource is changed to getUserMessageFromChange(DocumentSnapshot,UserEvent)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method UserEventResult(UserEvent,UserEventMessage) in class UserEventResult is changed to UserEventResult(UserEvent,UserEventsMessage)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadUserSessionUseCaseResult(UserSession,UserEventMessage) in class LoadUserSessionUseCaseResult is changed to LoadUserSessionUseCaseResult(UserSession,UserEventsMessage)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method getUserMessageFromChange(DocumentChange,UserEventsResult) in class FirestoreUserEventDataSource is inlined to method generateReservationChangeMsg(QuerySnapshot,UserEventsResult?) in class FirestoreUserEventDataSource", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method assignStarFab(FloatingActionButton,Boolean) in class SessionDetailDataBindingAdapters is changed to assignStarFab(FloatingActionButton,Boolean,SessionDetailEventListener)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method isDetailStarred(FloatingActionButton,Boolean) in class SessionDetailDataBindingAdapters is renamed to assignStarFab(FloatingActionButton,Boolean,SessionDetailEventListener)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "d6b67e7305bf8563ff631b5a621feef058a17d6e", "url" : "https://github.com/google/iosched/commit/d6b67e7305bf8563ff631b5a621feef058a17d6e", "refactorings" : [ { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class UserSessionMatcherTest is extracted from class TagFilterMatcherTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "To me it seems rename class.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method createTestUserSession(Tag) in class TagFilterMatcherTest is moved to class UserSessionMatcherTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method userEventIsPinned_matches() in class PinnedEventMatcherTest is moved to class UserSessionMatcherTest", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method TagFilterView(Context,AttributeSet,Int) in class TagFilterView is renamed to EventFilterView(Context,AttributeSet,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clearTagFilters() in class ScheduleViewModel is renamed to clearFilters()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.schedule.filters.TagChipAdapter is Rename to com.google.samples.apps.iosched.ui.schedule.filters.FilterChipAdapter", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class com.google.samples.apps.iosched.ui.schedule.filters.TagFilter is Move to com.google.samples.apps.iosched.ui.schedule.filters.EventFilter.TagFilter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.ui.schedule.filters.TagFilterView is Rename to com.google.samples.apps.iosched.ui.schedule.filters.EventFilterView", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(TagFilterMatcher) in class LoadTagFiltersUseCase is changed to execute(UserSessionMatcher)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method insertCategoryHeadings(List) in class ScheduleFilterAdapter is changed to insertCategoryHeadings(List)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method toggleFilter(TagFilter,Boolean) in class ScheduleEventListener is changed to toggleFilter(EventFilter,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method TransientUiState(Boolean,Boolean,Boolean) in class TransientUiState is changed to TransientUiState(Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class EventFilter is extracted from class TagFilter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field isChecked in class TagFilter is moved to class EventFilter", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Some methods are also moved, but they are not detected by either RefDetect and KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field tagFilters in class ScheduleViewModel is rename to eventFilters", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field VIEW_TYPE_TAGFILTER in class ScheduleFilterAdapter is rename to VIEW_TYPE_FILTER", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field _selectedFilterTags in class ScheduleViewModel is rename to _selectedFilters", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field tags in class TagChipAdapter is rename to filters", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field cachedTagFilters in class ScheduleViewModel is rename to cachedEventFilters", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method hasAnyFilters() in class UserSessionMatcher is extracted from method clearAll() in class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method removeOrphanedTags(List) in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method getSelectedTags() in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method add(Tag) in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method contains(Tag) in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method remove(Tag) in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method clearAll() in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method addAll(Tag) in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field selectedTags in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field FILTER_CATEGORIES in class TagFilterMatcher is pulled up to class UserSessionMatcher", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.schedule.TagFilterMatcherTest is Rename to com.google.samples.apps.iosched.shared.schedule.UserSessionMatcherTest", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method submitTagFilterList(List) in class ScheduleFilterAdapter is changed to submitTagFilterList(List)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method selectedFilters(RecyclerView,List) in class ScheduleFilterFragment is changed to selectedFilters(RecyclerView,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method filterDescriptionTags(RecyclerView,List) in class ScheduleFilterFragment is renamed to selectedFilters(RecyclerView,List)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method clearTagFilters() in class ScheduleEventListener is renamed to clearFilters()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "This method is renamed and also its parameter is changed. both are detected by KotlinRMiner.", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "d7d87d8543e16978c4592746b6aad47b3b4b0e8c", "url" : "https://github.com/google/iosched/commit/d7d87d8543e16978c4592746b6aad47b3b4b0e8c", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method isPinned() in class UserEvent is renamed to isStarredOrReserved()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadFilteredUserSessionsUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCaseLegacy,TopicSubscriber,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,AnalyticsHelper) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadScheduleUserSessionsUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCaseLegacy,TopicSubscriber,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createFeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCaseLegacy,GetConferenceStateUseCase,TimeProvider,SignInViewModelDelegate,ThemedActivityDelegate) in class FeedViewModelTest is changed to createFeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadStarredAndReservedSessionsUseCase,GetTimeZoneUseCaseLegacy,GetConferenceStateUseCase,TimeProvider,SignInViewModelDelegate,ThemedActivityDelegate)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsUseCaseTest is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadScheduleUserSessionsUseCaseTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadFilteredUserSessionsUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCaseLegacy,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,AnalyticsHelper) in class ScheduleViewModel is changed to ScheduleViewModel(LoadScheduleUserSessionsUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCaseLegacy,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class parameter is renamed. So it is not a real change method parameter.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsParameters is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadScheduleUserSessionsParameters", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadFilteredUserSessionsResult is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadScheduleUserSessionsResult", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createFeedSessionsContainer(Result,ZoneId) in class FeedViewModel is changed to createFeedSessionsContainer(Result>,ZoneId)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method execute(LoadFilteredUserSessionsParameters) in class LoadScheduleUserSessionsUseCase is changed to execute(LoadScheduleUserSessionsParameters)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "d892dbfa79a1f2dcd800df86b66d5d0e6ff66d48", "url" : "https://github.com/google/iosched/commit/d892dbfa79a1f2dcd800df86b66d5d0e6ff66d48", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCase,TopicSubscriber,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModelTest is changed to createScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,SnackbarMessageManager,ScheduleUiHintsShownUseCase,GetTimeZoneUseCaseLegacy,TopicSubscriber,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createFeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCase,ConferenceStateLiveData,TimeProvider,SignInViewModelDelegate,ThemedActivityDelegate) in class FeedViewModelTest is changed to createFeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCaseLegacy,ConferenceStateLiveData,TimeProvider,SignInViewModelDelegate,ThemedActivityDelegate)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,ReservationActionUseCase,StarEventAndNotifyUseCase,GetTimeZoneUseCase,SnackbarMessageManager,NetworkUtils,TimeProvider,AnalyticsHelper) in class SessionDetailViewModelTest is changed to createSessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,ReservationActionUseCase,StarEventAndNotifyUseCase,GetTimeZoneUseCaseLegacy,SnackbarMessageManager,NetworkUtils,TimeProvider,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createViewModel(LoadSpeakerUseCase,LoadUserSessionsUseCase,GetTimeZoneUseCase,SignInViewModelDelegate,EventActionsViewModelDelegate,AnalyticsHelper) in class SpeakerViewModelTest is changed to createViewModel(LoadSpeakerUseCase,LoadUserSessionsUseCase,GetTimeZoneUseCaseLegacy,SignInViewModelDelegate,EventActionsViewModelDelegate,AnalyticsHelper)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCase,RefreshConferenceDataUseCase,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper) in class ScheduleViewModel is changed to ScheduleViewModel(LoadFilteredUserSessionsUseCase,LoadEventFiltersUseCase,SignInViewModelDelegate,StarEventAndNotifyUseCase,ScheduleUiHintsShownUseCase,TopicSubscriber,SnackbarMessageManager,GetTimeZoneUseCaseLegacy,RefreshConferenceDataUseCaseLegacy,ObserveConferenceDataUseCase,LoadSelectedFiltersUseCase,SaveSelectedFiltersUseCase,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,StarEventAndNotifyUseCase,ReservationActionUseCase,GetTimeZoneUseCase,SnackbarMessageManager,TimeProvider,NetworkUtils,AnalyticsHelper) in class SessionDetailViewModel is changed to SessionDetailViewModel(SignInViewModelDelegate,LoadUserSessionUseCase,LoadUserSessionsUseCase,StarEventAndNotifyUseCase,ReservationActionUseCase,GetTimeZoneUseCaseLegacy,SnackbarMessageManager,TimeProvider,NetworkUtils,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCase,ConferenceStateLiveData,TimeProvider,AnalyticsHelper,SignInViewModelDelegate,ThemedActivityDelegate) in class FeedViewModel is changed to FeedViewModel(LoadCurrentMomentUseCase,LoadAnnouncementsUseCase,LoadFilteredUserSessionsUseCase,GetTimeZoneUseCaseLegacy,ConferenceStateLiveData,TimeProvider,AnalyticsHelper,SignInViewModelDelegate,ThemedActivityDelegate)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SettingsViewModel(SetTimeZoneUseCase,GetTimeZoneUseCase,NotificationsPrefSaveActionUseCase,GetNotificationsSettingUseCase,SetAnalyticsSettingUseCase,GetAnalyticsSettingUseCase,SetThemeUseCase,GetThemeUseCase,GetAvailableThemesUseCase) in class SettingsViewModel is changed to SettingsViewModel(SetTimeZoneUseCase,GetTimeZoneUseCaseLegacy,NotificationsPrefSaveActionUseCase,GetNotificationsSettingUseCase,SetAnalyticsSettingUseCase,GetAnalyticsSettingUseCase,SetThemeUseCase,GetThemeUseCase,GetAvailableThemesUseCase)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SpeakerViewModel(LoadSpeakerUseCase,LoadUserSessionsUseCase,GetTimeZoneUseCase,SignInViewModelDelegate,EventActionsViewModelDelegate,AnalyticsHelper) in class SpeakerViewModel is changed to SpeakerViewModel(LoadSpeakerUseCase,LoadUserSessionsUseCase,GetTimeZoneUseCaseLegacy,SignInViewModelDelegate,EventActionsViewModelDelegate,AnalyticsHelper)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field codelabsUseCaseResult in class CodelabsViewModel is rename to _codelabs", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadTagsByCategoryUseCase(TagRepository) in class LoadTagsByCategoryUseCase is changed to LoadTagsByCategoryUseCase(TagRepository,CoroutineDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoadTagsUseCase(TagRepository) in class LoadTagsUseCase is changed to LoadTagsUseCase(TagRepository,CoroutineDispatcher)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadSessionSyncUseCase is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadSessionOneShotUseCase", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionSyncUseCase is Rename to com.google.samples.apps.iosched.shared.domain.sessions.LoadUserSessionOneShotUseCase", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass CoroutinesUseCase is extracted from children classes LoadSessionOneShotUseCase,LoadUserSessionOneShotUseCase,RefreshConferenceDataUseCase,GetCodelabsInfoCardShownUseCase,LoadCodelabsUseCase,OnboardingCompletedUseCase,GetTimeZoneUseCase", "detectionTools" : [ "KotlinRMiner", "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/google/iosched", "sha1" : "eca234bbe82c328e9e10fd60aca9c9d6cf80d620", "url" : "https://github.com/google/iosched/commit/eca234bbe82c328e9e10fd60aca9c9d6cf80d620", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.test.util.fakes.FakeFirebaseUserDataSource is Rename to com.google.samples.apps.iosched.test.util.fakes.FakeAuthenticatedUser", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.data.login.DefaultFirebaseUserDataSourceTest is Rename to com.google.samples.apps.iosched.shared.data.login.FirebaseAuthenticatedUserTest", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method DefaultFirebaseUserDataSource(FirebaseAuth) in class DefaultFirebaseUserDataSource is renamed to FirebaseAuthenticatedUser(FirebaseAuth)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.data.login.DefaultFirebaseUserDataSource is Rename to com.google.samples.apps.iosched.shared.data.login.FirebaseAuthenticatedUser", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.shared.data.login.FirebaseUserDataSource is Rename to com.google.samples.apps.iosched.shared.data.login.AuthenticatedUser", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class com.google.samples.apps.iosched.util.login.LoginHandler is Rename to com.google.samples.apps.iosched.util.login.DefaultLoginHandler", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method provideLoginViewModelPlugin(FirebaseUserDataSource) in class LoginViewModelPluginModule is changed to provideLoginViewModelPlugin(AuthenticatedUser)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getProfileContentDescription(Result) in class ScheduleViewModel is changed to getProfileContentDescription(Result)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface LoginHandler is extracted from classes DefaultLoginHandler", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "2f67f8363b18bca935a4fb3a8d6d7d0332406e72", "url" : "https://github.com/mamoe/mirai/commit/2f67f8363b18bca935a4fb3a8d6d7d0332406e72", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method doReceiveCatchingExceptions(Packet) in class TemporaryPacketHandler is renamed to doReceivePassingExceptionsToDeferred(Packet)", "validation" : "TP", "comment" : "Note class TemporaryPacketHandler is moved to another package.", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestFriendListPacket is Move to net.mamoe.mirai.timpc.network.packet.action.RequestFriendListPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.PostMemberJoinEvent is Move to net.mamoe.mirai.timpc.network.packet.event.PostMemberJoinEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.Message is Move to net.mamoe.mirai.message.data.Message", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.internal.MemberImpl is Move to net.mamoe.mirai.timpc.network.MemberImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.KnownEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.KnownEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImagePacket is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImagePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.RequestSessionPacket is Move to net.mamoe.mirai.timpc.network.packet.login.RequestSessionPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.PacketFactory is Move to net.mamoe.mirai.timpc.network.packet.PacketFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MuteEvent is Move to net.mamoe.mirai.event.events.MuteEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.DecrypterIoBuffer is Move to net.mamoe.mirai.timpc.network.packet.DecrypterIoBuffer", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.GroupMemberPermissionChangedEventFactory is Move to net.mamoe.mirai.timpc.network.packet.event.GroupMemberPermissionChangedEventFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.data.Gender is Move to net.mamoe.mirai.network.data.Gender", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.ImageId0x06 is Move to net.mamoe.mirai.message.data.ImageId0x06", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.NullMessageChain is Move to net.mamoe.mirai.message.data.NullMessageChain", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.ImageId0x03 is Move to net.mamoe.mirai.message.data.ImageId0x03", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.IgnoredPacket is Move to net.mamoe.mirai.timpc.network.packet.IgnoredPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.QueryNicknamePacket is Move to net.mamoe.mirai.timpc.network.packet.action.QueryNicknamePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupPacket is Move to net.mamoe.mirai.timpc.network.packet.action.GroupPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.BeingUnmutedEvent is Move to net.mamoe.mirai.event.events.BeingUnmutedEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.TIMProtocol is Move to net.mamoe.mirai.timpc.network.TIMProtocol", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.TIMBotNetworkHandler is Move to net.mamoe.mirai.timpc.network.TIMBotNetworkHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.HeartbeatPacket is Move to net.mamoe.mirai.timpc.network.packet.login.HeartbeatPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.Decrypter is Move to net.mamoe.mirai.timpc.network.packet.Decrypter", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.PacketVersion is Move to net.mamoe.mirai.timpc.network.packet.PacketVersion", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.MessageChain is Move to net.mamoe.mirai.message.data.MessageChain", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.IgnoredPacketFactory is Move to net.mamoe.mirai.timpc.network.packet.IgnoredPacketFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.ShareKey is Move to net.mamoe.mirai.timpc.network.packet.login.ShareKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.SingleOnly is Move to net.mamoe.mirai.message.data.SingleOnly", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.UnmuteEvent is Move to net.mamoe.mirai.event.events.UnmuteEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.PrivateKey is Move to net.mamoe.mirai.timpc.network.packet.login.PrivateKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.SessionResponseDecryptionKey is Move to net.mamoe.mirai.timpc.network.packet.login.SessionResponseDecryptionKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.IgnoredPacketIds is Move to net.mamoe.mirai.timpc.network.packet.IgnoredPacketIds", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.ImageUploadInfo is Move to net.mamoe.mirai.timpc.network.packet.action.ImageUploadInfo", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.QueryFriendListListPacket is Move to net.mamoe.mirai.timpc.network.packet.action.QueryFriendListListPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupImageResponse is Move to net.mamoe.mirai.timpc.network.packet.action.GroupImageResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.KnownPacketId is Move to net.mamoe.mirai.timpc.network.packet.KnownPacketId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.PacketId is Move to net.mamoe.mirai.timpc.network.packet.PacketId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.SingleMessageChainImpl is Move to net.mamoe.mirai.message.data.SingleMessageChainImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.ItemBuilder is Move to net.mamoe.mirai.message.data.ItemBuilder", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.SendFriendMessagePacket is Move to net.mamoe.mirai.timpc.network.packet.action.SendFriendMessagePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.AddFriendResult is Move to net.mamoe.mirai.network.data.AddFriendResult", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.EventPacketIdentity is Move to net.mamoe.mirai.timpc.network.packet.event.EventPacketIdentity", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.PreviousNameList is Move to net.mamoe.mirai.network.data.PreviousNameList", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendAddRequestEventPacket is Move to net.mamoe.mirai.timpc.network.packet.event.FriendAddRequestEventPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestProfileDetailsResponse is Move to net.mamoe.mirai.timpc.network.packet.action.RequestProfileDetailsResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.utils.internal.NamedHexElement is Move to hex.NamedHexElement", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.QuitGroupResponse is Move to net.mamoe.mirai.timpc.network.packet.action.GroupPacket.QuitGroupResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.LoginResult is Move to net.mamoe.mirai.network.data.LoginResult", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.Face is Move to net.mamoe.mirai.message.data.Face", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberJoinEvent is Move to net.mamoe.mirai.timpc.network.packet.event.MemberJoinEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.AndroidDeviceStatusChangePacket is Move to net.mamoe.mirai.timpc.network.packet.event.AndroidDeviceStatusChangePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendStatusChanged is Move to net.mamoe.mirai.event.events.FriendStatusChanged", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberGoneEventPacketHandler is Move to net.mamoe.mirai.timpc.network.packet.event.MemberGoneEventPacketHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.XMLMessage is Move to net.mamoe.mirai.message.data.XMLMessage", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.handler.TemporaryPacketHandler is Move to net.mamoe.mirai.timpc.network.handler.TemporaryPacketHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.UnknownPacket is Move to net.mamoe.mirai.timpc.network.packet.UnknownPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.NoDecrypter is Move to net.mamoe.mirai.timpc.network.packet.NoDecrypter", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendConversationInitialize is Move to net.mamoe.mirai.timpc.network.packet.event.FriendConversationInitialize", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.DecrypterType is Move to net.mamoe.mirai.timpc.network.packet.DecrypterType", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.TouchPacket is Move to net.mamoe.mirai.timpc.network.packet.login.TouchPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.NoLog is Move to net.mamoe.mirai.timpc.network.packet.NoLog", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MessagePacket is Move to net.mamoe.mirai.message.MessagePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.OutgoingPacket is Move to net.mamoe.mirai.timpc.network.packet.OutgoingPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.UnknownEventPacket is Move to net.mamoe.mirai.timpc.network.packet.event.UnknownEventPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.GroupFileUploadPacket is Move to net.mamoe.mirai.timpc.network.packet.event.GroupFileUploadPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.NoPacket is Move to net.mamoe.mirai.timpc.network.packet.NoPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.UnknownPacketId is Move to net.mamoe.mirai.timpc.network.packet.UnknownPacketId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.utils.internal.TestConsts is Move to hex.TestConsts", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.UnknownEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.UnknownEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImageResponse is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImageResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.SessionKey is Move to net.mamoe.mirai.timpc.network.packet.SessionKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupImagePacket is Move to net.mamoe.mirai.timpc.network.packet.action.GroupImagePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.internal.ContactImpl is Move to net.mamoe.mirai.timpc.network.ContactImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendConversationInitializedEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.FriendConversationInitializedEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.ChangeOnlineStatusPacket is Move to net.mamoe.mirai.timpc.network.packet.login.ChangeOnlineStatusPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImageUKey is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImageUKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.PlainText is Move to net.mamoe.mirai.message.data.PlainText", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.Image is Move to net.mamoe.mirai.message.data.Image", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.ConnectionOccupiedPacketHandler is Move to net.mamoe.mirai.timpc.network.packet.event.ConnectionOccupiedPacketHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.BeingKickEvent is Move to net.mamoe.mirai.timpc.network.packet.event.BeingKickEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.XMLMessageBuilder is Move to net.mamoe.mirai.message.data.XMLMessageBuilder", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.MessageChainImpl is Move to net.mamoe.mirai.message.data.MessageChainImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.AndroidDeviceOnlineStatusChangedEventFactory is Move to net.mamoe.mirai.timpc.network.packet.event.AndroidDeviceOnlineStatusChangedEventFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendListList is Move to net.mamoe.mirai.timpc.network.packet.action.FriendListList", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.SKey is Move to net.mamoe.mirai.timpc.network.packet.login.SKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.SubmitPasswordResponseDecrypter is Move to net.mamoe.mirai.timpc.network.packet.login.SubmitPasswordResponseDecrypter", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberJoinPacketHandler is Move to net.mamoe.mirai.timpc.network.packet.event.MemberJoinPacketHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.IgnoredEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.IgnoredEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.NullPacketId is Move to net.mamoe.mirai.timpc.network.packet.NullPacketId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.handler.DataPacketSocketAdapter is Move to net.mamoe.mirai.timpc.network.handler.DataPacketSocketAdapter", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupImageLink is Move to net.mamoe.mirai.timpc.network.packet.action.GroupImageLink", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberPermissionChangePacket is Move to net.mamoe.mirai.timpc.network.packet.event.MemberPermissionChangePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.internal.QQImpl is Move to net.mamoe.mirai.timpc.network.QQImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestAccountInfoPacket is Move to net.mamoe.mirai.timpc.network.packet.action.RequestAccountInfoPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendMessage is Move to net.mamoe.mirai.message.FriendMessage", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.SubmitPasswordPacket is Move to net.mamoe.mirai.timpc.network.packet.login.SubmitPasswordPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.EmptyMessageChain is Move to net.mamoe.mirai.message.data.EmptyMessageChain", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendList is Move to net.mamoe.mirai.timpc.network.packet.action.FriendList", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendOnlineStatusChangedPacket is Move to net.mamoe.mirai.timpc.network.packet.event.FriendOnlineStatusChangedPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.NicknameMap is Move to net.mamoe.mirai.timpc.network.packet.action.NicknameMap", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImageLink is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImageLink", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MessagePacketBase is Move to net.mamoe.mirai.message.MessagePacketBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.QueryFriendRemarkPacket is Move to net.mamoe.mirai.timpc.network.packet.action.QueryFriendRemarkPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.CanAddFriendPacket is Move to net.mamoe.mirai.timpc.network.packet.action.CanAddFriendPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.EventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.EventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.QueryPreviousNamePacket is Move to net.mamoe.mirai.timpc.network.packet.action.QueryPreviousNamePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.Unknown0x02DCPacketFlag0x0EMaybeMutePacket is Move to net.mamoe.mirai.timpc.network.packet.event.Unknown0x02DCPacketFlag0x0EMaybeMutePacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class mirai.test.packetdebugger.PacketDebugger is Move to PacketDebugger", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.FriendMessageEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.FriendMessageEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.Packet is Move to net.mamoe.mirai.network.data.Packet", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.internal.GroupImpl is Move to net.mamoe.mirai.timpc.network.GroupImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.contact.data.Profile is Move to net.mamoe.mirai.network.data.Profile", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.FaceId is Move to net.mamoe.mirai.message.data.FaceId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.EventOfMute is Move to net.mamoe.mirai.event.events.EventOfMute", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.AddFriendPacket is Move to net.mamoe.mirai.timpc.network.packet.action.AddFriendPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.CanAddFriendResponse is Move to net.mamoe.mirai.timpc.network.packet.action.CanAddFriendResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.AvatarLink is Move to net.mamoe.mirai.timpc.network.packet.action.AvatarLink", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.RequestSKeyPacket is Move to net.mamoe.mirai.timpc.network.packet.login.RequestSKeyPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestProfileDetailsPacket is Move to net.mamoe.mirai.timpc.network.packet.action.RequestProfileDetailsPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.IgnoredEventIds is Move to net.mamoe.mirai.timpc.network.packet.event.IgnoredEventIds", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.IgnoredPacketId is Move to net.mamoe.mirai.timpc.network.packet.IgnoredPacketId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.UnknownPacketFactory is Move to net.mamoe.mirai.timpc.network.packet.UnknownPacketFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestFriendAdditionKeyPacket is Move to net.mamoe.mirai.timpc.network.packet.action.RequestFriendAdditionKeyPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.GroupMessageEventParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.GroupMessageEventParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupNotFound is Move to net.mamoe.mirai.timpc.network.packet.action.GroupNotFound", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.GroupFileUploadEventFactory is Move to net.mamoe.mirai.timpc.network.packet.event.GroupFileUploadEventFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.DecrypterByteArray is Move to net.mamoe.mirai.timpc.network.packet.DecrypterByteArray", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberMuteEvent is Move to net.mamoe.mirai.event.events.MemberMuteEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.ImageLink is Move to net.mamoe.mirai.network.data.ImageLink", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.At is Move to net.mamoe.mirai.message.data.At", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.CaptchaPacket is Move to net.mamoe.mirai.timpc.network.packet.login.CaptchaPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class mirai.test.packetdebugger.PacketDecoderScope is Move to packetdebugger.PacketDecoderScope", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.CaptchaKey is Move to net.mamoe.mirai.timpc.network.packet.login.CaptchaKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.OverFileSizeMaxException is Move to net.mamoe.mirai.utils.OverFileSizeMaxException", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImageOverFileSizeMax is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImageOverFileSizeMax", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.utils.internal.HexComparator is Move to hex.HexComparator", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RawGroupInfo is Move to net.mamoe.mirai.timpc.internal.RawGroupInfo", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.EventPacketFactory is Move to net.mamoe.mirai.timpc.network.packet.event.EventPacketFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberMuteEventPacketParserAndHandler is Move to net.mamoe.mirai.timpc.network.packet.event.MemberMuteEventPacketParserAndHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberJoinEventPacket is Move to net.mamoe.mirai.timpc.network.packet.event.MemberJoinEventPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendAdditionKey is Move to net.mamoe.mirai.timpc.network.packet.action.FriendAdditionKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.PreMemberJoinEvent is Move to net.mamoe.mirai.timpc.network.packet.event.PreMemberJoinEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.IgnoredEventPacket is Move to net.mamoe.mirai.timpc.network.packet.event.IgnoredEventPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.BeingMutedEvent is Move to net.mamoe.mirai.event.events.BeingMutedEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendNameRemark is Move to net.mamoe.mirai.network.data.FriendNameRemark", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class mirai.test.packetdebugger.Recorder is Move to Recorder", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.TouchKey is Move to net.mamoe.mirai.timpc.network.packet.login.TouchKey", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.ConnectionOccupiedEvent is Move to net.mamoe.mirai.event.events.ConnectionOccupiedEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberUnmuteEvent is Move to net.mamoe.mirai.event.events.MemberUnmuteEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.SessionPacketFactory is Move to net.mamoe.mirai.timpc.network.packet.SessionPacketFactory", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.ImageId is Move to net.mamoe.mirai.message.data.ImageId", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.GroupInfo is Move to net.mamoe.mirai.network.data.GroupInfo", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.utils.internal.PacketIds is Move to hex.PacketIds", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.XMLDsl is Move to net.mamoe.mirai.message.data.XMLDsl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.FriendImageAlreadyExists is Move to net.mamoe.mirai.timpc.network.packet.action.FriendImageAlreadyExists", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.LinkedDecrypter is Move to net.mamoe.mirai.timpc.network.packet.LinkedDecrypter", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.action.RequestProfileAvatarPacket is Move to net.mamoe.mirai.timpc.network.packet.action.RequestProfileAvatarPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberQuitEvent is Move to net.mamoe.mirai.timpc.network.packet.event.MemberQuitEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.MemberListChangedEvent is Move to net.mamoe.mirai.timpc.network.packet.event.MemberListChangedEvent", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass TIMPCBotBase is extracted from parent class BotImpl", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getGroup(GroupId) in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method tryReinitializeNetworkHandler(BotConfiguration,Throwable) in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getQQ(Long) in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getGroup(Long) in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,SessionKey,MessageChain) in class SendFriendMessagePacket is changed to invoke(Long,Long,SessionKey,MessageChain)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestAdd(UInt,UInt,SessionKey,String,String,FriendAdditionKey) in class AddFriendPacket is changed to RequestAdd(Long,Long,SessionKey,String,String,FriendAdditionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Submit(UInt,ByteArray,String,IoBuffer) in class CaptchaPacket is changed to Submit(Long,ByteArray,String,IoBuffer)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Mute(UInt,GroupInternalId,SessionKey,UInt,UInt) in class GroupPacket is changed to Mute(Long,GroupInternalId,SessionKey,Long,UInt)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestImageLink(UInt,SessionKey,ImageId) in class FriendImagePacket is changed to RequestImageLink(Long,SessionKey,ImageId)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,String,IoBuffer,IoBuffer,IoBuffer) in class RequestSessionPacket is changed to invoke(Long,String,IoBuffer,IoBuffer,IoBuffer)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Refresh(UInt,ByteArray) in class CaptchaPacket is changed to Refresh(Long,ByteArray)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestTransmission(UInt,ByteArray,Int,ByteArray) in class CaptchaPacket is changed to RequestTransmission(Long,ByteArray,Int,ByteArray)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,String,Boolean) in class TouchPacket is changed to invoke(Long,String,Boolean)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,Long,SessionKey,EventPacketIdentity)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QueryGroupInfo(UInt,GroupInternalId,SessionKey) in class GroupPacket is changed to QueryGroupInfo(Long,GroupInternalId,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Message(UInt,GroupInternalId,SessionKey,MessageChain) in class GroupPacket is changed to Message(Long,GroupInternalId,SessionKey,MessageChain)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey) in class HeartbeatPacket is changed to invoke(Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey) in class RequestAccountInfoPacket is changed to invoke(Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey) in class RequestSKeyPacket is changed to invoke(Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey,OnlineStatus) in class ChangeOnlineStatusPacket is changed to invoke(Long,SessionKey,OnlineStatus)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method instanceWhose(UInt) in class BotImpl is changed to instanceWhose(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey) in class RequestFriendListPacket is changed to invoke(Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getMember(UInt) in class Group is changed to getMember(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestImageId(UInt,SessionKey,UInt,ExternalImage) in class FriendImagePacket is changed to RequestImageId(Long,SessionKey,Long,ExternalImage)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QuitGroup(UInt,SessionKey,GroupInternalId) in class GroupPacket is changed to QuitGroup(Long,SessionKey,GroupInternalId)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MemberPermissionChangePacket(UInt,UInt,Kind) in class MemberPermissionChangePacket is changed to MemberPermissionChangePacket(Long,Long,Kind)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method close() in class Bot is changed to close(Throwable)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method instanceWhose(UInt) in class Bot is changed to instanceWhose(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getOrNull(UInt) in class ContactList is changed to getOrNull(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QQImpl(Bot,UInt,CoroutineContext) in class QQImpl is changed to QQImpl(TIMPCBot,Long,CoroutineContext)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method TIMBotNetworkHandler(CoroutineContext,Bot) in class TIMBotNetworkHandler is changed to TIMBotNetworkHandler(CoroutineContext,TIMPCBot)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getMember(UInt) in class GroupImpl is changed to getMember(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GroupImpl(Bot,GroupId,CoroutineContext) in class GroupImpl is changed to GroupImpl(TIMPCBot,GroupId,CoroutineContext)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Profile(UInt,String,String,String,Int,String,String,Gender,GMTDate,String,String,String,String,String) in class Profile is changed to Profile(Long,String,String,String,Int,String,String,Gender,GMTDate,String,String,String,String,String)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method EventPacketIdentity(UInt,UInt,IoBuffer) in class EventPacketIdentity is changed to EventPacketIdentity(Long,Long,IoBuffer)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestProfileDetailsResponse(UInt,Profile) in class RequestProfileDetailsResponse is changed to RequestProfileDetailsResponse(Long,Profile)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GroupInternalId(UInt) in class GroupInternalId is changed to GroupInternalId(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method TemporaryPacketHandler(KClass,CompletableDeferred,BotSession,Boolean,CoroutineContext) in class TemporaryPacketHandler is changed to TemporaryPacketHandler(KClass,CompletableDeferred,UShort,CoroutineContext,suspend ", "validation" : "TP", "comment" : "The package of class is also changed.", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method At(UInt) in class At is changed to At(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendConversationInitialize(UInt) in class FriendConversationInitialize is changed to FriendConversationInitialize(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RawGroupInfo(UInt,UInt,String,String,Map) in class RawGroupInfo is changed to RawGroupInfo(Long,Long,String,String,Map)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey,UInt) in class QueryFriendRemarkPacket is changed to invoke(Long,SessionKey,Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method filter(BotSession,Packet,UShort) in class TemporaryPacketHandler is changed to filter(Packet,UShort)", "validation" : "TP", "comment" : "Note class TemporaryPacketHandler is also moved.", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startLogin(UInt,String) in class MiraiBinder is changed to startLogin(Long,String)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey,UInt) in class QueryNicknamePacket is changed to invoke(Long,SessionKey,Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey,UInt) in class QueryPreviousNamePacket is changed to invoke(Long,SessionKey,Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method login(UInt,String) in class MiraiService is changed to login(Long,String)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,SessionKey) in class RequestProfileDetailsPacket is changed to invoke(Long,Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,SessionKey) in class RequestFriendAdditionKeyPacket is changed to invoke(Long,Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,SessionKey) in class RequestProfileAvatarPacket is changed to invoke(Long,Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface BotFactory is extracted from classes TIMPC", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class DebugNetworkHandler is extracted from class DebugNetworkHandler", "validation" : "FP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class ReceiveFriendAddRequestEvent is extracted from class ReceiveFriendAddRequestEvent", "validation" : "FP", "comment" : "To me class is moved.", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field groups in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field qqs in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field supervisor in class DebugNetworkHandler is moved to class TIMBotNetworkHandler", "validation" : "FP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method sendAndExpectAsync(Boolean,suspend in class BotSessionBase is moved to class TIMPCBotBase", "validation" : "FP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method sendAndExpectAsync(Boolean) in class BotSessionBase is moved to class TIMPCBotBase", "validation" : "FP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method awaitDisconnection() in class DebugNetworkHandler is moved to class DebugNetworkHandler", "validation" : "FP", "comment" : "", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ReceiveFriendAddRequestEvent(QQ,String) in class ReceiveFriendAddRequestEvent is moved to class ReceiveFriendAddRequestEvent", "validation" : "FP", "comment" : "Class is moved. So Move Method is incorrect.", "detectionTools" : [ "RefDetect" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class mirai.test.packetdebugger.DebugNetworkHandler is Move to DebugNetworkHandler", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.login.HeartbeatPacketResponse is Move to net.mamoe.mirai.timpc.network.packet.login.HeartbeatPacketResponse", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.timpc.packet.event.EventPacket is Move to net.mamoe.mirai.network.data.EventPacket", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.OutgoingPacketEvent is MoveAndRename to net.mamoe.mirai.timpc.TIMPCBot", "validation" : "FP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.PacketSentEvent is MoveAndRename to net.mamoe.mirai.utils.LoginFailedException", "validation" : "FP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.BotSession is MoveAndRename to net.mamoe.mirai.timpc.TIMPCBot", "validation" : "FP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method get(UInt) in class ContactList is changed to get(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method containsId(UInt) in class ContactList is changed to containsId(Long)", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class PacketFactory is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class UnknownPacketFactory is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class IgnoredPacketFactory is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class QueryPreviousNamePacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,SessionKey) in class CanAddFriendPacket is changed to invoke(Long,Long,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class CanAddFriendPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestFriendAdditionKeyPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Approve(UInt,SessionKey,Short,UInt,String?) in class AddFriendPacket is changed to Approve(Long,SessionKey,Short,Long,String?)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class AddFriendPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class FriendImagePacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class QueryFriendListListPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestAccountInfoPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestImageId(UInt,GroupInternalId,ExternalImage,SessionKey) in class GroupImagePacket is changed to RequestImageId(Long,GroupInternalId,ExternalImage,SessionKey)", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RequestImageLink(UInt,SessionKey,ImageId0x03) in class GroupImagePacket is changed to RequestImageLink(Long,SessionKey,ImageId0x03)", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class GroupImagePacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Mute(UInt,GroupInternalId,SessionKey,Long,UInt) in class GroupPacket is changed to Mute(Long,GroupInternalId,SessionKey,Long,UInt)", "validation" : "FP", "comment" : "KotlinRMiner incorrectly identifies parameters, whereas RefDetect accurately identifies the correct parameters.", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Mute(Long,GroupInternalId,SessionKey,UInt,UInt) in class GroupPacket is changed to Mute(Long,GroupInternalId,SessionKey,Long,UInt)", "validation" : "FP", "comment" : "KotlinRMiner incorrectly identifies parameters, whereas RefDetect accurately identifies the correct parameters.", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class GroupPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,SessionKey,Array) in class QueryNicknamePacket is changed to invoke(Long,SessionKey,Array)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class QueryNicknamePacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestProfileAvatarPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestProfileDetailsPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class QueryFriendRemarkPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestFriendListPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class SendFriendMessagePacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class EventPacketFactory is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class FriendOnlineStatusChangedPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class CaptchaPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class ChangeOnlineStatusPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class HeartbeatPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,String,Int,String,PrivateKey,ByteArray,ByteArray?,Boolean,IoBuffer?) in class SubmitPasswordPacket is changed to invoke(Long,String,Int,String,PrivateKey,ByteArray,ByteArray?,Boolean,IoBuffer?)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class SubmitPasswordPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestSessionPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class TouchPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decode(PacketId,UShort,BotNetworkHandler<*>) in class RequestSKeyPacket is changed to decode(PacketId,UShort,BotNetworkHandler)", "validation" : "TP", "comment" : "", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method alsoLogin() in class BotHelper is changed to alsoLogin(BotConfiguration)", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method withSession(() in class Contact is renamed to withBot(()", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method getOrAdd(UInt,() in class ContactList is changed to getOrAdd(Long,()", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method SuspendLazy(CoroutineContext,() in class SuspendLazy is renamed to suspendLazy(CoroutineContext,()", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass TIMPCBotBase is extracted from children classes TIMPCBot", "validation" : "FP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method reinitializeNetworkHandler(BotConfiguration,Throwable?) in class BotImpl is pushed down to class TIMPCBotBase", "validation" : "TP", "comment" : "", "detectionTools" : [ "KotlinRMiner" ], "validator" : "" }] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "d89f8acc435a95625fe03e8690d3f7a719b1dc56", "url" : "https://github.com/mamoe/mirai/commit/d89f8acc435a95625fe03e8690d3f7a719b1dc56", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method print(String,LoggerTextFormat) in class Console is renamed to println(String,LoggerTextFormat)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Note class Console from this address mirai-core/src/jvmMain/kotlin/net/mamoe/mirai/utils/MiraiLogger.kt is also moved to this address mirai-core/src/jvmMain/kotlin/net/mamoe/mirai/utils/MiraiLoggerJvm.kt", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method MessagePacketHandler(LoginSession) in class MessagePacketHandler is renamed to EventPacketHandler(LoginSession)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method purple(Any) in class Console is renamed to logPurple(Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method info(Any) in class MiraiLogger is renamed to logInfo(Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Note the class MiraiLogger is also moved from this address mirai-core/src/jvmMain/kotlin/net/mamoe/mirai/utils/MiraiLogger.kt to this address mirai-core/src/commonMain/kotlin/net.mamoe.mirai/utils/MiraiLogger.kt", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method changeOnlineStatus(ClientLoginStatus) in class LoginHandler is renamed to setOnlineStatus(ClientLoginStatus)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Note class is also moved LoginHandler from this address mirai-core/src/jvmMain/kotlin/net/mamoe/mirai/network/protocol/tim/TIMBotNetworkHandler.kt to this address mirai-core/src/commonMain/kotlin/net.mamoe.mirai/network/protocol/tim/TIMBotNetworkHandler.kt. Also, Rename and Change Method refactoirngs happened and both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method setOnlineStatus(ClientLoginStatus) in class LoginHandler is changed to setOnlineStatus(OnlineStatus)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Rename and Change Method refactoirngs happened and both are detected by RefDetect.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.handler.MessagePacketHandler is Rename to net.mamoe.mirai.network.protocol.tim.handler.EventPacketHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.image.ServerTryGetImageIDResponsePacket is Move to net.mamoe.mirai.network.protocol.tim.packet.ServerTryGetImageIDResponsePacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.image.ServerTryGetImageIDFailedPacket is Move to net.mamoe.mirai.network.protocol.tim.packet.ServerTryGetImageIDFailedPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.image.ClientTryGetImageIDPacket is Move to net.mamoe.mirai.network.protocol.tim.packet.ClientTryGetImageIDPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Class ClientTryGetImageIDPacket is renamed to ClientTryGetImageIDPacketJvm", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.image.ServerTryGetImageIDSuccessPacket is Move to net.mamoe.mirai.network.protocol.tim.packet.ServerTryGetImageIDSuccessPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerPacket(DataInputStream) in class ServerPacket is changed to ServerPacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "By looking at references it seems a correct refactoring. Note the folder of class is also changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientVerificationCodeSubmitPacket(Int,Long,ByteArray,String,ByteArray) in class ClientVerificationCodeSubmitPacket is changed to ClientVerificationCodeSubmitPacket(Int,Long,ByteArray,String,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientLoginResendPacket3105(Long,String,Int,String,ByteArray,ByteArray,ByteArray) in class ClientLoginResendPacket3105 is changed to ClientLoginResendPacket3105(Long,String,Int,String,ByteArray,ByteArray,ByteArray,Boolean,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientLoginResendPacket3106(Long,String,Int,String,ByteArray,ByteArray,ByteArray,ByteArray) in class ClientLoginResendPacket3106 is changed to ClientLoginResendPacket3106(Long,String,Int,String,ByteArray,ByteArray,ByteArray,Boolean,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientLoginResendPacket3104(Long,String,Int,String,ByteArray,ByteArray,ByteArray,ByteArray) in class ClientLoginResendPacket3104 is changed to ClientLoginResendPacket3104(Long,String,Int,String,ByteArray,ByteArray,ByteArray,Boolean,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerEventPacket(DataInputStream,ByteArray,ByteArray) in class ServerEventPacket is changed to ServerEventPacket(ByteReadPacket,ByteArray,EventPacketIdentity)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ofId(Int) in class FaceID is changed to ofId(UByte)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Note the folder of class is also changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method LoginSession(Bot,ByteArray,DataPacketSocket) in class LoginSession is changed to LoginSession(Bot,ByteArray,DataPacketSocket,CoroutineScope)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PacketHandlerNode(Class,T) in class PacketHandlerNode is changed to PacketHandlerNode(KClass,T)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientTryGetImageIDPacket(Long,ByteArray,Long,BufferedImage) in class ClientTryGetImageIDPacket is changed to ClientTryGetImageIDPacket(Long,ByteArray,Long,PlatformImage)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method AddFriendSession(Long,CompletableFuture,Lazy) in class AddFriendSession is changed to AddFriendSession(Long,CompletableDeferred,Lazy)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientChangeOnlineStatusPacket(Long,ByteArray,ClientLoginStatus) in class ClientChangeOnlineStatusPacket is changed to ClientChangeOnlineStatusPacket(Long,ByteArray,OnlineStatus)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FaceID(Int) in class FaceID is changed to FaceID(UByte)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The folder of class is also changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientPasswordSubmissionPacket(Long,String,Int,String,ByteArray,ByteArray) in class ClientPasswordSubmissionPacket is changed to ClientPasswordSubmissionPacket(Long,String,Int,String,ByteArray,ByteArray,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientSessionRequestPacket(Long,String,ByteArray,ByteArray,ByteArray) in class ClientSessionRequestPacket is changed to ClientSessionRequestPacket(Long,String,IoBuffer,IoBuffer,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "The folder of class is also changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method UploadImageSession(Long,CompletableFuture,BufferedImage) in class UploadImageSession is changed to UploadImageSession(Long,CompletableDeferred)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientLoginResendPacket(Long,String,Int,String,ByteArray,ByteArray,ByteArray,ByteArray) in class ClientLoginResendPacket is changed to ClientLoginResendPacket(Long,String,Int,String,ByteArray,ByteArray,ByteArray,Boolean,IoBuffer)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerCaptchaTransmissionPacket(DataInputStream,Int,ByteArray) in class ServerCaptchaTransmissionPacket is changed to ServerCaptchaTransmissionPacket(ByteReadPacket,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerAccountInfoResponsePacket(DataInputStream) in class ServerAccountInfoResponsePacket is changed to ServerAccountInfoResponsePacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerCaptchaPacket(DataInputStream) in class ServerCaptchaPacket is changed to ServerCaptchaPacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerTryGetImageIDResponsePacket(DataInputStream) in class ServerTryGetImageIDResponsePacket is changed to ServerTryGetImageIDResponsePacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ServerAddContactResponsePacket(DataInputStream) in class ServerAddContactResponsePacket is changed to ServerAddContactResponsePacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ServerLoginResponsePacket is extracted from children classes ServerLoginResponseFailedPacket,ServerLoginResponseKeyExchangePacket,ServerLoginResponseSuccessPacket,ServerLoginResponseVerificationCodeInitPacket", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Seems correct. But as we do not have intermediate changes it is not decidable that the refactoring is correct or not.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HexCache is extracted from class TIMProtocol", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field hexToByteArrayCacheMap in class TIMProtocol is moved to class HexCache", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field heartbeatJob in class LoginHandler is moved to class TIMBotNetworkHandler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "A look at references when the field is used show the refactoring is detected correctly.", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field message in class TIMBotNetworkHandler is rename to event", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method hexToUBytes(String) in class TIMProtocol is moved to class HexCache", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method hexToBytes(String) in class TIMProtocol is moved to class HexCache", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ServerEventPacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.login.ServerLoginResponsePacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.login.LoginState is Rename to net.mamoe.mirai.network.protocol.tim.packet.login.LoginResult", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.utils.ClientLoginStatus is Rename to net.mamoe.mirai.utils.OnlineStatus", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.TIMProtocol is MoveAndRename to net.mamoe.mirai.utils.HexCache", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ServerFriendMessageEventPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.ServerFieldOnlineStatusChangedPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method decrypt(ByteArray,String) in class TEA is changed to decrypt(ByteArray,IoBuffer)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method encrypt(ByteArray,String) in class TEA is renamed to decrypt(ByteArray,IoBuffer)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method get(Class) in class PacketHandlerList is changed to get(KClass)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ServerEventPacket is extracted from children classes UnknownServerEventPacket,ServerAndroidOnlineEventPacket,ServerAndroidOfflineEventPacket,ServerGroupUploadFileEventPacket,ServerGroupMessageEventPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ServerPacket is extracted from children classes ServerFieldOnlineStatusChangedPacket,ServerAccountInfoResponsePacket,ServerHeartbeatResponsePacket,UnknownServerPacket,ServerTryGetImageIDResponsePacket,ServerCanAddFriendResponsePacket,ServerAddContactResponsePacket,ServerSendFriendMessageResponsePacket,ServerSendGroupMessageResponsePacket,ServerSKeyResponsePacket,ServerLoginResponsePacket,ServerLoginSuccessPacket,ServerSessionKeyResponsePacket,ServerTouchResponsePacket,ServerCaptchaPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It seems only the folder of class ServerPack is changed. So, refactoring is not valid.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ClientLoginResendPacket is extracted from children classes ClientLoginResendPacket3104,ClientLoginResendPacket3105,ClientLoginResendPacket3106", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ServerCaptchaTransmissionPacket is extracted from children classes ServerCaptchaWrongPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class is there only its folder is changed.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class TIMProtocol is extracted from class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Only the folder of class is changed from mirai-core/src/commonMain/kotlin/net.mamoe.mirai/network/protocol/tim/TIMProtocol.kt to mirai-core/src/jvmMain/kotlin/net/mamoe/mirai/network/protocol/tim/TIMProtocol.kt", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field SERVER_IP in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field head in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field ver in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field fixVer in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field tail in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field fixVer2 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field constantData1 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field constantData2 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field touchKey in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field redirectionKey in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field publicKey in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field key0836 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field shareKey in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field key00BA in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field key00BAFix in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field passwordSubmissionTLV2 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field passwordSubmissionTLV1 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field messageConst1 in class TIMProtocol is moved to class TIMProtocol", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "bd9cf3bfd15b1bdda96b5a7715f4c6645743641e", "url" : "https://github.com/mamoe/mirai/commit/bd9cf3bfd15b1bdda96b5a7715f4c6645743641e", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.action.CanAddFriendPacket.Response.State is Move to net.mamoe.mirai.network.protocol.tim.packet.action.CanAddFriendResponse.State", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onLoggedIn(ByteArray) in class TIMBotNetworkHandler is changed to onLoggedIn()", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPacketReceived(ServerPacket) in class LoginHandler is changed to onPacketReceived(Any)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndChangeMethodParameters", "description" : "MoveAndChangeMethodParameters: Method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class ServerEventPacket is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity) and moved to class EventPacketFactory", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,ByteArray) in class RequestSKeyPacket is changed to invoke(UInt,SessionKey)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,GroupInternalId,ByteArray,MessageChain) in class SendGroupMessagePacket is changed to invoke(UInt,GroupInternalId,SessionKey,MessageChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,ByteArray) in class RequestProfileDetailsPacket is changed to invoke(UInt,UInt,SessionKey)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,ByteArray,OnlineStatus) in class ChangeOnlineStatusPacket is changed to invoke(UInt,SessionKey,OnlineStatus)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,ByteArray) in class AddFriendPacket is changed to invoke(UInt,UInt,SessionKey)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,ByteArray) in class HeartbeatPacket is changed to invoke(UInt,SessionKey)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,ByteArray,UInt,ExternalImage) in class FriendImageIdRequestPacket is changed to invoke(UInt,SessionKey,UInt,ExternalImage)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,GroupInternalId,ExternalImage,ByteArray) in class GroupImageIdRequestPacket is changed to invoke(UInt,GroupInternalId,ExternalImage,SessionKey)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method BotSession(Bot,ByteArray,DataPacketSocketAdapter,CoroutineScope) in class BotSession is changed to BotSession(Bot,SessionKey,DataPacketSocketAdapter,CoroutineScope)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPacketReceived(ServerPacket) in class PacketHandler is changed to onPacketReceived(Packet)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method KnownPacketId(UShort,OutgoingPacketBuilder) in class KnownPacketId is changed to KnownPacketId(UShort,PacketFactory)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass SessionPacketFactory is extracted from children classes FriendOnlineStatusChangedPacket,HeartbeatPacket,IgnoredPacketFactory,RequestAccountInfoPacket,UnknownPacketFactory", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class PacketFactory is extracted from class OutgoingPacketBuilder", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field sequenceIdInternal in class OutgoingPacketBuilder is moved to class PacketFactory", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.Response is Rename to net.mamoe.mirai.network.protocol.tim.packet.SessionKey", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ResponsePacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.EventPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.action.ServerAddContactResponsePacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.HeartbeatPacketResponse", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.event.ServerAndroidOnlineEventPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.event.IgnoredEventPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.event.ServerAndroidOfflineEventPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.event.UnknownEventPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.event.IgnoredServerEventPacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.IgnoredPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.login.ServerCaptchaPacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.UnknownPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.login.ServerLoginResponsePacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.NoPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.login.ServerLoginSuccessPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.login.PrivateKey", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPacketReceived(ServerPacket) in class ActionPacketHandler is changed to onPacketReceived(Packet)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method onPacketReceived(ServerPacket) in class EventPacketHandler is changed to onPacketReceived(Packet)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method filter(BotSession,ServerPacket,UShort) in class TemporaryPacketHandler is changed to filter(BotSession,Packet,UShort)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method filter(BotSession,Packet) in class TemporaryPacketHandler is changed to filter(BotSession,Packet,UShort)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method doReceiveWithoutExceptions(ServerPacket) in class TemporaryPacketHandler is changed to doReceiveWithoutExceptions(Packet)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,ByteArray) in class RequestAccountInfoPacket is changed to invoke(UInt,SessionKey)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,String,Int,String,ByteArray,ByteArray,ByteArray?,Boolean,IoBuffer?) in class SubmitPasswordPacket is changed to invoke(UInt,String,Int,String,PrivateKey,ByteArray,ByteArray?,Boolean,IoBuffer?)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,String) in class TouchPacket is changed to invoke(UInt,String,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method BotSession(Bot,ByteArray,DataPacketSocketAdapter) in class BotSession is changed to BotSession(Bot,SessionKey,DataPacketSocketAdapter)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildSessionPacket(UInt,ByteArray,String?,PacketId,UShort,Int,() in class OutgoingPacket is changed to buildSessionPacket(UInt,SessionKey,String?,PacketId,UShort,Int,()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writePart1(UInt,String,Int,String,ByteArray,ByteArray,Boolean,IoBuffer?) in class PasswordSubmission is changed to writePart1(UInt,String,Int,String,PrivateKey,ByteArray,Boolean,IoBuffer?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writeTLV0006(UInt,String,Int,String,ByteArray) in class OutputUtils is changed to writeTLV0006(UInt,String,Int,String,PrivateKey)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class FriendStatusChanged is extracted from class FriendOnlineStatusChangedPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "A new inner class is extracted and two fields are moved there.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UInt,UInt,ByteArray) in class CanAddFriendPacket is changed to invoke(UInt,UInt,SessionKey)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Parameters are incorrect. A change method parameter is detected but the order of parameter is different. KotlinRMiner made mistake as it detect a Move Method and Change Method parameter.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,UInt,ByteArray) in class RequestProfileDetailsPacket is moved to class CanAddFriendPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "It is a move and change method parameter.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UShort,UInt,SessionKey,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,ByteArray) in class RequestAccountInfoPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,ByteArray) in class HeartbeatPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,UInt,ByteArray) in class CanAddFriendPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,UInt,ByteArray) in class AddFriendPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,UInt,ByteArray,MessageChain) in class SendFriendMessagePacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,GroupInternalId,ByteArray,MessageChain) in class SendGroupMessagePacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,ByteArray,OnlineStatus) in class ChangeOnlineStatusPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,String,Int,String,ByteArray,ByteArray,ByteArray?,Boolean,IoBuffer?) in class SubmitPasswordPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,ByteArray,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(UShort,UInt,SessionKey,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UInt,SessionKey,EventPacketIdentity) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(PacketId,UShort,UInt,SessionKey) in class EventPacketFactory is changed to invoke(PacketId,UShort,UInt,SessionKey,EventPacketIdentity)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The initial parameters are not correct. KotlinRMiner detects the correct refactoring as well.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,ByteArray) in class RequestSKeyPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method invoke(UInt,String) in class TouchPacket is moved to class EventPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field qq in class FriendOnlineStatusChangedPacket is moved to class FriendStatusChanged", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field status in class FriendOnlineStatusChangedPacket is moved to class FriendStatusChanged", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "1e7aaaec480b1ab7d69b0525cf9b552db5a09e0b", "url" : "https://github.com/mamoe/mirai/commit/1e7aaaec480b1ab7d69b0525cf9b552db5a09e0b", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OnlineFriendImage is Move to net.mamoe.mirai.internal.message.OnlineFriendImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.ConstOriginUrlAware is Move to net.mamoe.mirai.internal.message.ConstOriginUrlAware", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OnlineImage is Move to net.mamoe.mirai.internal.message.OnlineImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OfflineGroupImage is Move to net.mamoe.mirai.internal.message.OfflineGroupImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.ExperimentalDeferredImage is Move to net.mamoe.mirai.internal.message.ExperimentalDeferredImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.DeferredOriginUrlAware is Move to net.mamoe.mirai.internal.message.DeferredOriginUrlAware", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.internal.QQAndroid is Rename to net.mamoe.mirai.internal.BotFactoryImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OfflineFriendImage is Move to net.mamoe.mirai.internal.message.OfflineFriendImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OnlineGroupImage is Move to net.mamoe.mirai.internal.message.OnlineGroupImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.SuspendDeferredOriginUrlAware is Move to net.mamoe.mirai.internal.message.SuspendDeferredOriginUrlAware", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.OfflineImage is Move to net.mamoe.mirai.internal.message.OfflineImage", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.LowLevelBotAPIAccessor is Rename to net.mamoe.mirai.LowLevelApiAccessor", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelQueryGroupList() in class LowLevelBotAPIAccessor is changed to _lowLevelQueryGroupList(Bot)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelNewFriend(FriendInfo) in class LowLevelBotAPIAccessor is changed to _lowLevelNewFriend(Bot,FriendInfo)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelDeleteAnnouncement(Long,String) in class LowLevelBotAPIAccessor is changed to _lowLevelDeleteAnnouncement(Bot,Long,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelGetAnnouncement(Long,String) in class LowLevelBotAPIAccessor is changed to _lowLevelGetAnnouncement(Bot,Long,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelGetGroupActiveData(Long,Int) in class LowLevelBotAPIAccessor is changed to _lowLevelGetGroupActiveData(Bot,Long,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelGetGroupHonorListData(Long,GroupHonorType) in class LowLevelBotAPIAccessor is changed to _lowLevelGetGroupHonorListData(Bot,Long,GroupHonorType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelSendAnnouncement(Long,GroupAnnouncement) in class LowLevelBotAPIAccessor is changed to _lowLevelSendAnnouncement(Bot,Long,GroupAnnouncement)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelUploadVoice(ByteArray,Long) in class LowLevelBotAPIAccessor is changed to _lowLevelUploadVoice(Bot,ByteArray,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelGetAnnouncements(Long,Int,Int) in class LowLevelBotAPIAccessor is changed to _lowLevelGetAnnouncements(Bot,Long,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelQueryGroupMemberList(Long,Long,Long) in class LowLevelBotAPIAccessor is changed to _lowLevelQueryGroupMemberList(Bot,Long,Long,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelQueryGroupVoiceDownloadUrl(ByteArray,Long,Long) in class LowLevelBotAPIAccessor is changed to _lowLevelQueryGroupVoiceDownloadUrl(Bot,ByteArray,Long,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelSolveBotInvitedJoinGroupRequestEvent(Long,Long,Long,Boolean) in class LowLevelBotAPIAccessor is changed to _lowLevelSolveBotInvitedJoinGroupRequestEvent(Bot,Long,Long,Long,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelSolveNewFriendRequestEvent(Long,Long,String,Boolean,Boolean) in class LowLevelBotAPIAccessor is changed to _lowLevelSolveNewFriendRequestEvent(Bot,Long,Long,String,Boolean,Boolean)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method _lowLevelSolveMemberJoinRequestEvent(Long,Long,String,Long,Boolean,Boolean,String) in class LowLevelBotAPIAccessor is changed to _lowLevelSolveMemberJoinRequestEvent(Bot,Long,Long,String,Long,Boolean,Boolean,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class MiraiImpl is extracted from class QQAndroidBot", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class Mirai is extracted from class Bot", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method rejectMemberJoinRequest(MemberJoinRequestEvent,Boolean,String) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptMemberJoinRequest(MemberJoinRequestEvent) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ignoreMemberJoinRequest(MemberJoinRequestEvent,Boolean) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method rejectNewFriendRequest(NewFriendRequestEvent,Boolean) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptNewFriendRequest(NewFriendRequestEvent) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method solveInvitedJoinGroupRequest(BotInvitedJoinGroupRequestEvent,Boolean) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptNewFriendRequest(NewFriendRequestEvent) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method rejectNewFriendRequest(NewFriendRequestEvent,Boolean) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptInvitedJoinGroupRequest(BotInvitedJoinGroupRequestEvent) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptMemberJoinRequest(MemberJoinRequestEvent) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ignoreInvitedJoinGroupRequest(BotInvitedJoinGroupRequestEvent) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ignoreMemberJoinRequest(MemberJoinRequestEvent,Boolean) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method rejectMemberJoinRequest(MemberJoinRequestEvent,Boolean,String) in class Bot is moved to class Mirai", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method acceptInvitedJoinGroupRequest(BotInvitedJoinGroupRequestEvent) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method ignoreInvitedJoinGroupRequest(BotInvitedJoinGroupRequestEvent) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.LowLevelAPI is Rename to net.mamoe.mirai.LowLevelApi", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.utils.MiraiInternalAPI is Rename to net.mamoe.mirai.utils.MiraiInternalApi", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.utils.MiraiExperimentalAPI is Rename to net.mamoe.mirai.utils.MiraiExperimentalApi", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method checkGroupPermission(Bot,Group,() -> String) in class QQAndroidBot is moved to class MiraiImpl", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "ef98f22d545e9b8740f466e5a275f5ed0a6aff1e", "url" : "https://github.com/mamoe/mirai/commit/ef98f22d545e9b8740f466e5a275f5ed0a6aff1e", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method DebugHandler(LoginSession) in class DebugHandler is renamed to DebugPacketHandler(LoginSession)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Class DebugHandler is renamed to DebugPacketHandler and the constructor is renamed.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method ActionHandler(LoginSession) in class ActionHandler is renamed to ActionPacketHandler(LoginSession)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method MessageHandler(LoginSession) in class MessageHandler is renamed to MessagePacketHandler(LoginSession)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.BotNetworkHandler.Login is Move to net.mamoe.mirai.network.BotNetworkHandlerImpl.Login", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.BotNetworkHandler.SocketHandler is MoveAndRename to net.mamoe.mirai.network.BotNetworkHandlerImpl.BotSocket", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.handler.DebugHandler is Rename to net.mamoe.mirai.network.handler.DebugPacketHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.handler.ActionHandler is Rename to net.mamoe.mirai.network.handler.ActionPacketHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.handler.MessageHandler is Rename to net.mamoe.mirai.network.handler.MessagePacketHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass BotNetworkHandlerImpl is extracted from parent class BotNetworkHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method tryLogin(Long) in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field login in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field packetHandlers in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field debugHandler in class BotNetworkHandler is rename to debug", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "PushDown and Rename refactorings happened. Note that the type of field is not changed and only its class type is renamed from DebugHandler to DebugPacketHandler which is a Rename class refactoring.", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field debug in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "PushDown and Rename refactorings happened. Note that the type of field is not changed and only its class type is renamed from DebugHandler to DebugPacketHandler which is a Rename class refactoring.", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field messageHandler in class BotNetworkHandler is rename to message", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "PushDown and Rename refactorings happened. Note that the type of field is not changed and only its class type is renamed from MessageHandler to MessagePacketHandler which is a Rename class refactoring.", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field message in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "PushDown and Rename refactorings happened. Note that the type of field is not changed and only its class type is renamed from MessageHandler to MessagePacketHandler which is a Rename class refactoring.", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field sessionKey in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method to(PacketHandler) in class PacketHandler is changed to to()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Both Rename and Change Method Parameter happened. Both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method to(PacketHandler) in class PacketHandler is renamed to asNode()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Both Rename and Change Method Parameter happened. Both are detected by KotlinRMiner.", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method close() in class BotNetworkHandler is pushed down to class BotNetworkHandlerImpl", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "eb8660667e5cdbc87752372fd3a83b5530f36a4b", "url" : "https://github.com/mamoe/mirai/commit/eb8660667e5cdbc87752372fd3a83b5530f36a4b", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.console.MiraiConsoleLoader is Rename to net.mamoe.mirai.console.MiraiConsoleTerminalLoader", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass MiraiConsoleTerminalUI is extracted from parent class MiraiConsoleUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method drawFrame(String) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method start() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method redrawCommand() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method drawLog(String,Boolean) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method addCommandChar(Char) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method drawBotFrame(Long,Number) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method deleteCommandChar() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method drawMainFrame(Number) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method clearRows(Int) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getScreenName(Int) in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method emptyCommand() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method cleanPage() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getLeftScreenId() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method getRightScreenId() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method update() in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method start() in class MiraiConsole is changed to start(MiraiConsoleUI)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface LoginSolverInputReader is extracted from classes DefaultLoginSolverInputReader", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field terminal in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field textGraphics in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field screens in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field commandBuilder in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field currentScreenId in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field currentHeight in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field hasStart in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field internalPrinter in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field lastEmpty in class MiraiConsoleUI is pushed down to class MiraiConsoleTerminalUI", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class MiraiConsoleTerminalUI is extracted from class MiraiConsoleUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "It is extract subclass refactoring.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method start() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getLeftScreenId() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getRightScreenId() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getScreenName(Int) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method clearRows(Int) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method drawFrame(String) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method drawMainFrame(Number) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method drawBotFrame(Long,Number) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method pushLog(Long,String) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method redrawCommand() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method addCommandChar(Char) in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method deleteCommandChar() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method emptyCommand() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method update() in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field cacheLogSize in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field log in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field botAdminCount in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field screens in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field currentScreenId in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field terminal in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field textGraphics in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field hasStart in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field internalPrinter in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field commandBuilder in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field lastEmpty in class MiraiConsoleUI is moved to class MiraiConsoleTerminalUI", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "The refactoring is PushDown and not Move.", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "71c86099160d1aa4baacff70e29d87979e47d84f", "url" : "https://github.com/mamoe/mirai/commit/71c86099160d1aa4baacff70e29d87979e47d84f", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method calculateGroupIdByGroupCode(Long) in class Group is renamed to calculateGroupUinByGroupCode(Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSubClass", "description" : "Extract SubClass: Subclass AbstractCancellableEvent is extracted from parent class Event", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PushDownMethod", "description" : "PushDownMethod: Method cancel() in class Event is pushed down to class AbstractCancellableEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface CancellableEvent is extracted from classes AbstractCancellableEvent,Failed,Succeed,FriendMessageSendEvent,GroupMessageSendEvent", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class Cancellable is renamed to CancellableEvent.", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface BotPassiveEvent is extracted from classes BotGroupPermissionChangeEvent,GroupSettingChangeEvent,MemberJoinEvent,MemberPermissionChangeEvent", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ImageUploadEvent is extracted from children classes Failed,Succeed", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass MessageSendEvent is extracted from children classes FriendMessageSendEvent,GroupMessageSendEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass MemberLeaveEvent is extracted from children classes Kick,Quit", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class net.mamoe.mirai.event.events.MemberUnmuteEvent is extracted from class net.mamoe.mirai.data.MemberUnmuteEvent", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Seems incorrect.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method MemberUnmuteEvent(Member,Member) in class MemberUnmuteEvent is moved to class MemberUnmuteEvent", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Not sure it is a correct refactoring. ", "validator" : "" }, { "refactoringType" : "PushDownField", "description" : "PushDownField: Field _cancelled in class Event is pushed down to class AbstractCancellableEvent", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getGroup(Long) in class QQAndroidBotBase is moved to class Bot", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method cancel() in class Cancellable is moved to class CancellableEvent", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It seems class Cancellable is renamed to CancellableEvent.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method MemberMuteEvent(Member,Int,Member) in class MemberMuteEvent is moved to class MemberMuteEvent", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.qqandroid.io.JceEncodeException is MoveAndRename to net.mamoe.mirai.event.events.EventCancelledException", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.Subscribable is MoveAndRename to net.mamoe.mirai.event.events.BotActiveEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.BotLoginSucceedEvent is Rename to net.mamoe.mirai.event.events.BotOnlineEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Based on the references it seems the refactoring is correct.", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.BotReadyEvent is Rename to net.mamoe.mirai.event.events.MemberLeaveEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.AddGroupEvent is Rename to net.mamoe.mirai.event.events.MemberUnmuteEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.RemoveGroupEvent is Rename to net.mamoe.mirai.event.events.MemberCardChangeEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.ForceOfflineEvent is Rename to net.mamoe.mirai.event.events.GroupAllowMemberInviteEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.FriendStatusChanged is Rename to net.mamoe.mirai.event.events.GroupEntranceAnnouncementChangeEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.Cancellable is Rename to net.mamoe.mirai.event.CancellableEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.events.BotEvent is Rename to net.mamoe.mirai.event.events.BeforeImageUploadEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method getFriend(Long) in class QQAndroidBotBase is moved to class Bot", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method cancel() in class Event is moved to class AbstractCancellableEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "IT is PushDown.", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "d05cecefc5d71d472e1f6645ded26f193f04ac09", "url" : "https://github.com/mamoe/mirai/commit/d05cecefc5d71d472e1f6645ded26f193f04ac09", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method ServerLoginResponseResendPacket(DataInputStream,Flag) in class ServerLoginResponseResendPacket is renamed to ServerLoginResponseKeyExchangePacket(DataInputStream,Flag)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.packet.login.ServerLoginResponseResendPacket is Rename to net.mamoe.mirai.network.packet.login.ServerLoginResponseKeyExchangePacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.event.events.robot.RobotMessageReceivedEvent.Type is Move to net.mamoe.mirai.event.events.bot.BotMessageReceivedEvent.Type", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.RobotNetworkHandler is Rename to net.mamoe.mirai.network.BotNetworkHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientVerificationCodeRefreshPacket(Long,ByteArray,Int) in class ClientVerificationCodeRefreshPacket is changed to ClientVerificationCodeRefreshPacket(Int,Long,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ClientSendFriendMessagePacket(Long,Long,ByteArray,String) in class ClientSendFriendMessagePacket is changed to ClientSendFriendMessagePacket(Long,Long,ByteArray,MessageChain)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sendMessage(Message) in class Group is changed to sendMessage(MessageChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sendMessage(Message) in class QQ is changed to sendMessage(MessageChain)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Contact(Robot,Long) in class Contact is changed to Contact(Bot,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Group(Robot,Long) in class Group is changed to Group(Bot,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method QQ(Robot,Long) in class QQ is changed to QQ(Bot,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method decryptAsByteArray(ByteArray) in class ServerPacket is extracted from method decryptBy(ByteArray) in class ServerPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractAndMoveMethod", "description" : "ExtractAndMoveMethod: Method setId(String) in class ServerPacket is extracted from method decrypt() in class Encrypted", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface Packet is extracted from classes ClientPacket,ServerPacket", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Packet is a class in Java and it is changed to a class in Kotlin.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass Message is extracted from children classes At,Face,Image,MessageChain,PlainText", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "Message is a class in Java and in the next version is changed to a Kotlin class and new functionality is added to it.", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass ServerAddContactResponsePacket is extracted from children classes ServerAddFriendResponsePacket,ServerAddGroupResponsePacket", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field verificationCodeCache in class LoginHandler is rename to captchaCache", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field verificationCodePartN in class ServerVerificationCodeTransmissionPacket is rename to captchaSectionN", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field verificationSessionId in class ServerVerificationCodeTransmissionPacket is rename to packetIdLast", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.robot.RobotLoginEvent is MoveAndRename to net.mamoe.mirai.event.events.bot.BotLoginEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.robot.RobotLogoutEvent is MoveAndRename to net.mamoe.mirai.event.events.bot.BotLogoutEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.robot.RobotMessageReceivedEvent is MoveAndRename to net.mamoe.mirai.event.events.bot.BotMessageReceivedEvent", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method toHexString(String) in class ClientPacket is renamed to toUHexString(String)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readString() in class ServerPacket is changed to readString(Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method readShortVarString() in class ServerPacket is renamed to readString(Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "readShortVarString() is renamed to readVarString() and method readVarByteArray() is also extracted.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method readVarString(Int) in class ServerPacket is changed to readVarString()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "readVarString(length: Int) is renamed to readString(length: Int)", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "2b477b3be7761d13747abc0bbd7d4da8a7804bb2", "url" : "https://github.com/mamoe/mirai/commit/2b477b3be7761d13747abc0bbd7d4da8a7804bb2", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.FriendOnlineStatusChangedPacket is Move to net.mamoe.mirai.network.protocol.tim.packet.event.FriendOnlineStatusChangedPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.EventPacket.AndroidDeviceStatusChange.Kind is Move to net.mamoe.mirai.network.protocol.tim.packet.event.MemberPermissionChangePacket.Kind", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.event.events.MemberPermissionChangedEvent.Kind is Move to net.mamoe.mirai.network.protocol.tim.packet.event.AndroidDeviceStatusChangePacket.Kind", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.EventPacket.GroupFileUpload is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.EventPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.EventPacket.FriendMessage is Move to net.mamoe.mirai.network.protocol.tim.packet.event.FriendMessage", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method println(String,LoggerTextFormat) in class Console is changed to println(Any,LoggerTextFormat)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method CorrespondingEvent(KClass) in class CorrespondingEvent is changed to CorrespondingEvent(KClass)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method UnknownEventPacket(UnknownEventId) in class UnknownEventPacket is changed to UnknownEventPacket(UShort,ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Not clear to me while the class name is the same but not sure it is a valid refactoring. The original file is mirai-core/src/commonMain/kotlin/net.mamoe.mirai/network/protocol/tim/packet/event/ServerEventPackets.kt and the target file is mirai-core/src/commonMain/kotlin/net.mamoe.mirai/network/protocol/tim/packet/event/Unknown.kt", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface EventParserAndHandler is extracted from classes IgnoredEventParserAndHandler,KnownEventParserAndHandler,UnknownEventParserAndHandler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractInterface", "description" : "ExtractInterface: Interface Subscribable is extracted from classes Cancellable,Event,EventPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class MessageEventPacket is extracted from class SenderAndMessage", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "To me class is moved.", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method upload() in class SenderAndMessage is moved to class MessageEventPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "To me class is moved.", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.FriendSenderAndMessage is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.FriendConversationInitialize", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.GroupSenderAndMessage is MoveAndRename to net.mamoe.mirai.contact.MemberPermission", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.FriendImageIdObtainedEvent is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.FriendStatusChanged", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "FriendStatusChanged is changed from abstract class to interface.", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.FriendEvent is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.GroupFileUploadPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.FriendConversationInitializedEvent is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.MemberPermissionChangePacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.event.events.FriendOnlineStatusChangedEvent is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.event.AndroidDeviceStatusChangePacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.IgnoredPacketFactory is Rename to net.mamoe.mirai.network.protocol.tim.packet.UnknownPacketFactory", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "b2542cd6bfe4cf3283709a6f668f90a4c66ed218", "url" : "https://github.com/mamoe/mirai/commit/b2542cd6bfe4cf3283709a6f668f90a4c66ed218", "refactorings" : [ { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.jce.RequestPacket is Move to net.mamoe.mirai.qqandroid.network.protocol.packet.login.data.RequestPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.jce.RequestDataStructSvcReqRegister is Move to net.mamoe.mirai.qqandroid.network.protocol.packet.login.data.RequestDataStructSvcReqRegister", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.protobuf.ProtoBuf is Move to net.mamoe.mirai.qqandroid.io.ProtoBuf", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.packet.chat.receive.ImageIdQQA is Move to net.mamoe.mirai.qqandroid.utils.ImageIdQQA", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.jce.RequestDataVersion2 is Move to net.mamoe.mirai.qqandroid.network.protocol.packet.login.data.RequestDataVersion2", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.jce.RequestDataVersion3 is Move to net.mamoe.mirai.qqandroid.network.protocol.packet.login.data.RequestDataVersion3", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.jce.SvcReqRegister is Move to net.mamoe.mirai.qqandroid.network.protocol.packet.login.data.SvcReqRegister", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.qqandroid.network.protocol.packet.chat.receive.ImageLinkQQA is Move to net.mamoe.mirai.qqandroid.utils.ImageLinkQQA", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbGroupMsgWithDrawResp(Int,String,Int,Int,Long,List?,ByteArray) in class PbGroupMsgWithDrawResp is changed to PbGroupMsgWithDrawResp(Int,String,Int,Int,Long,List?,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbMsgWithDrawResp(List?,List?) in class PbMsgWithDrawResp is changed to PbMsgWithDrawResp(List?,List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method SourceMsg(List,Long,Int,Int,List,Int,ByteArray,ByteArray,ByteArray,Long,ByteArray) in class SourceMsg is changed to SourceMsg(List,Long,Int,Int,List,Int,ByteArray,ByteArray,ByteArray,Long,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbPullDiscussMsgSeqReq(List?) in class PbPullDiscussMsgSeqReq is changed to PbPullDiscussMsgSeqReq(List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MultiMsgAssist(List?,Int,Long,Long,ByteArray,Long,Int,Int) in class MultiMsgAssist is changed to MultiMsgAssist(List?,Int,Long,Long,ByteArray,Long,Int,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbC2CMsgWithDrawReq(List?,Int,ByteArray,Int) in class PbC2CMsgWithDrawReq is changed to PbC2CMsgWithDrawReq(List?,Int,ByteArray,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbMsgReadedReportResp(List?,List?,PbC2CReadedReportResp,PbBindUinMsgReadedConfirmResp) in class PbMsgReadedReportResp is changed to PbMsgReadedReportResp( List?,List?,PbC2CReadedReportResp,PbBindUinMsgReadedConfirmResp)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbC2CMsgWithDrawResp(Int,String,List?,Int) in class PbC2CMsgWithDrawResp is changed to PbC2CMsgWithDrawResp(Int,String,List?,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ElemFlags2(Int,Long,Int,Int,Int,Int,List?,Int,Inst,Int,Int,Int,PcSupportDef,Int) in class ElemFlags2 is changed to ElemFlags2(Int,Long,Int,Int,Int,Int,List?,Int,Inst,Int,Int,Int,PcSupportDef,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GroupInfo(Long,Int,Long,ByteArray,ByteArray,Int,Int,ByteArray) in class GroupInfo is changed to GroupInfo(Long,Int,Long,String,ByteArray,Int,Int,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method NotOnlineImage(ByteArray,Int,ByteArray,ByteArray,Int,ByteArray,ByteArray,Int,Int,ByteArray,ByteArray,String,Int,String,String,Int,Int,Int,ByteArray,Boolean,Int,Int,Int,Int,Int,String,Int,Int,ByteArray) in class NotOnlineImage is changed to NotOnlineImage(String,Int,ByteArray,ByteArray,Int,ByteArray,ByteArray,Int,Int,String,ByteArray,String,Int,String,String,Int,Int,Int,ByteArray,Boolean,Int,Int,Int,Int,Int,String,Int,Int,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbMsgWithDrawReq(List?,List?) in class PbMsgWithDrawReq is changed to PbMsgWithDrawReq(List?, List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbThirdQQUnReadMsgNumResp(Int,String,List?,Int) in class PbThirdQQUnReadMsgNumResp is changed to PbThirdQQUnReadMsgNumResp(Int,String,List?,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbDeleteMsgReq(List?) in class PbDeleteMsgReq is changed to PbDeleteMsgReq(List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "Only the package name is removed. So, the parameter is not changed.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Text(ByteArray,String,ByteArray,ByteArray,ByteArray,ByteArray) in class Text is changed to Text(String,String,ByteArray,ByteArray,ByteArray,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbPullDiscussMsgSeqResp(Int,String,List?) in class PbPullDiscussMsgSeqResp is changed to PbPullDiscussMsgSeqResp(Int,String,List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "The class full name is replaced with class name.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbGroupMsgWithDrawReq(Int,Int,Long,List?,ByteArray) in class PbGroupMsgWithDrawReq is changed to PbGroupMsgWithDrawReq(Int,Int,Long,List?,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method RichText(Attr,List,NotOnlineFile,Ptt,TmpPtt,Trans211TmpMsg) in class RichText is changed to RichText(Attr,MutableList,NotOnlineFile,Ptt,TmpPtt,Trans211TmpMsg)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "List is chnaged to MutableList", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbThirdQQUnReadMsgNumReq(List?,Int) in class PbThirdQQUnReadMsgNumReq is changed to PbThirdQQUnReadMsgNumReq(List?,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbMsgReadedReportReq(List,List,PbC2CReadedReportReq,PbBindUinMsgReadedConfirmReq) in class PbMsgReadedReportReq is changed to PbMsgReadedReportReq(List,List,PbC2CReadedReportReq,PbBindUinMsgReadedConfirmReq)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbUnReadMsgSeqReq(PbC2CUnReadMsgNumReq,List,PbPullGroupMsgSeqReq,PbPullDiscussMsgSeqReq,PbThirdQQUnReadMsgNumReq) in class PbUnReadMsgSeqReq is changed to PbUnReadMsgSeqReq(PbC2CUnReadMsgNumReq,List,PbPullGroupMsgSeqReq,PbPullDiscussMsgSeqReq,PbThirdQQUnReadMsgNumReq)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbUnReadMsgSeqResp(PbC2CUnReadMsgNumResp,List,PbPullGroupMsgSeqResp,PbPullDiscussMsgSeqResp,PbThirdQQUnReadMsgNumResp) in class PbUnReadMsgSeqResp is changed to PbUnReadMsgSeqResp(PbC2CUnReadMsgNumResp,List,PbPullGroupMsgSeqResp,PbPullDiscussMsgSeqResp,PbThirdQQUnReadMsgNumResp)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method PbPullGroupMsgSeqReq(List?) in class PbPullGroupMsgSeqReq is changed to PbPullGroupMsgSeqReq(List?)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractMethod", "description" : "ExtractMethod: Method generifiedParsePacket(Input) in class QQAndroidBotNetworkHandler is extracted from method parsePacket(Input) in class QQAndroidBotNetworkHandler", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseIncomingPacket(QQAndroidBot,Input,PacketConsumer) in class KnownPacketFactories is changed to parseIncomingPacket(QQAndroidBot,Input,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseOicqResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer) in class KnownPacketFactories is changed to parseOicqResponse(QQAndroidBot,PacketFactory,Int,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseUniResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer) in class KnownPacketFactories is changed to parseUniResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildOutgoingPacket(QQAndroidClient,String?,String,ByteArray,(sequenceId: Int) in class OutgoingPacketAndroid is changed to buildOutgoingPacket(QQAndroidClient,Byte,String?,String,ByteArray,(sequenceId: Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Both rename and change method parameter happened.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method buildOutgingPacket(QQAndroidClient,String?,String,ByteArray,(sequenceId: Int) in class OutgoingPacketAndroid is renamed to buildOutgoingPacket(QQAndroidClient,Byte,String?,String,ByteArray,(sequenceId: Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "Both rename and change method parameter happened.", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "d60006376c4acf27a107cf8e3a2ef78cee250644", "url" : "https://github.com/mamoe/mirai/commit/d60006376c4acf27a107cf8e3a2ef78cee250644", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method createForGroupLongMessage(Int,QQAndroidClient,MessageValidationData,Long) in class MultiMsg is renamed to createForGroup(Int,QQAndroidClient,MessageValidationData,Long)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method uploadImage(QQAndroidClient,String,Int,ByteArray,ExternalResource,ByteArray,Int) in class HighwayHelper is renamed to uploadResourceImpl(QQAndroidClient,String,Int,ByteArray,ExternalResource,ByteArray,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.internal.network.highway.HighwayHelper is Rename to net.mamoe.mirai.internal.network.highway.Highway", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.message.data.LongMessage is MoveAndRename to net.mamoe.mirai.internal.message.LongMessageInternal", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.message.data.ForwardMessageInternal is Move to net.mamoe.mirai.internal.message.ForwardMessageInternal", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createToGroupImpl(QQAndroidClient,Group,MessageChain,Boolean,OnlineMessageSourceToGroupImpl) in class MessageSvcPbSendMsg is changed to createToGroupImpl(QQAndroidClient,Group,MessageChain,OnlineMessageSourceToGroupImpl)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method lowLevelSendGroupLongOrForwardMessage(Bot,Long,Collection,Boolean,ForwardMessage?) in class MiraiImpl is changed to lowLevelSendGroupLongOrForwardMessage(Bot,Long,Collection,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method lowLevelSendGroupLongOrForwardMessage(Bot,Long,Collection,Boolean,ForwardMessage?) in class MiraiImpl is renamed to uploadGroupMessageHighway(Bot,Long,Collection,Boolean)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method uploadImageToServers(QQAndroidBot,List>,ByteArray,ExternalResource,String,Int) in class Highway is renamed to uploadResource(QQAndroidBot,List>,ByteArray,ExternalResource,String,Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method createToGroup(QQAndroidClient,Group,MessageChain,Boolean,(OnlineMessageSourceToGroupImpl) in class PbSendMsg is changed to createToGroup(QQAndroidClient,Group,MessageChain,(OnlineMessageSourceToGroupImpl)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "1b67a9fcd8682cac3fbb9ae7183f388a473d913c", "url" : "https://github.com/mamoe/mirai/commit/1b67a9fcd8682cac3fbb9ae7183f388a473d913c", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method dump(SerializationStrategy,T) in class ProtoBufWithNullableSupport is renamed to encodeToByteArray(SerializationStrategy,T)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.utils.internal.InputStream is MoveAndRename to java.io.ObjectInput", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writeInt(Int,Int,ProtoNumberType) in class ProtobufEncoder is changed to writeInt(Int,Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writeLong(Long,Int,ProtoNumberType) in class ProtobufEncoder is changed to writeLong(Long,Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ProtoBufWithNullableSupport(SerialModule) in class ProtoBufWithNullableSupport is changed to ProtoBufWithNullableSupport(SerializersModule)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Voice(String,ByteArray,String) in class Voice is changed to Voice(String,ByteArray,Long,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Response(SyncFlag,List) in class Response is changed to Response(SyncFlag,List,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method ForceOfflineException(String) in class ForceOfflineException is changed to ForceOfflineException(String,Throwable)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method encode32(Int,ProtoNumberType) in class ProtobufEncoder is changed to encode32(Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method invoke(QQAndroidClient,MsgSvc.SyncFlag,Long) in class MessageSvcPbGetMsg is changed to invoke(QQAndroidClient,MsgSvc.SyncFlag,ByteArray?)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method GetMsgSuccess(List) in class GetMsgSuccess is changed to GetMsgSuccess(List,ByteArray)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.utils.Throws is MoveAndRename to net.mamoe.mirai.qqandroid.utils.io.serialization.tars.TarsId", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method load(DeserializationStrategy,ByteArray) in class ProtoBufWithNullableSupport is renamed to decodeFromByteArray(DeserializationStrategy,ByteArray)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "InlineMethod", "description" : "InlineMethod: Method load(DeserializationStrategy,ByteArray) in class ProtoBufWithNullableSupport is inlined to method decodeFromByteArray(DeserializationStrategy,ByteArray) in class ProtoBufWithNullableSupport", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method nextEvent(Long,Listener.EventPriority) in class nextEvent is changed to nextEvent(Long,Listener.EventPriority,E)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method nextEventOrNull(Long,Listener.EventPriority) in class nextEvent is changed to nextEventOrNull(Long,Listener.EventPriority,E)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method nextEventImpl(KClass,CoroutineScope,Listener.EventPriority,(E) in class nextEvent is changed to nextEventImpl(KClass,CoroutineScope,Listener.EventPriority,(E)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "a63af806685b389ad5d847b6ae85999add1a7fa1", "url" : "https://github.com/mamoe/mirai/commit/a63af806685b389ad5d847b6ae85999add1a7fa1", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendMessage(QQ,MessageChain) in class FriendMessage is changed to FriendMessage(Friend,MessageChain)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendRemarkChangeEvent(Bot,QQ,String) in class FriendRemarkChangeEvent is changed to FriendRemarkChangeEvent(Bot,Friend,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MessageSourceToFriendImpl(Int,Int,Int,MessageChain,Bot,QQ) in class MessageSourceToFriendImpl is changed to MessageSourceToFriendImpl(Int,Int,Int,MessageChain,Bot,Friend)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendMessageSendEvent(QQ,MessageChain) in class FriendMessageSendEvent is changed to FriendMessageSendEvent(Friend,MessageChain)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendDeleteEvent(QQ) in class FriendDeleteEvent is changed to FriendDeleteEvent(Friend)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MemberImpl(QQImpl,GroupImpl,CoroutineContext,MemberInfo) in class MemberImpl is changed to MemberImpl(FriendImpl,GroupImpl,CoroutineContext,MemberInfo)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method FriendAddEvent(QQ) in class FriendAddEvent is changed to FriendAddEvent(Friend)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass Friend is extracted from children classes FriendImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field bot in class QQImpl is moved to class FriendImpl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field lastMessageSequence in class QQImpl is moved to class FriendImpl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method uploadImage(ExternalImage) in class QQImpl is moved to class FriendImpl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method sendMessage(Message) in class QQImpl is moved to class FriendImpl", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.qqandroid.contact.QQImpl is Rename to net.mamoe.mirai.qqandroid.contact.FriendImpl", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.contact.QQ is Rename to net.mamoe.mirai.contact.User", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method _lowLevelNewQQ(FriendInfo) in class QQAndroidBotBase is renamed to _lowLevelNewFriend(FriendInfo)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sentBy(QQ) in class MessageSubscribersBuilder is changed to sentBy(User)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class QQ is renamed to User. So, the parameter is not changed. KotlinRMiner detects his rename class.", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method at(QQ) in class MessageSubscribersBuilder is changed to at(User)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Class QQ is renamed to User. So, the parameter is not changed. KotlinRMiner detects his rename class.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method member() in class GroupMessage is renamed to asMember()", "detectionTools" : [ "KotlinRMiner" ], "validation" : "NC", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpMethod", "description" : "PullUpMethod: Method toString() in class QQImpl is pulled up to class Friend", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "Text is different.", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method _lowLevelNewQQ(FriendInfo) in class LowLevelBotAPIAccessor is renamed to _lowLevelNewFriend(FriendInfo)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "db9ee62250482b3dd3e2936920a75afcc3fa2c26", "url" : "https://github.com/mamoe/mirai/commit/db9ee62250482b3dd3e2936920a75afcc3fa2c26", "refactorings" : [ { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass AbstractUser is extracted from children classes FriendImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass AbstractContact is extracted from children classes AbstractUser,GroupImpl", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field bot in class GroupImpl is pulled up to class AbstractContact", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field coroutineContext in class GroupImpl is pulled up to class AbstractContact", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field bot in class FriendImpl is pulled up to class AbstractContact", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "There is no inheritance relationship between classes.", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class AbstractContact is extracted from class FriendImpl", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field nick in class FriendImpl is pulled up to class AbstractUser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "PullUpField", "description" : "PullUpField: Field remark in class FriendImpl is pulled up to class AbstractUser", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field coroutineContext in class FriendImpl is moved to class AbstractContact", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveField", "description" : "MoveField: Field bot in class FriendImpl is moved to class AbstractContact", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "126b221079974eff930db2470e7eccf73e80e041", "url" : "https://github.com/mamoe/mirai/commit/126b221079974eff930db2470e7eccf73e80e041", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method BotEvent(Bot) in class BotEvent is changed to BotEvent(Bot)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass Event is extracted from children classes SuperEvent,BotEvent", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field randomTgtgtKey in class Login is rename to randomprivateKey", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field tgtgtKey in class ServerLoginResponseKeyExchangePacket is rename to privateKey", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field tgtgtKey in class Main is rename to privateKey", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "Main is defined in file mirai-core/src/test/java/PacketDebuger.kt", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.EventManager is Rename to net.mamoe.mirai.event.ListeningStatus", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method success(Any?) in class MiraiLogger is renamed to green(Any?)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "7d321ee206e0e5c4a0c971f70901190c1e172d53", "url" : "https://github.com/mamoe/mirai/commit/7d321ee206e0e5c4a0c971f70901190c1e172d53", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method uploadGroupVoice(InputStream) in class GroupImpl is renamed to uploadVoice(InputStream)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method uploadPttToServers(QQAndroidBot,List,ByteArray,ByteArray,ByteArray,ByteArray) in class HighwayHelper is changed to uploadPttToServers(QQAndroidBot,List,ByteArray,ByteArray,ByteArray,ByteArray,Int)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method encode32(Int,ProtoNumberType) in class ProtobufEncoder is changed to encode32(Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method encode64(Long,ProtoNumberType) in class ProtobufEncoder is changed to encode64(Long,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method uploadPttToServer(String,Int,ByteArray,ByteArray,ByteArray,ByteArray) in class HighwayHelper is changed to uploadPttToServer(String,Int,ByteArray,ByteArray,ByteArray,ByteArray,Int)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writeInt(Int,Int,ProtoNumberType) in class ProtobufEncoder is changed to writeInt(Int,Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method writeLong(Long,Int,ProtoNumberType) in class ProtobufEncoder is changed to writeLong(Long,Int,ProtoIntegerType)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractSuperClass", "description" : "ExtractSuperClass: Superclass TarsTag is extracted from children classes TarsTagCommon,TarsTagListElement,TarsTagMapEntryKey,TarsTagMapEntryValue", "detectionTools" : [ "RefDetect" ], "validation" : "NC", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "e643988c87d90b96a3d0188d3234ec34c949260b", "url" : "https://github.com/mamoe/mirai/commit/e643988c87d90b96a3d0188d3234ec34c949260b", "refactorings" : [ { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.utils.WindowInitialzier is Rename to net.mamoe.mirai.utils.WindowInitializer", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method openWindow(String,WindowInitialzier) in class WindowHelperJvm is changed to openWindow(String,WindowInitializer)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "FP", "comment" : "WindowInitialzier is renamed to WindowInitializer", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "c17c736054eaa156a05ce0c2eff191afa4bfb3cb", "url" : "https://github.com/mamoe/mirai/commit/c17c736054eaa156a05ce0c2eff191afa4bfb3cb", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseUniResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer) in class KnownPacketFactories is changed to parseUniResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseOicqResponse(QQAndroidBot,PacketFactory<*>,Int,PacketConsumer) in class KnownPacketFactories is changed to parseOicqResponse(QQAndroidBot,PacketFactory,Int,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method parseIncomingPacket(QQAndroidBot,Input,PacketConsumer) in class KnownPacketFactories is changed to parseIncomingPacket(QQAndroidBot,Input,PacketConsumer)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method buildOutgoingPacket(QQAndroidClient,String?,String,ByteArray,(sequenceId: Int) in class OutgoingPacketAndroid is changed to buildOutgoingPacket(QQAndroidClient,Byte,String?,String,ByteArray,(sequenceId: Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method buildOutgingPacket(QQAndroidClient,String?,String,ByteArray,(sequenceId: Int) in class OutgoingPacketAndroid is renamed to buildOutgoingPacket(QQAndroidClient,Byte,String?,String,ByteArray,(sequenceId: Int)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "d06197d346391a852a228e7d9e55bb3ac3355ebf", "url" : "https://github.com/mamoe/mirai/commit/d06197d346391a852a228e7d9e55bb3ac3355ebf", "refactorings" : [ { "refactoringType" : "RenameMethod", "description" : "RenameMethod: Method ServerHeartbeatResponsePacket(ByteReadPacket) in class ServerHeartbeatResponsePacket is renamed to ServerSessionPacket(ByteReadPacket)", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ClientGroupImageIdRequestPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.GroupImageIdRequestPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ServerHeartbeatResponsePacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.ServerSessionPacket", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveClass", "description" : "MoveClass: Class net.mamoe.mirai.network.protocol.tim.packet.ServerTryGetImageIDResponsePacket.Encrypted is Move to net.mamoe.mirai.network.protocol.tim.packet.ServerSessionPacket.Encrypted", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveAndRenameClass", "description" : "MoveAndRenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ServerSubmitImageFilenameResponsePacket is MoveAndRename to net.mamoe.mirai.network.protocol.tim.packet.SubmitImageFilenamePacket.Response", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method Encrypted(ByteReadPacket) in class Encrypted is changed to Encrypted(ByteReadPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class FriendImageIdRequestPacket is extracted from class ClientSubmitImageFilenamePacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "ExtractClass", "description" : "ExtractClass: Class HeartbeatPacket is extracted from class ClientHeartbeatPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "It is a rename class.", "validator" : "" }, { "refactoringType" : "RenameField", "description" : "RenameField: Field expect in class TemporaryPacketHandler is rename to handler", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method encode(BytePacketBuilder) in class ClientHeartbeatPacket is moved to class HeartbeatPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "MoveMethod", "description" : "MoveMethod: Method encode(BytePacketBuilder) in class ClientSubmitImageFilenamePacket is moved to class FriendImageIdRequestPacket", "detectionTools" : [ "RefDetect" ], "validation" : "FP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ClientHeartbeatPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.HeartbeatPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ClientSubmitImageFilenamePacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.SubmitImageFilenamePacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.network.protocol.tim.packet.ClientTryGetImageIDPacket is Rename to net.mamoe.mirai.network.protocol.tim.packet.FriendImageIdRequestPacket", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method httpPostFriendImage(String,Int,UInt,UInt,ByteArray) in class PlatformUtilsJvm is changed to httpPostFriendImage(String,Long,UInt,UInt,ByteReadPacket)", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }] }, { "repository" : "https://github.com/mamoe/mirai", "sha1" : "ead17724b6331de668da82293d49382b41d63e2f", "url" : "https://github.com/mamoe/mirai/commit/ead17724b6331de668da82293d49382b41d63e2f", "refactorings" : [ { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method startsWith(String,Boolean,MessageListener) in class MessageSubscribersBuilder is changed to startsWith(String,Boolean,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method MessageSubscribersBuilder(MessageListener) in class MessageSubscribersBuilder is changed to MessageSubscribersBuilder(String) ", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sentBy(Long,MessageListener) in class MessageSubscribersBuilder is changed to sentBy(Long,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sentBy(UInt,MessageListener) in class MessageSubscribersBuilder is changed to sentBy(UInt,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sentFrom(Long,MessageListener) in class MessageSubscribersBuilder is changed to sentFrom(Long,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method sentFrom(UInt,MessageListener) in class MessageSubscribersBuilder is changed to sentFrom(UInt,String)", "detectionTools" : [ "RefDetect", "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method has(MessageListener) in class MessageSubscribersBuilder is changed to has(String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "ChangeMethodParameters", "description" : "ChangeMethodParameters: Parameters of method case(String,Boolean,MessageListener) in class MessageSubscribersBuilder is changed to case(String,Boolean,Boolean,String)", "detectionTools" : [ "RefDetect" ], "validation" : "TP", "comment" : "", "validator" : "" }, { "refactoringType" : "RenameClass", "description" : "RenameClass: Class net.mamoe.mirai.event.MessageListenerDsl is Rename to net.mamoe.mirai.event.MessageDsl", "detectionTools" : [ "KotlinRMiner" ], "validation" : "TP", "comment" : "", "validator" : "" } ] } ]